From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AAFAC4332F for ; Wed, 8 Nov 2023 00:20:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A58B8000F; Tue, 7 Nov 2023 19:20:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 953B58000D; Tue, 7 Nov 2023 19:20:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81B5D8000F; Tue, 7 Nov 2023 19:20:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 72FAC8000D for ; Tue, 7 Nov 2023 19:20:03 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 44745160726 for ; Wed, 8 Nov 2023 00:20:03 +0000 (UTC) X-FDA: 81432879486.29.2BAE595 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf01.hostedemail.com (Postfix) with ESMTP id 0ACC240007 for ; Wed, 8 Nov 2023 00:20:00 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of "SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699402801; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F+5GoFsOkqSYj4CTZOtL+RN/HJVM1ENmaASKaLXOWkY=; b=xTpXjkVWsEiLFQA+FCp5ti6pthjvoSE4LKgs5GraZC4L7+8hJS5WCwaRXk2kTjE2HGdl26 AbpVRlSZgJEgCwC+QOiEq4WHS7wB8N9mYecGzjDoMPmU5KsYsr08TBIWEqvRq1S8NJZwMW bkaLO7Es4TU6tcECKQBBWT6QhO5xiHo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699402801; a=rsa-sha256; cv=none; b=8TqxtD73lY3lJ+xDCQKwZjCSq+3qQEwRQqwCrlSk1wSlyqpU1WNh8AokR2N8iiuHXB35N4 4ri5b35tAX/zrAZ1o9PkU62uZ21f+suh+AkW4afRvN6EEyaaOEbC1RJyvsXgySxjKF4eMf T4SHiVMOZ3ecUwJqrfCXfx49BXeZST8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of "SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org"; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 43437CE0FE8; Wed, 8 Nov 2023 00:19:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 550BCC433C8; Wed, 8 Nov 2023 00:19:50 +0000 (UTC) Date: Tue, 7 Nov 2023 19:19:53 -0500 From: Steven Rostedt To: Ankur Arora Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, David.Laight@ACULAB.COM, richard@nod.at, mjguzik@gmail.com, Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org, Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, Dinh Nguyen Subject: Re: [RFC PATCH 46/86] tracing: handle lazy resched Message-ID: <20231107191953.6b44790b@gandalf.local.home> In-Reply-To: <20231107215742.363031-47-ankur.a.arora@oracle.com> References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107215742.363031-47-ankur.a.arora@oracle.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0ACC240007 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: q6wa8mqaze9sx5mquy4yuuopqhz9mjw1 X-HE-Tag: 1699402800-37087 X-HE-Meta: U2FsdGVkX18k9cvIjBh5nw8hmK6IFfvboaE/LSSNH/bEUxI/QfGA9X8Q1neW09sRDeEnsp8aPQ+nmOkeJM0zAj0teWHUWtd7QCJKDVMEggW+2AHr8r7U4eEPIBwjTf572o4SDYQi25rs897m4docauCMP5RYtIX9uUlYQ261ZRrJD6q3HMrgS5F+fm45T/hIFayH7KtVKs7XU8q4eHYmxW2NHgqfh/W7jrKB+squVIMZO3NsEh78Wj4nSxx/aMEDvogzaYUqUZnu3fjDFzX/hF9k8slBVwAcog5swK7Dh1JraE4x/7JmER1ReUC+4OX8Zg7GJw2iHdVpxLlTmgcxwosEOFjx0SgGayYqj4H0n0rL/n5aYZmzeD12eTBNs3SldkB6bI+RBrXggVw7xOtMeikDFFskjHtoNd9GBRzjMresuELi1ju3l3ZoXOynWLC9kaKrvRdyA20lE7/RktABqNM27D37lHIVLPDGc4kg/4Dl6GjMnm4f4iF+BAoPZ/SUmRxKIfwxYuN1noqhNWs5L61MsA5Yt+NPhSsxjFdKmMGMDf550dCO9NXaRpeIRt1rxMmpY1h9JBAVNRFPAs1au5wclWHt8/CyKt3A93yM8QO04btv7kLZPl/F8va6gDC6fbKY7xwfJ0FYex9UqoTKf3vK8l0PmthVFC/TOU+cW+0cLetka1oMpLFpojAZjqVi6MV7/6yLmRT2INXLuVVoNsIgVLUxq2O8rbWfgLj5BEt6mEsnqcTRfSMz2T7eaZ7X40DVU7yXkSQOKY6T0dHstETZ0nftTjer/6j3XFQGvrJl3kDf8sQ7ge4HSQ+hXHnt0hRjDhi6FMC1B8HBtw7D/CYCDF7MafGH7nWN6eNF45Op10cb8AKtn0TwCfywhUvJn+khCHMAAuhwacJzwTg782/VakbHgFB9c+XCIRHbKUm8lfyOOGUNQZXpGZdpo4dzJskF7DOwGfYEgNDcav0 oHH0etV1 5a13vEHWvpnZkKSXOc974JcvcQhozLta53wovGESwcvIkkARv5FM+vJeOqWQsRqdc2LjWZ5oZIgQrT2e3dy255VqGJUaPhuhvMZGWHSvgH65JtjICWlNt1dsQHSrIEP0Msctjo6soMyzxCnSJnwwbal651mHQ13Y8+UTlfFPij+2ZzxDLybXNYHo47urOome4DoGqbiY6cjoASra9pUlMqpqNcWnQCZuRlw4mb0T6WTU2JnjOeeKvrKgno7oJKkdtXvwNu9jsabG4jZagtaVCjpNrSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 7 Nov 2023 13:57:32 -0800 Ankur Arora wrote: > Tracing support. > > Note: this is quite incomplete. What's not complete? The removal of the IRQS_NOSUPPORT? Really, that's only for alpha, m68k and nios2. I think setting 'X' is not needed anymore, and we can use that bit for this, and for those archs, have 0 for interrupts disabled. -- Steve > > Originally-by: Thomas Gleixner > Signed-off-by: Ankur Arora > --- > include/linux/trace_events.h | 6 +++--- > kernel/trace/trace.c | 2 ++ > kernel/trace/trace_output.c | 16 ++++++++++++++-- > 3 files changed, 19 insertions(+), 5 deletions(-) > > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h > index 21ae37e49319..355d25d5e398 100644 > --- a/include/linux/trace_events.h > +++ b/include/linux/trace_events.h > @@ -178,7 +178,7 @@ unsigned int tracing_gen_ctx_irq_test(unsigned int irqs_status); > > enum trace_flag_type { > TRACE_FLAG_IRQS_OFF = 0x01, > - TRACE_FLAG_IRQS_NOSUPPORT = 0x02, > + TRACE_FLAG_NEED_RESCHED_LAZY = 0x02, > TRACE_FLAG_NEED_RESCHED = 0x04, > TRACE_FLAG_HARDIRQ = 0x08, > TRACE_FLAG_SOFTIRQ = 0x10, > @@ -205,11 +205,11 @@ static inline unsigned int tracing_gen_ctx(void) > > static inline unsigned int tracing_gen_ctx_flags(unsigned long irqflags) > { > - return tracing_gen_ctx_irq_test(TRACE_FLAG_IRQS_NOSUPPORT); > + return tracing_gen_ctx_irq_test(0); > } > static inline unsigned int tracing_gen_ctx(void) > { > - return tracing_gen_ctx_irq_test(TRACE_FLAG_IRQS_NOSUPPORT); > + return tracing_gen_ctx_irq_test(0); > } > #endif > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index 7f067ad9cf50..0776dba32c2d 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -2722,6 +2722,8 @@ unsigned int tracing_gen_ctx_irq_test(unsigned int irqs_status) > > if (tif_need_resched(RESCHED_eager)) > trace_flags |= TRACE_FLAG_NEED_RESCHED; > + if (tif_need_resched(RESCHED_lazy)) > + trace_flags |= TRACE_FLAG_NEED_RESCHED_LAZY; > if (test_preempt_need_resched()) > trace_flags |= TRACE_FLAG_PREEMPT_RESCHED; > return (trace_flags << 16) | (min_t(unsigned int, pc & 0xff, 0xf)) | > diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c > index db575094c498..c251a44ad8ac 100644 > --- a/kernel/trace/trace_output.c > +++ b/kernel/trace/trace_output.c > @@ -460,17 +460,29 @@ int trace_print_lat_fmt(struct trace_seq *s, struct trace_entry *entry) > (entry->flags & TRACE_FLAG_IRQS_OFF && bh_off) ? 'D' : > (entry->flags & TRACE_FLAG_IRQS_OFF) ? 'd' : > bh_off ? 'b' : > - (entry->flags & TRACE_FLAG_IRQS_NOSUPPORT) ? 'X' : > + !IS_ENABLED(CONFIG_TRACE_IRQFLAGS_SUPPORT) ? 'X' : > '.'; > > - switch (entry->flags & (TRACE_FLAG_NEED_RESCHED | > + switch (entry->flags & (TRACE_FLAG_NEED_RESCHED | TRACE_FLAG_NEED_RESCHED_LAZY | > TRACE_FLAG_PREEMPT_RESCHED)) { > + case TRACE_FLAG_NEED_RESCHED | TRACE_FLAG_NEED_RESCHED_LAZY | TRACE_FLAG_PREEMPT_RESCHED: > + need_resched = 'B'; > + break; > case TRACE_FLAG_NEED_RESCHED | TRACE_FLAG_PREEMPT_RESCHED: > need_resched = 'N'; > break; > + case TRACE_FLAG_NEED_RESCHED_LAZY | TRACE_FLAG_PREEMPT_RESCHED: > + need_resched = 'L'; > + break; > + case TRACE_FLAG_NEED_RESCHED | TRACE_FLAG_NEED_RESCHED_LAZY: > + need_resched = 'b'; > + break; > case TRACE_FLAG_NEED_RESCHED: > need_resched = 'n'; > break; > + case TRACE_FLAG_NEED_RESCHED_LAZY: > + need_resched = 'l'; > + break; > case TRACE_FLAG_PREEMPT_RESCHED: > need_resched = 'p'; > break;