From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A4EBC4167D for ; Tue, 7 Nov 2023 19:14:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95DBA900002; Tue, 7 Nov 2023 14:14:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E5BA8D0001; Tue, 7 Nov 2023 14:14:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75EFA900002; Tue, 7 Nov 2023 14:14:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6252C8D0001 for ; Tue, 7 Nov 2023 14:14:17 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3B394160ABA for ; Tue, 7 Nov 2023 19:14:17 +0000 (UTC) X-FDA: 81432108954.25.5F763E9 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf01.hostedemail.com (Postfix) with ESMTP id 002ED40008 for ; Tue, 7 Nov 2023 19:14:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=bxqakIgK; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf01.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699384454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rjOtFeaNHpOrWagWwdPrXv1lywypy0gt2wnO9HYjDMg=; b=GpYqwgFVG29O1i/Of8JNC+YZN2+c1iIMdHNiKA0o/PtioCwutcuLNoVfsf+m58suDuZb5r Pocepw+zlPBhaZNfBwiEWEZqIKJls04a/ToL0D3KE9HBOxihGnhy9s/0N+blP56lX2Wiw/ ADrwGmYoJ+e+8Ik90D2RqftcE9C51ZQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=bxqakIgK; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf01.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699384454; a=rsa-sha256; cv=none; b=h4jHSpEkIlwLHzNa4jFZfMoeBpcnhNzNyfLFIGYV6F57TUOx+LFKq+zsUO1pkyEXY7S+tk pNWOsmhtA6v2+TU/e7kFU1NuopqXDMDbxChtbB4SL8sbzxza9wmmmVn50f3doryf59tsyU xjq46fJeHb0DUJ77OD0glGP2I7UOCy8= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id B051340E0192; Tue, 7 Nov 2023 19:14:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id iFnUvtCdkqc2; Tue, 7 Nov 2023 19:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1699384447; bh=rjOtFeaNHpOrWagWwdPrXv1lywypy0gt2wnO9HYjDMg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bxqakIgKJXLvskHTp9n0kAcoxBGPd4qfa5IcthADTAYfkStA0E6pi4QMMhKL06gjy f8zAf/8RicwZPLymzq9ZsvN33++Ey758DzbHN9hVX6oAmGNwEcVoaWo/H1ldCgkcKC HJ8VLETimjnUYXBfin417xyvBP4EN38+0sR+ltZfbllvSdqP5eRgQEMjOErKcWzSVB zpyqewOSkOCZZPJxUi75pN8fEGZ3y2J4eijXn7NTb6p1BNrDJsn2vbo6inR81p6h5M pt9GzRx07Pvo3LfOSKUYlsFR403+wVPcsPC+LiU9J1K5FS8/WSbuB9SDri8rLuct+k +SSREFKcdV873SXvM+Oq0hT8lVHywvQTgFXAz5WpGRue7OWnLlevd0L0fERclE6iEr mvjaj2b+NS6RyDReRAwI3qcK5GOn5jI7xw3NyMTMDOVmtCMM5k5DlA5vWPJxoMVQja 36deXxlzh2h0T4X+/nnY1GRPAr6cNRHESVsEjdN8diqNG7o4H8jnnCCJ8ApJlONcmV uPmEYJEh+yCsMlVSlo+07g8UI/X7dFP6esHrFwMehkDs0D8lripyVyDg8OKzsbVhnH LMgXdUn+O4MMv01KKXV6mDb6L/qUlcsR6ha21apKa2sqeLLQSR9r5iPsbYi0zumP6G S/HnHPXoM9koJGsaceJecymg= Received: from zn.tnic (pd95304da.dip0.t-ipconnect.de [217.83.4.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BF8BE40E014B; Tue, 7 Nov 2023 19:13:26 +0000 (UTC) Date: Tue, 7 Nov 2023 20:13:21 +0100 From: Borislav Petkov To: Tom Lendacky Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh Subject: Re: [PATCH v10 06/50] x86/sev: Add the host SEV-SNP initialization support Message-ID: <20231107191321.GBZUqMUQPMLOqhl+RH@fat_crate.local> References: <20231016132819.1002933-1-michael.roth@amd.com> <20231016132819.1002933-7-michael.roth@amd.com> <20231107163142.GAZUpmbt/i3himIf+E@fat_crate.local> <8ec38db1-5ccf-4684-bc0d-d48579ebf0d0@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8ec38db1-5ccf-4684-bc0d-d48579ebf0d0@amd.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 002ED40008 X-Stat-Signature: 1wofn7i948safa7mneurffdmg7r8i5m4 X-HE-Tag: 1699384453-743534 X-HE-Meta: U2FsdGVkX18MXUWQ3XDRrsHPCJ5EonTwPrkmqz6lZy4DTaQNBehw48CDikmc5Jb8x4A6mjm8PWLLIdjRtl06c2kyXZ06deJsWqbIC7NT1uQ27YlksDf6RZXPvXKvpLaw45Zm8AW5+hQrgQs3ZD+ZJp4XOQxlPwSuK118mkYsoJc0ku/q8vES4dVVOBJIFqDNWP+7gf2LMv+v0gl0OITZyKIe28bj8yxaGNfhEwVrhSW8JQLhw2qWvcmnSuY3tHJggcfUqXJUsqPO/4ShrnimnNzE/ALYh3rpsPJfMDAZjF99x2KJDpAw0vjh2P1VVO897oEMWQEQAxsrui4gchkPcdNA7spRK0L1X5PVJ03Mmx3V5EHVdrwyYFw8NQ+PjWPIfDQ7M4H2aM83/8rLcc33up0UwuOUaHe4YsHKKXG5A3jmk/hnyMlcS0akr5tHU9UV7vZw8TUU899+pEuLjnU+M0IdEkY7xNUn0KYdngM/AHE73hOSE4LVfbgZ0OXzvPQxzuC6ZH3Odtqs616d2cnywfiW8raAy7xY1n91ltW2WdpKMrT0QB/Kb26no0vUbWOyGco8ThqY3wAtipZ47F2NUgHVzlPkJxLWwsWwtl0celNFaLFRrp7hGpyzdZRZ9A+Ny0xjE2l82qYjMSykoxHgu/yHO1D2PPK9+Wxdk1MZNaCFH1J8I/D2PryHVGfHb3SLkWMzFFTHLJ5aISIt1Rv7XM5Z5+lf42wwgkGJv8PtLmTVWk9/resMt0KUo0nyAzWbVAf2PCzgXYNJaPv+/Mi7rn7Goo1JXpkzElzx8wk04u+fX3YJCLJQ5o0PbgTLlkkOgyBdANdOtC+eSiP6puL5opn19VRsPeOo8TpHwIHiiSHu9za4oTXaNiGFS0ubWcxHgIVIjE8u9zKhy5rsJO68Tu0wIzqeaFmNXOU1qLU1gFfSzYoMHWh10EDWxl9YRLyshqwz3xfBEN1iyRzCh2i J6GJUNa9 MDPiCa5gBOigFRHYMZiAa7y3hFfSkrP3vNx/OkgCbAR6gNhhunY8/L3OEIlsP4yqSM7wkwRMeB6MdZ7TuQVED6oPrndn03ZSRcjCSYHFlAJqPzU/wJIkugAKddGx4TLJwNsJYV7g75NtJxlYYLahhL1/S7T5oxIAVcBrbuHG8wfvF1ZPLSRcdDwGyRiOiHZAuuFfLuFt57qMNPoA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 07, 2023 at 12:32:58PM -0600, Tom Lendacky wrote: > It needs to be called early enough to allow for AutoIBRS to not be disabled > just because SNP is supported. By calling it where it is currently called, > the SNP feature can be cleared if, even though supported, SNP can't be used, > allowing AutoIBRS to be used as a more performant Spectre mitigation. So far so good. However, early_rmptable_check -> snp_get_rmptable_info is unnecessary work which happens on every AP for no reason whatsoever. That's reading RMP_BASE and RMP_END, doing the same checks which it did on the BSP and then throwing away the computed rmp_base and rmp_sz, all once per AP. I don't mind doing early work which needs to be done only once. I mind doing work which needs to be done only once, on every AP. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette