From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F33C4167B for ; Wed, 8 Nov 2023 00:07:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B0148000E; Tue, 7 Nov 2023 19:07:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6605F8000D; Tue, 7 Nov 2023 19:07:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 528E68000E; Tue, 7 Nov 2023 19:07:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 44E298000D for ; Tue, 7 Nov 2023 19:07:27 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2005B12016C for ; Wed, 8 Nov 2023 00:07:27 +0000 (UTC) X-FDA: 81432847734.20.A6D1A24 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 7CE46C0005 for ; Wed, 8 Nov 2023 00:07:25 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of "SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699402045; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E2RQ78kP+vi8RmYvAJsFY4pjaG//YJ88tewExCMgRBs=; b=nlhTGArwuSHJrqhB1EDLhsCTcf1EV9dmgk6xqfzHEVV/TJIMptToixYkbn0kMUtySFwLuU Xo78JeyiMzlZnoUytLVd4yee3mZITAR2BIfBqjckPMB/1fa2gqik72FHR0PhKRlKtDXWKH 4FTDFUGTdwZk7KN7DGimImrMVeHPENM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of "SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699402045; a=rsa-sha256; cv=none; b=Eh4GQF0K96jH1bUZKpksMST/LISeRUkUWrAIjohITqC+ZRYabhaRQsyIUYHCa+i8/Nw8LN su9qlVUvZiDkCMZtz4VlLFkQBR4rZLnNm1thnDxnFSI958T3QJSgtLAz/GVcyeMKTFcz4I qHmVaAM59SlbkeLL1s22WNt4/zwE7IQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 71EE060FDE; Wed, 8 Nov 2023 00:07:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8114AC433C8; Wed, 8 Nov 2023 00:07:20 +0000 (UTC) Date: Tue, 7 Nov 2023 19:07:23 -0500 From: Steven Rostedt To: Ankur Arora Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, David.Laight@ACULAB.COM, richard@nod.at, mjguzik@gmail.com Subject: Re: [RFC PATCH 45/86] preempt: ARCH_NO_PREEMPT only preempts lazily Message-ID: <20231107190723.2512d900@gandalf.local.home> In-Reply-To: <20231107215742.363031-46-ankur.a.arora@oracle.com> References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107215742.363031-46-ankur.a.arora@oracle.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7CE46C0005 X-Stat-Signature: rjpfou6xb1jyib53ehiu4hd8yirykih7 X-Rspam-User: X-HE-Tag: 1699402045-399185 X-HE-Meta: U2FsdGVkX19DO7QAd5xVX0+yeGe6UAixn21F2TZloP5KhsRxjl+YoCfuyt9DLYVMU0fELTbHzuONjCk+H6+5cwtZ/jl06PJP1TWm7+MRCDbZnY9ZprYzUQIkyMvGaZziRn9IdHc+CzWN4wL1vi/FyTR/pWeaUW7faUP2OeP8F9zi0LOZX4dEfoh28XoO1zlHa1AkKLZ9umFVIHFOlVR1gcd/9nMJfYEZ1lo5lvKUPVs2vbkSj7U5EY3RvxcZWh72YGXWQ+L8PoqJ5lk3oUaVoCkdy8Wp9nFt8DI+Hzj2119Yc+ICaAOye0YiCF7KzVbm7UB44WjxE02uJRR17+k6OKp5x2czyz0kxCu5TMz2bHX/I3eRVA8QxoQbegr6IR+eJqV5A9F4W5TeT9GjaPPeywPxaqTOmb9gw/qTslUDOyYbS+J+Hc9is97qzYFX1lckykapyAkNgJDccLH7jF3Zo5F5LVALVUf0LBOdTgdyUHXuQda/kc4G4VEDvTQ9oKqsZKtGX5iRfWbGzxBHGhvEZtfXbY7fq8HIBO5QP1X8dBJZcFrISfBU9wj0df17qQQDo+/Z45glQAntjFCPhpI67oh/IzEN4hLxSwPXBjUMuTDrQYQPq5gChTU1ShFzilVj/PYccx9EUN/3LS0EngEHvDB+/N3DMJF3xyAiCidyWAATQQQuuio4LT5YpvChqhh/3s9NfYg6S+BRoeEZJls0oKqPOsR6FbPYXuMKwSeM49HcX7A5c0+eEOhoDmddpgNvpnUXLN/HV5fChKQWplG8QBSr8D2gdVkIb/wGTgpsaQlDwy92onxyXFaNvbegrbZqCZk4CfQF2bxVaZZtFjgnA9aTS6SoBq6lcS0v5m4Bi0zMs+dG4iu+9WT5DEdrlXeQhsE5LWvuuwhBeTUKJKizjkXDWRltMsE89yAtRVhPiEAz/ogwBDODxdH5r1+3OAsrpHRQJ46SeTvil/ETb9/ 1DMyYz1w p8Juqoh8Un3YOtcB0ZmY6H4J7u+An55mv8B1ptGeZ5lFbaYUPsxZCJpyKEAyf/jg5aTpNpL/k/XtTri0p9b1frp/6OxgrKg7XG5/0j5QMVfe2XLi1oliBr5mIxx0OPRxrJVUGVZ6wMS1nTvWZPDZ6RTUs9xSTlVlTJwUlmsva75T7mGy6Kai8xzmUj8os7XtbNGMOCVMnwVrf8uCNbAw9jd/Q8x4tocgvfmhrAHIwZpyY3QAWFgKPgNr5j+4LNxTO3Xe1GPGZbIB5MgZZ0qP4zD2tohKlHiKfC+DBFmZHiyJfok62Y8SJBt4M/0jANYdDtE6f X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 7 Nov 2023 13:57:31 -0800 Ankur Arora wrote: > Note: this commit is badly broken. Only here for discussion. > > Configurations with ARCH_NO_PREEMPT support preempt_count, but might > not be tested well enough under PREEMPTION to support it might not > be demarcating the necessary non-preemptible sections. > > One way to handle this is by limiting them to PREEMPT_NONE mode, not > doing any tick enforcement and limiting preemption to happen only at > user boundary. > > Unfortunately, this is only a partial solution because eager > rescheduling could still happen (say, due to RCU wanting an > expedited quiescent period.) And, because we do not trust the > preempt_count accounting, this would mean preemption inside an > unmarked critical section. Is preempt_count accounting really not trust worthy? That is, if we preempt at preempt_count() going to zero but nowhere else, would that work? At least it would create some places that can be resched. What's the broken part of these archs? The assembly? If that's the case, as long as the generic code has the preempt_count() I would think that would be trust worthy. I'm also guessing that in_irq() and friends are still reliable. -- Steve