From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C0A9C4167B for ; Wed, 8 Nov 2023 00:00:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71E4B4401BA; Tue, 7 Nov 2023 19:00:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CDC744017B; Tue, 7 Nov 2023 19:00:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BC3E4401BA; Tue, 7 Nov 2023 19:00:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4C8FB44017B for ; Tue, 7 Nov 2023 19:00:23 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 19AD0140BCE for ; Wed, 8 Nov 2023 00:00:23 +0000 (UTC) X-FDA: 81432829926.09.928789C Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf15.hostedemail.com (Postfix) with ESMTP id 05CB2A0025 for ; Wed, 8 Nov 2023 00:00:20 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of "SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699401621; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ahtw26kAMcMpTzVRZbw3jwdjOV577YGoAjRhIMkmVs=; b=p+VvnEWosJo3RLU3jPzpKh6YhfX3Gj2cPHADwDXKFlANtisDc2zjEGHbgNgbvDYlNr5T6R PD43KrABqUsR/UvTwnO2qFxTSPiXUSwqZ4YXjs37yXKtedj1wr4PGn20OKqrI0WHLorrQx zSCVTtzZ6cqDjAPisLVf+MLXz4JCJTg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of "SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699401621; a=rsa-sha256; cv=none; b=wJbarmMPJgQJmh6JA9zCuvKbxrgUgSA05CDwO2+1i5yAKVrF+OMD0hon6FfSoLUvfPLAQQ b9wKL2CFT6yyFTjzR4Mlv+kgEinU6L18t/BxZBCXLsOy+kceMqbVk4R8SBCi/XRP1bi6RM bTAfwgPYEW2qIveKQQtAk8kguT3mUqs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D02BFCE0FED; Wed, 8 Nov 2023 00:00:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A48CC433C8; Wed, 8 Nov 2023 00:00:13 +0000 (UTC) Date: Tue, 7 Nov 2023 19:00:16 -0500 From: Steven Rostedt To: Ankur Arora Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, David.Laight@ACULAB.COM, richard@nod.at, mjguzik@gmail.com Subject: Re: [RFC PATCH 00/86] Make the kernel preemptible Message-ID: <20231107190016.2da8c402@gandalf.local.home> In-Reply-To: <877cmtxh77.fsf@oracle.com> References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107180153.4a02d2ba@gandalf.local.home> <877cmtxh77.fsf@oracle.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 05CB2A0025 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qakf591cnjw8ormynbhao1uy5b6ezfto X-HE-Tag: 1699401620-624703 X-HE-Meta: U2FsdGVkX18f5KCPrqlr6o7K2L85pbOlqbwNi22dgHwOxiPbMPpcZt8VoG28CrYngmfD4a2S7gjDmuScIPc8uW1IziUYbyw94DdSu6BtoJO3hDveLfqMMgEmvrS2n8MFlRgv1KYuwG01VT+nei4YueSIZvhrWPd5NHmnDebMeH5E775Q8EdYEN7hIezQJd1HD17B7Xp63JZ/m/kihNHB6Xui6B0z2aoFueVPew9Th/1yZ9iIevLHk2JOqTZS44to8N8MBQXReS0tP8ByEDVUBhG3hP58LrLLtGq4F6jKVfZDzAaou0xYl8etEaEaPbB/XAiuULMIBO0bhlfRsSFxFLE8o8XFWMsIyYNtKzcsQZu9ojnD2kIVf2TWGiPaJ1wf46HsgiCP/1/8NmP9S+JVuLGnQtHbiDG6NjXhuUf6NnDnSh/Ctp1Z/jfphxNQyhP7jYTzNdVe2KnA9U7rERL2Ivrli/NAJKpcbE1p7ddVPzDTNlrtxPDvHdMrSSvvr6Ht6heYrfX+iRdbokDM19lVMLZIesLbzRDfXfpLEgXPK0SI8cnlMASEaEQ4nTG0V1YFke+hhhz20CLsourHwmTDQSsZsBKVjtkWTJzymph0vIeq368tUciN5YkrVP9uuqF/1eJwYENhbodca+J+jNRsy8FVAevdjRHmVehWcf6SmOamiAUpEf5AcTBGMvP6j5kkPUkHJ4Ai+EFmsJkj2Vnafk4dAyyLDQ9lwoivt48YBlgCBSF+VjalvSNNMb2cCYnlqtrYM4Wb6yFqqkMlNQgzkrEylE1icoqHS8qZKXSctAOUXmlQbzPk2nVLx+bYT5U3WmRZDh5ytXqJVye4pBgUznJQSRz5F3c/B3vb5g1dP2Gi6aqoBtPf9+rYRsUEWUgsGDo/5EEjg5vMe9eaiZomF7OEC1XOMLN/b2uGp8Kn+Lia1ThFa7+PgnFnjvhz9Y1qakob7ePrcwGyeV34VZ3 03fd28Vl 2VoXLkhlTTSQMo6JptW7CcTICbalWWcMDtnVChyCcTWBioyqbOMsUizvQJOSFwbULj0+JbMeugGi+bRcbxCHSSPUKns68Lau2JKG2uBeQpFOHK2J36/kmcW9jM0fSYdZ/FlUjEzrJAKstrgsdWmF1pbx4ha47e0omeDwo4Cqn5KOVeV23RRhfu6Sqm09Iy4PhEpTj6s2ltBx70CUpeRd+2MeLfu8okJ7HUbO/3Ti5897F0NzFPyOJvGQhm+D0LNZ3T0eyqJvs3w26Wqui4Sn5AkSLCA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 07 Nov 2023 15:43:40 -0800 Ankur Arora wrote: > > The TIF_NEED_RESCHED flag is evaluated at all three of the preemption > points. TIF_NEED_RESCHED_LAZY only needs to be evaluated at ret-to-user. > > ret-to-user ret-to-kernel preempt_count() > NEED_RESCHED_LAZY Y N N > NEED_RESCHED Y Y Y > > Based on how various preemption models set the flag they would cause > preemption at: I would change the above to say "set the NEED_SCHED flag", as "set the flag" is still ambiguous. Or am I still misunderstanding the below table? > > ret-to-user ret-to-kernel preempt_count() > none Y N N > voluntary Y Y Y > full Y Y Y > -- Steve