From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BCD8C4332F for ; Tue, 7 Nov 2023 23:34:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A14CC4401B7; Tue, 7 Nov 2023 18:34:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C4EF44017B; Tue, 7 Nov 2023 18:34:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B4C94401B7; Tue, 7 Nov 2023 18:34:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7C8FB44017B for ; Tue, 7 Nov 2023 18:34:29 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5C5EBB4D44 for ; Tue, 7 Nov 2023 23:34:29 +0000 (UTC) X-FDA: 81432764658.21.98AFF33 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id A7BA24000D for ; Tue, 7 Nov 2023 23:34:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of "SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699400067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7FQkIMHnMddzjSmZFQLAtVDtQeu8FZE+elRUlMe/N7E=; b=p8zbJZ48gsynYG0nDDJkvlbhBCh413kUP5sZAeB2KB42c7cLDMU5mxyZjKdSP7joQ8Q2sm 7cfJjkwW5W16DwB8C5wpeRkzM/UxTgGEQUwEWhD+oNUxize8+dWuvdjqQH7/RMkV8N7swk V48p6P3LJW1ODnWUxEAuL0UZVrDG6PA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of "SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699400067; a=rsa-sha256; cv=none; b=Jqt6m/0UTs/0xfB2ROcz06Wuu53Fd00wfS7P6UrsKXr4shVZ6TfPsZLgPrENGmbRmMj88Y fWeq2A3WTB13UmixF0phMaXUyUWHi/n7UJqoadnK7Cfy5Ih3hPR+I1kDf7JmyXguJtxILw ALmZRaINvulG3YEnv2HBCr8XJHAxpmI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D2D7F61477; Tue, 7 Nov 2023 23:34:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E27B9C433C9; Tue, 7 Nov 2023 23:34:22 +0000 (UTC) Date: Tue, 7 Nov 2023 18:34:25 -0500 From: Steven Rostedt To: Ankur Arora Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, David.Laight@ACULAB.COM, richard@nod.at, mjguzik@gmail.com Subject: Re: [RFC PATCH 03/86] Revert "ftrace: Use preemption model accessors for trace header printout" Message-ID: <20231107183425.2f8b98a1@gandalf.local.home> In-Reply-To: <20231107183154.7f6db059@gandalf.local.home> References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107215742.363031-4-ankur.a.arora@oracle.com> <20231107181057.334c815f@gandalf.local.home> <877cmtywpy.fsf@oracle.com> <20231107183154.7f6db059@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A7BA24000D X-Stat-Signature: bi6tdqtby57udfyz6nf64mg55xqd6fxp X-HE-Tag: 1699400067-941834 X-HE-Meta: U2FsdGVkX19mZ3/dTvUWtRkyt5mGaY5ot+tUNXDrheB+I+bJ+UeO0oZ8Qy0gLAEuz0veXKll6qYT/BMMi55/iwvSqKsilBh3WO5MUmjPkn2Z5rHwJHLmz25jtPvTXUbd2wd6I+F9q385foGoFvkFtai0RrYdVw0Olbwcnjy7XumKLO7ohg41kDT9x5lfTj6VoX0e2vf54XNVLf0Lpo/DWlSd0UTntqOZYJtKbg+sN/HEA8nQu3j4euT6zltbV0TqPaZ3+HCh+qblnpUGDFFh9EUikY25ir1JQQz7JoLVAx4swdywuY3dKnCBm3dl5LPKr4WIeWJRxfTf8HuBOwhbzW/XK4iVOSTgwfAEmk+UmzCTMeVs4BSA/SvUC0WS1QeR4Fdbd6cg2j66HQavg6PSuOHqGyOmNoTlRyURQKLDupV2V/bYQ++EjrB0V1FSaRTliArcelGkh38AmtBSkd+U0ufjp3/miRfjEMFacOvAfxdo7grEjKfQhJ4uNVWG54kAuFOeNVTE1iGCzVNAzd8emWBcBmejiVjKKLkf0ZKsWnnwJPVewSkbeodXNvo0bSLScWcV0HDj1TXHdWTx0Q56p49ow2xuGfjWflXdaqeK9ySiQU/SjxHu1Hn0OST+XynJ5AZjPXiiwKUvTSxOWhHNPbGQXI1kpV+ElTgW0RbqJQdkj2n5hMuf0mVMP99kmie5UWqjPnUJFleY6UCuCHcibLHG/xbSzsKbEhris7U/9uFkKDTuGbbsHyxcERq4NO2nH3BpyTnQoQ8vwmYf56spXDuWAeTuAXH9fRUFUke7XIYT9jbXzn1Il8KdXhQiEMr95QqlyCthwCics4ErEY4ljzaAApvSEN5/fl7sA8XJ4nEJ/vhplQOqEeTPIvBAS6bkVPqpeslGELG/yxhkoLi43g8uCU+qPepg/2GGQ/K8WboBaKvIZ18gtC6rgApb3ST2hBbv9eLO4QZ0D0ltjSs 8u92xrL2 ZE4RIeG+O/f32XsSOvuCadQkMykVkfXrdUgprav79sl95CNcqFNTG8yCjMmAjXqQdRPS6iqQItg4ukzVCEbskNdr/EbIJ/KDWzw0H20eX6fJlYsVSKhh+6iTsCRN/GewKxqIOEG6+AJi8D+HL1CcDrpkGb8p0f3i0R7Yjerjpg4JDcrxgLt74o/GRxA5FDqeqcww9nrZMGEm2LmlidOi7eW4O9R4RsPc9muI66iUM7KYBQNcDDayt+/nXyTg7f6tSz6UUCZjtygaV19lNL22EC3X61BJhPm8xP8W52QJ0sNtScC1HcsXSBYpW8LDFGX11z1ZoiAzT4eE+mUo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 7 Nov 2023 18:31:54 -0500 Steven Rostedt wrote: > On Tue, 07 Nov 2023 15:23:05 -0800 > Ankur Arora wrote: > > > Or would you prefer these not be reverted (and reapplied) at all -- just fixed > > as you describe here? > > Yes, exactly that. > Note, a revert usually means, "get rid of something because it's broken", it shouldn't be used for "I'm implementing this differently, and need to remove the old code first" For the latter case, just remove what you don't need for the reason why it's being removed. Reverting commits is confusing, because when you see a revert in a git log, you think that commit was broken and needed to be taken out. -- Steve