From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E754C4332F for ; Tue, 7 Nov 2023 23:20:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 248CE6B0249; Tue, 7 Nov 2023 18:20:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F8586B024B; Tue, 7 Nov 2023 18:20:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E8B36B024C; Tue, 7 Nov 2023 18:20:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F367F6B0249 for ; Tue, 7 Nov 2023 18:20:37 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CF9FCA09C1 for ; Tue, 7 Nov 2023 23:20:37 +0000 (UTC) X-FDA: 81432729714.18.9324BBB Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf20.hostedemail.com (Postfix) with ESMTP id C34991C000B for ; Tue, 7 Nov 2023 23:20:35 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of "SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699399236; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TG04M9pdG4e1a7xe2WtpTgmtWYVqFT/rG6CEd+nqDwo=; b=MAlB49vLC2fRHZOUYL791fZ/t76XnRQLPNL0cZMOvDMrU2K/jwIU8rPcXhgkxzHsJovY7/ aT7MNyrWVEO6EalsSiUvKy5LHYFOzxNoy0NxQDRgNhZjBBx76cmUqypecH3xHbdr7Gr2bd /U+PU8ZZzfEx9TVrgzp7o0jMTaq9A+U= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of "SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699399236; a=rsa-sha256; cv=none; b=7l98pTSHstDTZVPxSS9AWL+LjzGLaUkIQjCdP3NtTcSmLaOExsriSZMBUop8WFu+cApHRI Ulxe/whhy+jCia0hxawBlWvDBBONTW9NvVaI0hDGIkpvGlx7claMJ6+0orZaTFubTdz1hF 9t7opdoHybkIvUanlqOLhijmRYyU5FY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 08288CE0FEA; Tue, 7 Nov 2023 23:20:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FFDDC433C8; Tue, 7 Nov 2023 23:20:27 +0000 (UTC) Date: Tue, 7 Nov 2023 18:20:30 -0500 From: Steven Rostedt To: Ankur Arora Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, David.Laight@ACULAB.COM, richard@nod.at, mjguzik@gmail.com Subject: Re: [RFC PATCH 14/86] Revert "preempt/dynamic: Fix setup_preempt_mode() return value" Message-ID: <20231107182030.0dfc4e78@gandalf.local.home> In-Reply-To: <20231107215742.363031-15-ankur.a.arora@oracle.com> References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107215742.363031-15-ankur.a.arora@oracle.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 69gch6jp6esyphk4kb7xr9ytcgq5kp5d X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C34991C000B X-HE-Tag: 1699399235-712988 X-HE-Meta: U2FsdGVkX1+j32plarXmNjZ99hw2UUGDxRPP66NWOIFFkipUdNV4riaooWaTdNrK2Dlv9x75DFWimeUg22SjYiwo7xVxYFfe9HYKEAlEl/oVQ4EKf8+VHJacrN1LQl+U3ML5rpykCU4Uz3hIvhMKvFNPXO+wKjCZi6rsMsTWU08AokiLFm7EGcJzBZq4u5AUGlAmFp2I9HxguWtq50oBpt7+WzaQlMfPFmP555RWEIbh5iHXlafMZSGTivPQJKf5IleMZ9yCVSwGjOZc10FMyWv5LbrznuxW4ncylpTYIgYq60mP+HYSMSGvL2OWaHqpSYyLO27JlIOWoAs9/qlke2A3dq+9X5bNuP9cun1aGz5U8zXLrdLzGvfZsYEExDOIapsb3/cjQyVyO7ed/DVaLD+mXwNYEFnllCYnUdt2HZnRRpI/DT/ijn4eB/PG7AAJDpa+tpdGdO76ddvHMTfGUOyMoXrWw1QKtvA3wrwcznJm/A4uWkHZlzrnULTyYAK3PSkoQp7FJvZR0v4nONQmTEl3sobhB1jYrBduzXvOqRxfMd6zFqCLb42+u2ulAeBp5Xq1NQ+1mhdQeUXVlnG6o6TjusuJ/Kw84bUQvuKk5+0K5UBuCzppzz4bKgaxNN6cDWhCqrdN6sldB8K7CyxAPR35ONulq03XLyzCNghUaioqe5AaHblmMOwCmEFGDH3UbqqH0zJHUCzRGHbRQLXEXc9nZSFuUXQaVTKv2WyU1pvUORTZaetKK/CCknDnGM463KkvqIWWx8jtKrt8PDzJQG2P2BPcOywM9ahzDeudcLPC4bSqOEwiFO2e0yZE//98fEw0fWBJmolRTtSFNMhQMItkiaIJmnQR1F0wn/xbmNKUR+lTHbYuZi/13+OdmO8geVxWpGfxtVxWzuu0J7sojW5KIhww6+fYSm/E2dtWZQio7zTqKt/VoHghiBHQlct9942Qc9NP6G23wqWyM/k bzFVQtdg WPXxNa/CcsGQXew/tcPstZL5l9ICgFVLcoaFWOAebtGJLpT3b/qwI7D/Ast7DV9bAbGa9/9SLVS/09rLRRx9lbJ4Qi3oXU4LOVYpqmvv1m/trDOI2l8UBqC1XggZezPQZ/PhM5Xjfjc0HFsW1Dak165vHWlJbFYgtGETYIiWrbXc4t6yd6G3OEvH43QCis/bofjST5PJRl3lxcWCvS165JDmjlhaXk8f8VVCZlVEQU0qLqpRvkSm0HLUNTuuaIvlIQQdLqRmBsY2Sty1d528YYUpDgeOA4ovrAufu4fAzoa1l/POizR5h9Mdh9mWkpeaywDYw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 7 Nov 2023 13:57:00 -0800 Ankur Arora wrote: > This reverts commit 9ed20bafc85806ca6c97c9128cec46c3ef80ae86. Note, it's better to just do a big revert of related code than to have to revert every individual commit. You can do one big commit that states: This reverts commits: .... And list the commits. That is, for commits that affect a single file, do not cherry-pick commits to remove, just remove them all in one go. -- Steve > > Signed-off-by: Ankur Arora > --- > kernel/sched/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index f8bbddd729db..50e1133cacc9 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -7062,11 +7062,11 @@ static int __init setup_preempt_mode(char *str) > int mode = sched_dynamic_mode(str); > if (mode < 0) { > pr_warn("Dynamic Preempt: unsupported mode: %s\n", str); > - return 0; > + return 1; > } > > sched_dynamic_update(mode); > - return 1; > + return 0; > } > __setup("preempt=", setup_preempt_mode); >