From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ACCEC4332F for ; Tue, 7 Nov 2023 23:17:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09A746B0248; Tue, 7 Nov 2023 18:17:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04A78280025; Tue, 7 Nov 2023 18:17:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E55766B024B; Tue, 7 Nov 2023 18:17:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D63A96B0248 for ; Tue, 7 Nov 2023 18:17:16 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AE4DBB5D50 for ; Tue, 7 Nov 2023 23:17:16 +0000 (UTC) X-FDA: 81432721272.30.3AF4268 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 0ADEF4001F for ; Tue, 7 Nov 2023 23:17:14 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of "SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699399035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8PAP1KvBiOfJ2FiiYNtARVE8OS5LnOvoZP4Mxfrkoy8=; b=7BjcVtpn4n9+hVvo8vaM9eERwI/onp4BajBgqugR5MrkHNCkupLSKgjvYJiX2r7KLXuftE 4BopMGjJS90Bfd+BaZAL1PPT7seQ2Pusa5yixVhJZ5oKnPNEnMvbB3/69UsTfTQSnv+rb9 qRM1FWisx+32I2QYdRiZuEs+a8ECOx0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of "SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699399035; a=rsa-sha256; cv=none; b=dMQqMfAI3TbUmbjt8h0Cg9BqoF83TCJY1FTCqCkaS56g+xUk0oC9GKzA+v37tz86WK1LJ2 SUTNMoGgC4b0Gn7ghY/s3MS664NU095BY/X8CuSbNL4QoBZhy36hn8Jr9rqimolOb0jrUE roivo9eVGicGem89DqPOvhdnZ8OfeIk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F1F0961345; Tue, 7 Nov 2023 23:17:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1445C433CB; Tue, 7 Nov 2023 23:17:09 +0000 (UTC) Date: Tue, 7 Nov 2023 18:17:12 -0500 From: Steven Rostedt To: Ankur Arora Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, David.Laight@ACULAB.COM, richard@nod.at, mjguzik@gmail.com Subject: Re: [RFC PATCH 08/86] Revert "arm64: Support PREEMPT_DYNAMIC" Message-ID: <20231107181712.28989b02@gandalf.local.home> In-Reply-To: <20231107215742.363031-9-ankur.a.arora@oracle.com> References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107215742.363031-9-ankur.a.arora@oracle.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0ADEF4001F X-Stat-Signature: uj9hsheiecwh7ecqata9bcar1t1xm537 X-HE-Tag: 1699399034-467424 X-HE-Meta: U2FsdGVkX19Z0ZAlZ40SHHVb4ke6RYAW98qv27Wei1eAQKmM5yj8QjH92dbeuatponwGB/Vdy7NT6xakCy6yXmJcwUXd2EdNMNZNScQAW3PN+J+FOCwyiC8VE0iQdn2PXbBNYu2xriWLSFetb50NDRbJLhD3q/J2qfGl+eCa6JneYROMvGuw0JNoCIQ0lFCjPGWvATc5GjwE6B2JR5jQWWlai3r/m//RN2J0hukGCJ0kUSNWLAM7XQAUCWgfMwAZws8yD30gmKAdbyz0FcpQ9ug7Net/L1/gkrPWQvhmtUg4AkdBgu7i79+1g6bZpBWALzTcdgzvy4Msaf2nu8pGQpK+kmhSG3rsOh7dcZh9btRUklfbQdVuNNjhov7i5S9NAtcoT+qCbHCBHOyxgINl9SIiDKsU+N83lA2J9b19ayqOQb2v2GOdK4x+pUWw2azJENQ9J7RRjWNfzwLikTP0LAr+6flgXu0LPy42kOisQHoyPbxE9vwQdmPx7/qE1WW0dj+yg+Y6PNzEdsuIJObQlkQAj1gLDHlIyPmQC0hzUrnSM7CjIjOXf3YB9CnIFlbfE4g73F+/rasbXgthrLf5kikGvWgw8+i2g/t5xThLgUnkuJ+sz2lriCQeT997CDfgQUeVl1IUmu66O66PnvL1Fu3CTulclBde2a/U+fO3/uzKx3UQlaNjYjZHY/+9/qenurD6r9TZlLkNuk7uJCi7aFOzzvlkDfS+ydSTRbaQUrHiQoab2keTx54zyO/GfI2R9aK26ZyROUv0tsF3LDbKYiABU8YBLwni91XHQavtWIu95xR7T//SYH9tnOsk0sVxZswsRVetdR+CjtcEDVZTHdE77EQvVIcL5nvz2VE1EENTHj2IsBl044yPB9/LbRs7HwqEp3sK9IozHr7liaX/EPGfmI7T/MteaFjuUrntBFMzqDHvJ7ImQu30K+xY495uV8DLGpwSKFzhUIBaQ2g jtDCfVho 6tk6kLf57HEEyB8VLqA4Lip+8kX7Z5esVO471KTY9qn6xWhhSQsIxQ7VNBL0MGMs7G7vplPcXMm3s/S3gBMWJD0xgyuRH6eCZ4zDvKihhmZqC/XwT8whOpz/oRDjoo7vGYd11Mq2hgS5hOVo9Ci4Sn91SDQX0y2z2D6vi4RwygH74VpkcgIm0jCm2yqjwZucTce7QSBn9OJjbPWM41uEGJBoPgdI67DNGI64zIndEHMwblSwLvgVxZIPoNNU+nRiXYxHFFQSCNt39+z6CoCsJhEoa2IS9q/BoRDNglLijmW5Cw/6ZEyHvotaXHr+5bHmBlu0j1kbYt9W8n4wvznLLcWPFtBvdJBs7lXEeehRQpneAxhg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 7 Nov 2023 13:56:54 -0800 Ankur Arora wrote: > This reverts commit 1b2d3451ee50a0968cb9933f726e50b368ba5073. > I just realized that the maintainers of these patches are not being Cc'd. If you want comments, you may want to Cc them. (I didn't do that for this patch). -- Steve > Signed-off-by: Ankur Arora > --- > arch/arm64/Kconfig | 1 - > arch/arm64/include/asm/preempt.h | 19 ++----------------- > arch/arm64/kernel/entry-common.c | 10 +--------- > 3 files changed, 3 insertions(+), 27 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 78f20e632712..856d7be2ee45 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -221,7 +221,6 @@ config ARM64 > select HAVE_PERF_EVENTS_NMI if ARM64_PSEUDO_NMI > select HAVE_PERF_REGS > select HAVE_PERF_USER_STACK_DUMP > - select HAVE_PREEMPT_DYNAMIC_KEY > select HAVE_REGS_AND_STACK_ACCESS_API > select HAVE_POSIX_CPU_TIMERS_TASK_WORK > select HAVE_FUNCTION_ARG_ACCESS_API > diff --git a/arch/arm64/include/asm/preempt.h b/arch/arm64/include/asm/preempt.h > index 0159b625cc7f..e83f0982b99c 100644 > --- a/arch/arm64/include/asm/preempt.h > +++ b/arch/arm64/include/asm/preempt.h > @@ -2,7 +2,6 @@ > #ifndef __ASM_PREEMPT_H > #define __ASM_PREEMPT_H > > -#include > #include > > #define PREEMPT_NEED_RESCHED BIT(32) > @@ -81,24 +80,10 @@ static inline bool should_resched(int preempt_offset) > } > > #ifdef CONFIG_PREEMPTION > - > void preempt_schedule(void); > +#define __preempt_schedule() preempt_schedule() > void preempt_schedule_notrace(void); > - > -#ifdef CONFIG_PREEMPT_DYNAMIC > - > -DECLARE_STATIC_KEY_TRUE(sk_dynamic_irqentry_exit_cond_resched); > -void dynamic_preempt_schedule(void); > -#define __preempt_schedule() dynamic_preempt_schedule() > -void dynamic_preempt_schedule_notrace(void); > -#define __preempt_schedule_notrace() dynamic_preempt_schedule_notrace() > - > -#else /* CONFIG_PREEMPT_DYNAMIC */ > - > -#define __preempt_schedule() preempt_schedule() > -#define __preempt_schedule_notrace() preempt_schedule_notrace() > - > -#endif /* CONFIG_PREEMPT_DYNAMIC */ > +#define __preempt_schedule_notrace() preempt_schedule_notrace() > #endif /* CONFIG_PREEMPTION */ > > #endif /* __ASM_PREEMPT_H */ > diff --git a/arch/arm64/kernel/entry-common.c b/arch/arm64/kernel/entry-common.c > index 0fc94207e69a..5d9c9951562b 100644 > --- a/arch/arm64/kernel/entry-common.c > +++ b/arch/arm64/kernel/entry-common.c > @@ -225,17 +225,9 @@ static void noinstr arm64_exit_el1_dbg(struct pt_regs *regs) > lockdep_hardirqs_on(CALLER_ADDR0); > } > > -#ifdef CONFIG_PREEMPT_DYNAMIC > -DEFINE_STATIC_KEY_TRUE(sk_dynamic_irqentry_exit_cond_resched); > -#define need_irq_preemption() \ > - (static_branch_unlikely(&sk_dynamic_irqentry_exit_cond_resched)) > -#else > -#define need_irq_preemption() (IS_ENABLED(CONFIG_PREEMPTION)) > -#endif > - > static void __sched arm64_preempt_schedule_irq(void) > { > - if (!need_irq_preemption()) > + if (!IS_ENABLED(CONFIG_PREEMPTION)) > return; > > /*