From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35DC8C4167D for ; Tue, 7 Nov 2023 23:11:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0861280023; Tue, 7 Nov 2023 18:11:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB87B280022; Tue, 7 Nov 2023 18:11:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5961280023; Tue, 7 Nov 2023 18:11:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 918DF280022 for ; Tue, 7 Nov 2023 18:11:03 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6B2E7C0BA8 for ; Tue, 7 Nov 2023 23:11:03 +0000 (UTC) X-FDA: 81432705606.24.1F27A49 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf02.hostedemail.com (Postfix) with ESMTP id 98EF180010 for ; Tue, 7 Nov 2023 23:11:01 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of "SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699398661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=67oMXM1lBl93o5PNgf3UsAuAIQqQQ/t8d9+OWS94FG0=; b=5zaoMfq+jcQVxcG9yi7r8CQUI0eBcMgBKFp1De1q6WPSiHe7vYqKF+5SiZYWAIIC4VYDNP BHAmUUATEOsC1U8uNm9aK2LIrLPQWQaRhW9yHDUoWcg+PNXZDOmPf4ZBcXWtP1z7JGQ/9U nHPyv6ydAQhN2PY6ZHg0o6hyndfGRKw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of "SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=mXuw=GU=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699398661; a=rsa-sha256; cv=none; b=Q0HfB6Mu0d2bVWgMCohGfJkUHpUeJ51bHfWs3Z0NuHmDlGYNS3MhiIpjT/AeeOnb31WDQW 4Y/Y6xH0nFwYCqQAtPPHc+FwC+oMWvu86znCPY3NkVkIrmKObPEQgTnZJf0xHfWWoCULLn Vb/NK0mHSGGAur12ya5v97oHXd44Dhk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id CA85AB81A19; Tue, 7 Nov 2023 23:10:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82322C433C8; Tue, 7 Nov 2023 23:10:54 +0000 (UTC) Date: Tue, 7 Nov 2023 18:10:57 -0500 From: Steven Rostedt To: Ankur Arora Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, David.Laight@ACULAB.COM, richard@nod.at, mjguzik@gmail.com Subject: Re: [RFC PATCH 03/86] Revert "ftrace: Use preemption model accessors for trace header printout" Message-ID: <20231107181057.334c815f@gandalf.local.home> In-Reply-To: <20231107215742.363031-4-ankur.a.arora@oracle.com> References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107215742.363031-4-ankur.a.arora@oracle.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: njgufnggn895m9wujgxn5fj5efuw1r7i X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 98EF180010 X-HE-Tag: 1699398661-13131 X-HE-Meta: U2FsdGVkX1+Ip7pLhDGeurUTClIrGLS4QFoSeclintbZMWigRtcaEb06UV0+AegVTgdwB8Ckvk4dE9c9CwEvgWSQRBeMdj0fM7IxVltrrWbMie3GX+3dUKEb+yAJ/8C87QcYtTpQXdmHEDnFQllEiskawL73HIsk0phvVEwbhQOilYrmm0k0d/8PxM9myQ5RRahTeSTeS3dyB8QwKSlQ69qSXp2PzW7/fyDlJ2DcL8h/N5fmqseDm80wJUh1Nr2GvG9EyUzvIWpYIsBtxX93F/MF2Mdj4LhTerx0j4LGypRFZ/AqMNev4UaHKEvrdGl30eVyMWPmasMqUxFQa97ndBsn3qod1SDdeuND8hH+Fxrc/Miq8ByLZxLUvDy2Ie5YhyWrUt+jx2Sg3xXFbnzwcjWtEyoLMh5skU/wDDI1LmlqfD46SOf7ONH2ZLp5DNKdUPM8M+3jgU6nRasdTTsUtPapkjuYwzno9A9ZXagYHldVGPyiToD4A0dwCMHN44+Sd8HDG78BPo+HkFkGvGFa6Xugq51TxrJvpVppgHYKBfbfQ9M/M/HxS39nahQWqb0H6gGpebOh+xhJrrFDh2S4Bn0rmVnVccNfCdzD0GCurC6Aa5JPTLYETbClUW/f3xZe4YNisywDzQjSOYDKfFqdvStcb7hXXX27aeCTGbLCtyjVz/IrHrfTCPmplUIhG9Ues+hOZHN0IxS5JzNO3Y/bhQcMp82biPPR5hO5Bqtt3dBbLA7Y4J6rSUWdNgBVWkpCNtcjh0htCzkQR5444+GdIs24E96d5N6766i7ETNIiqiqATwjsYH83pSodybmTOogloQOpbh7YztvkUp7AYP7KPhZQYhhZ227gU4y6Z9cWlGQ7lCy8RwT60+sjLnZwcmwCbUL+jXmcNKjTxv3AUB3BZCWuxqursRLjQfti5OOHWMwbpco74uzr8YjoQ1FVawbfRwBVverKYNOfC+jfkO VDqN9ssK xjVz16NwkVLFYVJn+nuZPfc2pSwm5eRspm8/YdcnH9JxKmU+iUqZhas1z+I3GgJz0KaZgylmnwMzyRQZYeSA/+m0fXB0j5m7dQYvKSPpbc4SI/3+X7IygeSkEHeOYBY3kh982SaKKVo2jIm6i0fEjZobQN+NhSfM8VtVxzZqPppreEGWVFDiqbCTeMZr/eMJAwRiKMrOac6nVda/poyZzda3R0m72CthLAsX4RNpSzIWLQFzccFe/nFRXxWto4AuUUc3r5ObILr2hnklZwdsyfO2HYg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 7 Nov 2023 13:56:49 -0800 Ankur Arora wrote: > This reverts commit 089c02ae2771a14af2928c59c56abfb9b885a8d7. I rather not revert this. If user space can decided between various version of preemption, then the trace should reflect that. At least state what the preemption model was when a trace started, or currently is. That is, the model may not be "static" per boot. Anyway, the real change here should be: diff --git a/include/linux/sched.h b/include/linux/sched.h index 7b4b1fcd6f93..2553c4efca15 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -2208,14 +2208,6 @@ static inline void cond_resched_rcu(void) #endif } -#ifdef CONFIG_PREEMPT_DYNAMIC - -extern bool preempt_model_none(void); -extern bool preempt_model_voluntary(void); -extern bool preempt_model_full(void); - -#else - static inline bool preempt_model_none(void) { return IS_ENABLED(CONFIG_PREEMPT_NONE); @@ -2229,8 +2221,6 @@ static inline bool preempt_model_full(void) return IS_ENABLED(CONFIG_PREEMPT); } -#endif - static inline bool preempt_model_rt(void) { return IS_ENABLED(CONFIG_PREEMPT_RT); Then this way we can decided to make it runtime dynamic, we don't need to fiddle with the tracing code again. -- Steve