From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A624C41535 for ; Tue, 7 Nov 2023 10:45:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 604D16B018D; Tue, 7 Nov 2023 05:45:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B4EC6B018F; Tue, 7 Nov 2023 05:45:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 457076B0191; Tue, 7 Nov 2023 05:45:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 31F8D6B018D for ; Tue, 7 Nov 2023 05:45:00 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0FBE71CB2C2 for ; Tue, 7 Nov 2023 10:45:00 +0000 (UTC) X-FDA: 81430825560.23.6E1275F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 49B17140004 for ; Tue, 7 Nov 2023 10:44:58 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EfHMKmIU; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699353898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XAfuS8xqpR5ivyK308ujgvuYRwKJzEEWPMIXoOnfrLs=; b=A6343AZNUJ4H1+f5vNOLbhHq0h/+dj87CsLMonzuFQ+oy+vmCqv7dpp3l43FCT/jHmoGhc h1dWIJhwo5fsIGfp8ECLH0SZNkLsN+h2BLqc/8e7avUnM4y7e6m7WyJStVCTUWudws587H WrHM0nC9KKqJuwtXJ2qU/WatNH8BoQU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EfHMKmIU; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699353898; a=rsa-sha256; cv=none; b=343mPIJbFy2/1oxFsFe9MNhsnZUjMyG6R6CSl5EpCb7vOffRpVMJNNq0DBKVsAs9oQ8SQ9 LJMlhTexW2uK3uZA6UPBiB31GYIiEuE76D7X1RhYRwsFj6JLV5EF/VGajgQcNiB25EJITI BPTr2ZWnDu+OxuZ16C5L575mqv6ibF8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3E35061161; Tue, 7 Nov 2023 10:44:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AF0EC433C7; Tue, 7 Nov 2023 10:44:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699353896; bh=6KvSSAyHzV1t/xzun1oJg0AqCmYPNZNoG1yjrk+2N5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EfHMKmIUi7LClGqSTR82uTGSALdsGhooGkAQNBOKzdAx9XrKCS32CwP6rRNlINeJp fTBcOh2CbrNgz5T9wN8X4IfDIz30xCLXq2htrhQAdC3JQhS9flLyk/+pf5MtKIc1uc JGySGdYEdfIvLpVTQJXhgpJr9YrJTitMM+csMdn+xILBQI2oGOVjB/sYO87FSSlzde FSNahA1CtFFCQyIxON1Z1I4OewRIeg1rULpA/yqisw7axPef9I0RY6dTvW/rbObEf0 ODLYbBKyXYy654yF6yL9+/nSFia7MKf5WBhUfT/JXvT2gH/1if2QXy5oq+hmLNVTje IOMZOtUYIwdeQ== Date: Tue, 7 Nov 2023 10:44:47 +0000 From: Will Deacon To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 04/13] mm/execmem, arch: convert remaining overrides of module_alloc to execmem Message-ID: <20231107104446.GA19133@willie-the-truck> References: <20230918072955.2507221-1-rppt@kernel.org> <20230918072955.2507221-5-rppt@kernel.org> <20231023171420.GA4041@willie-the-truck> <20231026085800.GK2824@kernel.org> <20231026102438.GA6924@willie-the-truck> <20231030070053.GL2824@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231030070053.GL2824@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 49B17140004 X-Stat-Signature: br5uk7tpepk6fd716fjuaocjd337zwzi X-HE-Tag: 1699353898-838733 X-HE-Meta: U2FsdGVkX1833rRMFPCdw09sHlEfFrbiIqeYGFMVFMZneM4hI4hSobgsZ7B7JOLg5MGyAltFQnxulWFNY3IssaYrHiZ2EQTrogBdNs1TfoCnuwilgJQVMQCXsTaSw2WfswiCBlklRkwiEFaTe4MnfDJ3F327EjVhhN528wAnppYWIBSe/8zfYHGpuPdDsK21mWW+jIo/JMn1wtGgKlqjFyTUIeIxhybYb3xuv0MIik5nvAD6LAEu2XRngJz36+/UkzxxvNJjlTTZCZEALflvqiV0ZrHQrM3+AfbVv7XSzGDljSU4NwmqeeyJT+X312DSpUf4eSYIohVUOeoX+sm/G5v60o6zHyPwY6qYRIdnZzB+KHN5wFIZ2r3xr1g+o5G5bY2IlST9SgWUXk/iry0EGdIbb8kfT2r4T8gVa1jcaJxQiR/du79S8ASPReiMwknTDqeNx8Hr276jwEobg/NMNVL9gYp5S18qZ3Ntg7+BqDR+q3yicU7/NARYa3iPWKXC8bHtR8V3C5ArHYLm6TFY4MyBrGN7wYtvhMwTtD9AjIdFzqsNsymciwUxexKOsV0S8gcuQiDH+3CNB/YquZXN23KL3M2KNZkQdWFx0nbj95neAa/LnxpH56f5l5XkXbnY+zg8zS5bI9Syh5P5HoffcWe5ykuadW4P5FER2MIL6mh7nBZndAPPshN9dkNTXTrv+FjA0wPzbgqWKA2zjXGFeFDRhoMCpEsEkjFPeUgEz9yyNhjT2rWxeP+l/PPbp7ZG0Wzzh+M6ecvVku5LPKYQMXlj7+gnssSsAmlVo+e9q1tvDYzYUi8eQiERLRsYil2y3fmFIOEEi7spgJuj3QpLVQeMAJBbP+B8NNM3MA4B1cdbccRwAJJoFgPsjtsCJaqcR6wKURjQpZA+7kFMS7igVhxB3G2MODsMpeZrQg9htbOApNAfhXTINMtl8oGM/hGqLducD3twtOO1ZBmGVL5 v3QWi1ub fDNqc+ftgIpRYknz19s+RUWXyC4sNv1nRYTDk6mZy464b6EVf8BpICTxTXPRjv2P2Osq+IZopXvlAJRnrxNUerTLZMyDOkjybHvwjUc8CH9r1lgtYLguHOjDELz8OjMd2C0jFNWlnTYd+sTdE5/VzYfUvVES6/9c/AJI1UY/1Oa7znqUV+EBX2gQ3GCpos0BcoNZWum2XmQ5dReq6VSj3ukSgUmzp9637aPw7gfo0ppJSGFUkFiYUxnn0kQy681tZ2X2G4LSkdhfea+Svcy6uK82PUX16dFMlcapfm6Bm850eDW9tL/kkc+5SGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 30, 2023 at 09:00:53AM +0200, Mike Rapoport wrote: > On Thu, Oct 26, 2023 at 11:24:39AM +0100, Will Deacon wrote: > > On Thu, Oct 26, 2023 at 11:58:00AM +0300, Mike Rapoport wrote: > > > On Mon, Oct 23, 2023 at 06:14:20PM +0100, Will Deacon wrote: > > > > On Mon, Sep 18, 2023 at 10:29:46AM +0300, Mike Rapoport wrote: > > > > > diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c > > > > > index dd851297596e..cd6320de1c54 100644 > > > > > --- a/arch/arm64/kernel/module.c > > > > > +++ b/arch/arm64/kernel/module.c > > ... > > > > > > - if (module_direct_base) { > > > > > - p = __vmalloc_node_range(size, MODULE_ALIGN, > > > > > - module_direct_base, > > > > > - module_direct_base + SZ_128M, > > > > > - GFP_KERNEL | __GFP_NOWARN, > > > > > - PAGE_KERNEL, 0, NUMA_NO_NODE, > > > > > - __builtin_return_address(0)); > > > > > - } > > > > > + module_init_limits(); > > > > > > > > Hmm, this used to be run from subsys_initcall(), but now you're running > > > > it _really_ early, before random_init(), so randomization of the module > > > > space is no longer going to be very random if we don't have early entropy > > > > from the firmware or the CPU, which is likely to be the case on most SoCs. > > > > > > Well, it will be as random as KASLR. Won't that be enough? > > > > I don't think that's true -- we have the 'kaslr-seed' property for KASLR, > > but I'm not seeing anything like that for the module randomisation and I > > also don't see why we need to set these limits so early. > > x86 needs execmem initialized before ftrace_init() so I thought it would be > best to setup execmem along with most of MM in mm_core_init(). > > I'll move execmem initialization for !x86 to a later point, say > core_initcall. Thanks, Mike. Will