From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317FDC4332F for ; Tue, 7 Nov 2023 16:32:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2CE68D0048; Tue, 7 Nov 2023 11:32:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ADC298D0001; Tue, 7 Nov 2023 11:32:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CB6B8D0048; Tue, 7 Nov 2023 11:32:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 899C58D0001 for ; Tue, 7 Nov 2023 11:32:32 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5824B8029C for ; Tue, 7 Nov 2023 16:32:32 +0000 (UTC) X-FDA: 81431701344.17.C80BBFB Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf10.hostedemail.com (Postfix) with ESMTP id 3730FC0017 for ; Tue, 7 Nov 2023 16:32:29 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="zZ/3bmoZ"; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699374750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m8orFybc5RaY5uqn1mHz0IMhGsCVv1ePrsDBN/8VWqI=; b=g/ymnB2edpeqOMV49oFz2oQN8DQGolSL6tF2bSXGWZk4CA3VbReS4BxapcwP+cVrxIZ+2o X1NwK7+9BbDL29f2up1BNFSCswyE0KKcxT4XdLXVIAivsEeUSUZmdeq9amkTSN0kGjqCHR MDtyKzslW5LaC1NWNCdBiFtU5czCOcU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="zZ/3bmoZ"; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699374750; a=rsa-sha256; cv=none; b=5cmyz8ni+pTq9eYgZXh1TdnruimVwdIMsVDd83EgW9qrbtt9UTQ9TnVfbS5AqDH0hLsOYq f+6NwLp9QjXI0GSybmfL+636Hu55oeOIrWBVOt6LS03G2j+SuZv8Rcyn3rMu67l5xWTfcb /0kUTXYbIVr/TI/bbyJcxT3BdrbuRK0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id EB389CE0A50; Tue, 7 Nov 2023 16:32:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0281EC433C8; Tue, 7 Nov 2023 16:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1699374745; bh=AePIgCWA1HUB2K2O8lYo+JWrk2IOpVUkPLhVIZjxpTY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zZ/3bmoZkPagTKjZTznZsZyM23cMbhjZaKU6rx3dRCKCIFJVdT8X7ZjbLciNJ/iXU vMDR5O67cBwGOUBP61sidc6o2cWgt2T8XpFER14R6qHjUCfd0dW+jgyDZHDalBHqVr IVNwwizIdiVvFrvlchnTU/qP3E6X9gd7UXvUw4zg= Date: Tue, 7 Nov 2023 08:32:24 -0800 From: Andrew Morton To: zhaimingbing Cc: rdunlap@infradead.org, James.Bottomley@hansenpartnership.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm:hugetlb_cgroup: Fix the wrong format specifier Message-Id: <20231107083224.cf5ca5fd48ca222c1315b4d0@linux-foundation.org> In-Reply-To: <20231106082723.8728-1-zhaimingbing@cmss.chinamobile.com> References: <20231106082723.8728-1-zhaimingbing@cmss.chinamobile.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3730FC0017 X-Stat-Signature: wjzf7jmgzz5si45yku45ibniwxe9i6jk X-HE-Tag: 1699374749-80399 X-HE-Meta: U2FsdGVkX19Y09LVeClo78mUY6Sc+JbVe5tDTPz7tHGkU8H/51YlSX5UR84CaIgjUC3HGO15j6hxSRqSOFfYQk/I1lJdN1vJXQMuQ64fnc4wa/Z7HtRKPhfNue3xTg0+2/hujn3kkT7vOMpsnDW4+VPyaZIATZbYYwozpMLuQMXx/MLVFdGsA9+jsA+qEWCBMYKEiwSsS8y1N3a8iCI7jjTGMtwt/baePyN0LloK4dOnoengDjidcOMswcExNq1jhSd/U4iChIbrAFul9EEzaT69Pm/t6g3xNDLnMcWoAadPrfbf0h3g/zvGR1WzR4mXLkO+KBNcSalisLiueZQKpf6rhhDWTWucFXh1vOa+6PYELTQXBKu1J/K4VZIr4Ijq2XTF8GxyuhLcOHZMnG56bZdMl+NC1AI1lYtNuo4h3KaxTQltPn5F3ibp+QFaWhhG6RqC+U8LgcLdf3ojgJrgbpQ/Gn3J6NJ46zc8D61eLdgjWft2NRQNG2aCISE5b8Naz8CRiJkj3Hen6aviPrv/90Fb8VS2Qw5QM109HWgjDLoEd8fHPkqj5sMHiYKq6xc0GqsZ+7TNLadVR3JSy7y4c823yDYbyDOOYshcZXRaAQZ0CCJtc4pju86e9o3EoRMZk3t2apDP60AYScPtyl8y6Zkm7wwivGGJbGUgkx0/tAZtL1h5RDKvyexQDhz+PR92JNHKeuM3ngIuNXAGnBqsMwoxfygiOCAeK0uZl6nsjxvUzHzHNVWQYxz/8mOtnszdXl2W+v79o8Bw4zqesREDa4WFLx91xn54WJxanHCoV/Jy4WBUP0le7JRsptWSc/XZc/3krAwq+pfqVhO2ez5+fB2+zOahnE1D8iyQXCVu4pkCh3sVcFq5jm3wrLGLkvzaj4ZYdZO/4a+WFys1CV15pWAL8Mb6eW1a7pXMJrXodWdS6Sayk44n9O8oYb6lXXOCNecI35OonOeVuXtA3KQ dfPKIlcq GSXdc9P90BCKNnvATQRIJKhY+zSMRJPXf9yMKPMjLGzbNiqP4T0oPglbxd882xxmkvL+KxpXTJ5QMD6yeuH63ixa4vGSMUv8KY8VBhgx0Hmr0GCKxJW4NHVtU29ELtgtVLvtXeSujQe1/M8bzwXmoCsIHvegwO9/yA6AdwphM4gjKD3uUPWMoltZ5rS2lbDZ7B5xS1Zc2gNmhClqbkBz8YafaObK7wR/HHylGwGJT8kFAvlwr/mH9hhCeKCZc6N5GEG8UZoDn7Xm4FRi6a+spv9bZ3MmptI0sqQ9oLGtyKiAzLtkiUfkIG24pEBjOlaB+gf6NTfD6GIFl3VY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 6 Nov 2023 16:27:23 +0800 zhaimingbing wrote: > The long type should use "%ld" instead of "%lu". > > ... > > --- a/mm/hugetlb_cgroup.c > +++ b/mm/hugetlb_cgroup.c > @@ -696,7 +696,7 @@ static int __hugetlb_events_show(struct seq_file *seq, bool local) > else > max = atomic_long_read(&h_cg->events[idx][HUGETLB_MAX]); > > - seq_printf(seq, "max %lu\n", max); > + seq_printf(seq, "max %ld\n", max); > > return 0; > } Well. We can't have a negative number of events. If we had an atomic_ulong_t, we'd be using that for ->events[]. Perhaps giving `max' an unsigned long type would better represent the intent in there.