From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF911C4167B for ; Mon, 6 Nov 2023 20:49:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 125028D0028; Mon, 6 Nov 2023 15:49:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D59C8D0001; Mon, 6 Nov 2023 15:49:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F06798D0028; Mon, 6 Nov 2023 15:49:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E0F6E8D0001 for ; Mon, 6 Nov 2023 15:49:44 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BBD25C0516 for ; Mon, 6 Nov 2023 20:49:44 +0000 (UTC) X-FDA: 81428720688.13.148F00A Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf09.hostedemail.com (Postfix) with ESMTP id 0DA3014001C for ; Mon, 6 Nov 2023 20:49:41 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bC5N4dGm; spf=pass (imf09.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699303782; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rWiQLXa7hB0EpnpPI6QbdIesgvYgEddfQTVM9/Bx2XM=; b=568AQx2SbFexO5mmrc5CVUMMDh6oR/tJ/NEgf06NDHfJReEjyc2iq8DDnXPg0ZSG8JOJnN G5KiXVQtHOuOurz1feE8iLF/IyC3xIGm1e8a8NqoxDmgsjdPy8Z/qyeZXhzXkcz29GRG6x Dc2Spba/wvCenECBR0qKa7nO5if2DPQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699303782; a=rsa-sha256; cv=none; b=hC0LatDno0qtARmhq6tL6zKhDY1e/2kpgFVG45/EZfhh5Mvjk/ZpzrRJDZGGtUoOh69wh8 rZF8W2PpAlLukFcwyBHnqfWsz0N8rWJTSz/0a8CxpmpiIY5RgoqSO7UMIUfPDviKYvZlQg +/re1s+tw2XpowhJuyc4AF1bT6aEZS8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bC5N4dGm; spf=pass (imf09.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 81BABB80E72; Mon, 6 Nov 2023 20:49:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62F79C433C8; Mon, 6 Nov 2023 20:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699303779; bh=1ojN924qEHttCwp4v9QEGZRz/p6BrttrFZ8fMDi8jpA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bC5N4dGm7TEY4nZ4PrDuV+pyZoNwoPz08WhnP6WiFLNehEuknMnqvvl3pANLzO67k /KQBtv/Q7z1Of+i30DSEUgyRdaT9mybZz8QUuZWtrSlK/wNob+gevwij/06hOeueOn lsJ2IlnRIgsxk111caCUnm/UFvvupS15XTwtZebecLtiQDyRiqzjN6CSDY16/sTtzz SnfC/egyneb6P83Dtm3PMTGy1lwGFdEUUAAgvj6CAZW54BB44Z7vMnFyz7Kq7KBaP3 HKq2nptBvLD1c7Iw09MkFlcwfqD6gwq+lDVBRF8Nb66dr7cKqurjKxYw62reqy15n+ KbachTLGfl8UA== From: SeongJae Park To: Deepak R Varma Cc: Dan Carpenter , SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm/damon/sysfs: eliminate potential uninitialized variable warning Date: Mon, 6 Nov 2023 20:49:37 +0000 Message-Id: <20231106204937.48488-1-sj@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: i7sxq741zg4zhzytpeatm98rponqhg9d X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0DA3014001C X-Rspam-User: X-HE-Tag: 1699303781-764597 X-HE-Meta: U2FsdGVkX1/1n/UigLC+1WVVhoSmBDjIuHnTY3Bg8GY7TRrG5yQVAjJTclBFC7fHwxel4r4Dls2LUBJ6RtWxMtNEPBrvN+YkxGsE4Z2g55UYMbzBiZvMKUllTOS0OTezjrxycYvqNFS2IK1pwnuNF/oxNjM++II9AC30TujhFXKCY4YxFIbSsypgtzgqL3wg0Tq9ouGQJ1atJLAI3LtPPR8R3nSJ2fer7cd6T9OMbBPbBjobtt49WiPqIbJw3ack3AomPVShOqW5Tfk1BwPPShd+RrMCY+YT98Cy4BBMCuaSWTOYkelzcCIFJf3bKNJTkG3TwA36VooykdaO5+imHY1FMspzYh1cpr2UDrmd/AAx7kJgXr3aUiBMMooQK20qVMTOp0g+8FddQNwQwcfOD/fINI8/BwWkosJJiCHTQdcuiI4S4t27aZc5NYxuXkDOEKPg7mfUAtxU0kpZW6GNYwm9AyRI2/tnSXW/SiaxXSXVhW53F8bC9zyFxcD1i4WGumMaadvXFlpFQdu+XjsoAQeMzTYpq8x6WioFGQ9gzGPvQZyFvGA44FRfsw16G0+c0UL2zRLMMwljTIOY7O10Fbda3y6Ps4SSoXX2s3+YWgOFrKxrhMN/pwg4vJ9WPpUcCuZKx/Fg9jeR5dU9PcHkk01P8a1oWvumXaP9QdGr4il84YSQiqE+5u0bbHtqG6ZohcCR7++YwwcQoopZu+poWLhfopx9jd7ANf8ROfrtVqBmFkAQpJsc6Dxvq5v9qWw8HyY4tGNkzIse31vGSXyz8hB6Xe+w9EWTSTZ2UWK9/yr5wpr0gq9Wj1/WHiiaaJiMpdh/ddMNUhW2w5VwfK3ljpRNskUYJ6hNi9zh2FP9xJr5HzDivDraS57Yhp8lVp1SxAKy+Emon3fCLWE63awLhLtRccGotYJ8+nkHHRfXOtmNWkb+xresQJ2YdToOaO4q+rUwxwZtgOBNzDjUCeY gHhbsGqA PrMo430vP62sYaKU86FACIukv+GyJh5lkNPQ7ogiBo+OzpFwWP9lQvxIaOjZsIMkoMaRCZXs8BTG/l8FhyKIv5YR23nvt0nwqVmoDnSf1pz9tFj7uDrqU2G9TN5eFAkEz4DohMd8yZqoXE9sS2YJrRlRbe7cy2inlCexktPwix5mjNWHVkUpeaxOIgobGWSaDWBWFLYCGHpuWRKHTMZIsUjpj885bk2esEZH49NqC5O+ViCol1r3mxemHZLZZgYa4eH9FEk/2mlVF/AIJDb4OlDHOdX+jJ6lBbBFEWpw/e1LNTPJAxh3H/Rc+kyO8Gy52WCXixkOCS8o9pPQ/VElJnAn8IfcfgNtScpc0vfgb1dTYzL4Kq927u3FoQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Deepak, On Tue, 7 Nov 2023 00:35:55 +0530 Deepak R Varma wrote: > On Mon, Nov 06, 2023 at 05:07:40PM +0300, Dan Carpenter wrote: > > The "err" variable is not initialized if damon_target_has_pid(ctx) is > > false and sys_target->regions->nr is zero. > > > > Fixes: 0bcd216c4741 ("mm/damon/sysfs: update monitoring target regions for online input commit") > > Signed-off-by: Dan Carpenter > > Should this be a void function instead as the caller is not checking the return > value. As I mentioned on a previous reply[1], I think the caller should check the return value. I will send the fix for that soon. [1] https://lore.kernel.org/damon/20231106165205.48264-1-sj@kernel.org/ Thanks, SJ > > regards, > deepak. > > > > > >