From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E97AC4332F for ; Mon, 6 Nov 2023 19:28:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE5AC6B0282; Mon, 6 Nov 2023 14:28:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B957C6B0283; Mon, 6 Nov 2023 14:28:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5D026B0284; Mon, 6 Nov 2023 14:28:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 965AC6B0282 for ; Mon, 6 Nov 2023 14:28:32 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6C93F140912 for ; Mon, 6 Nov 2023 19:28:32 +0000 (UTC) X-FDA: 81428516064.05.F3547EE Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by imf19.hostedemail.com (Postfix) with ESMTP id 8D48B1A0008 for ; Mon, 6 Nov 2023 19:28:29 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=1RCALoq8; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.210.45 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699298909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mlzvkAJRzuQZnUx9+U36N20af1pAsethgx21gTjo+4o=; b=k7ZrrVngI61fPq0VzwAoAz/gC3Di1kXUCSrpuFbuSS27+8P8QXJ/1QaDOtC4Nm7wks3R8E rr4/Dfhh/hhPsGwUZqSzpV4d67nCe0LLyg+hHGXBX4DzOMw3PQ9MY1aPOE/cRlwvE0dwF3 10m0tzRkXKqvQqAFXF78GTGBZkb3unw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=1RCALoq8; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.210.45 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699298909; a=rsa-sha256; cv=none; b=zsvUUvikBtSfO9wOA4fsEYBxc6/ZOcHzxyUdwl9tFK3fpp9jAZjZ48UPFS7RQo40skvOo3 0rUlzNZrnyA+xc6WXv1WboV4Ib1ko4w/TAHTdFGiq9RlUbABOaHXfYWuoXk93pEH/YsSFi MkEbv6xLWanMxrnZA81j6nttNE1+idw= Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-6ce2988d62eso3186898a34.1 for ; Mon, 06 Nov 2023 11:28:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1699298908; x=1699903708; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mlzvkAJRzuQZnUx9+U36N20af1pAsethgx21gTjo+4o=; b=1RCALoq8m4PXYkb4fGQfXW1RmrPIuU4NW8cVyiiknA2OE6AxgRd1ihw7yVaCd+jiYX 3Wnlx8EcDn5QarAh9REcCxjptY59sQp6YvYmk8fZZntxtSp364P2sIXkSR9cUjpFeZNk ECu/Osk5iDpLRr2klGEg/HOaBepx8MFhIYXYdUVbnrTabqsUMAKSCa33CKphm8Sv8j3r mrAXgqX9koXYi1YV25F1rmoBMsKWQAXVBO1eKkxQUZSin+fRkEJUiv+Fg4rblN9g22EH W/p3V+WPBlZaGla9zEJR7/K5RJnMsdFNtWpFThC31sxtmMcuBft7+X3tORGbSJE3thVj shbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699298908; x=1699903708; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mlzvkAJRzuQZnUx9+U36N20af1pAsethgx21gTjo+4o=; b=NTo+pXeRnsMcc5q8P1B0l2oFtx+/zhNmQVkk/twCQ094sz/pSDUg7Cd59y4rzEQA+2 iz8djU2kTkeEKou711RXpBli6k4crJe1aU6Lm/gID3LkmGHSzBaZjzGf/INeX2OvQQH+ L94JCBSq9sKjuyKJMpbvh1D5TST8oKDNesNi3SNL76iPCD2V+qjIk/hODRDVRCJixUsG MJn4t1gDblMOeD9S6gBMQ9DuwTGmMY4RNL/hE7DqBaISj45vT7zcz7yHMUVpLcSKi/VW xnT267Wep6mtVm8zjDdg9yFf2PH24RO191wBXq0qR2gQXQqci/Nd937vQtzN12RPLBU5 9ITw== X-Gm-Message-State: AOJu0Yz+TOoxypc6SsRuIhr0Oiqh3mRxPh53CNYWiG9XbIyOy57GZgv6 LCVm56PmYI/ibeqVEeRogbkrCQ== X-Google-Smtp-Source: AGHT+IGoMs3p/xp+2w/gcKq1uzQMmpxpoGkiwmFBR+1NzSnc9n7fN+/BGdPuKf2XBPGGt1/dGj4jPQ== X-Received: by 2002:a05:6830:2b2a:b0:6d3:1f3e:4c4 with SMTP id l42-20020a0568302b2a00b006d31f3e04c4mr19267202otv.0.1699298908462; Mon, 06 Nov 2023 11:28:28 -0800 (PST) Received: from localhost ([2620:10d:c091:400::5:86b7]) by smtp.gmail.com with ESMTPSA id jy5-20020a05622a818500b004181b41e793sm3660625qtb.50.2023.11.06.11.28.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 11:28:28 -0800 (PST) Date: Mon, 6 Nov 2023 14:28:27 -0500 From: Johannes Weiner To: Stefan Roesch Cc: kernel-team@fb.com, akpm@linux-foundation.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1] mm: Fix for negative counter: nr_file_hugepages Message-ID: <20231106192827.GA3661273@cmpxchg.org> References: <20231106181918.1091043-1-shr@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231106181918.1091043-1-shr@devkernel.io> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8D48B1A0008 X-Stat-Signature: jqjbmgbj366psj4mkz15fhkaa7ayci7e X-Rspam-User: X-HE-Tag: 1699298909-79045 X-HE-Meta: U2FsdGVkX1+8l2Bz/mKjzcS3xf5LrVvE8Pfp5BqzpTdSQL8PsVQCTtN4BPZwAuGP9bSAglIXVJI8pFdSGSlgpgUBr7Cpf9NVGrSUAbx1t86GRTJj5f1bC34Lu15Or1oM0GhgpwTh9Uh/c9gWGk3c4MEjEnxji/LgUH/dITXW5bgrMIzMHeXULAeSRiInmbp7yaNvLg1qh6clDZJXhsnZBMOr/OuU1VR6conl27JUtokJNaZPaYDNYLSEOH+HatFe0ZMGX2ATN7ccYPGar4V/ZkK9/1/1LWrhTv0I0RTQ9yxU1W3OdpIImaJzH0kyE05aL5zOJS7SiCDrthJfMMErEYDZU+kR+9dnXPA9JUBKCVXfYxIKhuUL1orVgbxnWl02zy9WsQEy5qjXkNOC9zisQp6n6tWkYebq4MNVOnz3exSxwqfaR1kTGpe17yK5w6W3GsbIvcJOQ6P2cxnPnmv8cjPD7MzUR68uAvr5M7AlrAGIrgsfnCmrGW4jZ/KeMW5y36PdwmhPG4St5i4bH3m9ZbC7LtUHqo34/CPDWqbzXaMTI26kC/YcKHtg1B2KPxeqew34+8vPse1pnyc7wtCYCyugXGiUKCdzL40UTmCvsmUW0X0tCHf9MdstO9gxu0MuhJfvXtrWQCN742ZR1E49bmYKln+X8k+pWRlGjfg52cT+lKb/7/EGre4/vSyU1zble8GnrxUCTtAFGp0NgYce0mvSAIedQ4bepjeU6u5SCoUToU+A7QEHX6/mTsdmtyS/W1LXnqFJNsxVBmOrTTfQpFdM8vUjiMRUMLu8l3ENCgu7IzjYFQ3AMQyXCmFKkFehlXTxYRqb0t+fFi5rvGG29rMzCbMn+bO+Jx+OJzJO2v/XO3HdPr24hsSIzu8nDyPXa62yN55QEr+SSN5jla/zSZcjm0kyr1/M7hT7xHZKIUFAwTO6RsxzHKjjugzY+8LIRN6j0zleWIjnijOyjtA Vj25iAO3 hP4MnbJ7kHUc4tTTT2U4H606Klel8HD08Hzn98IXwDT6ppClUu1GcUmGBmMk/w0HYcMndUOvuQr4IDCekwVK6GPHiMXj6w/0QNkr/GOPLkfgs/Br1QZO8K6sGWDvyJV1Ev/foW/zpyc0Hg962TG87EK6/gfPlWQTcwca0pB90hv0L9LZi2npnMI++GdYazIeDKbL6l+tIj6bBQvNQ2Z1YVD4AjwpVLf9Qtx/fnUq5CCuzgGRoGGZmb1LJU3ZTzt4OYQvO3UfmVzM5jLp1gxZ67DopRAr7++1K5BfodkUGgbi2bxBre9MWo7arveXZhLXGsUITjs25f7sGRkvwO01NQGQRMPVY9r+U1T8+XRb28Q06LH9kapXWhrHfueKxkoUeQiAi+28j0BYcZ645IKOcHGsN9du06fo/E+qMS4oUFV8m5W2EtzBsHYsFfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002032, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 06, 2023 at 10:19:18AM -0800, Stefan Roesch wrote: > While qualifiying the 6.4 release, the following warning was detected in > messages: > > vmstat_refresh: nr_file_hugepages -15664 > > The warning is caused by the incorrect updating of the NR_FILE_THPS > counter in the function split_huge_page_to_list. The if case is checking > for folio_test_swapbacked, but the else case is missing the check for > folio_test_pmd_mappable. The other functions that manipulate the counter > like __filemap_add_folio and filemap_unaccount_folio have the > corresponding check. > > I have a test case, which reproduces the problem. It can be found here: > https://github.com/sroeschus/testcase/blob/main/vmstat_refresh/madv.c > > The test case reproduces on an XFS filesystem. Running the same test > case on a BTRFS filesystem does not reproduce the problem. > > AFAIK version 6.1 until 6.6 are affected by this problem. > > Signed-off-by: Stefan Roesch > Co-debugged-by: Johannes Weiner With the newline fix Willy pointed out, and CC: stable: Acked-by: Johannes Weiner