From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A67DC4167D for ; Mon, 6 Nov 2023 14:41:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 346F68D001D; Mon, 6 Nov 2023 09:41:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F5EA8D0002; Mon, 6 Nov 2023 09:41:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BE708D001D; Mon, 6 Nov 2023 09:41:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0A3258D0002 for ; Mon, 6 Nov 2023 09:41:59 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6A8991CACDC for ; Mon, 6 Nov 2023 14:41:58 +0000 (UTC) X-FDA: 81427793916.24.FF52285 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf29.hostedemail.com (Postfix) with ESMTP id AB5D212001D for ; Mon, 6 Nov 2023 14:41:55 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bpFCHKcg; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699281715; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to:references:dkim-signature; bh=kOjmiQHYBnShoPi5+5ngtoiQC1XlTDcprxuYgb6yGDU=; b=jFWia8oUEQq2TyXP7GVbEEKsmimJ5OqwvMx+x3g9icq+Ki5PznzQCzZYHQhtz4m0fbQVak ihmPFVeVIPrkyEjMcBkPB9LFB9g/f0kGV0rKAfBNwu+flb/LnV+TVmDMz89LWutugJ3idS Pd6ZAgnkV+uAocNAzgkbOAvrMFxIZ+4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699281715; a=rsa-sha256; cv=none; b=iOiytX8JPOAt8bqzjrYfJgLEX+8lzv1STAujkhL2/z8G5sy7QSq4KZFKOOg7Gb7haPEmma OdeIbpTJ/eWrnqgD0wmmnVapKsZMVFX538/twCrpD+0ktRE/ndc+YK3nAYN6oLFgZuW1By aSxxPLezQZojGF251YCtMlHfzPLG1QU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bpFCHKcg; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id A9BE2B80DE6; Mon, 6 Nov 2023 14:41:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D52BDC433CA; Mon, 6 Nov 2023 14:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699281713; bh=Rdt3hTkEt0rry4dOU3WEMf9RmwFLUXqDzGIRpP0jJVw=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=bpFCHKcgiFORWu0nkbfmAvOWLbm/gLFQi9tT2UJ9w9CS+9XDXYJsp/sp5yg0IeL7+ 0tLWVPAeArctdiC27TpswzOVLew+VueO9nJ4W5IrdDK3whDK+8yfchm1hkL430ISbi HDwdLAp17wcmgCDsMaivy9yHSxYwqBtTCIdA5UHqfidGCxGfgA+Nd3UsEDXhqaBI9D xCymGgc+PO95PA/aSa+fljDM/OEdnQMyUyRol3bFAIdQqQbKPjrD8xuFtYRGm2kptV GMBRCql0/hp4jFb02CtcQ+PiOzz/71NUxhDfO+qCEZamoaRk2d53GO87nVMwWbvw0X eiyJr1f+FL6Hg== From: SeongJae Park To: Dan Carpenter Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm/damon/sysfs: eliminate potential uninitialized variable warning Date: Mon, 6 Nov 2023 06:41:37 -0800 Message-Id: <20231106144137.9772-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <739e6aaf-a634-4e33-98a8-16546379ec9f@moroto.mountain> X-Rspamd-Queue-Id: AB5D212001D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: oc76sawep18p8yqfp88amzs1bnferkqs X-HE-Tag: 1699281715-968083 X-HE-Meta: U2FsdGVkX1/yNBi4I+KCTPZpH9ZrO5Tsb2XAEyIE7onoXxN8tKqgcqJXIh3DBjcA3zbmSgVp6JYeRlI4HJ5UleNYHSzMYb3XaNjshK83guUsqIan21IXWMjx69Z9n3htQIPOhJpWC5R9+mD8fKQbqQxCna5vTqguOhroPUuYzGkZcboRGQsV3OnEiJVUvtxD/BQpHpoIVHu6Nwm8Gt5j8+6CGQqGgBmmSko3wv53hxIS0CLQWmF6F8sWf80PCX+E6sBg19slkuzhK3VK0ZcSQUq5HfS40FWna0nJwf7Gf3MeWahPCpuQ0asEzUn3fyIQgG/6XsBJcHJPK8FWslQpzwcf/vFBcfHGX0MiEU+zCD7EFFAXdrOYGUWrkoqyVWRjDKbocoRtikIyB7brBvNlaFJKZd7i8A3LSyK3dDaezRQ25kj1Zkk/T8ecGuD7lbn/vh+Dr19pJTbr/BO3olquEgZZ+v0GznC+Mg3vsqhvqVGgul9XvQo2ZhspmTawfCuYIBcpJqmYGjTaVJjl/zB/h26drsH/9AwuJKYIpx0lAl8TNDxa2FEevP5CzPhWvgBkWx5tJIGPmwMfZ1I6ydo5ShOoAoQiHfIDExagk5nyE6+rFerOuA+z/5yMmn7aE9qjPegAM7K2Qrf6aITzAJssdXN/Ww5qTOFMRrK9A1vgM3RT9KO1/0M5tCTKIeYZjKS8mElfzeiZQw3AGjaNADuD2DoAKgu0H8TSlhmux9ZpoPc+pJoP7GZ30csN1HwVvXq2Y2VFfciXkn7P8rbzfwu8NTmL3nhoK2ISpbn4x1TsFusxp4rEVZXy+EpDl3IcvujwY85ajfQ6qWNi2WsD5z9Uh0C2DIcTrWYMXGd5z4H96ke7Ec6CGfOr/wAeu8W0sfg3inXhMkTmP4DYz2RaMiGkILGgaEQE/3RkQrjBkvqQzm+2oPa80Aqn1PbKyDUfqDx4JFIZAqqZ+V2Z/t9/gBE Ck5+vxoH c1glVbfbyzBhJqwpuBw5NyKg/bmzvPIQgushYHfMCOJg+DdtKkwkrv6+RfA23Vt0CJsqiUA9wuPLYIYUheAdFk7qEEEAEY2K5WrKSTyVqxCxkHPGokRVEC9Ony56apqhyaEHqX2QEh6I+QScJDcUh4P1nC7oV1ieJi913l8DiDxCiMxd5zfUUoNN7LclsjuEzRaZf78OzYeahx7fBZ1yzQzNAtI2mbHplRUmGy9+G96bAiqtRTTkmVwiwfCzcOFYSvIGq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Dan, On Mon, 6 Nov 2023 17:07:40 +0300 Dan Carpenter wrote: > The "err" variable is not initialized if damon_target_has_pid(ctx) is > false and sys_target->regions->nr is zero. Thank you for fixing this. I actually noticed this issue from Coverity Weekly Scan of -next tree (CID 1570878), and was about to send very same fix, but you were faster :) > > Fixes: 0bcd216c4741 ("mm/damon/sysfs: update monitoring target regions for online input commit") Cc stable? > Signed-off-by: Dan Carpenter Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > index e27846708b5a..1dfa96d4de99 100644 > --- a/mm/damon/sysfs.c > +++ b/mm/damon/sysfs.c > @@ -1172,7 +1172,7 @@ static int damon_sysfs_update_target(struct damon_target *target, > struct damon_ctx *ctx, > struct damon_sysfs_target *sys_target) > { > - int err; > + int err = 0; > > if (damon_target_has_pid(ctx)) { > err = damon_sysfs_update_target_pid(target, sys_target->pid); > -- > 2.42.0 >