From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3DB4C4167D for ; Mon, 6 Nov 2023 21:35:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEF838D0002; Mon, 6 Nov 2023 16:35:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D9FA08D0001; Mon, 6 Nov 2023 16:35:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C67EF8D0002; Mon, 6 Nov 2023 16:35:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B4AD58D0001 for ; Mon, 6 Nov 2023 16:35:48 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7016880624 for ; Mon, 6 Nov 2023 21:35:48 +0000 (UTC) X-FDA: 81428836776.09.E9276CB Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf02.hostedemail.com (Postfix) with ESMTP id 44E5780025 for ; Mon, 6 Nov 2023 21:35:45 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=M5UZkVKY; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699306546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LgVb94CcZVd/QkXoxBdmEVaXIyB4jRsT/YrtlPClarE=; b=eIbRb+KI8bbHhwHPbd+HkQSEESlXynKe15ewq42zMwEuSHkHiUt1/o4EY2E7ZrclV6Hph1 b0ydQhkZg1sGRIKqphnA2/btZDr1xQSV6SatEPDEllNbHpJc1/3yT+pwkjfANCGldfgq+N Q3UkiuVs2Zr2S3oj9WqnqycTj5x9S3o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699306546; a=rsa-sha256; cv=none; b=Mtuk6sr2yHPZTCKMzkTriTsXe+6uIqNkDifzvOgntk+bJLvTyoPW+Ni9r4gumMnPWCiReW zkNY6qijcuja5OM3hwkM37OJdN0ATDtjc8biYXBpVXVV7SnRq04C5C3FVJ6a6QDSXNHanE 5yOt3xyRSDS+xfIGwhC7iv+q/RR1JJM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=M5UZkVKY; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4C61ACE0B3F; Mon, 6 Nov 2023 21:35:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64DBBC433C8; Mon, 6 Nov 2023 21:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1699306541; bh=lTIM326A7Yokevf2PJD10uUF9e1Zw3cztxxrSrh7tZU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M5UZkVKYxz+TPfHd6fnfWKrRIhczvcLqPBbG2OJfZtHgf1fjYCEDGoiGOJdqiGA/S fm62Hoe9EvT9DOzQdg69ymdBh5KDAzbERqYx8QmPd+aO/HWrne241gotVaFrc6UW1P cG9tHbIh7bcHeMf25Ga8uI3AqHcdTTlrisz/poGs= Date: Mon, 6 Nov 2023 13:35:40 -0800 From: Andrew Morton To: Zhiguo Jiang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH v2 1/2] mm:vmscan: the dirty folio in folio list skip unmap Message-Id: <20231106133540.0d985052fa9137136593cbde@linux-foundation.org> In-Reply-To: <20231019134211.329-2-justinjiang@vivo.com> References: <20231019134211.329-1-justinjiang@vivo.com> <20231019134211.329-2-justinjiang@vivo.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 5zd69thx5sn99jup97h8yuixd9d77u4q X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 44E5780025 X-Rspam-User: X-HE-Tag: 1699306545-71350 X-HE-Meta: U2FsdGVkX19xSKtMZ4IrGE3IB20jFy9jvihEdsyjxA5hwxF1qK+wmbjeVfNbQM5wIyJc20xtjQSl0GQ53DRNvaou4Pnn5NOkBgmkOlTascxv51uTWs2olyAS3ntBRIvL8ENOB47BknkoED0CvpTo9vBA5c2AsJU+Yv+J/Gj6TV1yKUcPiM5TVhWczkDyU7q+Bhc0xeiLNj6cNidedAyPWtlXmFa9FsZEQlyx2VgZIsoU+rz5kX1NlttLh9IN6trr05/F+3vfLvx3jL+OpEEFoXfyiqLPwK6yHE4Fc/yP6cqacgXqfdVuDPWaN+T8Ir5UFweS4ZP3UkLl3DJK3vXVcR468KouywjSEF5lCUKCYhQk2pF4yA6OBKdPB08xJT435Aqx6MMxN8xJKq9c/KJch35DKj8fhKbtp7P8dme9nxQDNZuJpLcmNN0I4m3tv59IfjZ/6/XqTl+0jivjaZBbWAHniQ/RQE/w9B4ktF4SEUycs0/rOb2b9EStCByipOLOIyY9BV6y9O07B7vT/R7oKQXEqnKbtg6sVHFflkL2VoJuvbg2GbToJbwcTq7R5veg+g6vc3OMeQF9EEPvIyoswIAUIk5O3MBoL26HmFTgMKbQYtxUEyH+Rba38YKbPz7q+3R8vCVlsawxC6BUIQGMBL8vsmiOhScEJIgTgFZfEp4r6BT3NOkiFEl0huXf5PmdQA2OttXd4ELik7cBX1YDnRRAioSg1KWgz6YvOMTQwvLTKiL7n/HODDzQqUAmefK6ROaZe/TZRb6KoSSVK9xdu6a/wSroFRF+b9niJTvsSgOLc7Tiu5rU/KKxRMlZkzGNWfDMgfThXF8t7RoOZA0aTYmPBhhx0Dw0PmsUOZ3W5mjIWMnANPBam3XFK66oMlqoUa00w8Uue1in4xOAlmKU032zscajmzd8Z2b8vd9FwQ5Wmq/GAiJKidle0o00lz8ithmoOKcthPuH+K7xluW TNJxM+4A SBWfuvgARMFPzkyPd4i/dgQvKoajy3V79Pp5hSLPvEIoO5Yz83I9XkOSD/i6dZ/et8o1r/wOYnZDpo5/JT+82NNnly4XP4HGtz7SeqvpvUO3CXvAP1PQ2U73s9tERiS2XRqomU4zAPLgLhBkTKGtleQePw713hJqfv0+5CgfPXbT5fC4wEMPE9QxNDc9BBHQRJj8XsAI5Mi/WgDZ5Oe6w+az6PsOGzKKbanZGxiXnDoWhcmmpDMIykh/es69c2cnS81vxq15iw0n4rIJPiytq5eRb3i1FI6cT9ew69mXNb5rYN4h9Ckb3ygaRpw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000140, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 19 Oct 2023 21:42:10 +0800 Zhiguo Jiang wrote: > In the shrink_folio_list() the sources of the file dirty folio include > two ways below: > 1. The dirty folio is from the incoming parameter folio_list, > which is the inactive file lru. > 2. The dirty folio is from the PTE dirty bit transferred by > the try_to_unmap(). > > For the first source of the dirty folio, if the dirty folio does not > support pageout, the dirty folio can skip unmap in advance to reduce > recyling time. > This patch does an amount of code movement and it implements a functional change. Is it possible to split these? The first patch moves code around but has no runtime effect, the second patch implements the functional change. Also, the patch doesn't apply to current code so please redo it against Linus's latest tree? Thanks.