From: Andrew Morton <akpm@linux-foundation.org>
To: Zhiguo Jiang <justinjiang@vivo.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v2 1/2] mm:vmscan: the dirty folio in folio list skip unmap
Date: Mon, 6 Nov 2023 13:35:40 -0800 [thread overview]
Message-ID: <20231106133540.0d985052fa9137136593cbde@linux-foundation.org> (raw)
In-Reply-To: <20231019134211.329-2-justinjiang@vivo.com>
On Thu, 19 Oct 2023 21:42:10 +0800 Zhiguo Jiang <justinjiang@vivo.com> wrote:
> In the shrink_folio_list() the sources of the file dirty folio include
> two ways below:
> 1. The dirty folio is from the incoming parameter folio_list,
> which is the inactive file lru.
> 2. The dirty folio is from the PTE dirty bit transferred by
> the try_to_unmap().
>
> For the first source of the dirty folio, if the dirty folio does not
> support pageout, the dirty folio can skip unmap in advance to reduce
> recyling time.
>
This patch does an amount of code movement and it implements a
functional change.
Is it possible to split these? The first patch moves code around but
has no runtime effect, the second patch implements the functional
change.
Also, the patch doesn't apply to current code so please redo it against
Linus's latest tree?
Thanks.
next prev parent reply other threads:[~2023-11-06 21:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 13:42 [PATCH v2 0/2] mm: the dirty folio unmap redundantly Zhiguo Jiang
2023-10-19 13:42 ` [PATCH v2 1/2] mm:vmscan: the dirty folio in folio list skip unmap Zhiguo Jiang
2023-11-06 21:35 ` Andrew Morton [this message]
2023-10-19 13:42 ` [PATCH v2 2/2] mm:vmscan: the ref clean dirty folio " Zhiguo Jiang
2023-10-20 3:29 ` Matthew Wilcox
2023-10-20 3:37 ` zhiguojiang
-- strict thread matches above, loose matches on Subject: below --
2023-10-19 13:14 [PATCH v2 0/2] mm: the dirty folio unmap redundantly Zhiguo Jiang
[not found] ` <20231019131446.317-2-justinjiang@vivo.com>
2023-10-19 14:15 ` [PATCH v2 1/2] mm:vmscan: the dirty folio in folio_list skip unmap David Hildenbrand
2023-10-20 3:59 ` zhiguojiang
2023-10-20 4:09 ` zhiguojiang
2023-10-20 4:15 ` Matthew Wilcox
2023-10-20 4:36 ` zhiguojiang
2023-10-23 8:07 ` zhiguojiang
2023-10-23 12:21 ` Matthew Wilcox
2023-10-23 12:44 ` zhiguojiang
2023-10-23 13:01 ` Matthew Wilcox
2023-10-24 2:04 ` zhiguojiang
2023-10-24 7:07 ` David Hildenbrand
2023-10-24 7:21 ` zhiguojiang
2023-10-25 15:37 ` zhiguojiang
2023-10-24 2:08 ` zhiguojiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106133540.0d985052fa9137136593cbde@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=justinjiang@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox