From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB558C4167D for ; Sun, 5 Nov 2023 16:33:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B32E440167; Sun, 5 Nov 2023 11:33:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 86383440150; Sun, 5 Nov 2023 11:33:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DE73440167; Sun, 5 Nov 2023 11:33:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5E191440150 for ; Sun, 5 Nov 2023 11:33:51 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3B83680368 for ; Sun, 5 Nov 2023 16:33:51 +0000 (UTC) X-FDA: 81424447062.22.A56A642 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 683D9100016 for ; Sun, 5 Nov 2023 16:33:49 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I2Rt6ERz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699202029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fRP3AdCuPldlN/4xgmE0wyZH8InceIme7Yx9aataN94=; b=tfEiPJVU4MPmRzzKEqA/eckemzSq2oYbVDn1KUbBBjZO1ji/+sjLkQYCHzXVfACaLv3k5e GXaOrBAOb/PpdZWT1IHikIHOX03ShOAzxOBk3Je/Ko4faAzTu+gZNDzyvHgVEM2FyLe655 GkaIst3nA905KbUQlQaL2QEwUBnM4oU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I2Rt6ERz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699202029; a=rsa-sha256; cv=none; b=Tdry30nWU07H86WLsx0ZCnfYBfAxXpGq4enCxYMPrx6E4XpDRFnnlF5r1qTYhdShHyzwgM ZizbnHE0z65J9PIlx1ll6HgU2q/dL2afxB6Pww7HAxLvl0BU9ZS8XbNYUMgQDdpZHxM3Do mjaBTNo/VCT0LcaD3mnFZ8ipLeNMMT0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699202028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fRP3AdCuPldlN/4xgmE0wyZH8InceIme7Yx9aataN94=; b=I2Rt6ERzfaWayzByGO21dEA0tv6PfeKzbNPWy8J/mRxX0i0Mz86QkzanTON4oVyve6CfF7 aBoEMF6hMkMcfEdk2B34/uVO84lso+eg+xGeJQgggVYf2YRRLQQ3YqJ3fdy/0INKAEWV8r GhTVWIpzaK6moQH++RdJl97OJW3ZzYY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-124-8GMKX0gaNwalOtRVdMIGuQ-1; Sun, 05 Nov 2023 11:33:45 -0500 X-MC-Unique: 8GMKX0gaNwalOtRVdMIGuQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 168C8101A52D; Sun, 5 Nov 2023 16:33:43 +0000 (UTC) Received: from avogadro.redhat.com (unknown [10.39.192.93]) by smtp.corp.redhat.com (Postfix) with ESMTP id 417422166B26; Sun, 5 Nov 2023 16:33:36 +0000 (UTC) From: Paolo Bonzini To: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Subject: [PATCH 22/34] KVM: selftests: Drop unused kvm_userspace_memory_region_find() helper Date: Sun, 5 Nov 2023 17:30:25 +0100 Message-ID: <20231105163040.14904-23-pbonzini@redhat.com> In-Reply-To: <20231105163040.14904-1-pbonzini@redhat.com> References: <20231105163040.14904-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 683D9100016 X-Stat-Signature: nri51rn1ybkzqetog4gdmi6xmu5z5k16 X-HE-Tag: 1699202029-455615 X-HE-Meta: U2FsdGVkX19lDT8FVXqRAqXqYcB3EFUW39XjNAYz/1rznqJzlQ+TTrAJjQyaUk3lIk7+OR5Krk9EbthxRZpG5qPL5Ewgt1PZtvsSoj7Br4cSlkDkzQLLptESwTp3xY7DX3yUu4kkzwqXoU/KGOj7LsU2dJL8mOfCWKiJ899GAtnsW+8IEVqq9f+zCMoo4zYdJPKQ3JByoQdzk03ym3nz16IUd6jlOycXEc4Dipz2poku4YvrhM1jnKTUNOEw7O1jztymug88kKlFhXp47Y/xNOm64h8lsaK4Yb00+2uIj1CzvYo08JLroKaW7KANhBRjltBDfBqAeAJXRjJFdM209NLmYYIITbQUxwlp298n7ibYat2UYU8RstNQq2ahFERr9GloLIJhVRqXTgbw9pItq6dfwuhySq/MD0E31Tfeev5sw2NDxatG7B5A7+hYsHPzMoHXuIsVIYZYMMzGHIEQi8nDb0taYgz8kR1OH9l5andEmgDiSdmAIc4Q7ZSkLWrDuNNgC7S2plDJ/+KHCAhHfR11oatxku1HQjum2v/JX4/U9JRJd1jlsW2S9oNDI4iK4sIMxzkxnxalNnVD3AGvAlR5zlUgXMM0qYl9vFqCVlod+pKH6fTSl2iS3syDDxqZchidYQI/HQIZ+M9ivQhRlT4rLfTUWFn0+0+W+SHECZPC70e0lLh6JZ7dMaaAw+JL8IjdSk6UKapG3W/Du7GGqDQZFRoVDJ6bzINsD4AmxAYCVK4N+3aMudn2AEOzPq2EvUSTsxYT52v1XHmIOaTLGfWjG9xSHmr9G2QWGSf2XVy/fdQsly7uruJXmYqi6k4dW6lmOPlXxj3W7lJwzsRexTi5jgKt0pKv9S0S+M97tHdXemG1qxkvWQSALN5BmURxvofk1WvMjy0i9KkpUr4QRsTf72HwF4ib8AId4bnVgyiwHBOd9FNP9bxMxKrfYSBt6enlzAbXxWmaw+xGNFE xaiuKL3q 3xCVtvkmY45yKLINuZhmgD9DtrBHMLa76ugfr7N6VP9wWPKX5Gbu00ZVTKq2/3o1mVcTvOBQjl1c69dFmvfL+qijFeI6T0RmRN6lyzj09gijkk2eA0VLf1vdGPJmS9Ch4qYqoe3KzeR/HUwpsb7+qwSDSLwP8W/YQAREhlwj+RQW6I3hRzRFh3hv57edeoj2RAoOWaCl+WNl2Bs3QFvVqKHy1IQPN4jN5pI+NksdO6h7cVsHuxrvDLRFALtd2WSipCQdjS/qqaYnvwznIT3FL4wOvcDOEuL+/aiCUKVRTmBUgmFto+0shJSZShuSg8V21DIRI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Sean Christopherson Drop kvm_userspace_memory_region_find(), it's unused and a terrible API (probably why it's unused). If anything outside of kvm_util.c needs to get at the memslot, userspace_mem_region_find() can be exposed to give others full access to all memory region/slot information. Signed-off-by: Sean Christopherson Message-Id: <20231027182217.3615211-25-seanjc@google.com> Signed-off-by: Paolo Bonzini --- .../selftests/kvm/include/kvm_util_base.h | 4 --- tools/testing/selftests/kvm/lib/kvm_util.c | 29 ------------------- 2 files changed, 33 deletions(-) diff --git a/tools/testing/selftests/kvm/include/kvm_util_base.h b/tools/testing/selftests/kvm/include/kvm_util_base.h index a18db6a7b3cf..967eaaeacd75 100644 --- a/tools/testing/selftests/kvm/include/kvm_util_base.h +++ b/tools/testing/selftests/kvm/include/kvm_util_base.h @@ -776,10 +776,6 @@ vm_adjust_num_guest_pages(enum vm_guest_mode mode, unsigned int num_guest_pages) return n; } -struct kvm_userspace_memory_region * -kvm_userspace_memory_region_find(struct kvm_vm *vm, uint64_t start, - uint64_t end); - #define sync_global_to_guest(vm, g) ({ \ typeof(g) *_p = addr_gva2hva(vm, (vm_vaddr_t)&(g)); \ memcpy(_p, &(g), sizeof(g)); \ diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c index 7a8af1821f5d..f09295d56c23 100644 --- a/tools/testing/selftests/kvm/lib/kvm_util.c +++ b/tools/testing/selftests/kvm/lib/kvm_util.c @@ -590,35 +590,6 @@ userspace_mem_region_find(struct kvm_vm *vm, uint64_t start, uint64_t end) return NULL; } -/* - * KVM Userspace Memory Region Find - * - * Input Args: - * vm - Virtual Machine - * start - Starting VM physical address - * end - Ending VM physical address, inclusive. - * - * Output Args: None - * - * Return: - * Pointer to overlapping region, NULL if no such region. - * - * Public interface to userspace_mem_region_find. Allows tests to look up - * the memslot datastructure for a given range of guest physical memory. - */ -struct kvm_userspace_memory_region * -kvm_userspace_memory_region_find(struct kvm_vm *vm, uint64_t start, - uint64_t end) -{ - struct userspace_mem_region *region; - - region = userspace_mem_region_find(vm, start, end); - if (!region) - return NULL; - - return ®ion->region; -} - __weak void vcpu_arch_free(struct kvm_vcpu *vcpu) { -- 2.39.1