From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CCF8C4332F for ; Fri, 3 Nov 2023 23:13:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7F2A44014A; Fri, 3 Nov 2023 19:13:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2F428D000C; Fri, 3 Nov 2023 19:13:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9830F44014A; Fri, 3 Nov 2023 19:13:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 878408D000C for ; Fri, 3 Nov 2023 19:13:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5E353B6972 for ; Fri, 3 Nov 2023 23:13:08 +0000 (UTC) X-FDA: 81418195656.13.E43B75E Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by imf14.hostedemail.com (Postfix) with ESMTP id 5FD66100010 for ; Fri, 3 Nov 2023 23:13:04 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=LYEp8QYz; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf14.hostedemail.com: domain of da.gomez@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=da.gomez@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699053184; a=rsa-sha256; cv=none; b=zL33SF2NH21ExcA9wA1vUcCq4txuZ/8RKCx0K6JPpTjva3o5U70n1gmXYJ5QXrM+qXdYcF LVpKHaxHfxcaIsCgbB/oD6SaW0TWOB5q4+s168nyXyvx0Q/+LgZcJvLkELdHub37XdTUWA cisCQE49zCzi39fJ/nv3CyAzzupkPYs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=LYEp8QYz; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf14.hostedemail.com: domain of da.gomez@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=da.gomez@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699053184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oHsO3OHKphhNYc2KKcSi9BXbYPXz/A7ETlyML/Q/00I=; b=1X6PTWwmmbuWllggEi2WXwhTg9EYM18O2LU2irqA0HhOid5JcjSFxlOg6XSw4QtTdpLJiR DlZ5glGcddSKN+nSU2ELQwPIwna0ESpAkDGgTn84e9i0tOi+I7LplG4R0JeDBmIpsh56Zw rP7TGp44kJdZdVSHIANwajXHVVItJmo= Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20231103231301euoutp0198043b1fa15a2f4b45c9c324ea5a9043~UP93kNNRW0804908049euoutp01r for ; Fri, 3 Nov 2023 23:13:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20231103231301euoutp0198043b1fa15a2f4b45c9c324ea5a9043~UP93kNNRW0804908049euoutp01r DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1699053181; bh=oHsO3OHKphhNYc2KKcSi9BXbYPXz/A7ETlyML/Q/00I=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=LYEp8QYzPDwiyxo0vJcR59grQQPKZw/jJGYxkBRhA1+xpmy1hXxufOiNL4gCdRgD1 baYL7KT4WACekSJU8eKAZUKlMSzZXdaMfjFIh/1eRzN6rxECFT4MjS44DLRRnLDAkk 79Fz/sGs8mH+Nb/lyRW47yIBA8MgRI6dHi4XOfPk= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20231103231301eucas1p192942ceb0cb6ebb63aee326a6f959e2d~UP92_LwPe0263002630eucas1p1C; Fri, 3 Nov 2023 23:13:01 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id A5.2B.42423.C7E75456; Fri, 3 Nov 2023 23:13:00 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20231103231259eucas1p18e529693e4b47b5e0623271bf319a25f~UP915_fmj2687926879eucas1p1Z; Fri, 3 Nov 2023 23:12:59 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20231103231259eusmtrp22251fecfaf13e569c815d97a704cbb52~UP911BCNL1325313253eusmtrp2c; Fri, 3 Nov 2023 23:12:59 +0000 (GMT) X-AuditID: cbfec7f2-a51ff7000002a5b7-2a-65457e7cccea Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id C8.69.10549.B7E75456; Fri, 3 Nov 2023 23:12:59 +0000 (GMT) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20231103231259eusmtip2247fb3c78e71787af6a52bb65a4d74c0~UP91nknSd2294222942eusmtip2T; Fri, 3 Nov 2023 23:12:59 +0000 (GMT) Received: from CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 3 Nov 2023 23:12:58 +0000 Received: from CAMSVWEXC02.scsc.local ([::1]) by CAMSVWEXC02.scsc.local ([fe80::3c08:6c51:fa0a:6384%13]) with mapi id 15.00.1497.012; Fri, 3 Nov 2023 23:12:58 +0000 From: Daniel Gomez To: Matthew Wilcox CC: "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "gost.dev@samsung.com" , Pankaj Raghav Subject: Re: [RFC PATCH 01/11] XArray: add cmpxchg order test Thread-Topic: [RFC PATCH 01/11] XArray: add cmpxchg order test Thread-Index: AQHaCePk2/Onfe3eA0ia1dQGCoKrA7BhNHAAgAgOVAA= Date: Fri, 3 Nov 2023 23:12:58 +0000 Message-ID: <20231103231254.bytltpzsc2qojlbw@sarkhan> In-Reply-To: Accept-Language: en-US, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [106.110.32.103] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKKsWRmVeSWpSXmKPExsWy7djP87o1da6pBtNnW1nMWb+GzWL13X42 i8tP+Cyefupjsdh7S9tiz96TLBaXd81hs7i35j+rxa4/O9gtbkx4ymix7Ot7dovdGxexWfz+ MYfNgddjdsNFFo8Fm0o9Nq/Q8rh8ttRj06pONo9Nnyaxe5yY8ZvF4/MmuQCOKC6blNSczLLU In27BK6MzUd3Mxac5anY13GcsYFxJVcXIyeHhICJxInn79i6GLk4hARWMErs3HedBcL5wijR On8KE4TzmVHi9IJnLDAtzy/1MYLYQgLLGSXObGWCsIGKjn2Og2g4zShx99p9Jri5M+/sYwOp YhPQlNh3chN7FyMHh4iAhsSbLUYgNcwCR1kllqzdBLZBWMBWYv3WOcwgtoiAncTDWy/ZIWwr iVdfroPVsAioSLzY/hOshlfAVGLOtMVgNZxA1y3d/gnsIkYBWYlHK3+BxZkFxCVuPZnPBPGB oMSi2XuYIWwxiX+7HrJB2DoSZ68/YYSwDSS2Lt0H9bGSxJ+OhYwQc3QkFuz+xAZhW0o0nPwM FdeWWLbwNdQ9ghInZz4Bh6OEwFQuibVL50Etc5E4enA31BHCEq+Ob2GfwKgzC8l9s5DsmIVk xywkO2Yh2bGAkXUVo3hqaXFuemqxYV5quV5xYm5xaV66XnJ+7iZGYMo7/e/4px2Mc1991DvE yMTBeIhRgoNZSYTX0dslVYg3JbGyKrUoP76oNCe1+BCjNAeLkjivaop8qpBAemJJanZqakFq EUyWiYNTqoFJe/1Fy0W1vvNvn9m0sGwBX8O6OKlXSb+bhBRXbS+r/nhon/n38A1qr2PWCq1w eZuqWvJZVkc5+YTPWhuJW29FvPzu5ZWuUZ/7mn8Jr9wRjYfFfZpF7y8d61ycv1xqwS82xlVz jncdVwnd28jsLML86kjEG8t/ouK1z2P1RduT7Hu8czIPHV/049J81uW+HaumKMYkLryRa5hl XRY2WTX7Zvz6M/6X1/1o6blpXft3Y07ywstBt1bf+v00jvlIzIJ1c580/5K2O+Gw+XBbtoCu 3by/b489++N7XzzMb4pkRY7AlLNp0Ukv2kzTbY0Odl5TK4z89vTJrh3FJrPbPl2Rtd21s8N5 55sfMV3MPB5cSizFGYmGWsxFxYkAjGb8Z+gDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPKsWRmVeSWpSXmKPExsVy+t/xe7rVda6pBj1ztCzmrF/DZrH6bj+b xeUnfBZPP/WxWOy9pW2xZ+9JFovLu+awWdxb85/VYtefHewWNyY8ZbRY9vU9u8XujYvYLH7/ mMPmwOsxu+Eii8eCTaUem1doeVw+W+qxaVUnm8emT5PYPU7M+M3i8XmTXABHlJ5NUX5pSapC Rn5xia1StKGFkZ6hpYWekYmlnqGxeayVkamSvp1NSmpOZllqkb5dgl7G5qO7GQvO8lTs6zjO 2MC4kquLkZNDQsBE4vmlPsYuRi4OIYGljBInzsxjhEjISGz8cpUVwhaW+HOtiw2i6COjxPPJ 21kgnNOMErP/XYPKrGCU6J/+kR2khU1AU2LfyU1ANgeHiICGxJstRiA1zAJHWSWWrN3EAlIj LGArsX7rHGYQW0TATuLhrZfsELaVxKsv18FqWARUJF5s/wlWwytgKjFn2mJ2iGVzmSTu/V4D luAEemLp9k9MIDajgKzEo5W/wAYxC4hL3HoynwniBwGJJXvOM0PYohIvH/+D+k1H4uz1J1A/ G0hsXbqPBcJWkvjTsZARYo6OxILdn9ggbEuJhpOfoeLaEssWvoY6TlDi5MwnLBMYZWYhWT0L SfssJO2zkLTPQtK+gJF1FaNIamlxbnpusaFecWJucWleul5yfu4mRmBK23bs5+YdjPNefdQ7 xMjEwXiIUYKDWUmE19HbJVWINyWxsiq1KD++qDQntfgQoykw8CYyS4km5wOTal5JvKGZgamh iZmlgamlmbGSOK9nQUeikEB6YklqdmpqQWoRTB8TB6dUA1O6tFrHju1ue1rd91ewfJFm2DIr SUL3Qctk7RUJ995WNb3ewfrr8O1eg/pEftWEjzqnNzUb3lVbJGAoeVv4yimVgs+tZWVb/299 uZVhIvOnDse8ZGmfZRMDG0PzL8+M0d9+89ix+SzvGUqjmK6efXHmynkP2XkCW97HBDh2Seuf cv9o9Tn2/6xnZ5/X/Jv2Rscq+U2b4ZHlCxy3as/2MZp5V+HGXVMedpvPujeUilremL5k/HBH aYbB/ijmMw6zI61Y3IMqWe5Gsr2M2sJQnXjEvGF52AG7Nyfs3ef9NeXdvG1DduusvZ2sUtfj 75Z6frBnenpb7Emiwdsz7Rb9J3st3v5b/jC7O2uZFrPo70dKLMUZiYZazEXFiQChzl1/8gMA AA== X-CMS-MailID: 20231103231259eucas1p18e529693e4b47b5e0623271bf319a25f X-Msg-Generator: CA X-RootMTR: 20231028211538eucas1p186e33f92dbea7030f14f7f79aa1b8d54 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20231028211538eucas1p186e33f92dbea7030f14f7f79aa1b8d54 References: <20230919135536.2165715-1-da.gomez@samsung.com> <20231028211518.3424020-1-da.gomez@samsung.com> <20231028211518.3424020-2-da.gomez@samsung.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5FD66100010 X-Stat-Signature: miqzr1weqq83e5nduoca5t7w8b3wii15 X-HE-Tag: 1699053184-811212 X-HE-Meta: U2FsdGVkX1/pa8Q9+NJgASIyaLKuyHiygjNboRVNkjL8AC7uSYllOjyn//ildctDY1zxQyRoCYfu907Us39UiMaYCRoNRxXfwYtoC+Hyzbv+tG39wZo+4CN+ig4y9vOPDTShTBPtdTtbhE1tR2bByTn3XTfvt8rH0GBX63tPmvmReNAvbVYwlCAPB32V8PsBGL/ovdI/t9nMwWWUhiB2w588InxD4q9rgGHoCfIFRhBlfQo4YHEYno3PkxD67R0AzhawQ3yJNXsMlueqXDrxNPO9L+Pxhy/rItspQrAeKH/N8cyC84gvau0awgtMYZPiC4ELpo5ZntOgSMFE1E7bIKuiIQeggJdmsq+LETwB62rIX+tn/KkD4rqNXyhWjrnKaP2NnBg9g+5T8wDW79OJzvrXPj8RcpesUAk6b9+06T+a2G2Xv9alUD3XibtNJ3TNqFQz0zzIuNpgzHDqSwV+GTRND6q/zOV/NKI73OaHl8fsMttpmbakj9xuH3Yc4jc6qnzFC0aydpZKEYHX9ns0M8y36t8uRx1nuXxVwEq5N9znUKNG4WXqdeAb1Z08iqNp7yBjmHYxyMFfA+zuypnmxljiJSQPEWzWA06ni6WR0/Gd84hSu8ML9vEPNYkwTjPQW2ywr+SHnVLrXOyMs4UO2VamN7JDK5Nb+n3uHgsqJ2KFSLee22HLpWJaEJKIdgw0ZX3M9UD1zKanuBNJaAdvLc+vttcW5bZOf382/nXCT1/g1kdbxn8XhR/oCfN10dakfkyKOqXjqaeKYVOX4clGXwqYBNZm2DzCKqcHQTg1AgObYxqv1Tj+f2wpdTSwmR9sOLGVv8JyokzUH56trYFZcV64Ny7vmdn/D7AcudJbIQZI+Tuo3Fjd5uK5J8NjRX7NLk/UrDSddwzDsAqwzsrk5pgEJKPwoRqBXbfnwxFp62Ohtotuw8u6i1QureCvtAorp5NLTepZwKtEJS3u7tg yJ6F4DN5 0EDxdksjIKIM8POUemp4iqdDB2W21Mput3HS58HcHHxIjapFcflzqVbglWWHnewV9WrCoCvZyTpQBeEjxZlrCnm9SVCpn4ULt5FD53Bq0LDUPViZNqeAVwPsQhjJ7Yo2dK+uvptXjNfC33vUGaE5XUm5yOVvP1N+NFjfz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Oct 29, 2023 at 08:11:32PM +0000, Matthew Wilcox wrote: > On Sat, Oct 28, 2023 at 09:15:35PM +0000, Daniel Gomez wrote: > > +static noinline void check_cmpxchg_order(struct xarray *xa) > > +{ > > + void *FIVE =3D xa_mk_value(5); > > + unsigned int order =3D IS_ENABLED(CONFIG_XARRAY_MULTI) ? 15 : 1; > > ... have you tried this with CONFIG_XARRAY_MULTI deselected? > I suspect it will BUG() because orders greater than 0 are not allowed. > > > + XA_BUG_ON(xa, !xa_empty(xa)); > > + XA_BUG_ON(xa, xa_store_index(xa, 5, GFP_KERNEL) !=3D NULL); > > + XA_BUG_ON(xa, xa_insert(xa, 5, FIVE, GFP_KERNEL) !=3D -EBUSY); > > + XA_BUG_ON(xa, xa_store_order(xa, 5, order, FIVE, GFP_KERNEL)); > > + XA_BUG_ON(xa, xa_get_order(xa, 5) !=3D order); > > + XA_BUG_ON(xa, xa_get_order(xa, xa_to_value(FIVE)) !=3D order); > > + old =3D xa_cmpxchg(xa, 5, FIVE, NULL, GFP_KERNEL); > > + XA_BUG_ON(xa, old !=3D FIVE); > > + XA_BUG_ON(xa, xa_get_order(xa, 5) !=3D 0); > > + XA_BUG_ON(xa, xa_get_order(xa, xa_to_value(FIVE)) !=3D 0); > > + XA_BUG_ON(xa, xa_get_order(xa, xa_to_value(old)) !=3D 0); > > + XA_BUG_ON(xa, !xa_empty(xa)); > > I'm not sure this is a great test. It definitely does do what you claim > it will, but for example, it's possible that we might keep that > information for other orders. So maybe we should have another entry at > (1 << order) that keeps the node around and could theoretically keep > the order information around for the now-NULL entry? Thanks Matthew for the review. I'm sending a separate patch with the fixes and improvements on the XArray cmpxchg test.=