From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6E80C4332F for ; Fri, 3 Nov 2023 15:16:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C09C8D00C0; Fri, 3 Nov 2023 11:16:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 249438D000C; Fri, 3 Nov 2023 11:16:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09C2F8D00C0; Fri, 3 Nov 2023 11:16:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E6FA78D000C for ; Fri, 3 Nov 2023 11:16:28 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BF4B41CBE2B for ; Fri, 3 Nov 2023 15:16:28 +0000 (UTC) X-FDA: 81416994456.26.512A7B2 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2056.outbound.protection.outlook.com [40.107.93.56]) by imf16.hostedemail.com (Postfix) with ESMTP id D834918000C for ; Fri, 3 Nov 2023 15:16:25 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=Jn5qwq6s; dmarc=pass (policy=quarantine) header.from=amd.com; spf=pass (imf16.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.93.56 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699024585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a08XbWVO9YN+VZwYojSl2NmshVyjXkTdRSViiHM00wY=; b=M8lVKKhCQqqXNJvcA9LgK+eJbbVqg+W4EOYY6DAjbo/OHBDeW/QAedm2LrZylHfGXqqli5 NG4g89LwRMxwjG/5R7dZDD9yxYDY0ySRL7YbbQ6UaBGO8B6i1O0X8NUm2nGDqvohk2+DJe OfFzcXR6hG8qWCIOVR2nJBv1+nnB0S4= ARC-Authentication-Results: i=2; imf16.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=Jn5qwq6s; dmarc=pass (policy=quarantine) header.from=amd.com; spf=pass (imf16.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.93.56 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1699024585; a=rsa-sha256; cv=pass; b=ZhuCOtgyJIQsJ0ugfGvv9ZORY2NXl9h8RYgbqxy/pRuXMqZG5OCYe6eS+A9nsNrQjvULUs IuIcYrT5EAW9a8ogKDsPczjCzEJYpMYkDm1zioCbj7LHCne7+TH1tPD1nuoEBLwKX4VrFP a5tC5+xdGEP2GTHAqmca6lMo+I8u5IE= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OdvrnoZfYPNQupXLkLKdzBtONF5f8wK64n4wbT5UrTsmTzKv9+kBq18788GG/MgfP3ckgvM611Au+2nQpLNZ4PtdouB3wUTO2/nNzqNvgqPSp3Mp/J3RfUy54TRSI6BYXacchDvGWQp7VX3GGP1PSLX3NOWtBBLoAsC3GDiDhLndcdvE9z3AtPYg0kMJo0Tr0HTsWyVBxSgPBxwiFLEbRp6oCjvTiQXiryODQn+ilSW0pZoC/aLhc/+KS8dBHFKMIU/U344LJorqIaAn428VrLUiNv7o6FC8FTGxViOy3USG/IK0lYCT/IfF9YTvRm0s8etsw9bW37L4vN1IziTHxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a08XbWVO9YN+VZwYojSl2NmshVyjXkTdRSViiHM00wY=; b=nde/r4SFrpgGAqZo5qEgKzwF4kPbOKYjWuQLlanKZtLWQmrsZE42jn9GyU6ZyAkKXV2853z/xf09uAughBFbqvYRQRbSfvuFRVKzbXgNQBUJlV85mzqhPqHwAqUcdn0P+X/TjkM16qmnBEchpz+Gai+g2NYMErrohwcUtbVMT+X5+9ldLryVFKFdAoVfQf1vzUvNPT9N44EFquK7cuyj92VhxkmYiapdo87B/KMUWuaT1VHyKXTGhDBDzOm+1RUmG8muU8+xmC+OLIlNEH0qxvL68KgsNMuYos7jWrtNZ49rCuEsWh7wFuiW0lI94xiV6PCa0ilwhq/0EOYnQPf/6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a08XbWVO9YN+VZwYojSl2NmshVyjXkTdRSViiHM00wY=; b=Jn5qwq6sB2Q3cwcamt3Ia1jHjHGAKKzH6oCCOKWq1KZSfjAxf0YYd0sOioJB3HvDVekMCCfIFppOMxdpsXVXvYV1eTTDv0DgLUv4nz29ulSSzpA0E+LY/sgjWM41eM3rbPom1XRTSEpxCF43I46OGS2PZoPUuxsBXKc0xX6E9Ko= Received: from MW4PR04CA0358.namprd04.prod.outlook.com (2603:10b6:303:8a::33) by MW4PR12MB6973.namprd12.prod.outlook.com (2603:10b6:303:20a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.21; Fri, 3 Nov 2023 15:16:18 +0000 Received: from MWH0EPF000989E8.namprd02.prod.outlook.com (2603:10b6:303:8a:cafe::e4) by MW4PR04CA0358.outlook.office365.com (2603:10b6:303:8a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.22 via Frontend Transport; Fri, 3 Nov 2023 15:16:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989E8.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6954.19 via Frontend Transport; Fri, 3 Nov 2023 15:16:17 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 3 Nov 2023 10:16:16 -0500 Date: Fri, 3 Nov 2023 10:15:31 -0500 From: Michael Roth To: "Kirill A . Shutemov" CC: , , , , , Ard Biesheuvel , "Vlastimil Babka" , Nikolay Borisov , , Tom Lendacky , Paolo Bonzini Subject: Re: [PATCH] efi/unaccepted: Fix off-by-one when checking for overlapping ranges Message-ID: <20231103151531.7e374teoxeekcrlm@amd.com> References: <20231103142650.108394-1-michael.roth@amd.com> <20231103145353.5wzcwc5znkzt6vzf@box> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231103145353.5wzcwc5znkzt6vzf@box> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E8:EE_|MW4PR12MB6973:EE_ X-MS-Office365-Filtering-Correlation-Id: bfd83ada-b658-4e81-e058-08dbdc7fd442 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kwmS6Gj6MuNB3KzmVfngxdirQ6BTVNQT84rWdW/Z37mfOSIOWzpXnp5dJ5faDnNRzwzI8AACu/KMq//OQSNYaA/7wqXfqnidJ2WkXKfUVXSzJ2xF8IgiuWl/1X5gLslgRjAn3ym49frCPbxmfC8L2Brz7QZd1DC3jKyht1WPROKbAXBIZnmjaHql9KhAj0bmnICiAbY5vzJRbiy0bGEo0pJW7Wq4+IwSdDWhQ0ENvQZF/ygpFXkngAnqH7AM34QBu5DoTb6ZMSUWnAD4RFsFu6sv2k27F6346JMN/0VT7S40Bkda6hfO9arRg7bF864TMzdYiV+dqpo1HM+OgIbUV3oSdKHhSDMYNnBeofYuBPdvi38Gb816zHbPHW1tkwLKdN8gZO6Uf7lT7yqoTPXSrkqj50bQFdXTtWm5rX2kV46OC2mAmFCBP2Q2DrwNq3YuZPwOdZ5YTdeP+KIf0AMl877IpLu1B2FjH7uMgR8HJkQgEkXHKEAazkE/U6R/HyQChckBkfzFV0XBSkmO1GdnWvZFmsv1zgMDcVJ8xOUGsmT/FalZD+xGlrWT4+j0IlOZYB8rt7by6d6u6x1zxNkneD8AdHhAhyY/O0pbhHlhX6CxyqMrngj7CFiaXcY+ler1M3YJ3kjQpAAV3h7F855TauXNfObPRPOBbLdVL6Rk6guIhHEHzqOuXmDReMAL3MOR6GLj544xurLOWiJaUpmWMAZIo9mT3AKd4HcpTnq9+lndplUimjoBkaS8pwqjYMoM X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(396003)(136003)(376002)(346002)(39860400002)(230922051799003)(451199024)(186009)(1800799009)(82310400011)(64100799003)(46966006)(40470700004)(36840700001)(86362001)(316002)(6916009)(54906003)(4326008)(6666004)(8936002)(8676002)(70586007)(70206006)(426003)(2616005)(478600001)(16526019)(26005)(36756003)(1076003)(966005)(336012)(44832011)(41300700001)(5660300002)(83380400001)(7416002)(2906002)(47076005)(40460700003)(40480700001)(36860700001)(81166007)(82740400003)(356005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 15:16:17.9729 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bfd83ada-b658-4e81-e058-08dbdc7fd442 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E8.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6973 X-Rspamd-Queue-Id: D834918000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qk1py5m9z5xjctfironydiisx176n6mz X-HE-Tag: 1699024585-106057 X-HE-Meta: U2FsdGVkX19ahvamnZDv9WOCRmc4odoto2AiM5JAE7x9Rsqwt7h0VrkONq6nc2IvGDIIsWw+8hlrXT78VHPy7pYwhE+yCM0wA1Q9e88SuN3TVfP/hpfNCwqJzjWvJcFmXYqMOhDN+7eg7VvEAfidwNY2aN+P0ZxzlBHs143Vk8qhTw6fGPFk4Sizt/SbItS2fzr9V3gtSrkPrC8B1Dq/OGa5wiQylBiONSbqFqzI9IE80ryjfpwMr91LviEHy06eFZbYKJgqo+Ho6sslBnlU12zG8akqPrHiTdBkeJHE+wchCdDeZ2JLLAFsoO4HUvhJ7Fz5I7BQkuGnaMKyQKSr5KMAm0x25Ct/i7aoioPCYQgYMxllLSoWdjlOjyOkZj8SDGa8HurKxZfCEsOJP1SFPskSkQBIZH52tguZScrmALk+Z2yWwnbbhLdIDMRsn6Wb0ah03PSn0F6vpxaWXARiNqbiSIh4qTJyRM8ERpE6wUMOKbOg/UfG9gJNiqsESpxJODZYyenO3PWfCDwHXo0z3Il5x/07rN3U3+Rf+FFhRqs6bA8ha5yOGg2UX0MeIvM/uhqH9cq8mS6G0AeSbYsbC5vKUVVwNfR/QwiP1K7ZlZLoe0O7tYweiqRrYyj/SevbQEZ/jjz6IPVIF2k4BbihZrZOOBiYJKyFmsiealLL7ZhC4ih/+aUDsiqBXBxJr+YQeSGIZH0999v7TRXTeqMY6xuOTsSUDllY60uUhBaFcaqSOF/MoY1sbkDszEoVQJJMbshP9eFbSyZC+RkLIiXkfYkXXqBFtHDVH5xls34cBWpfcdBAMCMDXjmcCpl8jPtIxscoFpNQBhpDCp3LeDBcPxrxdBu0wVrDlgWT2Vjsqrgxea0agqnhN3jQ3bgzg2S9c4a5IKYGxqwXga6tvGRYkRm7vZXHUlcYLabr42zVKKFE0wHAUE+wfiqGn1v/DHKTaJk40Kzmv5aeew9ByyB qMynPt+1 pBH08i1dTE4jpt4qoqk6gkFRLbzx8C8RYIrZE95dfs7J8BaXmf6nuBGxbRzPBqxI8z9YPMWCYVwTErK2rA+m3y5gB33tSLaAGNkv0gBq9LD1XBT5e51TSnZ6QGvNlGsMyDlCE6jkTLUGgHXDtf51945i52yI0ctnp5Burvuuz0IxIz/nYk/++cwEZXXlQE+ed05vYfc5YlDNVnv36griAOwGT/6vwDMUU0BPjPFS3HkVriNcgGrQaZbRFrfDH1lmfKGm0cJqnjW10W5WU526BsrItAdLOIx9VnMJbhIAKgCLzLUrCgjoSzOaeg+n1aEkgBqcNGwC37tC7uYS+ny3qU/hYFW7vTMeJeUlS/wi6JN/BSjW0zF+5ncfVy+54LTn7nRUOWYppO6XMna+eAEKtGgrtGu6grWSr3AqzORYd+rAXrM2vwGHNXmz83i1oYZzVCkrWFvPu6af/6LRQcFvnr1HaNrE8x23m0A8L X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 03, 2023 at 05:53:53PM +0300, Kirill A . Shutemov wrote: > On Fri, Nov 03, 2023 at 09:26:50AM -0500, Michael Roth wrote: > > When a thread needs to accept memory it will scan the accepting_list > > to see if any ranges already being processed by other threads overlap > > with its range. Due to an off-by-one in the range comparisons, a thread > > might falsely determine that an overlapping range is being accepted, > > leading to an unnecessary delay before it begins processing the range. > > Maybe s/thread/task/g ? > > > Fix the off-by-one in the range comparison to prevent this and slightly > > improve performance. > > > > Fixes: 50e782a86c98 ("efi/unaccepted: Fix soft lockups caused by parallel memory acceptance") > > Link: https://lore.kernel.org/linux-mm/20231101004523.vseyi5bezgfaht5i@amd.com/T/#me2eceb9906fcae5fe958b3fe88e41f920f8335b6 > > Signed-off-by: Michael Roth > > Otherwise, looks good: > > Reviewed-by: Kirill A. Shutemov Thanks! Sending a v2 with suggested changes. -Mike > > > > -- > Kiryl Shutsemau / Kirill A. Shutemov