linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: David Hildenbrand <david@redhat.com>
Cc: John Hubbard <jhubbard@nvidia.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Xu <peterx@redhat.com>, Shuah Khan <shuah@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built
Date: Fri, 3 Nov 2023 14:08:14 +0100	[thread overview]
Message-ID: <20231103130814.GC8262@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <15ff806d-59ab-46ab-8891-05ab917a1528@redhat.com>

On Fri, Nov 03, 2023 at 01:59:28PM +0100, David Hildenbrand wrote:

> Okay. the question is if your workflow can be easily adjusted, or if we can
> improve that header handling as a whole.

So on IRC the following was suggested:

  make O=defconfig-build headers ; make O=defconfig-build -C tools/testing/selftests/x86

But that makes absolutely no sense to me; because the headers and
selftests are not .config dependent. Furthermore I don't want them in a
kernel build dir.

> The problem I had with this recently: just because we did a "make headers"
> once in a git tree doesn't mean that it is still up-to-date.
> 
> So once some selftest changes showed up that require newer headers, building
> the selftests again fails without a hint that another round of "make
> headers" would be required.

Yeah, so I've been adding #ifndef guards all over the place for decades
and that just works. You need it in normal userspace too.

This super reliance on the very latestesetst headers is just a total
pain.


  parent reply	other threads:[~2023-11-03 13:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230606071637.267103-1-jhubbard@nvidia.com>
     [not found] ` <20230606071637.267103-11-jhubbard@nvidia.com>
2023-07-10 14:20   ` [PATCH v3 10/11] Documentation: kselftest: "make headers" is a prerequisite Mark Brown
     [not found] ` <20230606071637.267103-12-jhubbard@nvidia.com>
     [not found]   ` <8e208e0f-699c-2c34-d66e-bf6d488a7a1e@collabora.com>
2023-06-06 20:10     ` [PATCH v3 11/11] selftests: error out if kernel header files are not yet built John Hubbard
2023-06-07  5:37       ` Muhammad Usama Anjum
2023-11-03 12:16   ` Peter Zijlstra
2023-11-03 12:22     ` David Hildenbrand
2023-11-03 12:46       ` Peter Zijlstra
2023-11-03 12:59         ` David Hildenbrand
2023-11-03 13:00           ` David Hildenbrand
2023-11-03 13:08           ` Peter Zijlstra [this message]
2023-12-08 15:14       ` Peter Zijlstra
2023-12-08 15:21         ` David Hildenbrand
2023-12-08 20:29           ` John Hubbard
2023-12-08 22:10             ` Peter Zijlstra
2023-12-09  1:39               ` John Hubbard
2023-12-08 12:44   ` Miroslav Benes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231103130814.GC8262@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=david@redhat.com \
    --cc=jhubbard@nvidia.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nathan@kernel.org \
    --cc=peterx@redhat.com \
    --cc=shuah@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=usama.anjum@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox