From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B955C4332F for ; Fri, 3 Nov 2023 12:46:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0D8428001A; Fri, 3 Nov 2023 08:46:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBDD128000F; Fri, 3 Nov 2023 08:46:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C867C28001A; Fri, 3 Nov 2023 08:46:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B9C5C28000F for ; Fri, 3 Nov 2023 08:46:13 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9086440190 for ; Fri, 3 Nov 2023 12:46:13 +0000 (UTC) X-FDA: 81416615826.23.8BD2D08 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 9D71C40021 for ; Fri, 3 Nov 2023 12:46:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qk6oIoXE; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699015571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8TMcEyG3RiD7RECaqRdhYHspaIsImlZ9FwqzKP0l02s=; b=FFgf4oOHHcJH6pFfyMCYU/Xo80HJGJhUFoNkhOtuHTDPd6owpZknLVoGCUe+bf+jtAoRvl M4fq+mCwg+AgHAC3gml9GWfs8sdEDDuU/L+E2nc+zxvqBb9uPsaF4QKfRrYckuQoWupMVn ay4nwW3lCJS3Je99qymWODWUEAoO1VE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699015571; a=rsa-sha256; cv=none; b=uMMgivEw0W3VfbveEnxL8jKyl62TPG/hVXecRJuOH863ptl432q0+myXbMVm+DpHUnSMiM aBBmw9uTjMwjDIjyup8Erx0YET1bfTAfvC/DF26+91q8lRxoMX+XUwBqRrPV8Lqff2V6cz gZku6EH0+gvZGiA5+23nqQuNjyjJTBo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qk6oIoXE; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8TMcEyG3RiD7RECaqRdhYHspaIsImlZ9FwqzKP0l02s=; b=qk6oIoXEFgEVm8AON0Ukab/6vv ShSen0t+/dOGOL0ERyspoiGDTmFT6inioEId0OvPa4RGxfEb+Lsw9Hyb/NgkKG5HHHuE3PK2V66nN AplQjJvaElTsFMiIq+52qMkdpIdg/emYsRctcIUZncQ118bmb9RSA7DSmTLWrq5dq+5pKh894llEx 9kpKQo7UVJDoMRlm0OhvPuVkHsAfEGqpveBs2GNIGSrDuHZMhga9Cnf1wgVplDKJA2V1HL/hFAmTh mdv74d3ddFOGo37LrlBPLsxDb1WW4H8zwDOCU4XQjiG7KepTotk67cIJrIl2UbZcRocs/N6JSHN6/ zosR8S4A==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qytYs-005R6w-AA; Fri, 03 Nov 2023 12:46:07 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id A2E9530027B; Fri, 3 Nov 2023 13:46:06 +0100 (CET) Date: Fri, 3 Nov 2023 13:46:06 +0100 From: Peter Zijlstra To: David Hildenbrand Cc: John Hubbard , Linus Torvalds , Andrew Morton , Peter Xu , Shuah Khan , Nathan Chancellor , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML , Muhammad Usama Anjum , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built Message-ID: <20231103124606.GB8262@noisy.programming.kicks-ass.net> References: <20230606071637.267103-1-jhubbard@nvidia.com> <20230606071637.267103-12-jhubbard@nvidia.com> <20231103121652.GA6217@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 9D71C40021 X-Rspam-User: X-Stat-Signature: bxzj5pjpcz94k7peetkxm1qah3qsgjff X-Rspamd-Server: rspam03 X-HE-Tag: 1699015571-592533 X-HE-Meta: U2FsdGVkX1/botqKkP8R36oXhu7YCFj12DnzfjKQYizKnBupgvOokcA6e4Wa+GbyyL77YX76e7Prh1/6Aaeog6xEM1JwR3XoA5ajhQEG+OeBwp9+ZXbfkAi6w2KluwBZdamErLw8Av4ekVa7YNDF0yjF+l7cdIY/FzsVng/YMgA3R7E0PuytshA42ICfPsFEqsPjBe4yWs99Hkcs2PsG+MQB+DXhT8K50lAsKZ1ZVHSwdTdn6N4mkD+NQDEqrX1W/sHPG8hmp32j0jQV4000oivO9+T+ErBPs32LfVaGdIzNk19phkkcGQzOoE0b5ytFjDc6F0ums4PFd+RhTH3KS4OUB6i9f6LYgJVLZHuq68zTsaol0pJPakmU8RGPQIWavq7UeJNYIwoWojJ5PVuBdK9YfZLlwKX/G6+jNY02/DqeesFkw2dNlHw03pjwU5ejKIL6tWVokdvm3ZD5L51MIrBStEpqVhxCJKUJ36eZjzX8+NbgsnBf7Lu2JlyU0Ff9XW6VrslKYTeej+4GsLeLEk1z00VZlPvEWE0LHkc/evTQ02vRbLJjZ0cjZjE3qbb6zDwgvBIMeFnTQXjRncgoJtXd/fVFKsaw9G6K8P4rGL1R69cNSAwvN7jhtS/zg9Up5RGW1IFma20vVmbr4sURgnQ8U+03a3+k9qepHC6PDWEmKqhmJpABciMPZinJgQf1Uk3UvdRzwWRFYu+NTNSso2uPELE4OM5K9gEnnVrRI34WHkh36+lNxucGkAShc9Jaiii9uA/W840B6HdZy4a/jduBSO1P2cngWEs9DKplGvt5MaHJM0YM0HU6MLckX8RrE8H9lLAL6fnhbDPm5JsiEd5CVgWbDAguiD4drr+dFp4b9dr9Oe19J/1vkVVgN6dmo2cswmv1Iq06ovNYG1KwEJTem0uLFOkczSIwye+3GBrSG8zvGiphaRKRd/o3YFNRsuOX3F0W0eiIG+X46ro mp8Ib3ti SvLA3QM83e7JJek0wY/agzqW0+iuZH9rQA3uWAcJheza5XfEHaQCfMilOasV5oc8BpBgXBDxvRXGe1IRW3uxjMD6MrLVlJk1jyUyY/4AoWcIy75f+dSjshmCXd86SavwrUZ3CqQPl6CFHsSk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 03, 2023 at 01:22:54PM +0100, David Hildenbrand wrote: > On 03.11.23 13:16, Peter Zijlstra wrote: > > On Tue, Jun 06, 2023 at 12:16:37AM -0700, John Hubbard wrote: > > > As per a discussion with Muhammad Usama Anjum [1], the following is how > > > one is supposed to build selftests: > > > > > > make headers && make -C tools/testing/selftests/mm > > > > > > Change the selftest build system's lib.mk to fail out with a helpful > > > message if that prerequisite "make headers" has not been done yet. > > > > > > > NAK NAK NAK > > > > This now means I can no longer run selftests, I thank you very much! :-/ > > > > root@spr:/usr/src/linux-2.6# make O=defconfig-build/ -j64 > > make[1]: Entering directory '/usr/src/linux-2.6/defconfig-build' > > *** > > *** The source tree is not clean, please run 'make mrproper' > > *** in /usr/src/linux-2.6 > > > > > > I've always done: > > > > cd tools/testing/selftests/x86; make > > > > and that has always worked > > > > Now I can't bloody well build *any* selftest or risk not being able to > > do builds. > > This change landed in 6.5, no? And 6.6 was just released. Just curious why > you notice that now. Dunno, last time I edited the selftests and needed to recompile was a few weeks ago.