From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A654C4332F for ; Fri, 3 Nov 2023 12:17:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82BD5280019; Fri, 3 Nov 2023 08:17:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DBEB28000F; Fri, 3 Nov 2023 08:17:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A3E1280019; Fri, 3 Nov 2023 08:17:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 580D928000F for ; Fri, 3 Nov 2023 08:17:04 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1D229407CD for ; Fri, 3 Nov 2023 12:17:04 +0000 (UTC) X-FDA: 81416542368.22.E23F460 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id B869640025 for ; Fri, 3 Nov 2023 12:17:01 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BchoTeSy; dmarc=none; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699013822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NwSa0s/USIN07+9So8CURfAeXqMYxed0LGoxTxzaWIs=; b=r/QZ5MnUZXZi3ZVM7sYuJ3ckdglO7l4HbOCCAXxLWv6gFTYIoQjn04m1BEE2/1glhGbdrn RiFJCuvtzStnM+49x7yUNLQ5SvYgLatL1FVch78Stl71FDvbRHloWV+OvDsNcm//CeDVsV de7Zn4EuLc6m90tBqCAEQ3WT1C59DIU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BchoTeSy; dmarc=none; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699013822; a=rsa-sha256; cv=none; b=uUlfYjlxNL8aKa6wv2hYn++v1266MJmLOZVGBSdT7hysFUJBWYt1iONrNJc7EOCVIUic6P HAOOo1WAqeGUXpGOG/30Yp03Dfp6rEQkgXkwLlBlefibDGJ5fP9hEPcy144HIH+pGiPqIP ZQSqomQiajKGmtU4BRwvpdTQ0/DTUeA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NwSa0s/USIN07+9So8CURfAeXqMYxed0LGoxTxzaWIs=; b=BchoTeSyaSsw5YVFa0b7Ex3dB2 ju2JfCId7dUuJE49APsnTneSoVKSrhL53EotUSuwvei7yXOReaWDMIhubsDi+lBog4vQAJJndh8DN +LAv7TWkcksMmHOMwcz9ucJgK1ioB2mA1Gh5pD7Y//cyET7H8VkMorvC/LBcxVfCX7/7NEQY96nij tTkMuEULNfhWoyNLGPiZdoMOO7Q96Io/nxiuqgkFhB/F9mf/MAaKLQujHM3sHaHvAw0UhyraxcjrC igy/vrquBieQzo4jS+1sevMuzzV7wSTAzquZAPk5f7/ef+olx4YXjWSzjmJAnhDVi4p6nbfd9nXVV z2h7jgCQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qyt6a-005IuG-3S; Fri, 03 Nov 2023 12:16:52 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 727F2300202; Fri, 3 Nov 2023 13:16:52 +0100 (CET) Date: Fri, 3 Nov 2023 13:16:52 +0100 From: Peter Zijlstra To: John Hubbard , Linus Torvalds Cc: Andrew Morton , David Hildenbrand , Peter Xu , Shuah Khan , Nathan Chancellor , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML , Muhammad Usama Anjum , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built Message-ID: <20231103121652.GA6217@noisy.programming.kicks-ass.net> References: <20230606071637.267103-1-jhubbard@nvidia.com> <20230606071637.267103-12-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230606071637.267103-12-jhubbard@nvidia.com> X-Rspam-User: X-Stat-Signature: wsc3iuzgycaq8m58bgt6m5844dn7b5p3 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B869640025 X-HE-Tag: 1699013821-491644 X-HE-Meta: U2FsdGVkX196gxwd+ec+yfptFPp6CnS/dNOJMvFaoRidXtMQ87NqWY86yCI73pkluNrfhtrnvrssthmh2XGtxY7VhdWgbqB6bL9GmENL6sWzD5dX3K7PdWVc1307qAfTrtw/hsMFr/Zz5JktzEYCghFyRO+2MzMnbfw7YOb5rdAKKGUdADJc8AL6jvjKGHEN+Oq/p+VwNWWR3wNxuMuQgrtdquaN7iOpS/k2kKexQEODIf2SpRiFoGgXN3S1/C1sldDpSuBdl7uXHr6res8TFoi31uLSo5VBHYFBrIEefRlsTX1v78/57M6i7CD9udGqMZCgQIUvSECoJtLZylPNLQ+B15es9WPIOw8rd4zsdLs47H6piNEa63LwlO01H4+SkMVSAeidcD/yJy/rVEwSRH1acxMlG+H3IMu0FBFbD7ouiW6fzwje9JPWQnzTCne+50GjeqUWjiV1xLm1cVm1x++4CJ3rf34OBBylVHsyfTBrsu6rBMtOr1lOfx+gZnLCb+c3etqm3QgY8j3WOB0kbdTS1iqIev1fXbmQeC3jaRG1lbOG4BOnTaM4V72GOr1cXgF3PtRXCqHLuw0nJDSt0aw5DbonuFY9BjWaMux9SmESzZWO/pmrcN8esFDqVJlRrMYz/13urIdktxwmpYiG3RdPpsDMQe18Wg/Xr/ZLG5O9xEkhcBVQti0S5Hs2968HmxvyhxNORTVzHXKQojtbjXYbQ/NWet4giLgJ4wp6s9Lfl2N5zbzQPW4gQYiZpeUgIeKnyhNWK9Gp0ZTRdj0HgzO2wEVOhVqnHPGTDiZt/j/5E8cUM3L5N2Q4msAFo1Mcl6O3757qqOlroIwu0SMCso/A+ALiX1YG8mKziO7GF08r+ltJp1OrdGnaEPaATyJgAbD3Chtn6RSJlum3UgonoRQ4cjhloGi31Ay9gNP4/FZFcNlxhBW4cpq7sucaGcdIkBug+e9VnvwBYe+SXy9 dC85jorw iWoVwJNq5PV4jWFSj9kC6PoWruDmlfOdaxrqw+qFmfIwQBWM9QH34I40QNSUyM0sYCAfI7SwLdp7MbVjbl5ptEaFFWcL2CLDKdUoIsJIowty10BHu5N3OvSixDL+hlD44AXiaEAEJUNFSfFQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 06, 2023 at 12:16:37AM -0700, John Hubbard wrote: > As per a discussion with Muhammad Usama Anjum [1], the following is how > one is supposed to build selftests: > > make headers && make -C tools/testing/selftests/mm > > Change the selftest build system's lib.mk to fail out with a helpful > message if that prerequisite "make headers" has not been done yet. > NAK NAK NAK This now means I can no longer run selftests, I thank you very much! :-/ root@spr:/usr/src/linux-2.6# make O=defconfig-build/ -j64 make[1]: Entering directory '/usr/src/linux-2.6/defconfig-build' *** *** The source tree is not clean, please run 'make mrproper' *** in /usr/src/linux-2.6 I've always done: cd tools/testing/selftests/x86; make and that has always worked Now I can't bloody well build *any* selftest or risk not being able to do builds.