From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5090C4332F for ; Thu, 2 Nov 2023 05:40:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20DAC8D0077; Thu, 2 Nov 2023 01:40:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BDFC8D0026; Thu, 2 Nov 2023 01:40:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 088948D0077; Thu, 2 Nov 2023 01:40:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EB6388D0026 for ; Thu, 2 Nov 2023 01:40:19 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B642580EDC for ; Thu, 2 Nov 2023 05:40:19 +0000 (UTC) X-FDA: 81411913758.28.D19F262 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 1EDD52000E for ; Thu, 2 Nov 2023 05:40:16 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=JQ3mbFJS; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf13.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698903617; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zDOBDi8eBolO+x8QUwzdil25EMQyOW65409etgkw17U=; b=CpHQ/DTTyEedzIEoEoC3QNMeHiUyhWTqCvWKw6RnVrfcZyrdLlmLbbkBL+dlVLOn0cRsoW WQ+bSU3G1FzooHP+tRfv2q26D2wxrzlwMf5BedA6fPFgFUfCRtE7vfb3+mc9nbP2RgC5C0 Y6jFxCDTPrkK/Pk6TurCLADNCtYhNGQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=JQ3mbFJS; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf13.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698903617; a=rsa-sha256; cv=none; b=SxyGDz63vjKMOrBwtb8pPD6UcAUpDKdjpUBL1KZ1B9ry5gQ35AzRt/mqd6Y34iCGsqTy9W v7owT1rOKX6HGN4PhBpukworO6WnDETKKHd3ohvjOkKPwKujqxJqKyxI86koVsFRXQgRpv dhKO3REre/CW70d6prE4htLJZmpBn1E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2AF0561267; Thu, 2 Nov 2023 05:40:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 183CBC433C9; Thu, 2 Nov 2023 05:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698903615; bh=C0oNnW2C4+FnQKa7bIHzaESxVdM7l0n5Xz2J7g6Tzek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JQ3mbFJSkioebglr77L0j6L8u0OR1FY/7pYGvuIEUHigCcjjzKy76JlfANUBFgD3m dLoTSnCmGpQXW84MBRD6I2KRbwjyiwYvc23sjvfDJrv0kB16MF/qBfngEl262iymrg hdc+MDUQQLqljd9l2WeoiedK/a+rbTZ4XRGexV64= Date: Thu, 2 Nov 2023 06:40:12 +0100 From: Greg Kroah-Hartman To: Li Zhijian Cc: Andrew Morton , rafael@kernel.org, linux-mm@kvack.org, ying.huang@intel.com, y-goto@fujitsu.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 4/4] drivers/base/node: add demote_src and demote_dst to numastat Message-ID: <2023110230-lilly-mustang-9b57@gregkh> References: <20231102025648.1285477-1-lizhijian@fujitsu.com> <20231102025648.1285477-5-lizhijian@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231102025648.1285477-5-lizhijian@fujitsu.com> X-Rspamd-Queue-Id: 1EDD52000E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 4hm1pc9kgzhuyeuxhocyoe73oq8jxn9r X-HE-Tag: 1698903616-604317 X-HE-Meta: U2FsdGVkX18BxUJSo5geEz3bYkn1IrjSdW9NxFSzJ0i6Wa3hlHQfcBznoBZtsXPydW06kNA6TNtDrRrD6Hja4KFAhl4m4CuzFSqrzgo6sswc2ZuPy62s7jXtU87jo1kOZtL1uwTBchScWNSEkTFp1WzdhNV9717yfi8oCW6h1+dBTTHT3QmH7mlsJyyqx3XVlP1KLndRLwfhmUSXdYjdt01uv2rQcFckQbvHZeMqIOLi1uRG9Nu3MIjs7qju5VE3pp8989NtPWfOOfuC5SeqCgLCLhCqERaZoy5lI5dlfC0aaYpRQcHsPDXxTuJASqnCLVThasAyU5GJfNMQI8oHimGjnHDA/YlFaw4jiSXzZMc3PFN6uNQpzk69u3xneT+3y739BuzaCsoRFg9WF/WuCbrenddy2RGPJYbmrmFkODTAQTzficPVJFBti/LiDlHveL53aqXhRhEOcGUCb3p4aLn7cNtKZFTT/9A/ymAbLQro9rW50wGQIIy5B1wdY6DjD87ajLz9lH90dDX7sjIMXGANGeHwyyFqnN6QTzKiUk6IEhDFbf+KnlHjf7E+NfS1f9n8sVElMf8ezgOBN7AwF24irrBSfrOq8OSFErHT0Lycl6HxWa++xeqAmC8n/UtWDAxVFVzzBLoUx3y3EDBDaePyBoNFsOWV/aPXmOja46yDA+ZmBCUtj91ZKagK5gY8AIIj1cC8P2yif76aJV5f8vI7ZaSb+MxEK/9elkIIynpC22/bGrYtVfQkZPUY3GhDhwkUqFct6DNxd5v9KyOqA+44NHLGNe2MjmvDjHGiF6ydP8U+6P15VM6jLwVot1EMaEWgbFRtyWaUW4HLFo4MgU01LT8ZXhVnzzoHAP8H1D0Iffq3HC6CBVPm1d46dI1F9DsDDvsD0+PQngIaxWCvL8eFbh23JDUHUI7/gHALSW8PatV+2M+0lNNSwz0juVgP2rx5zBUYn+ewYWdjhOa AXHNU9gp utOR6DziDmBDOWxWScZXE0eL3DIXs+9qRa11IJ+oX/Q30g5YqKZKb3QOU1LXjCc4f4ifhmQqnqC83UU9LFwk673T/7s78Ftgz7tzO5B1WLMSWr2l4QztluKemsRkXLifFd+pANIPlTbJB2X84XOoi7GpTPDoUulJM1DNp9Z/NWuEqty05k+hVPijRdV4YWVn0D5jlm5pW+Jt6FBT6WlJQmgstJc0Qziv8zsFgG0cOv/4JQqjJwOIfwspBWdg8WBVmzFSEwVfRv+Qq8FECMrqG7AqQTAA0lQD6sH+h X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 02, 2023 at 10:56:48AM +0800, Li Zhijian wrote: > node0 and node1 is DRAM node, node3 is a PMEM node. > > $ cat /sys/devices/system/node/node1/numastat > numa_hit 646590 > numa_miss 3963 > numa_foreign 30651 > interleave_hit 416 > local_node 645252 > other_node 5301 > demote_src 200478 > demote_dst 0 > > Of cousre, the userspace numastat will be extened to support these 2 > new fields in the future like: > $ numastat > node0 node1 node3 > numa_hit 741793 702460 364154 > numa_miss 1759 8104 28893 > numa_foreign 8105 30651 0 > interleave_hit 653 416 0 > local_node 741762 701115 0 > other_node 1790 9449 393047 > demote_src 163612 203828 0 > demote_dst 0 0 367440 > > Signed-off-by: Li Zhijian > --- > drivers/base/node.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/node.c b/drivers/base/node.c > index 27e8502548a7..d3fc70599b6a 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -496,20 +496,32 @@ static DEVICE_ATTR(meminfo, 0444, node_read_meminfo, NULL); > static ssize_t node_read_numastat(struct device *dev, > struct device_attribute *attr, char *buf) > { > + struct pglist_data *pgdat = NODE_DATA(dev->id); > + unsigned long demote_src, demote_dst; > + > fold_vm_numa_events(); > + demote_src = node_page_state_pages(pgdat, PGDEMOTE_SRC_KSWAPD) + > + node_page_state_pages(pgdat, PGDEMOTE_SRC_DIRECT) + > + node_page_state_pages(pgdat, PGDEMOTE_SRC_KHUGEPAGED); > + demote_dst = node_page_state_pages(pgdat, PGDEMOTE_DST_KSWAPD) + > + node_page_state_pages(pgdat, PGDEMOTE_DST_DIRECT) + > + node_page_state_pages(pgdat, PGDEMOTE_DST_KHUGEPAGED); > return sysfs_emit(buf, > "numa_hit %lu\n" > "numa_miss %lu\n" > "numa_foreign %lu\n" > "interleave_hit %lu\n" > "local_node %lu\n" > - "other_node %lu\n", > + "other_node %lu\n" > + "demote_src %lu\n" > + "demote_dst %lu\n", This sysfs file is already a total abuse of sysfs so please, do NOT make it worse by adding more fields, that's just wrong and something I can not take at all for obvious reasons. thanks, greg k-h