From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33F42C4332F for ; Thu, 2 Nov 2023 08:54:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFEE78D0083; Thu, 2 Nov 2023 04:54:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAFE18D0026; Thu, 2 Nov 2023 04:54:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 976EA8D0083; Thu, 2 Nov 2023 04:54:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 873788D0026 for ; Thu, 2 Nov 2023 04:54:31 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 65A4A40D57 for ; Thu, 2 Nov 2023 08:54:31 +0000 (UTC) X-FDA: 81412403142.23.DB0DDEB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id AC655100010 for ; Thu, 2 Nov 2023 08:54:29 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=odffH414; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698915269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E71F4fGVkzPvvC7T0SvVgSk3UcNYR1KYBkhmBETecFk=; b=jIhQRiGnUAAsRa4rPr4kBUigbwhrOaa/bPZVhzzVWoSa7R8qpFvRnE0xXuw3WgdirAD0gt Oo/YMqA2OdRQttDnRlnFOheuPZqLJE3Gci1pFbwHuEOBWOTbsiMroJbrFdGoTT1WS1D0JP 1JSuu1aFcuKGfunIS4Atqg4nE/rIWqs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=odffH414; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698915269; a=rsa-sha256; cv=none; b=28H5nw652h6gFaIEw1uJRa8xDhY4pP8/IZXU8fVtclQxowL/I72Gt9XJTOB8hu/kGa3jHA ag6KkuFO+ltjP4gV89vbVe5NMAMIj7mwHy1dkE1toiLBsp4EBhMvGUICUIAvzH6ythgKRJ WpgAqTZgOl2NjLPQ0S3Oqd7uXvwb//M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BA96D6137A; Thu, 2 Nov 2023 08:54:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56789C433C8; Thu, 2 Nov 2023 08:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698915268; bh=A7FoYJUUU5fM6KDQZG7+WD2UG90QXjzmTG48GuucSeg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=odffH41401if0nynpcNzmku2bPes9u+NXTnn3/94mJEdsp9QMJqQPk9qH5NKaxWsn /lSKcAaj1SO+piCDEqR/x3kPUJxK3KtKZYEC+bLhliNZVI62+ztUkNvVn0oaqc8npe NXexRyK5JnpWtGKEeUTTLuFD0Ih9tcrdTqPQkEDzNTmoKIXtHxESH/x882yPlE4twJ 5WjXMPZEdoAhJdKOdrmTEcgJCM8qDsf0snG+AQK0vAd86swQdWsh6SIIK8ZJ+7x3dM 43qflqT2U0FzRfEnoujJm1q9wO6HOGspX1uhiSLe8X6COkqrWaSxMawbfxtOcQfBTd aUGcv/nwmWSyA== Date: Thu, 2 Nov 2023 10:54:18 +0200 From: Mike Rapoport To: huanglllzu@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Liangliang Huang Subject: Re: [PATCH] mm/memblock.c: using judgment statement can reduce loop and enhance readability. Message-ID: <20231102085418.GM2824@kernel.org> References: <20231102023710.13023-1-huanglllzu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231102023710.13023-1-huanglllzu@gmail.com> X-Rspamd-Queue-Id: AC655100010 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: dh43sfakmijze1pfqzryuqsfqf79dn3b X-HE-Tag: 1698915269-914776 X-HE-Meta: U2FsdGVkX1+U++MaxGRV9QFfzUgrPUCPNRadakF4ovVq26koaXZpd9wXshfDFZ1bVHNmIRKFJwSXtI2pqktYX+tOV4E/bv/mZM+VpTQ1n5JnW7p9lacBUV0aNMhf8qJKs/9NQOUEnPKyS9Fc80Q0as2+Z7YIMrlJtygsH22qqNdIY7Z2wmBB0fCuucx9hzjFw32SGxkhoAP6vhZpHM3+YKnnq4ykHOW9IH2XAf0sbNs3LzOxeyatg1peXA0dBlxVLj5Cx88DVNA+XnY6+cb9O4NZt2jppGSjba+dTdkXaDGmMcc/e92frAWUy2vXCI/RbLz7uCBjwQvFH4cDc9+meAJ1p0W8DWEvwT6l67s8J9Qq8YZ/nRETJAkL1TMvFH33zKzwtoXXR/ipkrGqn1j8BB63qyeS3K49M4dBUEB/jwgVi4o3y93BygGiNYWRsg0VGq656pGcta9BrKCIk1B5AoXz4ETm8q8OA8mpnTUz9uBMRBso8NV0G+Uouv5EKDYPb9xu/0f+5l+FFtjs3tAj8GhckWBn4VdTveQF3niFXkXaw99V9M0/6jlE6AX9AzQE+47uei5WWdYvhaBNG3lIFWnzXaXXJ+juNqZSvZBenGYaByTdiCWTlMrGL1oVUPWtqG6hkJx05iVOW7lBwGgT3rm18rBe/qXG+nnK3xUNBTyNkn9I8XvallvBROmDGSw9MH1iEcyLJGIKll2wBJaVksyNSugSnO0q5etdyk0A3dMv3A2+imiJGr6Y4j2r/rLBdVuJWXBCyqK1i8fOaLqK5XHSgummibQLWXLYW5y8Z6fmI+Y+a1iiA7s57/s77UUrNpp5pT96PvqJv9ycP8twE5wQ0Gm9S4xXbrF2wujGao4X3uGBOwTVAbX/1bE2rRwdWU1GbACcoY/KbnSmM8QI7JWW5tEmm5JB4SbWEfSy8iMjjEjb6hiKAHYQrRUyQifFlqkWJ6ukaFFVu2274J0 B6au9bGT 58jv/Kr0aCGBZzpfpJzMKis6L2pLq6QnvnvLaq13KyiEMFBUKs4RU13xfbFERVFvf5r4oEtk03DWjvHnOA2CHjrcSnCiWSx/L1uZWuXsM+ixYbgVr0a8vYEIldQIu9HlhWUku/i5APPWvG7RfUdb+hHk4xguVlJowRnOoG8dpcUK7dyiuU5Nbw5uPRfkPhpvPD8PSLc+02AC4+L8LKqh1jyYtIi/hYzl1X/XL6SBK4aI6RoJ4wm9PQlS+88KlcEyRNY40zS2v1HzuyRY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000031, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, > Subject: [PATCH] mm/memblock.c: using judgment statement can reduce loop and enhance readability. I disagree. On Thu, Nov 02, 2023 at 10:37:10AM +0800, huanglllzu@gmail.com wrote: > From: Liangliang Huang > > Signed-off-by: Liangliang Huang > --- > mm/memblock.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 913b2520a9a0..e48dea7144bb 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -655,7 +655,11 @@ static int __init_memblock memblock_add_range(struct memblock_type *type, > } > } > /* area below @rend is dealt with, forget about it */ > - base = min(rend, end); > + if (end < rend) { > + base = end; > + break; > + } else > + base = rend; min() is perfectly clear and there no change in number of iterations of the loop. > } > > /* insert the remaining portion */ > -- > 2.25.1 > -- Sincerely yours, Mike.