From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99E77C4332F for ; Thu, 2 Nov 2023 16:24:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14B148D009B; Thu, 2 Nov 2023 12:24:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FB568D000F; Thu, 2 Nov 2023 12:24:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDDEA8D009B; Thu, 2 Nov 2023 12:24:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DEE3D8D000F for ; Thu, 2 Nov 2023 12:24:47 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AE44780DD5 for ; Thu, 2 Nov 2023 16:24:47 +0000 (UTC) X-FDA: 81413537814.17.4F42C62 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf29.hostedemail.com (Postfix) with ESMTP id 4CD7B120011 for ; Thu, 2 Nov 2023 16:24:44 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ciKD3Sqq; spf=pass (imf29.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698942286; a=rsa-sha256; cv=none; b=yumrFvrSFx9PGsiKDwQPTJbfQEtKYeg/nlzKTO5vFghwBFXXzfV9PARuBkNR3XeR6T2kcg baFjouG4iZcR3lLmQtMoxYhfaYjng5cuectO/rvzpf3ehD8RiXdR72Oxi6j6lUmfN9wJiN HUN0cW9q7LDi6IXgYP0BTL3F/K5sLJw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ciKD3Sqq; spf=pass (imf29.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698942286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HnyBGy2XgkPSPqImTiPWH8+PRjTRB/35l+KAA1/cEPM=; b=Bo9jQDYQYRWOLhNfldv4wRwKZH0QRKvqHEREK2gwvenMif2OECt9JZncfLBDAe12SQA8iY OwAtTa9SM4n12CREdkTc7OsdV1YTUvNJF/F7qxcac1n7QtYDWPzKoUc2YUwn/qOak7rVhj KRG5t/4k0tYZzTC7e8bOfSXBPPcZlU8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2668ACE2132; Thu, 2 Nov 2023 16:24:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFBABC433C8; Thu, 2 Nov 2023 16:24:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698942279; bh=1oyVMjQI7OXHCUtZSgK71uJyeSsja11PK2zu0Sgh3ck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ciKD3SqqJbMFjIcI6bCCYkwFV34fiO2ArRgF5fXcYKuOaGXb4Wyi9zozkY1GPacll Wb4+rsmrOAiUFpUvVmXoDHyclytLXtYqrhZkU0PpNpIyYDeZGFKHZDDWtqHWW99OuO qo3jhEw/diJ1a/cjqpth3wyK9LJTK2A2KbT6VwEC/UhcdzfCTDR5j8l+p9MS2DAQxb LzKQyThoycm/wTmhlnVYtsizofoKOqeGHL2Li2UrkzPUXr3zUUph4Dx0xK0JakNnV7 d57GUWFGv9wIfjooWNbwoPxilLaGhd+yLjY93dOc3Y/tHVaznNMcGB6moDDpowdxsF zbisHCIeWrzQg== Date: Thu, 2 Nov 2023 17:24:27 +0100 From: Christian Brauner To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Subject: Re: [PATCH v13 15/35] fs: Export anon_inode_getfile_secure() for use by KVM Message-ID: <20231102-freihalten-vorsah-fdd68051b005@brauner> References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-16-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231027182217.3615211-16-seanjc@google.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4CD7B120011 X-Stat-Signature: 8yc99nhsqei31hc1iusuwtg7f9am96f1 X-Rspam-User: X-HE-Tag: 1698942284-433623 X-HE-Meta: U2FsdGVkX1+x4ksvktJiFPh9f2uQee6gelVn+uCPwvkmIOueAAfl7+am4xnsY9F4hrKb+5gQJ/8kz44YlJKKiABk7HSy9VC7n0vCdeeaEfreYAw37khXn//dq+9rekQZXytu0Q2tN0lNpENQ85nPoND5l6dpXZNqK+b1w6I2yl3vuRFfk9JpYJ6pP8pw9eVpS8gS8ywU02Y1grxkRfuW3W7DGYigXU2ujbwr+WTKPkyy8LQuLYfDR1VdFBLnoQT7+fi/LPQssY03Ydy9QIXkE5yPxjtMqQInhGJssskDU2UPN6ik8kHHO0igv/L+9EYlkuqC8k9ztvOZrDjCdUSBKtTGK8mfmwNewYB6/ppVYSBBC+eZSmaiwNAjW3Wxytfh6S8OnlX5FRTYK3jPXq8s0cXOFrJz4cqWqCz+sfKK489SqVO3JdkChgaX5SUvLIVbWi0OdAlccEjrP9OEvXLo0224RCLR9JsyBaDVjSY35BqD+NHXRp4XWU32ThGIBG/oULVevPrgZR2yl0jQq9CrJqVIcDf9yegEAd4SLv+QXw3cA8DJv73AZG0Kvn1olmQqiQvdgiysVD4H4nZ3s6OaFfVwpMsHmbgtxwOSPqdTahGuzPjrmxLOsxm027YKw60qBihfU0lI17WDWkuu8a4y85YYS6xbEctWpKgXihSykP/EB2JTiCmlDDjm7EusWI74HP9ftC+qgcUpG65ltrmh/I2CXUyxwlrr1hTYK+4U3BynRTXev+Ss8qZJlx//cqKYsuG5Q3B1j499B+4R/k1WXGb4Be9zfBnAehyHhMVfZ63IxefUDfR5Lr2BdFrzwPXNN5d8Fpq62b9tX4ftyy3R7h8dkyyytgGtUJwYrWJ7e1zaY4HO14r05no/acaLUiJ6z70HQ2+bnO4pXW7Igxn5+e2BBqT+KQwgZ+wL4iIG1LSu55f5gNpJj+KFlkFc8/eK8xpvkiY8pWsieI2YZ35 FV3fOuSf iF3sXnEgPlJgO3Nsm3AxrI7R8PdGng5cwpeV8E5Nxk0Fln/2/jngQlZxG5dPuB4Mwtku6X/toG4fHe+rJrMC4VNVad3xBjJbihTc5HxJxqpNdvdWBLRaavnhZcw5WftVnSc4rAdrksTTcoGne5fWiJAfKOOkoIKyk4WvwYnHCyCDbOIqTAaq2eHyuU5IQuFJ2rbCwpYyiXIBwXq4IKWFtOwqzHKplLGgf62JNEKv7CetoWM7gIXRmZWvr1Du93DaGBsggB1r4GxzTrprB/ior+/E8t7+ioEfwQx/4Di4CaDX270uOKEpkgSnyj5Au6Zoyza9zLJ5W1aUIrxs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 27, 2023 at 11:21:57AM -0700, Sean Christopherson wrote: > Export anon_inode_getfile_secure() so that it can be used by KVM to create > and manage file-based guest memory without need a fullblow filesystem. > The "standard" anon_inode_getfd() doesn't work for KVM's use case as KVM > needs a unique inode for each file, e.g. to be able to independently > manage the size and lifecycle of a given file. > > Note, KVM doesn't need a "secure" version, just unique inodes, i.e. ignore > the name. > > Signed-off-by: Sean Christopherson > --- Before we enshrine this misleading name let's rename this to: create_anon_inode_getfile() I don't claim it's a great name but it's better than *_secure() which is very confusing. So just: struct file *create_anon_inode_getfile(const char *name, const struct file_operations *fops, void *priv, int flags) May also just remove that context_inode argument from the exported function. The only other caller is io_uring. And neither it nor this patchset need the context_inode thing afaict. Merge conflict risk is extremely low so carrying that as part of this patchset is fine and shouldn't cause huge issues for you.