From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BA47C4167B for ; Wed, 1 Nov 2023 15:45:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A7A48D004A; Wed, 1 Nov 2023 11:45:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 957C08D0001; Wed, 1 Nov 2023 11:45:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81F998D004A; Wed, 1 Nov 2023 11:45:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 72B838D0001 for ; Wed, 1 Nov 2023 11:45:18 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3158D1207B9 for ; Wed, 1 Nov 2023 15:45:18 +0000 (UTC) X-FDA: 81409809516.05.C89C2F7 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by imf14.hostedemail.com (Postfix) with ESMTP id A0CE510000B for ; Wed, 1 Nov 2023 15:45:14 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JYCZ70Th; spf=pass (imf14.hostedemail.com: domain of lkp@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698853515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4cDj3ugRoGYjkuipiQZBaxULTyv9sbNZksCkitRcDcA=; b=Fd9X3M7i2CHm2fRFwQCmdv2Z/W/x1oIciQ2W32Xr8Dg4j5L4J4qItIVhYlqACheX7qfbbu q7XX6He9ixMLYiBWl1nW/dkjcA5UpduZm6NQfZFyZtR1iKwNDkVblxLrxWIzxqkGv/qz9W 7BtelYRsw50vc6x4X7Jttj6ZIsDN/Cw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JYCZ70Th; spf=pass (imf14.hostedemail.com: domain of lkp@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698853515; a=rsa-sha256; cv=none; b=4aIhqgcsj/pVQqE+qwlyBt+Cosh84p6x3Kzm/2SzmrX7nMVokxiLhKTczM7IKT7c+7AF+U 8AoyMrvXMnC/v3QrX0100SI80SzymgzgegQs59LIw8dGvk6B2Ybiju+xOxtX3VYGPLh8nF k52bdiiialo8q/2jqX6Id5iUm0u8Nqs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698853514; x=1730389514; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0uD79xch+yhiRL277ZQ02UoFmVoZX8XE900MgWoHMgQ=; b=JYCZ70ThZ1zv/Q2gmQrjqhc5VMpThQco3dFY02nyRVVpy8/Sm+NXwnYH OuTLJptxn+/jsIBSuF4DnT5MXOlwIGfUXre4Rcwth+1Yc00yD8C2wD+Oe qgTYIEDR2ngzEkSs+t/U0fCYCIlCPFG34+wAHXKJwBGgJ98gWCg6ioFKX lmhL2o1j5yF9SbSm4sMxMznReoJuBL8gLsNCnvCefrZkDydn0CK8ffnDA jVSpPPV+ame4ZI4f1KWLT6leqgVpqlcN0vI31FBHlc2TADXfLMT7CmEKu 2J3h13UZnsdwlUi+7+b3z3Tp09iNj17qFG/F7idbcLeYQpitHjxHNXEFf Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="385694831" X-IronPort-AV: E=Sophos;i="6.03,268,1694761200"; d="scan'208";a="385694831" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 08:45:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="790136244" X-IronPort-AV: E=Sophos;i="6.03,268,1694761200"; d="scan'208";a="790136244" Received: from lkp-server01.sh.intel.com (HELO 17d9e85e5079) ([10.239.97.150]) by orsmga008.jf.intel.com with ESMTP; 01 Nov 2023 08:45:07 -0700 Received: from kbuild by 17d9e85e5079 with local (Exim 4.96) (envelope-from ) id 1qyDOz-0000rE-0z; Wed, 01 Nov 2023 15:45:05 +0000 Date: Wed, 1 Nov 2023 23:44:10 +0800 From: kernel test robot To: Dmitry Rokosov , rostedt@goodmis.org, mhiramat@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, akpm@linux-foundation.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, kernel@sberdevices.ru, rockosov@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Dmitry Rokosov Subject: Re: [PATCH v1 2/2] mm: memcg: introduce new event to trace shrink_memcg Message-ID: <202311012319.7ULVSdyR-lkp@intel.com> References: <20231101102837.25205-3-ddrokosov@salutedevices.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231101102837.25205-3-ddrokosov@salutedevices.com> X-Rspamd-Queue-Id: A0CE510000B X-Rspam-User: X-Stat-Signature: 3u68rbp3g3mnkmx8ouofmp5gx37i3pi1 X-Rspamd-Server: rspam01 X-HE-Tag: 1698853514-398010 X-HE-Meta: U2FsdGVkX19r7kIamWkF5qYAXOGIbFdh5xFaH+FLSRS6PmhPBqZG4w5UGY9VX28RMf2gR+icqj5797WNNy+z0RuacwuohLoQmpRj/KcdwFMxC3s1f3M5tuHEiQ+hMZUt3fpX8NM8Yh8vVUzxhkLn0jhyzibTkdseo0lYWzuJSdZ4bBhw3dktZteferCxSaxrng7uA9N8Id9IKNefVCbxoyTFCRFlVL7vixFGtzw0n/4GdTydpx972M8kCkzQpTZ7mJrk6NFWOCCcpd9Tu6GpQvttdSJXjbr3sqNDChiulXRfsdjlUAmHGfMNl/b+vHzIu8cHIMSXOcTnRCzouaO7rMPizb2krlYoEOm7PYf6yBpTBNYIXX6l/a0AkAPKLo7i7Bg807Jj1jm1jzpl/3q3HeOcT/gPvtRo2w2ar/sbqeBxboyk6ZGlzI67Wm2R0hQuNnmZB4SIOZfrntc6+zv/X84TBlVYosDIf8cjr3kp744/hAAQZAvaEKbz9OFu0nBtumS6TN4Qtomm11TCDVL4QW+uJPp9Y8TcYz8JfuCswvexpP/7RsuX+kwtV+soY+I4G8TZ2NluT2odEuhC+7VJjANZV032CaPxt09TaRzLKuQ8rqy7cFNDiY16/XR/L6E2etniq37YM8jsEmgLJmees6XuGu34Nxbw/Px0+KzXb+3qYmaFgb1MYogBgtKnGBwDYnzqnLD6KecRGtd1ZuCRT5H/AMwGXRaqLnTYD+smkLcl7jjXmev8l0qHuvwM588EhcxIwJBvHXoW8Uhzrz4W47gu6yleMFaqKf9IXEeeqlc1EExb6mCdN0AdmR77JmUuV7caoV90IlVg3Wjs3Z0AdqUI9P2YeFqDAxS4U0cG1D5bWZnKzlq/dSktoe0TDtcvtVygdOGOI2m3ik/v20LP4Pg98MJp8RosDNhQxlHpUJ3cRnMKLK6zStJDzDq5RxRMctUzsIIlVkJSX83Abco A0y694RY M/mJyV0TuZj0lkHjUPqbK//czjWBgQugJ5BafmS7fUD3pTTSikqDjqLFiG5X4Q9LeVaN4ZwW0T6EGSQUzNQWNtp0U26DDXJtWRDH4dUqNJSC/sqB3/tynz73bMWzHoDq4IzUiGjg3gBfy61U+VBZdbR/TKqJEdgDU12B0fGH+slDqCwp7aLfqr6LSAN/bk5eJe03sx35yU+hWXYMp9xKYFWRw20W6rgEdfwPy0970wtDskCOL4uduP5ZNlGpIQqcE8jfNgAdfUhUFNF2bzOso9chatBeRLWOB2Zvgz+ldixyw3Jl6RYr5gQPhOH/tzkNt+Q+W1H7EWtX9p1iw0mFovERLJesvJKbTsgO22MwfgQ/7pO1fDnA+nIoy7KN6nhzECp6vdbq98ZuWmnjMBXCD8Pcw+KHxJO8cDlSn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Dmitry, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Rokosov/mm-memcg-print-out-cgroup-name-in-the-memcg-tracepoints/20231101-183040 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20231101102837.25205-3-ddrokosov%40salutedevices.com patch subject: [PATCH v1 2/2] mm: memcg: introduce new event to trace shrink_memcg config: um-allyesconfig (https://download.01.org/0day-ci/archive/20231101/202311012319.7ULVSdyR-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231101/202311012319.7ULVSdyR-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311012319.7ULVSdyR-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from mm/vmscan.c:19: In file included from include/linux/kernel_stat.h:9: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from arch/um/include/asm/hardirq.h:5: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/um/include/asm/io.h:24: include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __raw_readb(PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) ^ In file included from mm/vmscan.c:19: In file included from include/linux/kernel_stat.h:9: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from arch/um/include/asm/hardirq.h:5: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/um/include/asm/io.h:24: include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) ^ In file included from mm/vmscan.c:19: In file included from include/linux/kernel_stat.h:9: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from arch/um/include/asm/hardirq.h:5: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/um/include/asm/io.h:24: include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writeb(value, PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:692:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] readsb(PCI_IOBASE + addr, buffer, count); ~~~~~~~~~~ ^ include/asm-generic/io.h:700:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] readsw(PCI_IOBASE + addr, buffer, count); ~~~~~~~~~~ ^ include/asm-generic/io.h:708:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] readsl(PCI_IOBASE + addr, buffer, count); ~~~~~~~~~~ ^ include/asm-generic/io.h:717:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] writesb(PCI_IOBASE + addr, buffer, count); ~~~~~~~~~~ ^ include/asm-generic/io.h:726:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] writesw(PCI_IOBASE + addr, buffer, count); ~~~~~~~~~~ ^ include/asm-generic/io.h:735:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] writesl(PCI_IOBASE + addr, buffer, count); ~~~~~~~~~~ ^ >> mm/vmscan.c:5811:3: error: implicit declaration of function 'trace_mm_vmscan_memcg_shrink_begin' is invalid in C99 [-Werror,-Wimplicit-function-declaration] trace_mm_vmscan_memcg_shrink_begin(memcg, ^ mm/vmscan.c:5811:3: note: did you mean 'trace_mm_vmscan_lru_shrink_active'? include/trace/events/vmscan.h:467:1: note: 'trace_mm_vmscan_lru_shrink_active' declared here TRACE_EVENT(mm_vmscan_lru_shrink_active, ^ include/linux/tracepoint.h:566:2: note: expanded from macro 'TRACE_EVENT' DECLARE_TRACE(name, PARAMS(proto), PARAMS(args)) ^ include/linux/tracepoint.h:432:2: note: expanded from macro 'DECLARE_TRACE' __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \ ^ include/linux/tracepoint.h:355:21: note: expanded from macro '__DECLARE_TRACE' static inline void trace_##name(proto) \ ^ :33:1: note: expanded from here trace_mm_vmscan_lru_shrink_active ^ >> mm/vmscan.c:5845:3: error: implicit declaration of function 'trace_mm_vmscan_memcg_shrink_end' is invalid in C99 [-Werror,-Wimplicit-function-declaration] trace_mm_vmscan_memcg_shrink_end(memcg, ^ mm/vmscan.c:5845:3: note: did you mean 'trace_mm_vmscan_memcg_shrink_begin'? mm/vmscan.c:5811:3: note: 'trace_mm_vmscan_memcg_shrink_begin' declared here trace_mm_vmscan_memcg_shrink_begin(memcg, ^ 12 warnings and 2 errors generated. vim +/trace_mm_vmscan_memcg_shrink_begin +5811 mm/vmscan.c 5791 5792 static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc) 5793 { 5794 struct mem_cgroup *target_memcg = sc->target_mem_cgroup; 5795 struct mem_cgroup *memcg; 5796 5797 memcg = mem_cgroup_iter(target_memcg, NULL, NULL); 5798 do { 5799 struct lruvec *lruvec = mem_cgroup_lruvec(memcg, pgdat); 5800 unsigned long reclaimed; 5801 unsigned long scanned; 5802 5803 /* 5804 * This loop can become CPU-bound when target memcgs 5805 * aren't eligible for reclaim - either because they 5806 * don't have any reclaimable pages, or because their 5807 * memory is explicitly protected. Avoid soft lockups. 5808 */ 5809 cond_resched(); 5810 > 5811 trace_mm_vmscan_memcg_shrink_begin(memcg, 5812 sc->order, 5813 sc->gfp_mask); 5814 5815 mem_cgroup_calculate_protection(target_memcg, memcg); 5816 5817 if (mem_cgroup_below_min(target_memcg, memcg)) { 5818 /* 5819 * Hard protection. 5820 * If there is no reclaimable memory, OOM. 5821 */ 5822 continue; 5823 } else if (mem_cgroup_below_low(target_memcg, memcg)) { 5824 /* 5825 * Soft protection. 5826 * Respect the protection only as long as 5827 * there is an unprotected supply 5828 * of reclaimable memory from other cgroups. 5829 */ 5830 if (!sc->memcg_low_reclaim) { 5831 sc->memcg_low_skipped = 1; 5832 continue; 5833 } 5834 memcg_memory_event(memcg, MEMCG_LOW); 5835 } 5836 5837 reclaimed = sc->nr_reclaimed; 5838 scanned = sc->nr_scanned; 5839 5840 shrink_lruvec(lruvec, sc); 5841 5842 shrink_slab(sc->gfp_mask, pgdat->node_id, memcg, 5843 sc->priority); 5844 > 5845 trace_mm_vmscan_memcg_shrink_end(memcg, 5846 sc->nr_reclaimed - reclaimed); 5847 5848 /* Record the group's reclaim efficiency */ 5849 if (!sc->proactive) 5850 vmpressure(sc->gfp_mask, memcg, false, 5851 sc->nr_scanned - scanned, 5852 sc->nr_reclaimed - reclaimed); 5853 5854 } while ((memcg = mem_cgroup_iter(target_memcg, memcg, NULL))); 5855 } 5856 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki