From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B846BC0018A for ; Tue, 31 Oct 2023 11:16:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4ABCD6B02DD; Tue, 31 Oct 2023 07:16:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45B5A6B02DE; Tue, 31 Oct 2023 07:16:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34ADC6B02E0; Tue, 31 Oct 2023 07:16:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 229376B02DD for ; Tue, 31 Oct 2023 07:16:16 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 001ED160B18 for ; Tue, 31 Oct 2023 11:16:15 +0000 (UTC) X-FDA: 81405502752.22.E38C1CC Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf15.hostedemail.com (Postfix) with ESMTP id BDEB3A0027 for ; Tue, 31 Oct 2023 11:16:13 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=fnKeu2Xt; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698750974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wk3G10Xt+BuVhnIgltoFz1hAGxFu2UKBKoqgrFwmKw8=; b=UW4acZ6fm5aPnfAHZuTMTBW9zdj7ymGIccAx1qPeSaohZbe/hgKAbCj+zIDcKG5IfNu/Zu OfMDTjoc6b378acK0z+fCqLs3LaiX/Zf+teYTGdcdD2EtGDEzVcJLenqrcyVEChHBG4YH5 wzIJGvyBNVQ7w09z/cE1WCqTWtFCnAk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=fnKeu2Xt; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698750974; a=rsa-sha256; cv=none; b=MSIDhHZXp5y6Diz+50Zu1F75tc2AEaB3KzR1TFUw6hVMFeuoidlYWx3kGFsNaijNyVClVC CvqcWGlCx6iARZ1nvXj2ZYspu+gul4L70rlaFqqxYr73QZnQv4T3gyduZMlZwiJ9FcBsGj bAeOHOpcejkD5W120foy6fKVDf7eDus= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 07488CE0A15; Tue, 31 Oct 2023 11:16:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1EFDC433C8; Tue, 31 Oct 2023 11:16:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698750969; bh=w8kgG/MgAOuluXb5mP0VQ+GKsS6sWg759ncFQ+iOEMg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fnKeu2Xt0bImvB+xP6CSqSUtvGO5Z4szF4LOtkSpmeTrxrCKKVHgqS/BgLpANNr38 dTCgIe+n7mmuxVB9vk2H1R1oI90/KQHrrvxT0g0Yk6C1F23UfJG0uLgX/FAZg2EL3P DjnJnl+tpdLJ98NulIH9qGgewMB7sqsCrz3aJDes= Date: Tue, 31 Oct 2023 12:16:06 +0100 From: Greg KH To: SeongJae Park Cc: stable@vger.kernel.org, Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 6.5.y] mm/damon/sysfs: check DAMOS regions update progress from before_terminate() Message-ID: <2023103157-rebuttal-directed-7f83@gregkh> References: <2023102716-prudishly-reggae-1b29@gregkh> <20231028213936.45621-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231028213936.45621-1-sj@kernel.org> X-Rspamd-Queue-Id: BDEB3A0027 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: j85f9t61ec4bgnyrzscxk85uzxyddnho X-HE-Tag: 1698750973-993497 X-HE-Meta: U2FsdGVkX1/kGg+lBZc7j3FjDXj46e9mT+WQYEM31oGNA4Q/diZvetfp6vbgXlils9rdSVsx480FWh0vvivbK3VWhZkzEi8rYHsPuru+RK/D5zsyj+OjNrkbFVdzoGxey4JZQZMO2+69LUT+oq7gKGEsWRmsMZbj0aNLdEUqVuLmeDanL7FFGKshVYm0Abw/rsPLhKIORJlTNZWMnrSQnlrZCveKKRsTA8uF5MHjU8LdAdN/yZeKffofOHtTbLJHnKcUV/Wl3NveV6gRRB4vFuDZPo2C+9z16eI3mOmko/iN6BPvzAwS0Sj2eIbXhGrA0lX4eUEr8BjitLzfaU4qhTRQ76pirigR+fDEtFjrGMpj4fZWogS5oPOj/pJTNlqS+peLEJKcoYXKd9T/pzXGko6rtbL8nygo6Cn9GstUTTG3kYI4s6jMAzlrtnBwK8cv6Fh3YU8c4zPj+w7RcIaE0tG4sP0ez1A5vIfUvbCB0a3JHHoYnRfZ20x4dwg3CuB64NfzLVib1NuZ4EJMjNcv2B4YyQocr7tW9xDlWu1xjM6qeGzHv/hT0SBjri+FNIzdT72HwQeMxXqlreDJyewLfYBtOH/7gqt38eksoHwGfBGU9T+3Ztsz6af/6+Zcw2HL8kWMI2GmtAuS8eZsZFxK4IIX2DGHL8nfmk5GHcF9Dkf23+ytdVcho1opHmQiSqKZ/EnytfAC/KhEuNFKgtMYEk9MzeJcVMFWKjNmY8hSX1hkAp+RblsOj7uVfdPmlQbkIo4AWX4Gsay4asmmgAXmve7NM7agKw1Htn7B7ctkL3EQTOUXM1JuXoZIi/CAc7kV/rDpawoflPy6RilXwzqlaAnFMnsEV0jwqe2vbxKh2aLlaRoCQomReA5aBqoGySOyozWabN9GlHLb+hr1b9VCBAx/pDbA+B5XFaQ350hk/b6cKn2cGNthLxJreWVmsKOimyO8geEr+cBasf1onuB LXDKI3G+ kCAVvXqpsVLKLRCkEo9KrI6wZnD7UzpWVuHohhM+i4qBmHUB3TCJG67+ldGxRUuHIAt6RwZZJMxEEND5VVyh9bxcYneLcDor8bBwChgXD/IUqF+TxI3ZQ2C3nj/tqrU9TRlhXZg/ZajeLJT34ucgu9UImF4cNfMJRQX9AnZF73x0mtltUp9ansAgrhXD0tlKc2H0d5tcP/CU0M6NFNDOY983ChCs9SlHqYs+OW9Gv6amYTEHiGMR23tEBvRZDa6hPWepzibU9wGzitNvqzgYqHAbaCTGV3AWwslWAZn+15En6XJD3FJy2rgmY0A+fzhGgq7JXDmT0nN0VccecEoPuf+9xjnWkaSMeVUW0eonY3DPMiL9lybdTmftIvAn1YH0E2pVD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Oct 28, 2023 at 09:39:36PM +0000, SeongJae Park wrote: > DAMON_SYSFS can receive DAMOS tried regions update request while kdamond > is already out of the main loop and before_terminate callback > (damon_sysfs_before_terminate() in this case) is not yet called. And > damon_sysfs_handle_cmd() can further be finished before the callback is > invoked. Then, damon_sysfs_before_terminate() unlocks damon_sysfs_lock, > which is not locked by anyone. This happens because the callback function > assumes damon_sysfs_cmd_request_callback() should be called before it. > Check if the assumption was true before doing the unlock, to avoid this > problem. > > Link: https://lkml.kernel.org/r/20231007200432.3110-1-sj@kernel.org > Fixes: f1d13cacabe1 ("mm/damon/sysfs: implement DAMOS tried regions update command") > Signed-off-by: SeongJae Park > Cc: [6.2.x] > Signed-off-by: Andrew Morton > (cherry picked from commit 76b7069bcc89dec33f03eb08abee165d0306b754) > --- > > I sent this patch yesterday, but seems not archived in lore.kernel.org. > Sending again Cc-ing more mailing lists, to ensure it is sent and others can > find it, to avoid any duplicated works. Now queued up, thanks. greg k-h