From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AC84C4332F for ; Tue, 31 Oct 2023 15:23:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6948D8D0017; Tue, 31 Oct 2023 11:23:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6429E8D0012; Tue, 31 Oct 2023 11:23:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 531DD8D0017; Tue, 31 Oct 2023 11:23:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 41D858D0012 for ; Tue, 31 Oct 2023 11:23:19 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0A90F1CB6BA for ; Tue, 31 Oct 2023 15:23:19 +0000 (UTC) X-FDA: 81406125318.28.92065E8 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf17.hostedemail.com (Postfix) with ESMTP id 3F24940010 for ; Tue, 31 Oct 2023 15:23:16 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LUiHrSqR; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of helgaas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=helgaas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698765796; a=rsa-sha256; cv=none; b=E2LqjYF9o3WJBfod4/eh22kuP8yvjMkI6b8pOBCZLaY695gKnEFVHYsDukUD9ITPNGD1gg bOS9uFlt8flhm//WVPuDg2tFskU3dQhQFq7k34iziMZ5nDZsfLwcEfwQkThRTHFI6n8G+e P5y6V2bJtCXlz7C0QIL90FD3WAOhApQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LUiHrSqR; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of helgaas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=helgaas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698765796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=5MEZcFSkE8qbbGoNYwb4Hx/PvVOF4yok5V+x1rJfzcU=; b=AjWl3ayOWxVTGViAgKtiXuw0ntHriMLG1JzMudIFbbJ8nkVQoOQtKehAyWI/qQWX17ARxt mB0/+Hk+6UUHReH5oSz+7OKmC6MShWfm2pT4FMsWsDllHiAqiDD6cpDNrlMS9Jr9xSu0eU JVemgBEw5xuJQ45Bz+8vOfibtmN2mjs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 7440EB81101; Tue, 31 Oct 2023 15:23:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98CD2C433C7; Tue, 31 Oct 2023 15:23:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698765793; bh=DNS7Led7XteASI8BJ9J6/kZQu8gsY1vHkII4+CuQzAk=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=LUiHrSqRR/a+NNV64ofMXSwqTZ2smdatebIhMLVF1O9nu2jvxbqt/rFrIcwT34Rsj xCZhKJWLikiMqRWmceLSEavy487xDVK+Wn+AuOwtjYbgR6eB2RrBQAOmPDFhp1xZA7 C6p3R+YsDJ+yTPwJowzZzG31NLxRbEGhbaXkj1SQcf75MJVv0jqUE5reGvd222vyLa iLdvvBVU5Dk8aOBiLzmdETwqt4wLOT/Rrfw0vwtrJdJMpknbucc/6BMp7Nk4In+CUT n38DrtDASTYzvjC7aiEJE68UJ16nhk+iDyXUxw9c101SRix7qy07k/v6MwrDhZsfzs J1bRdpH/qVAHA== Date: Tue, 31 Oct 2023 10:23:11 -0500 From: Bjorn Helgaas To: kernel test robot Cc: D Scott Phillips , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [linux-next:master 14769/15220] drivers/pci/hotplug/acpiphp_ampere_altra.c:63:75: warning: suggest parentheses around arithmetic in operand of '|' Message-ID: <20231031152311.GA10429@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202310270037.19V5rqDL-lkp@intel.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3F24940010 X-Stat-Signature: nxetdeq46d89q7togaoubt4e1shm6rc4 X-HE-Tag: 1698765796-696652 X-HE-Meta: U2FsdGVkX183Tzlb9kalmgSxK0EwUqkLMWEH8h+yFH6WpWE2lUbtewACllhSgac6eXa8WkC7KOvacQ8siVYfOUqBNY5DXPC9c6Y2hW/F0dWRXx1Xxy6+d8+jv7Wr9LazmZt+0q01f4vfZ+0OkO+tkgNRtO2tr6/BLGBc8XJmDJiGMxCC7XAuglEmNsijeoWbh0iWmAKUxFqTLHwN5HRe+NcaQt/JUYlqyvCSoGFmguqUfdsaF1f5+hzzrDuHTxXtnCeATXZYyTkM3kqOKqJYUOnvBKB5RuqG70w81DHC9WiUM3MCx2dZcNPK4Dnp3PCIK9j8vs/DbAkQuRSG6ebFacCWJ8JRguPQOcpg/PNqk6oCtbgPBfd41V4mCq2Kgtt0ueLJy3+5fM9NVDIx3i5y4xqLahG0jTPyrBr20I4ICf+c/zhNnVQgzMBQJk6jnSnm2et8QoUHeK78E+um5g8lVEJnn6eGwHFPkajgTWHtBbQjOKVU3r9tdTamfePIn/2HM6FY34M0LIxY+Y1JFq6R826faBquCiApsJBoX+jNaGoe4eOTwMChOzuWcBAcymkh92DjtbjGIB64YFyrpPkkmAbDvOLXuZataZN0/9U+cWNoA019lqzcZwbothuvoPW09KgWHhMr1GRtt3YzUuwyuXqaqlzJ1oGBVGc7wdq5Rknl/4AApiTX7ZRHNqlXp94X+LQPa0pxn4wur06ViVTXkyDnllvnbUwFhk1IHwG+muFSdiTrg3iRDu7z69I37xzvXcOKIVMcD2xp5qrEeLbNlhHvZmACDUjjxV5PwFzcHZSOu2hzher5A1JrJzS6HBweN69XA2ltXDV0XDBs1MFi6hljotNvOutXK/rVd3WhIG8MJoV+SWfpRo6mMrlbe2PiD0zaBdgVD6XDHwXUe3ceOzW1lH+qYen+BtJ3ldcVuPPApkznAYNlC5gGaJbpRr+m4sQ1aIuXMLBybyeDJ+p 3f3qj7N5 3ViZ/moL67eV3xhZ9OU1LGJdZKcqrLTJRtR8pgJtjyoMaM8fj8j7jOMN6aQC2zw8sgjd2GWCzScqRtUhbPd+EmNO1k0k2nWliF/XgO90l2Z99TvqubV+yfGBWHVRsyEQ0zsAY2ZK6GRk1COMj34NdsK2UVinlpo5nyUI4br/iMERiOv3f6V985rSH1evQ5NAmjQZeXUy3i6p/y4Lq8332qe9W44Sx1W7GbWgAme/DdNGAnsXdb1aqBadAO0f9xqynPkCJW6z62hlld76hXJTy5v7x/BYUvUTJjzGQ2CG+urOOY9df8L7ds/SubuIUYL/36jysz2aE9HPws1+U32b/Oi/mXByYa2cTVnvoTn6X5/EwGlIKtZfP29iAPbbVhYZK+B+bgYSHTGUnYCU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 27, 2023 at 12:51:23AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 2ef7141596eed0b4b45ef18b3626f428a6b0a822 > commit: 13ba8a09c4f6fd87b4919ed2dc5e0dbf27c3de7e [14769/15220] PCI: hotplug: Add Ampere Altra Attention Indicator extension driver > config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20231027/202310270037.19V5rqDL-lkp@intel.com/config) > compiler: aarch64-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231027/202310270037.19V5rqDL-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202310270037.19V5rqDL-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > In file included from include/linux/psci.h:10, > from arch/arm64/include/asm/acpi.h:14, > from include/acpi/acpi_io.h:7, > from include/linux/acpi.h:37, > from include/linux/pci_hotplug.h:92, > from drivers/pci/hotplug/acpiphp_ampere_altra.c:14: > drivers/pci/hotplug/acpiphp_ampere_altra.c: In function 'set_attention_status': > >> drivers/pci/hotplug/acpiphp_ampere_altra.c:63:75: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] > 63 | PCI_SLOT(root_port->devfn) << 4 | pci_domain_nr(bus) & 0xf, > | ~~~~~~~~~~~~~~~~~~~^~~~~ > include/linux/arm-smccc.h:380:44: note: in definition of macro 'arm_smccc_smc' > 380 | #define arm_smccc_smc(...) __arm_smccc_smc(__VA_ARGS__, NULL) > | ^~~~~~~~~~~ Just for the record, this should be resolved by https://git.kernel.org/cgit/linux/kernel/git/pci/pci.git/commit/?id=820f59ed9680, which is in the current PCI -next branch. > vim +63 drivers/pci/hotplug/acpiphp_ampere_altra.c > > 38 > 39 static int set_attention_status(struct hotplug_slot *slot, u8 status) > 40 { > 41 struct arm_smccc_res res; > 42 struct pci_bus *bus; > 43 struct pci_dev *root_port; > 44 unsigned long flags; > 45 u32 handle; > 46 int ret = 0; > 47 > 48 bus = slot->pci_slot->bus; > 49 root_port = pcie_find_root_port(bus->self); > 50 if (!root_port) > 51 return -ENODEV; > 52 > 53 local_irq_save(flags); > 54 arm_smccc_smc(HANDLE_OPEN, led_service_id[0], led_service_id[1], > 55 led_service_id[2], led_service_id[3], 0, 0, 0, &res); > 56 if (res.a0) { > 57 ret = -ENODEV; > 58 goto out; > 59 } > 60 handle = res.a1 & 0xffff0000; > 61 > 62 arm_smccc_smc(REQUEST, LED_CMD, led_status(status), LED_ATTENTION, > > 63 PCI_SLOT(root_port->devfn) << 4 | pci_domain_nr(bus) & 0xf, > 64 0, 0, handle, &res); > 65 if (res.a0) > 66 ret = -ENODEV; > 67 > 68 arm_smccc_smc(HANDLE_CLOSE, handle, 0, 0, 0, 0, 0, 0, &res); > 69 > 70 out: > 71 local_irq_restore(flags); > 72 return ret; > 73 } > 74 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki