From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56FCAC4167B for ; Tue, 31 Oct 2023 00:38:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C99056B00C0; Mon, 30 Oct 2023 20:38:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFB436B00C2; Mon, 30 Oct 2023 20:38:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A75886B00C8; Mon, 30 Oct 2023 20:38:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8ED856B00C0 for ; Mon, 30 Oct 2023 20:38:23 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 69FC8B5988 for ; Tue, 31 Oct 2023 00:38:23 +0000 (UTC) X-FDA: 81403895286.30.78D81CA Received: from mail-yb1-f195.google.com (mail-yb1-f195.google.com [209.85.219.195]) by imf09.hostedemail.com (Postfix) with ESMTP id 994D614000F for ; Tue, 31 Oct 2023 00:38:21 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Iu3jvkrZ; spf=pass (imf09.hostedemail.com: domain of gourry.memverge@gmail.com designates 209.85.219.195 as permitted sender) smtp.mailfrom=gourry.memverge@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698712701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OD4RKFVfAbTN2kU9bJZ9F+y9XLZ/Az1TURsN25S7xmg=; b=FPdew/xnnjg+c6ZDqiIKo63g7b1X86zGRD/rMmtj2/q7S7ZELkd/az1ukg5u1MKy/jJiqv NVDNKXh99Wwrm1VJSpKPm2ZthvQdtl9lF+EKhRX04xr0Nl7GASwdkVIfU2/IvDjhKRQJb+ LS1HnFBAgp6kbJrp5esNiTf8O6ok2/g= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Iu3jvkrZ; spf=pass (imf09.hostedemail.com: domain of gourry.memverge@gmail.com designates 209.85.219.195 as permitted sender) smtp.mailfrom=gourry.memverge@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698712701; a=rsa-sha256; cv=none; b=7Nsu32e8Kl12b8cz+8LIClW5vswyI45njEwjBPelCagL5VW6EzHW6vjCWBRtHroS9ubP4b /d48wWEY/iH7b2bKiFwH7ThTtqv1rrjsAuB3i9B2wSx9dBPnUsm0DS+9WoVQEr82qWs1g9 GYHCamQTDdDUbzxctZniKQa289Phr7U= Received: by mail-yb1-f195.google.com with SMTP id 3f1490d57ef6-da077db5145so4147494276.0 for ; Mon, 30 Oct 2023 17:38:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698712700; x=1699317500; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OD4RKFVfAbTN2kU9bJZ9F+y9XLZ/Az1TURsN25S7xmg=; b=Iu3jvkrZUuZDf52AEpJD4f8wC5rGzMy3Vv2N+T7/KsN78vnrXT4jfXgaM63hlaxnoN UKprBhBsGSz3vLbTuiN/WBRYgk5Zp8zL5Nq/S4/tBtDNdnHW4yqmbWAJEYoCvy4CKDE5 sFpnFAs03od2H9qW/9OzIWYS3QA09cKXtURfjfiTFD/aHfZnxB7ViAeGivoeHwmJOD9U lQywN95XcujkPr1wWtEU5RJNOMsn0OhXXcpBMpiGobrkIySV2hPjG8FRc5Qd3FGzfZAH /sr4RotATxuSoI5LcbHfCXc7vk0jK7lgXb5T6lCHJZjdtOkVkGed9eoz1RReMFk0lgZP tF7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698712701; x=1699317501; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OD4RKFVfAbTN2kU9bJZ9F+y9XLZ/Az1TURsN25S7xmg=; b=wuNPmr5qOG+spEcGOtgIsFd8jd4uspqlq4F5vtmxYPsvqJs0Ho17wGkHWV9cy1Cr1M zaTsu+PfXgYiNHXGIVrc6f+UXqx9pBQJfnWrQJJTutrx0eBekIxjc3C/+QyoLmct/QoL 20xrq7Wnbnx5ETe8ob437HbHBbuR6IZCyAJhCGFdnAJA+qnsXF4tpUd1lxw8/NcuSaGf bHlDuw6kJ604FkarHtdzz4ObS4eJsJCVDBIcOq0x2tKLPzHPHJ9lUEZblDD2zLy1TJJw DQyq3RKDGcdRQzSXVb3zCJ+GqN1f8OB188o/OHryDvVATmfgppuXozlz4AJBgb+RGM2I l4NQ== X-Gm-Message-State: AOJu0YwlJZiKnveaknUhJmbVdwe0R8bIiiWZLEE6F69y3QVbipsCBJWQ tDaaoNkHh1iDL8V+IDPaFw== X-Google-Smtp-Source: AGHT+IFfmuVE+ioJmsCa3B2MRGYbfibjNOTfLGweeVtA4hU+86oyAaa9aIfB3b+hqlewkbs+8GiZ7g== X-Received: by 2002:a25:83c2:0:b0:da0:3535:41f5 with SMTP id v2-20020a2583c2000000b00da0353541f5mr10377007ybm.52.1698712700698; Mon, 30 Oct 2023 17:38:20 -0700 (PDT) Received: from fedora.mshome.net (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id b19-20020a25ae93000000b00da086d6921fsm182750ybj.50.2023.10.30.17.38.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 17:38:20 -0700 (PDT) From: Gregory Price X-Google-Original-From: Gregory Price To: linux-kernel@vger.kernel.org Cc: linux-cxl@vger.kernel.org, linux-mm@kvack.org, ying.huang@intel.com, akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, weixugc@google.com, apopple@nvidia.com, hannes@cmpxchg.org, tim.c.chen@intel.com, dave.hansen@intel.com, mhocko@kernel.org, shy828301@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, Gregory Price Subject: [RFC PATCH v3 1/4] base/node.c: initialize the accessor list before registering Date: Mon, 30 Oct 2023 20:38:07 -0400 Message-Id: <20231031003810.4532-2-gregory.price@memverge.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231031003810.4532-1-gregory.price@memverge.com> References: <20231031003810.4532-1-gregory.price@memverge.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 994D614000F X-Rspam-User: X-Stat-Signature: 1gij6dg74ha1h1xxoyiukukdo5g3tkoy X-Rspamd-Server: rspam01 X-HE-Tag: 1698712701-133760 X-HE-Meta: U2FsdGVkX1+ePkVu9RcgkMEbNI6PAXAwYJEKGp4xO0jKQ43cNegj9JMt524xE8muSjma8v4bjCdAVsnt3KS43y1exdcpEgZY0mB1yQFuMCGd9FvVdrLlfTFbGZSM+oW8FPEBRStb4advQFt4awpf6LA4uZOniaXLKjlmuWDmERWrfddjajrkcA1WEvNnJT2NZeepW+oQ3qRCftoEE0q161BAt0YS+YEGAX1C5ZVK+Y3+gU5yKfTCT1C0G0XFPgzH7ETTGdcFHFhaZtDLJ3j4FGCBAHGQ2qWnaTGOt06aRWcGoXEKYvHWhUjJLxFLPrjP0ecgNyecDtTGOjpFUGAWBs4tC3irXB/a6J0Eo87/sAqOXWSrMIuw/mFV+DSBTcJc34jnvVRDhj4H/SktNkbzsa+8eQmB12iyjnAeBZFybEpoLnsQ7JI4u0s5WSwtMENrK0oi64SYLAjQ1QID+DCVvTUoNYiHfI1NemZdrFyeYJMB4hdkRbZWzm8WU0Z2CWYgOIwT24lHZ0r1EV45zkDQooV4t8UV6fxhBuleGXTf8ZgNWSiZwz43UN6wu94UtDZeMt7hHVEyR2XSFpiXL5OE7nVkMa0eaLAySF36Sf6pwm482cdmniZasM8nGV9wr0jjUP9EvzRc/vNoz/s7munP32B6G7acvBYQJmb9hbEG4sv15Q2cI1goZKssuf6XbezEeMSrJvyOCBrcX5VS+oLg7cLomroZwaYvrc3GR07kI/ZZv52qURRHnD66BsEfA+SFZiZQrTqtRvyV/C6Jd/32fipVByPBJv7aBETvns1zx6TWyVbyhFkB2O9ryhKAErhmgZnkjXz8hLLRDPwAkoI0o1niZqCuBH+ZGUdbbvMNJtwGnARBqmisxH85mRWPcrofNxBdQhDmzsUWNsBb+kfTm6O9oiYcwP+qWS06FJEUqNmnH1o9oDl/ImmGzGpqXwCQd8EcGnzI2KzEswIOHJ8 tfXiBviH dDsZQk8Ruu33Z83e3+kojJ33YASk+4warZa5bDUtWVQnE4GvuKgiRRoOkPgHt1BbvZVnjMlQTFYfXYvfkQVvPpR8xzNdMM/HUQ9qovV5a9CEvNLAvfjoFIkD/8SqjdFJC7eRgV27zuFtdwcjX702+U3UwvG+02vEgT8mGVnoevKJ9h3pWXWshgAeq3qgoEtdTwnu+n3DJrxiBf6hnKQs2u3aAlU8an3d+jbRRCpxA+4gvBjLhEBtvJvsBKXyNjb20XW/X/LY12sh6SfDAN9p371kKQ3wrIZpi0y/5YIDniW8+fnPsrZA8Geg353QaCgp51+RVgV0JFIgCQywjWvEW2oV/GJdcx0ZTUXjM9hVW8Ci3dx8jYRdjMn429fPUJ60MYEDQoPJoWkFQAFXT47QPg9/pI46ao48kRIkL+CEB+pMPF/vP9sEnxdzRzZzbV6475tt49bZOUUZdO8YOZr4vWumS46UaRYYubJkE62PpbFIB99Y4Dsy6xDdbUgmozFTHkiRkh+FCOZLFUf9xpyLWO/3YjA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The current code registers the node as available in the node array before initializing the accessor list. This makes it so that anything which might access the accessor list as a result of allocations will cause an undefined memory access. In one example, an extension to access hmat data during interleave caused this undefined access as a result of a bulk allocation that occurs during node initialization but before the accessor list is initialized. Initialize the accessor list before making the node generally available to the global system. Signed-off-by: Gregory Price --- drivers/base/node.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index 493d533f8375..4d588f4658c8 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -868,11 +868,15 @@ int __register_one_node(int nid) { int error; int cpu; + struct node *node; - node_devices[nid] = kzalloc(sizeof(struct node), GFP_KERNEL); - if (!node_devices[nid]) + node = kzalloc(sizeof(struct node), GFP_KERNEL); + if (!node) return -ENOMEM; + INIT_LIST_HEAD(&node->access_list); + node_devices[nid] = node; + error = register_node(node_devices[nid], nid); /* link cpu under this node */ @@ -881,7 +885,6 @@ int __register_one_node(int nid) register_cpu_under_node(cpu, nid); } - INIT_LIST_HEAD(&node_devices[nid]->access_list); node_init_caches(nid); return error; -- 2.39.1