From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49852C4167B for ; Tue, 31 Oct 2023 00:17:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A14D8D0002; Mon, 30 Oct 2023 20:17:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BFB18D0008; Mon, 30 Oct 2023 20:17:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 759978D0002; Mon, 30 Oct 2023 20:17:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 663DA8D0002 for ; Mon, 30 Oct 2023 20:17:33 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3C8DF80418 for ; Tue, 31 Oct 2023 00:17:33 +0000 (UTC) X-FDA: 81403842786.03.4FF7706 Received: from mail-yw1-f196.google.com (mail-yw1-f196.google.com [209.85.128.196]) by imf11.hostedemail.com (Postfix) with ESMTP id 648A640014 for ; Tue, 31 Oct 2023 00:17:31 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TSHUkXpo; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of gourry.memverge@gmail.com designates 209.85.128.196 as permitted sender) smtp.mailfrom=gourry.memverge@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698711451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OD4RKFVfAbTN2kU9bJZ9F+y9XLZ/Az1TURsN25S7xmg=; b=49OPKUSBz5pjP970SCNGZQCqXIH0lwBwofubCy/yJudgSV8g5SfpxZBBr++y9Ih6TjEbjT aaLX5WodtwTQZjVgI/bARVQeOQxZ7cvOyLXufeJe1p0Cf6G5xA4XBfXYlN7SOnxlkRTjqX pNaRzHpqZAIDVXLSA8Hd3EFDz5WpBlI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TSHUkXpo; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of gourry.memverge@gmail.com designates 209.85.128.196 as permitted sender) smtp.mailfrom=gourry.memverge@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698711451; a=rsa-sha256; cv=none; b=rPRNWzib4TdtdNBpfzJRZqloEiPkQTajo496gYGSYUhwjwP5DXDGPD+QM2k2R8FZ6Y5URW r9SRGIKHxmjnANPbwkc0pyLv4kNJuyVT4uryuCOhx5OI1NlY3kcWEPr9B2hEirGIgXhGq0 H8fA6MofV8H1vvvcYXLwnw6yjOS8tN8= Received: by mail-yw1-f196.google.com with SMTP id 00721157ae682-5a7afd45199so49146647b3.0 for ; Mon, 30 Oct 2023 17:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698711450; x=1699316250; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OD4RKFVfAbTN2kU9bJZ9F+y9XLZ/Az1TURsN25S7xmg=; b=TSHUkXpoHpotVAMsl+QPTygzYbTHY0w9r5MgS4BJKv9hAEJ3FjUmGXvhWnDjg/YcWV Tv9o09gKTaQFuzMmsVJHuR6Nb/P2IUKiogtXJarxeptcKZnHmU9uipYftiT1EmXosM1d 1AGEbIs/ms6wSP8+8DIc30oneRERFIPNGtg0iUTt8TdggZ4DH18dtSsq3qQTcgVOWXD7 KYeC7eTE13833zMPfodt74kLuMCN2U9ZWUp03p33gSFO35VTOlykmJ66zjeOTczxNhYF EPb8XHwQWv2p+MnGP4aSzv5wdcGkxwlD+GlX6BU4qdUN2wzqXXj2nxQyWmHQHLJG48xR ct0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698711450; x=1699316250; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OD4RKFVfAbTN2kU9bJZ9F+y9XLZ/Az1TURsN25S7xmg=; b=kkQiXSngTa1TWbO6X6GeDSDLPEcGorJ2Outru4fxwuIqmZT+THbsOV+L9m2v1O0BAU qe2kgEqRSNDhZ1q9UgRMFEBd9+yQodpU2ScKMifmXqhboEqwy8ZU98x+zRcQL4xCRV83 N7LtUjafN/UJikuncmCvyt1h1dKvQJ8+SDZq2ZBwn89uVAbUdGstBkpQxrs1N4CVU4Rm 08TTlDj7JkIqShQFifGNgDKbn5jMRzNzOrmz0wciHuwHU2VTaAerwdypgaSH5jvzieDS Y1GKfti5ES7LmRJl/2mmUlo5IfBeG7NyavRPgISE33AlhoQzlZ7uWFGo5NlSGXsCHwtZ GGOw== X-Gm-Message-State: AOJu0Yy3xYC9yusEPnH3Pukvg3/17ejdNOEW+VzQ6vaftFJbFjyC1YSV 8YFwN/o7XKWKDjIlILVqeQ== X-Google-Smtp-Source: AGHT+IGzePeyJoClGwnIsWFkX4hXlTIZr0JUl/wQg+3Lp0v/LfNvyO3K6nm7n7V51FdM3fuJwQISgg== X-Received: by 2002:a05:690c:f13:b0:5a7:d133:370d with SMTP id dc19-20020a05690c0f1300b005a7d133370dmr14467747ywb.16.1698711450524; Mon, 30 Oct 2023 17:17:30 -0700 (PDT) Received: from fedora.mshome.net (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id fc10-20020a05690c314a00b005a7bf9749c8sm113824ywb.4.2023.10.30.17.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 17:17:30 -0700 (PDT) From: Gregory Price X-Google-Original-From: Gregory Price To: linux-kernel@vger.kernel.org Cc: linux-cxl@vger.kernel.org, linux-mm@kvack.org, ying.huang@intel.com, akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, weixugc@google.com, apopple@nvidia.com, hannes@cmpxchg.org, tim.c.chen@intel.com, dave.hansen@intel.com, mhocko@kernel.org, shy828301@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, Gregory Price Subject: [RFC PATCH v3 1/4] base/node.c: initialize the accessor list before registering Date: Mon, 30 Oct 2023 20:17:18 -0400 Message-Id: <20231031001721.3972-2-gregory.price@memverge.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231031001721.3972-1-gregory.price@memverge.com> References: <20231031001721.3972-1-gregory.price@memverge.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 648A640014 X-Stat-Signature: 1gij6dg74ha1h1xxoyiukukdo5g3tkoy X-Rspam-User: X-HE-Tag: 1698711451-68224 X-HE-Meta: U2FsdGVkX1/iiWqUjWXfTevs2IfjQnrWr+3PUuNeY8z3Z7Rpo+zSnSBWR1ALGic+s48YJrZk8aYzl4o0gPHKzuZrrHQcn9EOxi8grs7pJCoHGwyAgw+CcCHgkS/Cf9pYrR7dYN0wUBLY9GGL3Gi0ZILLfHtTLLVx5FV/bnbnYK2ohfuqtccu8pOmxkBrmyAUeV1Iu9Yf3FvKcJuSjqV7IG+G6jTzB72GNLQsC3Gv0ELshVRDgWsgpLaEkXjKiq0PRSbXinQHtfiedFmXYfmbfjyMmcnehAFk2nk5kzwNkdOBWHgDepVdkQVxToXgvp4X+82IJvH39wMo3d9+3otT48YY20QwII8OMr27AR+0NILZQwligCYcmMJzAn8NGtG1vwGXD4B2Qu0ztAltTtuLCvugyEXmavH0528AWvEMcOt14UcXIpryM3FHtFUIEegNoU8vOlNsDR9rkKCuYYdD9SX95tP8rpUZ3uO3JH7c3X483c0yHhLQ+96BhnlsZ6i9/A1VmK3K1yoopnPfnlxIY26to5qwBxt7PkcI/aopyCnENAPy1BYNTdxSpybZxFZBIrKqfLJFMytMaTrhevxTNKDhTD3gFC+ShsL9lXxAKb3bzwCP/69o5KsdhzuJzygFM2bDNIStWkuLNyrRUZ1ffqDb9kKY2IZwzlPg9YwQ65pbgNN7xeSBX/M2Be7LduBDMIcv7CPeBthoC2nHfpQMsUTC6Q+WA+lOMwWbDR1XHqrsqJ0PwyY6kndAKWjhEjycuPfS5LqyngZLbp6PGluPANnAONnN60+cS75BbLrGSD8FxUT+fS4R9WpZ1J/KIrRUjLDz8iERJDvQ5+SJVy1yhgtZ7ML+ijSMNZVuyzLdMsTY9f8Mj7aGNIGUC4fyDIq9gPMUI6mfmiHcHr2kE8d+TZBJXGLS0afpIK51q/un3foLjAxU7njzN4AcPxFy8dPJg/bxkMdhqrwAJ+9ROoi sFb7X5n0 ZXUXsUYyuSEAd8xIE+90rUH+u0o7q9uSQ9eHNxEdxUD3kHmINi7l5XVmHDrtiMXOlFnVUP2I7SyPyWsxA8m+CGASAAiKf+3dlPFk44uirO747jceoJDuSQCO+RZKx7DrvPRDeUI1b7LzJBRCr0csxmH4bD3+DBVKTjumZJlWapTl+M2ZlQbcEiErWKAzogY0D02zgx1d6ySr6i3yV13JkFvbuH6Ivm3acGJYQ5J0G+gsYGZfU3XLKwACnUVN04hLht1HBuuJLxT9oLGJD3qGREoH1hCVz5CBMWCYeF2R41YdZyZlpvymIGfHPu6i99bpsXTuZRMYqcV6W69660jh3r5Mgbu6t8O4kHPCkUIrS+vNkQGzdvQNwJg1JaKDchgzDwSOgK4+/FZX9QzHdu9hV1qv9ztKuznEl+oWQUNfDFX0RQMBjsqw8iQvCXcgQbkptzXiefaqzLOMXsUz6D4gTwEpwV4NcSQBUf2d4Bs5kHkOhPPBywv1cDTzj9sPowtnCq6nk/TF3yAyrWmATzIEMWe5CTA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The current code registers the node as available in the node array before initializing the accessor list. This makes it so that anything which might access the accessor list as a result of allocations will cause an undefined memory access. In one example, an extension to access hmat data during interleave caused this undefined access as a result of a bulk allocation that occurs during node initialization but before the accessor list is initialized. Initialize the accessor list before making the node generally available to the global system. Signed-off-by: Gregory Price --- drivers/base/node.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index 493d533f8375..4d588f4658c8 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -868,11 +868,15 @@ int __register_one_node(int nid) { int error; int cpu; + struct node *node; - node_devices[nid] = kzalloc(sizeof(struct node), GFP_KERNEL); - if (!node_devices[nid]) + node = kzalloc(sizeof(struct node), GFP_KERNEL); + if (!node) return -ENOMEM; + INIT_LIST_HEAD(&node->access_list); + node_devices[nid] = node; + error = register_node(node_devices[nid], nid); /* link cpu under this node */ @@ -881,7 +885,6 @@ int __register_one_node(int nid) register_cpu_under_node(cpu, nid); } - INIT_LIST_HEAD(&node_devices[nid]->access_list); node_init_caches(nid); return error; -- 2.39.1