From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0D8CC4332F for ; Mon, 30 Oct 2023 18:20:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 358A66B027B; Mon, 30 Oct 2023 14:20:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E1786B027C; Mon, 30 Oct 2023 14:20:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 181FF6B027D; Mon, 30 Oct 2023 14:20:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 069906B027B for ; Mon, 30 Oct 2023 14:20:04 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B41C91A0A09 for ; Mon, 30 Oct 2023 18:20:03 +0000 (UTC) X-FDA: 81402941886.22.C78F450 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id F383F10000A for ; Mon, 30 Oct 2023 18:20:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=hW9q=GM=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=hW9q=GM=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698690002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rGUIcrhBWADm2ArI0FvZZaqSpeoGZS0JzJU/39x5mNU=; b=TBT0DUdRvlcWiXbunY6LPOfftbCYRiE7D4CF1vq5oTUYhXEhChMtEJ99n7r2qlWQahPifb zR6LDzx1S5wiR0aeIkzi3lp4YiGp3SR5h2+3afBg4Bx/YsKG2QTiy8MwVtMDpyJkoh+aP8 BGGtBNteLlc73DAI5+TPuBbEVt+BS70= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698690002; a=rsa-sha256; cv=none; b=fp4+fk+P/bWiF0vC7JFpcU7Jma+7NSVvNN9Dk4WeZ77uItBgBxPPd30dZfc/sQErvaNGce 69VqG9bva6QHIQAJ0RtEjkefqTGLhZ38hWeMnzRl1pWNATN3ZD2Tuav/a0XnYCidDUePyJ Z0DfvaWaPSvAw99phLieePe1T5y288g= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=hW9q=GM=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=hW9q=GM=goodmis.org=rostedt@kernel.org"; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 076DC60B2B; Mon, 30 Oct 2023 18:20:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3E65C433C8; Mon, 30 Oct 2023 18:19:57 +0000 (UTC) Date: Mon, 30 Oct 2023 14:19:56 -0400 From: Steven Rostedt To: Mathieu Desnoyers Cc: Linus Torvalds , Peter Zijlstra , LKML , Thomas Gleixner , Ankur Arora , linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, Joel Fernandes , Youssef Esmat , Vineeth Pillai , Suleiman Souhlal , Ingo Molnar , Daniel Bristot de Oliveira Subject: Re: [POC][RFC][PATCH v2] sched: Extended Scheduler Time Slice Message-ID: <20231030141956.05661b90@gandalf.local.home> In-Reply-To: References: <20231025235413.597287e1@gandalf.local.home> <20231026105944.GJ33965@noisy.programming.kicks-ass.net> <20231026071413.4ed47b0e@gandalf.local.home> <7871472b-a0c4-4475-9671-69a3244f956d@efficios.com> <20231026164549.14d45c60@gandalf.local.home> <644da047-2f7a-4d55-a339-f2dc28d2c852@efficios.com> <20231027122442.5c76dd62@gandalf.local.home> <20231027124930.3753cdd4@gandalf.local.home> <20231030094508.031357b4@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F383F10000A X-Rspam-User: X-Stat-Signature: 9p451kasqyi75nqq45njpg5swrj5anmx X-Rspamd-Server: rspam03 X-HE-Tag: 1698690001-421832 X-HE-Meta: U2FsdGVkX18RaO22X4Flp02YlpYGf/f4SM1NaO8lqEeOkwuzy3QFBIuXPIEEPjEAvkKBFkFgnCSgcB8KlU/cfKI9VjjsAmFvhx9M7Trn4RY2+aQGBJdjsb13QKC8rE0dq/iI8KqwCGAzws0sYssmK6eIhb0iL854Qk1O/MEGXImGc9jSmNs3qqDexvy1f+NxIV/9LwekO6f4/x7eHsT2D6ihDrKptd3+6TrSNXHBfBjkDOpuwjUvivp57iEzxcyNMvMKAaMATCtizB8V830EWy18SDIky9jpmtDVR4MlZShxrPqFBYKBsUCO7xrBL22QjtC4ym4scsi1hRIyyBsOG8QtFBLiI25/YOr6CnvoBmnMtgPgeEMN6uLcZrSgd/jq+W6RTjJTLQhGumJpc1S50Mqw3BsQCQxOqwMhJVEEng64oykwkOrOihlpuF7tTnsjhbU9j4APF+8tJbdFjY2t4jlnwdHLfwjpbEg9EWFPMgPuoiEI3y0zClpHhr2OklOytW3IEX4kWeqPxUCC7dBOt00cuePEeaLAYg6mBMW76zq4SwbvgPpNv9y4cdv4bqhv2s4MgGebya3z4ILzN8W1uvCQ3JX8LzmULrqgVimdVoARs/+MBOZ0QQmtDGoETCl5QPG03eH7vIFb3QGOzhdEmcyVty4FCXh1jEON/jgUm7HzAt2Tz//FGQNBaDL9X406meHvej7vP9g1sQZ8tcKBgz5EwHFawwPFZvchH25u1iWjER6a9PIOT9vh9LYASYSweaZOU1v87E2x6NC/6ihchRSTHEIU6gtNuxhZxBNwjOlIJSpt06i9uqc7eZC6Dp/g5TIYnCw/bxhDz7DZ/Dd6yzd87XdeDNsu2xgMOQstn8aMBJcVKdGae+1pvHjCdlpK7Bmkcjr0HYGeQifWgMcoab9pWosMKOk88+KFhSrgzw64Ii97C9vrYs1KvcEbY5umiYPG7tq+GqeHdA+fTVr bFZSs4wH bRyCf4l4aIa5EZHXh9tkVt9EKDDkTDrqvVOor4xeekj6hh5sXv7NjvBvFyVGMy9pTX1AkolyzZs5aMXl4sVxrBk4E2ZtVLM0YLhyecJoDtenGZ9kQf1JxC0qZxWYzM6Q8zsU7tXg5qNcOYreErSEu87lc0tiqtaX9XYg2wR9H1wwWs9NATGDOQFXquJrwVPGk6WKMB+yvRjcGWtbsYbugX6EM5vTnXgz8wc/HGByTwDTc1woPpJ/tTe5UomlEnhHlQomUy/MOjww+Cc4A1K//Lpo3NoBiYhzK9ol1vI/U1esyB8ORV+1BXykoPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 30 Oct 2023 14:05:05 -0400 Mathieu Desnoyers wrote: > If you have the nesting counter, why do you need the explicit on/off > switch ? Because I gave up when I found that one of the lwlocks seemed to take a long time (pretty much the entire test) or I couldn't find how it was unlocked (the code isn't trivial). So I just made every unlock disable the extended time slot. I need to go back and enable both a counter and an on/off as I now realize that the spin locks (called within the lwlock) will disable the extend time before the lwlock is released. This should work if I have the spinlocks inc and dec (they are straight forward and all locks are associated with an easily found unlock), and have the lwlock use bit 31 as an on/off switch. Anyway, I would let user space decide what it wants to do, and giving it 31 bits to say "I'm extended" and let user space come up with how it handles those 31 bits. -- Steve