From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10EC6C4332F for ; Mon, 30 Oct 2023 05:15:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B56E6B017F; Mon, 30 Oct 2023 01:15:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 664926B0181; Mon, 30 Oct 2023 01:15:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 554556B0182; Mon, 30 Oct 2023 01:15:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 440756B017F for ; Mon, 30 Oct 2023 01:15:47 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0AC11140394 for ; Mon, 30 Oct 2023 05:15:47 +0000 (UTC) X-FDA: 81400965534.21.C665FC4 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by imf03.hostedemail.com (Postfix) with ESMTP id 9F4DE20005 for ; Mon, 30 Oct 2023 05:15:42 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MilGyA4X; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf03.hostedemail.com: domain of lkp@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698642943; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Vdw2JIF2XdaMPEEKpj1LG30DuV9wxXFqO3t7m6n59vE=; b=ZSPO/dII/eL1KsPNOPD5Z7MsN9ALEfqXXgfElhnL4D6m6ldh43PrxTu4PGGjhrt1g5dSLK LmO5ITHcvVXZpFQvdqJRfbzSUfIn71Qg300cFn+YzQji3NrR7kVdtfxC7Epz5e86CCSWJb x+vwwjbejuwUOnMhzioKaaj+YV4CcjU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MilGyA4X; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf03.hostedemail.com: domain of lkp@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698642943; a=rsa-sha256; cv=none; b=aMgatQRbK2d45ErdBJUx1QlGHS6HPcxDdUoxwbmiIsYQg5lcKfpcWSmUzBODggV8069hMt duYKdxs0pJiK/V8hdUjxplMZILWn5ylJHc0zUzwfnYGhOJCDfP/4zD+KDbMr9P2YW8ejOq C8Xkci6Bd4n9IkJM2GHDb8MkCGZrVAY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698642943; x=1730178943; h=date:from:to:cc:subject:message-id:mime-version; bh=Mo2C41xCPgfbH3NPdYKapCpoK7Xcq+wMQtztJ4Z2I6Y=; b=MilGyA4XqYTNl9nG3JQj73ZanqJq1/MLqN3bnaYzs9mJ/YaQtdUwLg85 cYWUjSpHrMLm87Sl8SCKTi2zUBewsspuPOjgAUQVn9qWfPRSjqLan9J9L 95WAsNhUJBkHQjbuKNSscR1ytzaSiiKQTPYvA4xxub9YifyVzoZqd49rC zSYKlFi89DKKCer5fQeeSp7EMJUD83/tbTm/Fas3Ln88+trluSKA8cMtn tcUPQhyd007Gg5BHKnZByYOo9mlm/cbuLdlTNoYwVO/0G4omdWYMHXwbH n050cqkNKxNuNVpv0hH7uoeUbv5TYQ/KRs00UD1v2MmNg3p3wxs/BL4Wa Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10878"; a="9547691" X-IronPort-AV: E=Sophos;i="6.03,262,1694761200"; d="scan'208";a="9547691" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2023 22:15:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,262,1694761200"; d="scan'208";a="1407430" Received: from lkp-server01.sh.intel.com (HELO 8917679a5d3e) ([10.239.97.150]) by fmviesa002.fm.intel.com with ESMTP; 29 Oct 2023 22:15:39 -0700 Received: from kbuild by 8917679a5d3e with local (Exim 4.96) (envelope-from ) id 1qxKci-000D3P-1U; Mon, 30 Oct 2023 05:15:36 +0000 Date: Mon, 30 Oct 2023 13:14:58 +0800 From: kernel test robot To: AngeloGioacchino Del Regno Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Chun-Kuang Hu , =?iso-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E?= Prado , CK Hu Subject: [linux-next:master 9156/15478] drivers/gpu/drm/mediatek/mtk_disp_gamma.c:78:6: warning: variable 'cfg_val' set but not used Message-ID: <202310301338.pB7KCZxs-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: 9F4DE20005 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: og1sghbkz9wfqge1uhasgeitbjp3cdoa X-HE-Tag: 1698642942-155945 X-HE-Meta: U2FsdGVkX1/Kc+xYnHKOUS/4vf65muOj4qf9S1lduL2hxgWpHu8xiaQybP09WANgBkeixwCu450/+a+h7ySefjI5cJOPaSqoRmNgNCLDLdZ3Nl4vw2JP8ozjF/QkE2Jt9HQcYFnV46iRqHhigwJasjynUvvS4eLl1u7qwzU3oZsXximco/ThiqAKVYSsWroVOQBde67aFQyn1uTyo+3syuKtUKPub/t02aiHBMq+haecYvxXniyqveZgrBfqhyeVTA7kWyCwMO2OkccDsaYDhhBcBQbEJZFTC5y22YC0vpeqS5l4rRvCeCqJDFe6R+LT+WAqBUOZesw27xKiNz68utLxhB58bZ3uU3/hGw411e5cBuOZH28e9YElwSUVTKG609j9uPpaZ9ipO7b0kZRPcYxfx895bbcclQyUT1Ljg7OMpMT17bBGLbugrZRAs7o7m0A91Or+TpeVLvDpPVajdlpF7rJ3eHahHkAzpwpGJ2nwaJhxF/8dRZzPWTAlZLd1+OcYDr+wMPGAr1+0mowSW0WCLOB+aCrtUOOqApAUp6JGgLUBW5akjkNl5DNpoCs9Sn8aTqPR85kiG7jKtON5KDgZUWnJrFfYqFGWsQ/J3jSZ/x8CicYw7zpHNttjCtoxMJWuddXLEowI5uUAZlro3/W4aNayHg9+rwnyp71umbyitHGzW2O5Uzc3Eif9phAWqJILAMoKHZl+7IlRHwGSrexWF/Pfysi585YEpYFhMA3vArLrphjFrZWf03QJtIZ4IO9cXkIE2ZXgNtXMxB0qnNqVEKx50uno+rLyb5UzSUahclr9A3wvZzt5Vi1cSqtEDMV34QcOWUAOlpelFfOFsu8f3VeFyOF5E5T2+2AIZYNfvOxnnbGKOynpArGvknAZGIHVZAlkyp4jP45+uIdg5aVwLw1kQUwFedoYZObLFe97lbJDhJa7Z0Lhh1vda79+P/Nhg9ldzX/QTfD9xDt ph293+OH bUWxPKHsFobLrjquAK6Q6UZvN2qFZFCbcRHh6Hx01B2H5w2eBSTxYvHfYDlvq6N+iuOeDWQRTI+TgUGUOWAyUg0cxYvLsCObiBwWUsvdwcFsM1xDWUL0A9VQiWXmwWYvrslyZAWiKYLd7VI3TiY+Gdk68FkKB0dX2nl45+9Q9kABhQ4nue6iqpngOQ0vABYAD0a4jldlY4uwAeqn0fMNExJvZ+S/oF8dfTDV92GwpUFI1lxvrxd2kv/A6naJIH7FtxLEWvZoR2aDNPGudS8/9t1L6emBGXattKGV4H3+YMJcfHp4iuTuO+JieBpobBHIgKvNupZoDrjHndoZUMvh8v/gyck30+eqj/YOQsOsMbf9grnEKvuclqnJC/L47bedEs0wjVY2PmkeezC6iTWTQC2XZSP26BxgM2rBGJOa9RnlBaS4JpECBqlnvuiu8Nq5BiBrJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi AngeloGioacchino, FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 66f1e1ea3548378ff6387b1ce0b40955d54e86aa commit: a6b39cd248f3321dbf066f95f95a9841f891229e [9156/15478] drm/mediatek: De-commonize disp_aal/disp_gamma gamma_set functions config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20231030/202310301338.pB7KCZxs-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231030/202310301338.pB7KCZxs-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310301338.pB7KCZxs-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/gpu/drm/mediatek/mtk_disp_gamma.c:78:6: warning: variable 'cfg_val' set but not used [-Wunused-but-set-variable] 78 | u32 cfg_val, word; | ^ 1 warning generated. vim +/cfg_val +78 drivers/gpu/drm/mediatek/mtk_disp_gamma.c d243907bb42f66 AngeloGioacchino Del Regno 2023-10-12 71 a6b39cd248f332 AngeloGioacchino Del Regno 2023-10-12 72 void mtk_gamma_set(struct device *dev, struct drm_crtc_state *state) 69a4237ab1d13a Yongqiang Niu 2021-01-29 73 { a6b39cd248f332 AngeloGioacchino Del Regno 2023-10-12 74 struct mtk_disp_gamma *gamma = dev_get_drvdata(dev); 0d4caaaf61ce05 AngeloGioacchino Del Regno 2023-10-12 75 unsigned int i; 69a4237ab1d13a Yongqiang Niu 2021-01-29 76 struct drm_color_lut *lut; 69a4237ab1d13a Yongqiang Niu 2021-01-29 77 void __iomem *lut_base; 0d4caaaf61ce05 AngeloGioacchino Del Regno 2023-10-12 @78 u32 cfg_val, word; 69a4237ab1d13a Yongqiang Niu 2021-01-29 79 aa5fb24f971dd4 AngeloGioacchino Del Regno 2023-10-12 80 /* If there's no gamma lut there's nothing to do here. */ aa5fb24f971dd4 AngeloGioacchino Del Regno 2023-10-12 81 if (!state->gamma_lut) aa5fb24f971dd4 AngeloGioacchino Del Regno 2023-10-12 82 return; aa5fb24f971dd4 AngeloGioacchino Del Regno 2023-10-12 83 a6b39cd248f332 AngeloGioacchino Del Regno 2023-10-12 84 lut_base = gamma->regs + DISP_GAMMA_LUT; 69a4237ab1d13a Yongqiang Niu 2021-01-29 85 lut = (struct drm_color_lut *)state->gamma_lut->data; a6b39cd248f332 AngeloGioacchino Del Regno 2023-10-12 86 for (i = 0; i < gamma->data->lut_size; i++) { c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 87 struct drm_color_lut diff, hwlut; c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 88 c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 89 hwlut.red = drm_color_lut_extract(lut[i].red, 10); c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 90 hwlut.green = drm_color_lut_extract(lut[i].green, 10); c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 91 hwlut.blue = drm_color_lut_extract(lut[i].blue, 10); c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 92 a6b39cd248f332 AngeloGioacchino Del Regno 2023-10-12 93 if (!gamma->data->lut_diff || (i % 2 == 0)) { 6e46998c13f123 AngeloGioacchino Del Regno 2023-10-12 94 word = FIELD_PREP(DISP_GAMMA_LUT_10BIT_R, hwlut.red); 6e46998c13f123 AngeloGioacchino Del Regno 2023-10-12 95 word |= FIELD_PREP(DISP_GAMMA_LUT_10BIT_G, hwlut.green); 6e46998c13f123 AngeloGioacchino Del Regno 2023-10-12 96 word |= FIELD_PREP(DISP_GAMMA_LUT_10BIT_B, hwlut.blue); ba99d08da6adec Yongqiang Niu 2022-04-28 97 } else { c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 98 diff.red = lut[i].red - lut[i - 1].red; c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 99 diff.red = drm_color_lut_extract(diff.red, 10); c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 100 c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 101 diff.green = lut[i].green - lut[i - 1].green; c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 102 diff.green = drm_color_lut_extract(diff.green, 10); c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 103 c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 104 diff.blue = lut[i].blue - lut[i - 1].blue; c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 105 diff.blue = drm_color_lut_extract(diff.blue, 10); ba99d08da6adec Yongqiang Niu 2022-04-28 106 6e46998c13f123 AngeloGioacchino Del Regno 2023-10-12 107 word = FIELD_PREP(DISP_GAMMA_LUT_10BIT_R, diff.red); 6e46998c13f123 AngeloGioacchino Del Regno 2023-10-12 108 word |= FIELD_PREP(DISP_GAMMA_LUT_10BIT_G, diff.green); 6e46998c13f123 AngeloGioacchino Del Regno 2023-10-12 109 word |= FIELD_PREP(DISP_GAMMA_LUT_10BIT_B, diff.blue); ba99d08da6adec Yongqiang Niu 2022-04-28 110 } c18119dee1919c AngeloGioacchino Del Regno 2023-10-12 111 writel(word, lut_base + i * 4); 69a4237ab1d13a Yongqiang Niu 2021-01-29 112 } 0d4caaaf61ce05 AngeloGioacchino Del Regno 2023-10-12 113 a6b39cd248f332 AngeloGioacchino Del Regno 2023-10-12 114 cfg_val = readl(gamma->regs + DISP_GAMMA_CFG); 0d4caaaf61ce05 AngeloGioacchino Del Regno 2023-10-12 115 0d4caaaf61ce05 AngeloGioacchino Del Regno 2023-10-12 116 /* Enable the gamma table */ 6e46998c13f123 AngeloGioacchino Del Regno 2023-10-12 117 cfg_val |= FIELD_PREP(GAMMA_LUT_EN, 1); 0d4caaaf61ce05 AngeloGioacchino Del Regno 2023-10-12 118 a6b39cd248f332 AngeloGioacchino Del Regno 2023-10-12 119 cfg_val = readl(gamma->regs + DISP_GAMMA_CFG); 69a4237ab1d13a Yongqiang Niu 2021-01-29 120 } 69a4237ab1d13a Yongqiang Niu 2021-01-29 121 :::::: The code at line 78 was first introduced by commit :::::: 0d4caaaf61ce0556843e2fa9d41ec65962b51c14 drm/mediatek: gamma: Enable the Gamma LUT table only after programming :::::: TO: AngeloGioacchino Del Regno :::::: CC: Chun-Kuang Hu -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki