From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EE15C4167B for ; Sat, 28 Oct 2023 23:13:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 671A76B02C7; Sat, 28 Oct 2023 19:13:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FBA46B02C9; Sat, 28 Oct 2023 19:13:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EE466B02CA; Sat, 28 Oct 2023 19:13:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1C79B6B02C7 for ; Sat, 28 Oct 2023 19:13:46 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0378FA049A for ; Sat, 28 Oct 2023 23:13:45 +0000 (UTC) X-FDA: 81396424452.12.EB16032 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf26.hostedemail.com (Postfix) with ESMTP id 38B4314000E for ; Sat, 28 Oct 2023 23:13:43 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=sifive.com header.s=google header.b=h9hANiwC; dmarc=pass (policy=reject) header.from=sifive.com; spf=pass (imf26.hostedemail.com: domain of samuel.holland@sifive.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=samuel.holland@sifive.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698534824; a=rsa-sha256; cv=none; b=V22/eqzDy1JaSqU/rrimtx8/5Jm+FB6qBfVvBkjNoxZQymHWUE3Pwn9G454h7PxmBfsh8y ZnW1kQO8aqOmtjhHGEFDxyB3Z0EwVH2TtIMqZtL6hPeCJYyyH7S/UdTjb1u/kKID3iNJXr SYTbdn+kFKE6aWDzI3tyuZan160nS18= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=sifive.com header.s=google header.b=h9hANiwC; dmarc=pass (policy=reject) header.from=sifive.com; spf=pass (imf26.hostedemail.com: domain of samuel.holland@sifive.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=samuel.holland@sifive.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698534824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2EsAJ3DvynnbB6jUfsinRvKaNQwCusxxXujfrC8RtXI=; b=4wWDz98Uq8Srv5pMg5b/FuuLt+B0RHpX+z1S5wmLakIl26v+cVaQbr2+nNFW9BCLdzyPUh wwB+RwyzDrtDvHjVjkDlzh4bpQ2rz17aPGj4aUTFAx5EQ+ETOAxkrfg4H/ouhL7fyuag5p TxWB0jBgijU4AgtiwKngsh2OHAavdq8= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1c9b95943beso29439925ad.1 for ; Sat, 28 Oct 2023 16:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1698534823; x=1699139623; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2EsAJ3DvynnbB6jUfsinRvKaNQwCusxxXujfrC8RtXI=; b=h9hANiwCCf1WxgF7bTFKjdDfaqNbHzWooHLmrt6tIs1KS8NWQ7BcLboU7u0PiVKpQ1 mrcxNcqXbAl9FDQRYKD994aTKsdCEh8FhcBSGB4yvNCnZJETYoLcinxoUiX+prZjpVOq EMnoZ7BLb69rP6Sk/9cKgRIcXwGFI5NiU22sz4j4b6d0N7xvmdxgW4EGszVdU3goQnNz zvzayGUBUz2M9Vz5HZtd0ty7XFRhWho6iKxIfwjlSNUmEQ/alniJdMxG9rwTQ/zmX3kg mVQfqhLKwuBRCNPmgrqCdsqvGTCH30pmrykrlBQBHG3KJkKfBjdTfkJ2FliT3m/feyt6 qt4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698534823; x=1699139623; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2EsAJ3DvynnbB6jUfsinRvKaNQwCusxxXujfrC8RtXI=; b=r8XcSb/Q0AEDBRkrvgPfjUaoJSegaxGppKGjetX60wfQA+8oRPMEBvJqBLYOn1WPKr dvXCbBMThk3XiNHxa/Va3fccS3LxqrD9/MJZuMRP2fL5WBffBWeA+36gzkSDPKJvcrvs Foq8AkBew2ioHu89npKZUwwHQAKDrT1IbMP3hai9DK6sohQZ3/6WWssKdlD2AmAFCYzb mITkaPE07oS+oLXrXtqoyUcUSyYLosGu1rQHSKq83G+5CT1uxaqX3/tLffo6gL3j1rCg lt2hJ/Aq9gd28UV68Mhax79r1GByN7d1TCXU0b5l4kewVXP6ywxEzJGc8lFsP7/T8vtT I/5A== X-Gm-Message-State: AOJu0YzIDR5fnb8abfXblTRkCCvFWAqTeETF03IWpSA+UFOG2Easl/wK SgShG6rXduWRVgfT28PcJlWINg== X-Google-Smtp-Source: AGHT+IFw/0gO2jty39BfEl53e0TAm8jThBxaHB3Pi6HPPc0H5aL70GOaasoPy4Ex/mKBNftI1RCeRA== X-Received: by 2002:a17:902:cf41:b0:1ca:8252:a91 with SMTP id e1-20020a170902cf4100b001ca82520a91mr7454451plg.41.1698534823149; Sat, 28 Oct 2023 16:13:43 -0700 (PDT) Received: from sw06.internal.sifive.com ([4.53.31.132]) by smtp.gmail.com with ESMTPSA id u17-20020a17090341d100b001b8622c1ad2sm3679345ple.130.2023.10.28.16.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Oct 2023 16:13:42 -0700 (PDT) From: Samuel Holland To: Palmer Dabbelt , Alexandre Ghiti , linux-riscv@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Jones , Lad Prabhakar , Samuel Holland Subject: [PATCH v2 01/11] riscv: Improve tlb_flush() Date: Sat, 28 Oct 2023 16:11:59 -0700 Message-ID: <20231028231339.3116618-2-samuel.holland@sifive.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231028231339.3116618-1-samuel.holland@sifive.com> References: <20231028231339.3116618-1-samuel.holland@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 38B4314000E X-Stat-Signature: zaznggxujxps1hz7iu1ysiishhfop9gf X-HE-Tag: 1698534823-980467 X-HE-Meta: U2FsdGVkX187A/kIfnGpuacns6ZjN5jBw3vg2NiU4H0/FX4FF2+bbg1iiECSEuQI93TBp7D8CEvnW4jIyvWzbXlqcGpHDtE6qBziTIJXBv75YgJtRt/kzCecQnQHt34powtmAWdd2tO0LJ92lWQuBHfvZExCYSo1jKT5C/tMdU6QN8Hp48mhP1XU6avPSFXWPbdzaQ1ZHdPIQC5QnzesxDrBp2LMO60a8CwZbg1TwNGdO275rdhLUWX94FieaOar94xUg4IrArXJCBtfRLsn0nJnftN3xrPwtLs03HKysUkjNodDnsbRYht6+AbIrOQOkA50HHchPP1pnMblU7+PTtYc6QuHCno7ndpbn2kqVxwYyyKKsXKMxye24jtG4lPm8ggKdD76WU5n5uPtqpNYJIdYtVqhBfxtZJVxsazLBf3+bRXOYVlL77E+OWFLDni0ads2Pu1IE3a0a5264bVtR9RbMGjkPDlkmOzbXz/Y9Ht4qyotlSPpm9uFnzJ6V8pie8Ni7q7SQAdZPC4+IBLBHxGRYYBGHGXg0N8xUE5dZJklwErxux8HoCBiNXWbVeCUFhsPHeFKf2Ye9YC1+/C/5qQaRBkOctsc+rzO2XkYAfPSIDTOdP7U2RaRKxnqVWPhwTkjbBQ19c/BuwVToB7I3mROyVTCS9ERCql04EMZXR5j2HlJQXmA2XeyAUCro9Vv6EFcQ4g0AnCujPlNUCXRt1oWHcG3sGuXBs5wFowXF6VEXu8TYUS6+t6VsghqdG1bKT2rukpPxwpj0tf7JR+nrAtOQi4nrtrNCZjmLvksMHkinXjT4bRZmRtGNzmV5IAVnYxAtURyVShorotUL98lhXVr+lwdcZvQIj+CW4WXsge64ACrP4GIHHWSLiYUkggLENLPTC8rFL2L/zeqsHDzXmoSzYeYmb6Mi0/W9evVJRQaXwjcQ6HMZNuGvyWr6jhqX+gBBmJ8Nvn/W0RAQop v9Kliwhq 35ZaCLRhoPIGatoO0ZiiOc65/5/8zVzfnV2eKyRHFU1hW3zZivJZLtzt308erokf3LlMIZHbv8VRn8K9BEEcu6rVwJQMbgccD80d0V/S5mvEd2NdxvCU56Z7wgrVQhXzr1nLxt8S2hCrNeuDJDnz/9OpvRkpuo348K3bF6wavRNvQ6GwSei+EpfHjHq1sJ52MDmSOFNhYZ35IKjW4b+idn6Ip+Jeymzj+c7PMsxq5NKvfM5gS1347Lf56SZYSLOLvrS+aqxcikEEmdwSdXkNFF7CcVWYyUjqkCmwtbozdDQq4nWWiZB7OEkNK6E/0n73tkHsZE5LS6iX5mnlSxY/pSKv8XN6GmdQb9MGv0qTggO9qYIUQt7atgHUCTsx9XtdRpyGsKCNkdbz4Rt2OO4TRTwucM+dSDnh5w9IRWM07O9r9snZTUq2eDddM0AqyLvSe5pp/J5yWWKrCfqhqt5qY3zQ/1i3RG82rDO6zlQq9WerxpXqtxlUpub4ZO6xnUVLZLCr37Ypo2y23XL8kG+kJydwv+PUMRht8lXOVTQdLgBoeBht3zJAnWHtIx8YogsCZlb0tG0xgBnOZeIU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000088, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Alexandre Ghiti For now, tlb_flush() simply calls flush_tlb_mm() which results in a flush of the whole TLB. So let's use mmu_gather fields to provide a more fine-grained flush of the TLB. Signed-off-by: Alexandre Ghiti Reviewed-by: Andrew Jones Tested-by: Lad Prabhakar # On RZ/Five SMARC Signed-off-by: Samuel Holland --- Changes in v2: - Rebase on Alexandre's "riscv: tlb flush improvements" series v5 arch/riscv/include/asm/tlb.h | 8 +++++++- arch/riscv/include/asm/tlbflush.h | 3 +++ arch/riscv/mm/tlbflush.c | 7 +++++++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/arch/riscv/include/asm/tlb.h b/arch/riscv/include/asm/tlb.h index 120bcf2ed8a8..1eb5682b2af6 100644 --- a/arch/riscv/include/asm/tlb.h +++ b/arch/riscv/include/asm/tlb.h @@ -15,7 +15,13 @@ static void tlb_flush(struct mmu_gather *tlb); static inline void tlb_flush(struct mmu_gather *tlb) { - flush_tlb_mm(tlb->mm); +#ifdef CONFIG_MMU + if (tlb->fullmm || tlb->need_flush_all) + flush_tlb_mm(tlb->mm); + else + flush_tlb_mm_range(tlb->mm, tlb->start, tlb->end, + tlb_get_unmap_size(tlb)); +#endif } #endif /* _ASM_RISCV_TLB_H */ diff --git a/arch/riscv/include/asm/tlbflush.h b/arch/riscv/include/asm/tlbflush.h index a09196f8de68..f5c4fb0ae642 100644 --- a/arch/riscv/include/asm/tlbflush.h +++ b/arch/riscv/include/asm/tlbflush.h @@ -32,6 +32,8 @@ static inline void local_flush_tlb_page(unsigned long addr) #if defined(CONFIG_SMP) && defined(CONFIG_MMU) void flush_tlb_all(void); void flush_tlb_mm(struct mm_struct *mm); +void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, + unsigned long end, unsigned int page_size); void flush_tlb_page(struct vm_area_struct *vma, unsigned long addr); void flush_tlb_range(struct vm_area_struct *vma, unsigned long start, unsigned long end); @@ -52,6 +54,7 @@ static inline void flush_tlb_range(struct vm_area_struct *vma, } #define flush_tlb_mm(mm) flush_tlb_all() +#define flush_tlb_mm_range(mm, start, end, page_size) flush_tlb_all() #endif /* !CONFIG_SMP || !CONFIG_MMU */ /* Flush a range of kernel pages */ diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c index 77be59aadc73..fa03289853d8 100644 --- a/arch/riscv/mm/tlbflush.c +++ b/arch/riscv/mm/tlbflush.c @@ -132,6 +132,13 @@ void flush_tlb_mm(struct mm_struct *mm) __flush_tlb_range(mm, 0, -1, PAGE_SIZE); } +void flush_tlb_mm_range(struct mm_struct *mm, + unsigned long start, unsigned long end, + unsigned int page_size) +{ + __flush_tlb_range(mm, start, end - start, page_size); +} + void flush_tlb_page(struct vm_area_struct *vma, unsigned long addr) { __flush_tlb_range(vma->vm_mm, addr, PAGE_SIZE, PAGE_SIZE); -- 2.42.0