From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B818EC4167D for ; Sat, 28 Oct 2023 21:09:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C3AB6B030D; Sat, 28 Oct 2023 17:09:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 974016B030F; Sat, 28 Oct 2023 17:09:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 863366B0311; Sat, 28 Oct 2023 17:09:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7693F6B030D for ; Sat, 28 Oct 2023 17:09:36 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 46592140294 for ; Sat, 28 Oct 2023 21:09:36 +0000 (UTC) X-FDA: 81396111552.25.4F36FC4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id B58241A0007 for ; Sat, 28 Oct 2023 21:09:33 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HAkFHdXr; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698527373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=akCWBDW684115rgNSKzDVzE27lOs/49VO1ry0ooCIsM=; b=ZmlnKTYd2C8iQxZDRdiaNC5G5kWZFrx4H3SOztOx9YV0/LopKqasyv0o+GsIcsb7xlHUTh sNYkYECX2SNsCt58mj2FFLhtASvxZA8kP2tCda5aakQkvch5ilSP0K0kdHyp2v1TCPSTM2 t64pJnLSHK8Khq0/s1cVLODjcktNW/Q= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HAkFHdXr; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698527373; a=rsa-sha256; cv=none; b=BFPU78uaGqsc6asrm89x7wl8ZZZ28LUhPj9TEG/XEjJ9t6pljpeMyQbJ0QSIq5mPgZyrMw AThqP1Bjx1+rF/64oXQkwAY6p+O+1eMi3EHQG7dNYRJ0k+p2ajIBG6f8thZ6A+bPbAVOtu 6tDmPinKCWIuy9xPZstZCvnLR+hZbro= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BE45A600BE; Sat, 28 Oct 2023 21:09:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CB32C433C8; Sat, 28 Oct 2023 21:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698527372; bh=Wyr214KNSlnSWHwuMNRLzj8fmPHGsLCvoHa+yx4LD2k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HAkFHdXrEJ5NUZx0+7uR1BgK9gapGCmVtZlckCrNLoKRh322FrjpBp5EyQxesjxAI uHpkCcfmi5pFr7LHoGu8/Q0RwEM6y622KXmLjFQ+8ZxjTFfMcz0U6NeZ6yvBOSaAOq wzP7z4L/N9gjVH/FPAPz/YA4YM3PIkS4fNMkU2ORuT0pl4AhDKLrs1L7N7rd7imngt smoA22ePDhKjc1CKDInPfCPMfxqoQCUBRyVM+3+HL3zs/tX27rfkS0Yjt+OhbT+nH1 9tevZoYzzbB8FGlY/W1Kry7tZVlbJSu/wRpJPvUpf4Ou511hW9rfPLs5iWzrkkSSN/ 7639m0hyt65Aw== From: SeongJae Park To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] mm/damon/sysfs: remove requested targets when online-commit inputs Date: Sat, 28 Oct 2023 21:09:30 +0000 Message-Id: <20231028210930.62947-1-sj@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231022210735.46409-2-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B58241A0007 X-Stat-Signature: 4q7aiwg368rc8p6a7rmafnzzzsis699y X-HE-Tag: 1698527373-322978 X-HE-Meta: U2FsdGVkX183jv3aT0vo7s17VuHv90Lexud+h+tjjon7FKoWxzxX0bFQ3jq93YA+h1HGPO3BrPX+AKgSJwhLBc6FfwW0vqNOyP+o82F2xC7Z515+Ex+79aWr6MIBa2O2hAAQPPbYBMwbotaO2re0pDAmIfAQ6DK8X1rX6AWC4JRblcC4xCKZsGtkP8Xzos5V2AiOAypsFUQfSS0WWucqVyVPf4afHc8QRaqkwlpe3iuB+mwrvz89mNQFba7FcqjyjxaDM6d+1Ng6idemeAoeNebJWprfy8V8q+HfAHlQZEhgkEH7+OyDvEogZPs4e42uTv/ZhMRJafTKH0ZjlCVr2Q7jOnjc1EWB6dqMysWBmjL9iPBDofbIZQLi1e0JhpWdO+za+2lRgGE1zByKaAjA1zesQz5Asurv2vEqeEqRhGYy+sxrTSKBmt8wwXiPNRQtyh1FSt0jv8mmmkF+P0z9e4HhlSV2EMPzIN8JvKNaDk4GmPKImsSAIbyr0pn3Ezm+y/f23qzKI/xwt60uw/hNxzH7UF82G5ib6C9iCUvAlBgrBo8oOsqdB0MoAWvN/GHu4jDQUJcXrF6p3BMI9wAqEmDqHivpS9xXRydbpWzVwdDtqlCwRTt76ziN4fKhy8VzUD2ED1aLQ9Vw44qirBFpmOCocEtuHlg0GmL3kE7mgvFl3M1qNayC3VoroV5gkZphcPirgaQzmjfUrXPIhb7L0r7qJjjEWT90KVfdw3xYeMcyV1gfmcqCIe5mLvETCVPeKoWa3b898HvlearGOMjrJ4ZZqRdmpehFdXB4srvMuXbeAkbffg0GSeSqaoVtLiikPfkp2tpN9WA+BaOe6Q5VB2jwc4QedoBXO5o+SCd/iBcKwHv6VNkDC96MRex83E+vqBD8t3npGTkvDJR9r5KCx+RtGNSc4PiplFDWwe77bjrBYs7ALUuKlL4SXGjzzOCFof1kUDKtYzlXM9QBVzg 8fNH1YPL wHu5xleK9QVC5DPUJ2evya9IMtvMgbTc/IsC8ffbYTuyRg808ywDOM7kv5Q97WPpL48Dn+ZwFDOYhSNX51NzTYmr2Zs+fIe4oLCgmq/3KgOV4yA8a1vFZG4Tn1Ou4y7/HX6QexHZAMA6WpKO1joovjP8ZKYPgep6PBGdLNlYWzrPeDrOKXFjCxQszABHO4XRYyMKX3aLf8QLJjclnO0HU5zhaf0RJczx9KjfQOm02bqHoXoo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 22 Oct 2023 21:07:33 +0000 SeongJae Park wrote: > damon_sysfs_set_targets(), which updates the targets of the context for > online commitment, do not remove targets that removed from the > corresponding sysfs files. As a result, more than intended targets of > the context can exist and hence consume memory and monitoring CPU > resource more than expected. > > Fix it by removing all targets of the context and fill up again using > the user input. This could cause unnecessary memory dealloc and realloc > operations, but this is not a hot code path. Also, note that > damon_target is stateless, and hence no data is lost. This is not true. 'struct damon_target' contains monitoring results (regions_list). Hence, this patch makes all monitoring results to be removed whenever doing online-commit. I was confused with init_regions at the time of this writing, sorry. I will send a fix for this soon. Thanks, SJ