From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38865C4167B for ; Sat, 28 Oct 2023 19:18:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDEBE8D0058; Sat, 28 Oct 2023 15:18:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B67918D0006; Sat, 28 Oct 2023 15:18:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2FD58D0058; Sat, 28 Oct 2023 15:18:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8FECC8D0006 for ; Sat, 28 Oct 2023 15:18:04 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 69FD6B5761 for ; Sat, 28 Oct 2023 19:18:04 +0000 (UTC) X-FDA: 81395830488.02.B3B21A8 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf09.hostedemail.com (Postfix) with ESMTP id B129C140006 for ; Sat, 28 Oct 2023 19:18:00 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of "SRS0=FLsA=GK=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=FLsA=GK=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698520680; a=rsa-sha256; cv=none; b=tLFNfUswgtBFItYRwvBbmKjavfMUCOj6/hDL+REEc7hCcIM4674ZmM8XplEdt4MLc3qlw/ 6u4+GWengOlivShUQ7teJ19XXH/0pQXbXtWVxsgTvqrIofhR+fgj4oyjg03lH/fUoiH+eZ 5MYZNAVQzgzRNBxlbjPavkFro3MVb0s= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of "SRS0=FLsA=GK=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=FLsA=GK=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698520680; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C+tpvQHe7jefksw5qzG1xP6ij6ZPOhX/Ys1X+Xy/P18=; b=A1NRewP7KU1ngRNQdqhO9QazOfjIq0g26GHaEuNfZV6YFvi4VYM8why151D5ewSr0TIbq6 o0z0MoUmGfxoz6OezwBMy+Fd79E5RllKXY2CNhUrnsiNMRrbrvvy7qQGPYtVsCTNlIkuN3 npFPj1GWT0VQFL7InQsA/I0OmFY8lhM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id AD2EAB808D3; Sat, 28 Oct 2023 19:17:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D21AAC433C8; Sat, 28 Oct 2023 19:17:55 +0000 (UTC) Date: Sat, 28 Oct 2023 15:17:53 -0400 From: Steven Rostedt To: "Arnd Bergmann" Cc: "Naresh Kamboju" , "open list:KERNEL SELFTEST FRAMEWORK" , linux-trace-kernel@vger.kernel.org, "open list" , linux-mm , lkft-triage@lists.linaro.org, "Masami Hiramatsu" , "Mark Rutland" , "Andrew Morton" , "Oleg Nesterov" , "Dave Jones" , "Greg Kroah-Hartman" , "Paul McKenney" , "Alan Stern" , "Sasha Levin" , "Peter Zijlstra" , "Ingo Molnar" , "Dan Carpenter" , "Ajay Kaher" , Beau Belgrave Subject: Re: selftests: ftrace: RIP: 0010:__lock_acquire (kernel/locking/lockdep.c:5005) Message-ID: <20231028151753.1df27654@rorschach.local.home> In-Reply-To: <8f86f22a-e182-4ddf-b533-b4ae8b088dd4@app.fastmail.com> References: <8f86f22a-e182-4ddf-b533-b4ae8b088dd4@app.fastmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B129C140006 X-Stat-Signature: z9898h19qwdm1szgz4se5jnijat3ysqo X-Rspam-User: X-HE-Tag: 1698520680-576671 X-HE-Meta: U2FsdGVkX1+y5ux0z1qAgEvqWCgT6fh+XzZF5YYEm9izWGRStY2MbIKZVo7Tlv1idrHV6Vpf+HeK1RO3h+ysO9ctWfyybYZOQVgXOIqcAPLbYDfQKBeVuOxZuzLM7y7t/3A0VV46hJxfPn4YkCupxj5l9cmD8Db1oHWlXxuD8OgxsUceqdpQ561ydaGoKDqqtID1tS6a3sKAkQwzLiVDmCnqorS5l8gULF9GBz/VF1OK9+W0D9ektO7yuKcvSVLQDMAHsvEyVWNeUqgUpdwcvhD7/M73SZFl3iTqiap0ZInzJSGh4ZyGwKJ7LY/9K3fBMOjctmPV/VFgHmW996ZBQqKxYapdC5JEn2wrE7XNqenmLgzlL8ud9tQIX066ezIfmwEZMyuq0pGwOe9rXWvq182BEZCcbD3RRFefISDqE9v6KK8iq6rqnvyyY218YNS9FeSXrb4aLtrRcxQaprzizRONNji1qWc17AOhT0B33rBIY12CJdCRSuzQDtoRgQWDzq/uYvR4vAiEPvVtUXO1oa4Qi4NFlzKDhJpHlgmrFXvucZfWgdUhqlycbAn4Zt6tomPtFc2w0qnhEcm4GNl77KW8XZu2OJpyDE4yXg4DrR24hjewYBu0JeuAwYu2BaMtHdFuIjjMO5phW/Bof3cUBsqOtJTKVfWhrkdwt18DZeM7SdIDu8GGk7/0nsT5wGfkF2blMlo+RHVCEPMCgQLAssidFHTQuQvgBHZSWGuy/G54+6yEHfh6YYKs/TJpJS8AVy0z/5papqQViEwR9QhT2P6qkQ+zEzJrCHHotZt6jf0p3VbppSTb4ZTh0d4K6F2AawzsHrtkPRA0O/F7VcA8HYl97lGuC3hIXDnTEVSFuAwQUDAs/jqdAPBswWUi0y2Cgc8bg7xZEDIObc9h4XRhdsnKN9mbEFe7ZBYiSAa3sS0Pv8OuDIA0Xrjgs5RYf+np6PdCDdzs8ekPfwNgbmU s6Ow9m1B 9ObkZ0iZwefSfSjpkeRicUKTA/q79uUyE928wdCPhrUMRF+Nz3Ez0tUCIHkqisxoYHSdVQ+QcNc/ws75sOjE2l3uEMFvStm6rA30lBwuN0aBMRu5eUq9B2vMTwxRz4hfEXPRzA4D12WkxWr5krEoA/Z7e+wkIT4ceQsr/S3qWGZRM+v/pqXmpLua/ghJsWONuCyVZko2b5nX6Q+x6P9zqphi0kLPMUeZhqr1BEkUNkJ5YpUfAFO7R4aLbYpo8sRZgMBcuLAmntjLH5LTjSORM07EAQmQx9QYkxscRWIkUNXITPo3rihdmG5C1z2ULv0cOUUdk69mtFpFNFWWG9Zo1rrpTEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 27 Oct 2023 14:55:14 +0200 "Arnd Bergmann" wrote: > This lock is part of the dentry passed to d_invalidate() > > > [ 1402.609170] ? lock_release (kernel/locking/lockdep.c:5429 > > kernel/locking/lockdep.c:5773) > > [ 1402.612923] ? create_dir_dentry.part.0 (fs/tracefs/event_inode.c:387) > > [ 1402.617803] _raw_spin_lock (include/linux/spinlock_api_smp.h:134 > > kernel/locking/spinlock.c:154) > > [ 1402.621467] ? d_invalidate (fs/dcache.c:1725 (discriminator 1)) > > [ 1402.625126] d_invalidate (fs/dcache.c:1725 (discriminator 1)) > > [ 1402.628619] create_dir_dentry.part.0 (fs/tracefs/event_inode.c:390) > > Which is called by create_dir_dentry(). I don't see a bug > in that function, but maybe Steve has an idea. > > I see a bug ;-) Can you test this patch? Thanks! -- Steve diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index 4d2da7480e5f..ef003149e4d3 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -234,6 +234,10 @@ create_file_dentry(struct eventfs_inode *ei, struct dentry **e_dentry, bool invalidate = false; mutex_lock(&eventfs_mutex); + if (ei->is_freed) { + mutex_unlock(&eventfs_mutex); + return NULL; + } /* If the e_dentry already has a dentry, use it */ if (*e_dentry) { /* lookup does not need to up the ref count */ @@ -333,6 +337,10 @@ create_dir_dentry(struct eventfs_inode *ei, struct dentry *parent, bool lookup) struct dentry *dentry = NULL; mutex_lock(&eventfs_mutex); + if (ei->is_freed) { + mutex_unlock(&eventfs_mutex); + return NULL; + } if (ei->dentry) { /* If the dentry already has a dentry, use it */ dentry = ei->dentry; -- 2.42.0