From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A458C25B6B for ; Thu, 26 Oct 2023 23:54:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 112848D0036; Thu, 26 Oct 2023 19:54:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C2668D0034; Thu, 26 Oct 2023 19:54:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECBFD8D0036; Thu, 26 Oct 2023 19:54:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DD7BA8D0034 for ; Thu, 26 Oct 2023 19:54:48 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B9BAE160E1F for ; Thu, 26 Oct 2023 23:54:48 +0000 (UTC) X-FDA: 81389270256.09.76377EC Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) by imf22.hostedemail.com (Postfix) with ESMTP id B67ADC0007 for ; Thu, 26 Oct 2023 23:54:46 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="wlXDU2r/"; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698364487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fxBcC6WpG3KRFkLY2+tQDJJ4+RZgo+8n9ZWicropf8c=; b=7zAirRcbASyoS+dgp6GouGk5N6JfUMfF7GSckRnj5JK38f1z/eVbvR7/r5am98NS3HPXWf pX6eUeYARPThL7vXIqsjVziDpxnBESRTFlOBpsD0bA/eEYs9X3rcBbURG7DExB4nyls56q WRhDiDCoONZQwhdawXh+fLqi3pGyOGs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698364487; a=rsa-sha256; cv=none; b=v2eF+u6lWLSkdgYnzexl9A2OohWA99Q+DgsG65xW7okFvlSi60uwHVhtLr1BPpmJFd7tqT Tz7MzzwvCWf3vKe5jGyllzDn1fPkdfE8Q7frVOFytCQGWX6TyxGhSgu+ypP5PO5qeHpkCq 6xf8A+d5y8r1plPlHPPpcSYv3iFC2mk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="wlXDU2r/"; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Thu, 26 Oct 2023 19:54:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698364483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fxBcC6WpG3KRFkLY2+tQDJJ4+RZgo+8n9ZWicropf8c=; b=wlXDU2r/5NnsFnSK4PA0DRbeQnz5idT7VKahwUmPIGnLuoPyox6xMFxCRq1Pws1EO9s3ve aIg3upr66EtS1MsZX/PbSPfqPxCaMEUcPviZb6meANiNZEhNmrQ2++x3KPz3NDd9hcGBJa 757p2yOOJ0ABimOFGTUk16CjWjiwuWc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Thomas Gleixner Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v2 28/39] timekeeping: Fix a circular include dependency Message-ID: <20231026235433.yuvxf7opxg74ncmd@moria.home.lan> References: <20231024134637.3120277-1-surenb@google.com> <20231024134637.3120277-29-surenb@google.com> <87h6me620j.ffs@tglx> <87jzr93rxv.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87jzr93rxv.ffs@tglx> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: B67ADC0007 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: pkxji4gjy5uuopy7nd3dahhgptfu6isi X-HE-Tag: 1698364486-137067 X-HE-Meta: U2FsdGVkX1+snskXqBVxg4njVFPB2TVRiKfio/8xEO0+8n4z8cRIxS29iaUEv0tR/mwykfVc+gwQ2LqWiVQUCHtvs22ZHhKoEcQhuseZVNR8xX+mMCQ4CryBvHNZVKO62ID/DCfV+SDQPytZJXATerVGuvOZokzu40K0KJR05+BAkOfvNBQdSn0jpU3cyfkOfjQ+FFtMyH2EEMTcx1bbIExr7/vOIDOJKAM6GTF5xyVxu5VgfwgjAITomeQJoKIxHs7v0f1ZsidbJQFgqQ4pbjW1W8xDvCt4UDeENBnXOCMtNMzyK9dB9XQCO9uTzk/LpcERou0RK41zmZMmthMC0pVPtXO0XzlLU91bF0u+91czQJeqwIBnvjbe3AcxunLJ6AjjTbkUFyRKPSxZ7dFGxAl/mcgzi9iWuFDHRUxvBAw9/fuvBYKOYS5Vm1fwZgHLqwIe7j7+zpd7H01ruzf4b+fH2lwztqqxX9R8MMNZNaFwSDG6EYX5Ssn479x3NxcSeIZNyUlJqKep4v5pzTPT26fU5LGr6ZxDCye3KLUCQnpPdPUi4pMA5uh6qaNGEVrULrh95vj7JMBPDLDEmMp2iX4n9cQiW8AhIOYzUQLr+eBJfCKq3zeRF4b6eWHocD2fPF3dUNRVEe1hxNfsbLDpSPkBoF9i86MzlLI52UtmCCKfoDooSGDPTpRIraQSZPLoq6M34B66sFWrCE9293wRZqgo82ox2s/fxxy+y0qPjxu2AczW53doYYub1RJvEbQrEwImP2zJLIewFuiX7ygfiQkAgX7kLMyrj+CiAl1eclpIsM5nIuVHdjQKPpqAy1qWlipzxRIwb2BGkchBvsXYnApwJW4lqH26A5zxYUA3b/z+wenNRU51Nx//UrH5sOUp/vm8Z+KFlvIq94tS4ecb6acOyjnVMv+8cs6nmpQCyLVVhYspVvUtzi4Z9nHweY/lC5IFHyoPgf4o0UlR/Eh 9NeOxkKg FJKz0W3JH1VywlqhsbxS8aaMY6RLgrHOp8g7mCaUXBNtgqg2VnH55wZPe3O7hKqwdLWRLN9W63Cblsaw//4ug2HzUhSKyI/3drVslaSFMCmNSei0qhvj7l5R6hA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 27, 2023 at 01:05:48AM +0200, Thomas Gleixner wrote: > On Thu, Oct 26 2023 at 18:33, Suren Baghdasaryan wrote: > > On Wed, Oct 25, 2023 at 5:33 PM Thomas Gleixner wrote: > >> > This avoids a circular header dependency in an upcoming patch by only > >> > making hrtimer.h depend on percpu-defs.h > >> > >> What's the actual dependency problem? > > > > Sorry for the delay. > > When we instrument per-cpu allocations in [1] we need to include > > sched.h in percpu.h to be able to use alloc_tag_save(). sched.h > > Including sched.h in percpu.h is fundamentally wrong as sched.h is the > initial place of all header recursions. > > There is a reason why a lot of funtionalitiy has been split out of > sched.h into seperate headers over time in order to avoid that. Yeah, it's definitely unfortunate. The issue here is that alloc_tag_save() needs task_struct - we have to pull that in for alloc_tag_save() to be inline, which we really want. What if we moved task_struct to its own dedicated header? That might be good to do anyways...