From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9FC0C25B48 for ; Thu, 26 Oct 2023 13:28:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DD4C8D0026; Thu, 26 Oct 2023 09:28:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4635C8D0001; Thu, 26 Oct 2023 09:28:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B6198D0026; Thu, 26 Oct 2023 09:28:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1824E8D0001 for ; Thu, 26 Oct 2023 09:28:55 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C9D2540139 for ; Thu, 26 Oct 2023 13:28:54 +0000 (UTC) X-FDA: 81387692988.18.51DDFD3 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by imf02.hostedemail.com (Postfix) with ESMTP id 43B5880021 for ; Thu, 26 Oct 2023 13:28:51 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=K5uoFIPF; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698326933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Qe1Mt2Ju0O7bVLpKOclJLNaxkWpEVKx/v7Ik+GM+6bM=; b=3r/Uz4zMgbqasefCFCpHvbaiq6tC50SE16q6Suk1yCVdO8WA/yvDARvTbRmtIii6IbUsdR sJaPyhNuCnqUQIxeI2DJmMg08mpNd4pYtviyf+Llfs2X2hxLM/Xzp7iQLbUmKwosU6YgIY v6UHgf4hIWRRpnXgMCewAovGPl9ycAc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698326933; a=rsa-sha256; cv=none; b=4SdGTwUk5ta9sbEl8t3ecXy24I/gmcpuWamw/VBE1yWB7sj9hDgdXZ61C6u3yRH96x0L1V qyT4TMYi623JS/pbnOBx1qeqHhvtp9oDB/wqsSCzr6LxxYTuu7nI4ns9M2f3rEpdZlo885 FMCiWxtzWYO5RI+B/IK1KPty5CpwJgg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=K5uoFIPF; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698326932; x=1729862932; h=date:from:to:cc:subject:message-id:mime-version; bh=OmDa3RzcbQ/VeKX1sPqLXLUlPv4hO5tKQNi9qdtoKRk=; b=K5uoFIPFQfQR5kwbwOIbY3kJJpkhlVsSBVnk96O/q8ITeNCXbi57hHXU QQFL1qlALzNlB3An2kawTgJTIQoF5uM5J8p/+GC4ftj6GIkC1s8kupiv1 w0Wyj/cuRtFC1b4Yl7D4T1b7cW7wNWp/r2ZO0rNFnw65n765NR78kHpYx 31lMxyriZ066NgkFdAk7dCtU8frssTm7AC9KDXcXxV2R98sicU1tjBWXH Aq8T/U5SvOMKhgiIopeoPNO86lUj1VKE/Ctn+A1GPvWlHxfU9aEwNJjj6 JYS2IeJVnQW+YEyI3ys++EvNF994vtwAsweA4jXkoOSNJaQZk+/VE1/kT w==; X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="454016915" X-IronPort-AV: E=Sophos;i="6.03,253,1694761200"; d="scan'208";a="454016915" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 06:27:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,253,1694761200"; d="scan'208";a="6909555" Received: from lkp-server01.sh.intel.com (HELO 8917679a5d3e) ([10.239.97.150]) by orviesa001.jf.intel.com with ESMTP; 26 Oct 2023 06:26:01 -0700 Received: from kbuild by 8917679a5d3e with local (Exim 4.96) (envelope-from ) id 1qw0OO-0009ot-0t; Thu, 26 Oct 2023 13:27:20 +0000 Date: Thu, 26 Oct 2023 21:26:34 +0800 From: kernel test robot To: Sergey Khimich Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Vinod Koul Subject: [linux-next:master 9065/14992] drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1239 dma_chan_pause() warn: inconsistent indenting Message-ID: <202310262104.JQhDdU3I-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: 43B5880021 X-Rspam-User: X-Stat-Signature: 3yfp3fjgeisqegawfw3ca8jwxq6yosnx X-Rspamd-Server: rspam03 X-HE-Tag: 1698326931-655994 X-HE-Meta: U2FsdGVkX19xExUjStm/UndK28HSCvqieFOseEVj6OFOPTfoTW7Jr6BPUhf0w2+pLzjJG3lwUl5/xzyKOTAp7J8QaC6zNzSPb0VMNDbXQFSPDNbmzDN5H7s6OpvbMwH3+mDsf/6DHoYzJohKiT0AMd/tl7eOV5nqs2XyEh8fh5cm44bsT8yqDT6IOH7BNKlSzGf6DqEsG/0ym1Num/UnaCt86i2wA+IEaorGRBlxlmW7J+eDuh5w2Nx/ur8C6cJ+/DKP0rQXKmj4A0PeUTHccJi0RiZaJGhkrn1BKGXDRTyIsWEC81XMcmw4uq7tpc8PrGrECWtFQCdso1aI+X0Cj2zAns1jKIL9Q/6hLcOQmFV77pRP367WqW4SMRiuEu6CVP86wv63+OKGndyfgtJ3bTQ1/5tTnuXOG8kvw3GU2IvwmQpwH+PuJXDQRHV1uQTUozrASPyxpfAWoephz2KaBuaUOeItzxgPVS6MAG9j+uQQBFRY+L0d5pIQFlwD7YtDs/yHXOC+N575H0mO453IDTMMz/CEco3GXLaEXVVqMC9oJ1UHt8ecgZqHWOWT4fNDXRcK8LauPjwcz9MKQO5ArESuwooXkglO6jGRJgifJVzOIfpYYeSMisZX8GL2lda8oonhiah+49ejgWWRwOG2GPHr/Ik67t2OlNCAy0URKuFPnoB+A+b9AfufmgN9G0Ci1CSQ/nG+2d+zKJRlOZidtc98P/FMnQLk6G9wWmGOY02/6a+0sFVZYbDGad4EeuUffOM6couM1FafyNNkdQoR78fYQMhSG0DTZlAclrP4oaPcw9WYqybGR920E9WQNUCV9e3DSmjQr1rHWNr76EyP7udWd8xLzKWrUXCEwwirQBI7LisSApVroJpBC/ARd0vpC9gUpOKKzzvkzcGvTXFrBkhYZwHvkcoFlxBrvsKqiKsFBmn13bHw1sMmtT4LHJWemcmRk3lejM9PrhvGfgN mVpy0TlO TtYuvxyUgeSU6Q6XZlTeN2YMt5koI+6Blkl8QkIYqOYlAuiNG4Wb9xCAqnP1dzVgf8VPgESohWV6akqZn14mqaadbh5CeNT+id8NMdOu20cenAGK5qHqe2TWeHmT5PLHySv5Bekz3Sx8DujIPEqlToFYrjAhsqG+pQ5JfO6+TbFCeMvfLhI34ICaFw9m0fP7ZhoxlrNQQu1SGx+L9fbwYiVG2HcAgB0hg0vmUHmg6Aq442HX/dHjdi7uUaP1NDoOEyxUMCIoRRfx7BTMcPNVnOylc4mBcSQ18qdmzZ0tP4YNRfANlLP2CknbWYjyUtz2dj1+8w/QmmNV8JcBf2mPtqZStGV+xK0v0sePh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 2ef7141596eed0b4b45ef18b3626f428a6b0a822 commit: 495e18b16e3dd8218eaec6a8a55334fb55245d59 [9065/14992] dmaengine: dw-axi-dmac: Add support DMAX_NUM_CHANNELS > 16 config: x86_64-randconfig-161-20231022 (https://download.01.org/0day-ci/archive/20231026/202310262104.JQhDdU3I-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 reproduce: (https://download.01.org/0day-ci/archive/20231026/202310262104.JQhDdU3I-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310262104.JQhDdU3I-lkp@intel.com/ New smatch warnings: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1239 dma_chan_pause() warn: inconsistent indenting drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1286 axi_chan_resume() warn: inconsistent indenting Old smatch warnings: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1345 axi_dma_resume() warn: 'chip->cfgr_clk' from clk_prepare_enable() not released on lines: 1340. vim +1239 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c 1218 1219 static int dma_chan_pause(struct dma_chan *dchan) 1220 { 1221 struct axi_dma_chan *chan = dchan_to_axi_dma_chan(dchan); 1222 unsigned long flags; 1223 unsigned int timeout = 20; /* timeout iterations */ 1224 u64 val; 1225 1226 spin_lock_irqsave(&chan->vc.lock, flags); 1227 1228 if (chan->chip->dw->hdata->nr_channels >= DMAC_CHAN_16) { 1229 val = axi_dma_ioread64(chan->chip, DMAC_CHSUSPREG); 1230 if (chan->id >= DMAC_CHAN_16) { 1231 val |= (u64)(BIT(chan->id) >> DMAC_CHAN_16) 1232 << (DMAC_CHAN_SUSP2_SHIFT + DMAC_CHAN_BLOCK_SHIFT) | 1233 (u64)(BIT(chan->id) >> DMAC_CHAN_16) 1234 << (DMAC_CHAN_SUSP2_WE_SHIFT + DMAC_CHAN_BLOCK_SHIFT); 1235 } else { 1236 val |= BIT(chan->id) << DMAC_CHAN_SUSP2_SHIFT | 1237 BIT(chan->id) << DMAC_CHAN_SUSP2_WE_SHIFT; 1238 } > 1239 axi_dma_iowrite64(chan->chip, DMAC_CHSUSPREG, val); 1240 } else { 1241 if (chan->chip->dw->hdata->reg_map_8_channels) { 1242 val = axi_dma_ioread32(chan->chip, DMAC_CHEN); 1243 val |= BIT(chan->id) << DMAC_CHAN_SUSP_SHIFT | 1244 BIT(chan->id) << DMAC_CHAN_SUSP_WE_SHIFT; 1245 axi_dma_iowrite32(chan->chip, DMAC_CHEN, (u32)val); 1246 } else { 1247 val = axi_dma_ioread32(chan->chip, DMAC_CHSUSPREG); 1248 val |= BIT(chan->id) << DMAC_CHAN_SUSP2_SHIFT | 1249 BIT(chan->id) << DMAC_CHAN_SUSP2_WE_SHIFT; 1250 axi_dma_iowrite32(chan->chip, DMAC_CHSUSPREG, (u32)val); 1251 } 1252 } 1253 1254 do { 1255 if (axi_chan_irq_read(chan) & DWAXIDMAC_IRQ_SUSPENDED) 1256 break; 1257 1258 udelay(2); 1259 } while (--timeout); 1260 1261 axi_chan_irq_clear(chan, DWAXIDMAC_IRQ_SUSPENDED); 1262 1263 chan->is_paused = true; 1264 1265 spin_unlock_irqrestore(&chan->vc.lock, flags); 1266 1267 return timeout ? 0 : -EAGAIN; 1268 } 1269 1270 /* Called in chan locked context */ 1271 static inline void axi_chan_resume(struct axi_dma_chan *chan) 1272 { 1273 u64 val; 1274 1275 if (chan->chip->dw->hdata->nr_channels >= DMAC_CHAN_16) { 1276 val = axi_dma_ioread64(chan->chip, DMAC_CHSUSPREG); 1277 if (chan->id >= DMAC_CHAN_16) { 1278 val &= ~((u64)(BIT(chan->id) >> DMAC_CHAN_16) 1279 << (DMAC_CHAN_SUSP2_SHIFT + DMAC_CHAN_BLOCK_SHIFT)); 1280 val |= ((u64)(BIT(chan->id) >> DMAC_CHAN_16) 1281 << (DMAC_CHAN_SUSP2_WE_SHIFT + DMAC_CHAN_BLOCK_SHIFT)); 1282 } else { 1283 val &= ~(BIT(chan->id) << DMAC_CHAN_SUSP2_SHIFT); 1284 val |= (BIT(chan->id) << DMAC_CHAN_SUSP2_WE_SHIFT); 1285 } > 1286 axi_dma_iowrite64(chan->chip, DMAC_CHSUSPREG, val); 1287 } else { 1288 if (chan->chip->dw->hdata->reg_map_8_channels) { 1289 val = axi_dma_ioread32(chan->chip, DMAC_CHEN); 1290 val &= ~(BIT(chan->id) << DMAC_CHAN_SUSP_SHIFT); 1291 val |= (BIT(chan->id) << DMAC_CHAN_SUSP_WE_SHIFT); 1292 axi_dma_iowrite32(chan->chip, DMAC_CHEN, (u32)val); 1293 } else { 1294 val = axi_dma_ioread32(chan->chip, DMAC_CHSUSPREG); 1295 val &= ~(BIT(chan->id) << DMAC_CHAN_SUSP2_SHIFT); 1296 val |= (BIT(chan->id) << DMAC_CHAN_SUSP2_WE_SHIFT); 1297 axi_dma_iowrite32(chan->chip, DMAC_CHSUSPREG, (u32)val); 1298 } 1299 } 1300 1301 chan->is_paused = false; 1302 } 1303 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki