From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF5C4C25B48 for ; Thu, 26 Oct 2023 10:24:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 402D48D0025; Thu, 26 Oct 2023 06:24:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38AE08D0001; Thu, 26 Oct 2023 06:24:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 204778D0025; Thu, 26 Oct 2023 06:24:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0DC928D0001 for ; Thu, 26 Oct 2023 06:24:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C3A74120CCD for ; Thu, 26 Oct 2023 10:24:53 +0000 (UTC) X-FDA: 81387229266.20.FF893EA Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf07.hostedemail.com (Postfix) with ESMTP id E6E644000D for ; Thu, 26 Oct 2023 10:24:51 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZyX3dszi; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of will@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=will@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698315892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IYuWW2mai+mszjKM9HqrM4yCjQ9Ykqq12Al635QJOZM=; b=UdUIf3NHM2h1CvWy7Z7etCarkNjpLRbx/SLsICsNZ72Q86lf/Iqh1ZHYXsuRTK+im9U+s2 GfNz0o0nFKhD0pTU2ZKugR08rpxfQ/Zj5kdMB+dGaN7t03HmzJn1yGdCZwbWqBX11PW58W zAiUTXZYXczLzQTKBwPuyQHNhGu43rc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZyX3dszi; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of will@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=will@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698315892; a=rsa-sha256; cv=none; b=LgjjnxZn52ZxeYH9vtFJXO2Ks15N8kBULrrOBdgISLw0QDNZN/kfM7lUzHzic6DYWl1vmQ Fm1iwZXn8H4ahX2W/FZeEp7j279vwBKZdLEhzhdGTlKFbDxFVR54CkO3o5++SOyyXj1UjG 7whPZ0Vnn8zfUwpiM+kpqogpTqmbIKk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 17FABB8077C; Thu, 26 Oct 2023 10:24:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1DD8C433C8; Thu, 26 Oct 2023 10:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698315889; bh=WN2YIA4Ghusd7FbmcNZrWw/oKLuywPkap4tOfxaAQ4k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZyX3dsziPkRUXG2UWwCRe9pQvhY4J8EKCi1UMJicG8n+1K8kuqLhkCHInfodKwhzx IGdZJx3E0WGYfJuhn5slU+daxFVHZfLRqURf8zRCQM4mPgPcJg6TqmPoqs/pWtOypa aGTSZPjPNBzHwtWONSwhXj/25YMcitUcojHP1kRQ49c14Z4eV6Kpw2ampGhmL7G6Sm v7J3Ia4FdxDhFLmdhSb20AH9mufPj5bcJmpVjmk+yiUwvbVfd/gsYS5NT3Ej9E93W4 br849v8H22PcC0TOPiwgXMZFArfvyVNNVM97V2kwDBdHjqJI1bEYt3iRHEo7Tm6Bk9 Y3kn5Rw8Exupg== Date: Thu, 26 Oct 2023 11:24:39 +0100 From: Will Deacon To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 04/13] mm/execmem, arch: convert remaining overrides of module_alloc to execmem Message-ID: <20231026102438.GA6924@willie-the-truck> References: <20230918072955.2507221-1-rppt@kernel.org> <20230918072955.2507221-5-rppt@kernel.org> <20231023171420.GA4041@willie-the-truck> <20231026085800.GK2824@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231026085800.GK2824@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E6E644000D X-Stat-Signature: 3icedkwpdi8nwzwht7z4qgp9n1dcpk64 X-Rspam-User: X-HE-Tag: 1698315891-213381 X-HE-Meta: U2FsdGVkX18kTVgWA0PZuNog0xbQ5m5WA5wkQDOubbnVmnXktTOgLJ63f5PbzYLVd8fjpY8EqbzWM6pmR0UmrvGImBEvRTDimz0pzBVzoLITRWKisnj/0RRjxcfdKTaZ+UCy6DsvrkSvclLo0Mk/chaePXhcKISm5PrkjyX6K6VdDE4eiEeMFgdwbFt1VyByBrd9qKOsARdvz2BHnS2P8YnAgoSCWq69ek4/hEpHQHb1eTGyyzpSX78nqP44tV9pSIEcH4Y0jzYJsCd2USyFjrRSqlI2f0U6Vod2u3BnhmXaNcVa2uzCceQ/Ov7ftUwz6W2PM+cbKLiFQeEkiF2q8GQ1x8vLPgjv5BcOOFug7wKz1CwQHC5Sto5wwqIkQNPuJT3GHQUaH9xOe7V+lUwLR0RwcmnBn0E5a25zGV1C6JvAN/9UabHTrAP3MfKDtHYYEhqVnlZ3ysDqxWwnEkGR4oH+VK1P4Yw6UgQhO8nYTczqcWmcOY0Z9XlHRteUiMUjScVymPTPH2YuHdnLH1rbmHgKDjsoX4r7sERHpzaRIE5RpQxwPMszTnqDjw7QtvKVjdEioN7QVUzU7/UiMmBBaFqLZVfvfbkv36CjN3t0mMz8UiqPxwr4KXOVw4y3FGA9W1qp730Y+4EwsCCLpG5/WFddb/NJYTfL7pGnAdueplFJwhnl11q/Ql9bFFiJ/gvUASIFklOCAFZ2lNF6t9UqJN8ynwgnUh9R1Q5oauibkXLzfNvtaXlX9OFUSULDmfUAoaywBK93aWetNkiP834gILYzPW2v4PbCLSIqv8gzLExP9Mzzc8AvLOEqdRVauVaaIATlOprVRIAIKLuJTKNWmHmzCoCLmHTfx1ke2k6ZbYsl9ZbQ/fFFUK0fdRuC8UUs1tyr39WN+ar6yMz8BpA/Kso0dOShVLRJqKCPjzgYXYqnnQ9r8N427K6jC3W1N98BZlFDYtYhhMO+zbNgDRg En46p4PV RUdzljQ0in/zmnw5FdUZQGuamomYylkCPQB4MElE4k/XkOITZopdz9S+teJMU4uyGGfQsJolRPl81TKYOxzWrBwJEF56M3prVvBqcELztbadFsgbnHtO9esTjnaBWo49e/z9P05zwbFC0eATf3UJHppOgZEKd0y9jwylF0gkSjRQ8ZOaBM182iQxR+90Om2NgJHylqyGjmQ+J7HT+XqGE19GNKXkthavbutZ6+etzE8cJU2dopJN4h3FpTEeRcrhh8oYgf1zcYYi/fjiI5UL4zhc+VHrS9e7Sg4OP72EKtGkWDOkWUHWnQA1O/A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 26, 2023 at 11:58:00AM +0300, Mike Rapoport wrote: > On Mon, Oct 23, 2023 at 06:14:20PM +0100, Will Deacon wrote: > > On Mon, Sep 18, 2023 at 10:29:46AM +0300, Mike Rapoport wrote: > > > diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c > > > index dd851297596e..cd6320de1c54 100644 > > > --- a/arch/arm64/kernel/module.c > > > +++ b/arch/arm64/kernel/module.c > > > @@ -20,6 +20,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > > > #include > > > #include > > > @@ -108,46 +109,38 @@ static int __init module_init_limits(void) > > > > > > return 0; > > > } > > > -subsys_initcall(module_init_limits); > > > > > > -void *module_alloc(unsigned long size) > > > +static struct execmem_params execmem_params __ro_after_init = { > > > + .ranges = { > > > + [EXECMEM_DEFAULT] = { > > > + .flags = EXECMEM_KASAN_SHADOW, > > > + .alignment = MODULE_ALIGN, > > > + }, > > > + }, > > > +}; > > > + > > > +struct execmem_params __init *execmem_arch_params(void) > > > { > > > - void *p = NULL; > > > + struct execmem_range *r = &execmem_params.ranges[EXECMEM_DEFAULT]; > > > > > > - /* > > > - * Where possible, prefer to allocate within direct branch range of the > > > - * kernel such that no PLTs are necessary. > > > - */ > > > > Why are you removing this comment? I think you could just move it next > > to the part where we set a 128MiB range. > > Oops, my bad. Will add it back. Thanks. > > > - if (module_direct_base) { > > > - p = __vmalloc_node_range(size, MODULE_ALIGN, > > > - module_direct_base, > > > - module_direct_base + SZ_128M, > > > - GFP_KERNEL | __GFP_NOWARN, > > > - PAGE_KERNEL, 0, NUMA_NO_NODE, > > > - __builtin_return_address(0)); > > > - } > > > + module_init_limits(); > > > > Hmm, this used to be run from subsys_initcall(), but now you're running > > it _really_ early, before random_init(), so randomization of the module > > space is no longer going to be very random if we don't have early entropy > > from the firmware or the CPU, which is likely to be the case on most SoCs. > > Well, it will be as random as KASLR. Won't that be enough? I don't think that's true -- we have the 'kaslr-seed' property for KASLR, but I'm not seeing anything like that for the module randomisation and I also don't see why we need to set these limits so early. Will