From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A22C25B48 for ; Thu, 26 Oct 2023 07:06:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B2C28D0021; Thu, 26 Oct 2023 03:06:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 762C08D0001; Thu, 26 Oct 2023 03:06:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 652828D0021; Thu, 26 Oct 2023 03:06:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 577978D0001 for ; Thu, 26 Oct 2023 03:06:48 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2829440CE2 for ; Thu, 26 Oct 2023 07:06:48 +0000 (UTC) X-FDA: 81386730096.13.8A4AE43 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf01.hostedemail.com (Postfix) with ESMTP id 500A040006 for ; Thu, 26 Oct 2023 07:06:46 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=i8Kcmnwz; spf=pass (imf01.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698304006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wMNJftQVf2QXKCuFxZZxgj6EiiH5We62gPsWdhpccM8=; b=D8UK0yea0O7JVVd/SxpBCS/dWBManndB08eBqY12CLZjpd4VoCnRWH3SCyiauHWaUiRI7e DYZvSRAeqLcZAaj6PHBkYdpfuH9SexRs3P5acF9iMCVrdtQfOS0Xf3rXt3uNFA7ENcOjyw s4m5syNOd/UfBuR9HMSemfs4EOmNSU4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698304006; a=rsa-sha256; cv=none; b=FvnsW4nnYLJXyXy3jnD62JErHbPLS79zY/o/zZNPYToaOoOlGYIbDmMvOq7IQU7Z4gs/5X uYsPogCArwDA0AYb1ceqHZbyQ6chsU7zVPvTNfwCQ8WthIrEqVxUw1R55Ca1s3pPKZt94x TbU40KfaXe7yiPxRX2JirY8/WhyIaw8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=i8Kcmnwz; spf=pass (imf01.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1cac925732fso4354335ad.1 for ; Thu, 26 Oct 2023 00:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1698304005; x=1698908805; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wMNJftQVf2QXKCuFxZZxgj6EiiH5We62gPsWdhpccM8=; b=i8Kcmnwz2piv8A6A7PY1VILTJf1vDEb/dHtBv0IZ1ER24LYuEzRtnrmHOZIBbwQQKs 6La3tsBD2ZkJEZk1+lQjcvwnGnsGXrQcbSc06UOaPvglgM3fWveVGHdWVU3VibU2ja75 4QN0o2gXBFzRJ9Dtu+PxdYAWwaMI0XDyeRyxA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698304005; x=1698908805; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wMNJftQVf2QXKCuFxZZxgj6EiiH5We62gPsWdhpccM8=; b=mR8ADG5FlOfZpB/oO4KnWZfMl9sJdpFcGbT9Asb//hjEYw5mBm/pk1e1n7bSofrigw 0q+x+XVCY9L8lXTCSdKjA/amYLg6TokYMlCukMdmuVT5VJeqxuvL33C3T3D4z9BqRTNU xueIHapzk3YovwcTNh1ETcSCLanYo3JBQ54dyhTTCvVXqWDrjbjmYNg03w3x12Y+DYEi ddPDhtZcUhF2CMXRKF/T8YGA2DKH3NEMiivkxb+91fw1OOT0VhcYE0JpKEiJ69eYWRcu 7mKoum3+qZTyYqfjHpiqWKLPiIBFQzu7KEINqmxErhgjqXo9/Qn7PHQnc2ivJ1c3oobu H7Mg== X-Gm-Message-State: AOJu0YwBTQLCN9D60XlBWg+gZxXDgTEhHxVePB+hkJ5CQ2/0XreQ55P+ LlLNfwNcLKifCqaI9TcPkc1bDA== X-Google-Smtp-Source: AGHT+IGHuqs6cJxAO05b4OtnwLDo1D2gymVrsLExkse7C+G6Afwt0vVL7asDisJo5osA7Lk44ixdag== X-Received: by 2002:a17:903:110d:b0:1c9:e508:ad43 with SMTP id n13-20020a170903110d00b001c9e508ad43mr17082989plh.8.1698304004990; Thu, 26 Oct 2023 00:06:44 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:f228:3a07:1e7f:b38f]) by smtp.gmail.com with ESMTPSA id f11-20020a170902ce8b00b001c5076ae6absm10295706plg.126.2023.10.26.00.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 00:06:44 -0700 (PDT) Date: Thu, 26 Oct 2023 16:06:39 +0900 From: Sergey Senozhatsky To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH] zswap: export compression failure stats Message-ID: <20231026070639.GB15694@google.com> References: <20231024234509.2680539-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231024234509.2680539-1-nphamcs@gmail.com> X-Rspamd-Queue-Id: 500A040006 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 4iywbfzssk9c9hi9tus645qh46d1ps63 X-HE-Tag: 1698304006-847634 X-HE-Meta: U2FsdGVkX1+pXLyYCLXCTKjlKRHQjKqkjhUpJ1gcEZnlKg/9xCDN3ro7hA2vTbqZgxBvndpwirfIHo5hq7zkwDUa5aDxA75+0Xq7EInqmzk6eRH343KNWABz7tKWE6UaxsRWqLUACDJMiuvFqQSffudzN9SLEie9wJX9PGXBDwEr8s8FrTKb/0cSXsi+EQJyoAYuSZISgnTbM3kGgb2AwWXzEn8B9VS0LFIEz+/1QbjOmzCpW8iA/QvuFD7LP9xyUV/i47B9sZ9z95XOFw5TotLYZLLe6DRMW4rLxTn7CkGihAXON5NHKPFTnB7/rGVEyF59Sj+bM5VskS3mh/s7PfS5Ss9H+7oBU8MBwMCDsZUD5HiBgLtMkheiI37BxSmc6rf+43+CXyVpHs8zulQH5X5ZT/yMlrZ/MCLE4TNGwsxWcrW9KpO/8c3dEFPFcNCVyUo7UimeprSuNUU1p+25cRCBM5WE/DKrsC0kOWXNvvbpA0eVYmtjGLXUzlVhZpAzfhm0md9yjaPfMR7MMAo5FLezfrvu/5YnjOpiV2wcAYIR9+GReknO52XeW+qKDX7KzEfrmAChP1eWZM6E2Pe8VCs/UT7bOuETd/eUqTVL8ujsVqluDWgUr3nYWFGzNgF5HkoW/nI6BSewZlaRrV2QrU5+7RlJQ2PBpd7deLmOhtjoxROFSlMplKHn4A/mN2lupvtAn5fUyUQDvYwicdJFuhXhZaw8+UoO1OFc1rtLa2u+lzIUtbEWXtyY9zUe8albDf1vXn62C1oPSzNt6HtkDzS2STrSRynvgI9KPc36YLJvJmPetcZgUqDYpt6WOtXfAJvizxIUuJ2jz7WDxnXRbugr0Gm1m+TDR8AVAvuMvt+vSBYxTDhL0uphICKW0jPWrhTpJxmA8Vp2jFtXVZ+/+fK6/WM0Vz/XRhriufSU1F2rWbOtsuFXfZLzh01jqwNVB/DS5gdIhVYce+bPY2e iMFiHQc3 YUc3zzLXI63IDIRqlZxMRF3BIAdN0sTW7Vq9J0vLDx/xIaLh/tkkJE9MJHqVJ9HGBG4xMRyy7hGVKM60aYUeKxVDeqfBAP+ihM47vLGkC6hTku8hy+7ZaG+YF7nbRocUUqcGherD7yKTN418Q1FMbMwBjGF7U207g2XKD121kJEr+zZuGS3dtMEhPLOBWNVG83dqUhFxGWhhzjpATt4PFxTbw2oejW7GsYwqUw/1iyjr6eCUlXA386fplsUnZ7izrspC7Lx3JTSTSvd9JNqJ/y6tJv3LP1xzCR6jbnhGbHZ6yznmA8ch6rzlUwinmlabXntZQHwH8kc3D8NEKM+zhhf2lbE0UeGVOS3mrcstWhWqwYMFDWAK940zvddZgHHVuAGmdUojExsF3Brutcv1dmvxXDtjjcBVSObzyZiofacIWmLLuANqEyybPX9Ze/3GzplgtW8YAXj20Ng4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000419, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (23/10/24 16:45), Nhat Pham wrote: > > During a zswap store attempt, the compression algorithm could fail (for > e.g due to the page containing incompressible random data). This is not > tracked in any of existing zswap counters, making it hard to monitor for > and investigate. We have run into this problem several times in our > internal investigations on zswap store failures. > > This patch adds a dedicated debugfs counter for compression algorithm > failures. > > Signed-off-by: Nhat Pham FWIW, Reviewed-by: Sergey Senozhatsky