From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71014C0032E for ; Wed, 25 Oct 2023 21:48:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E23C48D0017; Wed, 25 Oct 2023 17:48:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD2DB8D0001; Wed, 25 Oct 2023 17:48:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9B888D0017; Wed, 25 Oct 2023 17:48:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B93C28D0001 for ; Wed, 25 Oct 2023 17:48:14 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7729980B04 for ; Wed, 25 Oct 2023 21:48:14 +0000 (UTC) X-FDA: 81385322508.19.490258C Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id 5651618000B for ; Wed, 25 Oct 2023 21:48:11 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=EGcnm8qa; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698270492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PIqdDI/0Rqxv/NH42ZIU0tgYbJ1SoPBcIaEiNAB/Np0=; b=WmZvjFXYzMWXC0CkIalj4+e4/QqaAXn1sxrLiMkdk0OTMqKV9EqzfHZDhWSO1Uw6jYu9hO LnJ8XCObprws/SCEOBt/PptRAlNhE0WYaDL2A9lS2wIv4YXA3P7quLimawM8NrUQO6Vj7f ADIUo/nnttSvHBwZoKI2UmdXtoyBVns= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=EGcnm8qa; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698270492; a=rsa-sha256; cv=none; b=j+99L40uo1eocqiwOaG3HUegxm53bAz7zXpbkU1nE1nAUqdEdvJ+ljI/btojIhh5eLgdYo K5XTZVJ5A6gzYnM2ugTJyADZzgAvUN013wyLRvWz9U1O2aSXf2ttTuWA5if5zEgtUjviyp vR+/2MT/ePs+FIW2sFAqYn1Gihk0WJo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E0423CE34F7; Wed, 25 Oct 2023 21:48:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4C10C433C7; Wed, 25 Oct 2023 21:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1698270487; bh=FivMY2UZEjYxUUisKcHog0hj9YelNqxTfva3B6Fv7W8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EGcnm8qaNwuS8KZJm/tL05RTzbs4uEVOWgI7qv8c8ygV5VynW6dZye1e0s/0KealV Xy0muOhCQ7qq2dN3Jh6wi5eazMXItrFhT+YHNc0QAfgBg3e6kjyDndOZve78/PeTzr sm4kR8kKiFdOE+BdDBcJ2czXWYpZ1tC12xV1EVI8= Date: Wed, 25 Oct 2023 14:48:06 -0700 From: Andrew Morton To: Haifeng Xu Cc: Michal Hocko , hannes@cmpxchg.org, roman.gushchin@linux.dev, shakeelb@google.com, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] memcg, oom: unmark under_oom after the oom killer is done Message-Id: <20231025144806.a10f34be15e564871861f698@linux-foundation.org> In-Reply-To: <1a8ee686-e416-466b-4f6d-1dd26212b360@shopee.com> References: <20230922070529.362202-1-haifeng.xu@shopee.com> <6b7af68c-2cfb-b789-4239-204be7c8ad7e@shopee.com> <94b7ed1d-9ca8-7d34-a0f4-c46bc995a3d2@shopee.com> <9b463e7e-4a89-f218-ec5c-7f6c16b685ea@shopee.com> <1a8ee686-e416-466b-4f6d-1dd26212b360@shopee.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5651618000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: zutnz7pkpfizzumyc3w7xk5qq69m7i3r X-HE-Tag: 1698270491-374956 X-HE-Meta: U2FsdGVkX19OJoV805emjt7yUnLV6Uk6DPveiQimOJtQoOPDxOYV1L3wirrJTRym76cUNwnnAdOHdkF1IuW1Wa11R8srlllRA3jFXbY4hQkNjMdgAb0Gl0O/ELVqHC60gHs2wR5xS1pDIx1zBbdyxZOfRH70Sa1NPYDguHhKj6aAbv59g4nKl8ZUxo/eveZeJEy21wKMUHMHOsy0M6dMfiGRyGdbNOiRUqG/kD5krjBiVeP6mfq+CtF1+UODjWjCUOLRVclSQTTJY+0Egquvy23HXG5sP8D0GdSjgS8wRYR3TEo70TGcDv22Ivp65AA99/vuvL5HCMy09Jbz3qh1AZzvv8MbR4PCEBNRYV45uN9Fv6mcDJ10zSv34lvMHGQEWfMhD44OoIrm9e5W1cl3voRQZPm55wrCxLiENhM8s6BeZ1Oqd8ivd4OWCQefdjjJ29n7LKAOVAVYtgzFxqyJV7goITuYfUoHPxn6nntywDXVtv6iVjTB5T4Vgvg2uP7ksWHJimajYtzI2CYiCCRUn5gkT2XElTkcrezgDJQKvGR2D7pluWaXq/rLU674zE3IPDaCipf+pFJ51LxKMI3wQBrWAYU6nr0PtHnbcHPmIRz4ELNJqNF2DRmRe4T8vokuGCdaZiKC2lrnWs2mknctSUxRDb1D/JtVbW5VwbN/0+h6ms6GXKhY+kKqWtKd4KXyyKVgPAD82m8iYYaK6UjPc2oHpq7k+L5Oypcj/Kqo6rN8yRI6IG0fxdjgup2bSP7jT9XlUTwHoBrHitUgwtKnNko217jX/tD7+GX3W/7R3N0BzCen6lurdpf8S9yHGZ08z0A+9l3rbkWledPaj9LgYDdfYxguJgAxxJzjSYj6/nBnRuA6CLPCECB6b+ZlqHcQNyIumVc4bFeRZzjKTMmFcv6DS9TX0oSWdnHcIdBLLwHFKVqbU7OnzltKChqANn3ghhXkzlmC6cphqiSB3v/ wfcIfQ6y QTz3d1zSFqnBxjCzuIO1v+MjoH+hLETJIL7VxdAe9RQMZX7VjamaShyxi2GLO9b7JjYT5SUcb8ZXk5M84zMmP3mbDEgWVAbHDhE+olWcuLMzl25i+UFCN/V3/iqeFc4f8Z5/DpxAmj68/anKt8ngAuevjevb2qmTLrvs07wetlJjrBaS+8C4ocwZnunOMK+bEPBLGyKvYoanwhyg5TK12JCu+fzMsr4BjBoeaAzt/NdegIl8WwaKQOBcKbjBkVzH7K6tejUu9nap17aauhmHQUDAv+ZYasnaiZKg/VL51bpO6fnghZTILvMg1qD85fCTRmMF7Vf0HvED9oko= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 11 Oct 2023 09:59:25 +0800 Haifeng Xu wrote: > > > On 2023/10/3 15:50, Michal Hocko wrote: > > On Thu 28-09-23 11:03:23, Haifeng Xu wrote: > > [...] > >>>> for example, we want to run processes in the group but those parametes related to > >>>> memory allocation is hard to decide, so use the notifications to inform us that we > >>>> need to adjust the paramters automatically and we don't need to create the new processes > >>>> manually. > >>> > >>> I do understand that but OOM is just way too late to tune anything > >>> upon. Cgroup v2 has a notion of high limit which can throttle memory > >>> allocations way before the hard limit is set and this along with PSI > >>> metrics could give you a much better insight on the memory pressure > >>> in a memcg. > >>> > >> > >> Thank you for your suggestion. We will try to use memory.high instead. > > > > OK, is the patch still required? > Yes > As I've said I am not strongly opposed, I'm confused. You (Haifeng Xu) are looking at using memory.high for your requirement, yet you believe that this patch is still required? This seems contradictory. Oh well. I think I'll drop this patch for now. If you believe that kernel changes are still required, please propose something for 6.7-rcX.