From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61EDCC25B47 for ; Wed, 25 Oct 2023 14:40:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F053C6B0323; Wed, 25 Oct 2023 10:40:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB53F6B0326; Wed, 25 Oct 2023 10:40:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7D716B0327; Wed, 25 Oct 2023 10:40:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CA6DF6B0323 for ; Wed, 25 Oct 2023 10:40:09 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id ABD1F1A062F for ; Wed, 25 Oct 2023 14:40:09 +0000 (UTC) X-FDA: 81384243738.22.1A4E7BB Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf28.hostedemail.com (Postfix) with ESMTP id 5E6C4C0004 for ; Wed, 25 Oct 2023 14:40:06 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=eSOBcTG6; spf=pass (imf28.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698244808; a=rsa-sha256; cv=none; b=zL0Vs07y3TPmMkvcN3oZ1tHhD8LTYSNRvu5eDgMlWtvv+EEj/1p2LRKW013Vi9bCtwcXZ2 JQCPh1XatD1Yres5hzZGxpF/5W8yCqZBO8QcEZr2holeFcxPLkdAU9i4SqmC3O5JFKRDbp 1KCnN5Ijm2rBEGyEANca+NS71ozgLTk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=eSOBcTG6; spf=pass (imf28.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698244808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bld5a7dn+O1a0B1xG/X1BMi6vOdcvGLRb0eDwV/qxMI=; b=sIGDj3nZsulSRcEAq65gZkY3/PvSRgT47OGrtvyNKolCz9CkSDWARt1inxgaPZtOVB6hWS zBJDD3zOMet+fA6S1CtpVOo3Dyfjvn1EKlYo1AB3PplMxl5BL9NJROWrvdnPqWDWeFX8+Q fTIL6fZap88bHxSoXWBg/icv6rZFC88= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6AE10CE2ADE; Wed, 25 Oct 2023 14:40:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B53EC433C8; Wed, 25 Oct 2023 14:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698244802; bh=ZsyjdxTVs6itWoN60CajWTBiY55Mxf69XVsG6IddPiw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eSOBcTG6fmO/7Y94SFHz5tQHb29xFHidQPzjKqkf7U374cJqty9/mU48GewklkUou UCaKC2JOK3OnsiAAH5O1UMNDS7nRI2sGnB1PWUx/ztQlkLePEmatJKtfnSApZdcgRv JlI9saS06zcFPKUPQT28UPj2Dugk5uWD6VClw/Bu7h+U2x+SSKNwom3NlaPHC+bHzJ m6lJbrgEkF4DbVF/QtHGmMTGcEArPl5onx4KvDK8aAWXNEvoVtZ/xUU5CIG1jIysqe Sqy7UwwmNY6aGLBr/4PWVjl/WQNEDCqVywfzfcoQJhy63Cja+eDDcU6ykUB4IVzPgp DCNJDNDQM0hrg== Date: Wed, 25 Oct 2023 07:40:02 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Jens Axboe , Matthew Wilcox , Ilya Dryomov , Andrew Morton , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/4] xfs: respect the stable writes flag on the RT device Message-ID: <20231025144002.GD3195650@frogsfrogsfrogs> References: <20231025141020.192413-1-hch@lst.de> <20231025141020.192413-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025141020.192413-5-hch@lst.de> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5E6C4C0004 X-Stat-Signature: hhngkp9mzdj6wprhpdu81ua3k5ca861g X-Rspam-User: X-HE-Tag: 1698244806-282736 X-HE-Meta: U2FsdGVkX1/zFg473Y25H+gnoOR+uwm5+jCrb3MjwtESsFPplM/gBbs5WCHfipLhUyQMRhDGaEwriLzNqKmiEYYARkReVwha6+pFuCpqv/MLoZNNaa0o726onuwnBTi1aCtjGonRqNBNCfO8o2839DuZLVxYe7W3j6oUsuC1JJyIGT57X065um03PIbrhfYmjoYDma/tOiBesy8hDmv0eSzfbJOHXS+vVu7EoTdYYgGVB1dKbVKSDT9oh9/54abfG4DdqI9CuPrbrs2I0URZJE7n5vyvp2WSM945bdcj1Wd57NOXWsGoQHx39/eWavJLZu3eCLERf+UwP1lGa7PDmsPVtsbB7JZbEGqOC8UJ6o7go1rRdOl5fBXckQmEfvoJLs+DS9pHTChxBZAqxheIf0pk2Efv+BEhNfYw+mHgLnAZkCwjXmrfLYOIk6G8pNFwSQxojdmxOMiiR4rIl9/mwVYtTxuR2M47fkaVaWJvaSdGDvMM/U5J2vuFWQq7dq2+BCYWvaEEKXzai/ZIaZr02t6GMGewR6ZPHq6cACnZCC7Qqp4kdiv0KyXqBjIhGw4QXaMVtVspQgUxobOPQ7kTm4KIquMYIxmeja1pzs7Genv5vJoiHlAGc8UHABgLZUyr9Jp7vtgoQqb9A2rzKlJA7v/qKeGIRzMgbChosIhoAdiwH42uEwfyPMWhOpYB7Gq/DQV12yrsdo9IRuYMX74k3+bLKetS/B4+lLCfu62AZrLTIMKaXacnSrZJvtotsNFrsVN67evOYJay11lgIpz9zyjSS5g3ph/V3q98+MpRRdQSbzgU78v6aF/oPGV4UzADt1F6QC8EMNB1ikGAuxbH3i2QQ2jy7bxSdKIzZXMwUl9Ig5yCS9MPMpjmSM/tFS3QVnws/XXI5t56cpKyGiEyvVDawa7o1wiRtreyzjVuRvRbkyEUtscoifYd1NwvogE88VhFP4bX7/RnjTLf+8r FTiVu26A 1tBErcRwbLGdmBQWL8GuJU5GjZQGL8A1UjeBPdebnnZ6ilvqvK6tHcJmGTvOKX4BVSQ0nfQS5S37BXA4yE+LiBQ9x6KDwr0Fs8DxJqY2IcZyaC6y9l+A9en6OuSzbbqsfSJTkgGXJYCn4O/d5lrif3ksDzt9vZX9aywd02hXo40GxKk2wJAGEPY6mgNM+iTOdwnGVNGcFvdzXfmwG+EKFD/bY7baWyoYqAJbWhWvaVA7LvGQwhvI4K1auiA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 25, 2023 at 04:10:20PM +0200, Christoph Hellwig wrote: > Update the per-folio stable writes flag dependening on which device an > inode resides on. > > Signed-off-by: Christoph Hellwig Looks good now, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_inode.h | 8 ++++++++ > fs/xfs/xfs_ioctl.c | 8 ++++++++ > fs/xfs/xfs_iops.c | 7 +++++++ > 3 files changed, 23 insertions(+) > > diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h > index 0c5bdb91152e1c..682959c8f78cb0 100644 > --- a/fs/xfs/xfs_inode.h > +++ b/fs/xfs/xfs_inode.h > @@ -561,6 +561,14 @@ extern void xfs_setup_inode(struct xfs_inode *ip); > extern void xfs_setup_iops(struct xfs_inode *ip); > extern void xfs_diflags_to_iflags(struct xfs_inode *ip, bool init); > > +static inline void xfs_update_stable_writes(struct xfs_inode *ip) > +{ > + if (bdev_stable_writes(xfs_inode_buftarg(ip)->bt_bdev)) > + mapping_set_stable_writes(VFS_I(ip)->i_mapping); > + else > + mapping_clear_stable_writes(VFS_I(ip)->i_mapping); > +} > + > /* > * When setting up a newly allocated inode, we need to call > * xfs_finish_inode_setup() once the inode is fully instantiated at > diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c > index be69e7be713e5c..535f6d38cdb540 100644 > --- a/fs/xfs/xfs_ioctl.c > +++ b/fs/xfs/xfs_ioctl.c > @@ -1149,6 +1149,14 @@ xfs_ioctl_setattr_xflags( > ip->i_diflags2 = i_flags2; > > xfs_diflags_to_iflags(ip, false); > + > + /* > + * Make the stable writes flag match that of the device the inode > + * resides on when flipping the RT flag. > + */ > + if (rtflag != XFS_IS_REALTIME_INODE(ip) && S_ISREG(VFS_I(ip)->i_mode)) > + xfs_update_stable_writes(ip); > + > xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG); > xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE); > XFS_STATS_INC(mp, xs_ig_attrchg); > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index 2b3b05c28e9e48..b8ec045708c318 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -1298,6 +1298,13 @@ xfs_setup_inode( > gfp_mask = mapping_gfp_mask(inode->i_mapping); > mapping_set_gfp_mask(inode->i_mapping, (gfp_mask & ~(__GFP_FS))); > > + /* > + * For real-time inodes update the stable write flags to that of the RT > + * device instead of the data device. > + */ > + if (S_ISREG(inode->i_mode) && XFS_IS_REALTIME_INODE(ip)) > + xfs_update_stable_writes(ip); > + > /* > * If there is no attribute fork no ACL can exist on this inode, > * and it can't have any file capabilities attached to it either. > -- > 2.39.2 >