From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4114EC00A8F for ; Tue, 24 Oct 2023 15:02:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C64406B00FE; Tue, 24 Oct 2023 11:02:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C140D6B011E; Tue, 24 Oct 2023 11:02:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B04506B0120; Tue, 24 Oct 2023 11:02:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A0A1D6B00FE for ; Tue, 24 Oct 2023 11:02:07 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 72AD114031D for ; Tue, 24 Oct 2023 15:02:07 +0000 (UTC) X-FDA: 81380670294.27.90346D8 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf02.hostedemail.com (Postfix) with ESMTP id 3A4AE800B5 for ; Tue, 24 Oct 2023 15:01:47 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KktcCfct; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698159708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2mCYXgdWIH++8QZAlGWHdswttPh87Emfc0Wd+Hlsklo=; b=Y40q1MHg1t11sJ5acpYi/dY48gjkDpH0zLs6TKT3CweVYaF+rZQNI9Jk8vda5pnlT7668t o0k7HcoQVjiJpaQxIlA3JQk1qUYaO4ylZM/HjaIuIHnVJMfP4ZstglUXJjbvMtJ3IGUgcJ kdLKUInVuR5Wvdo+90YgL2cPb2b0Z9I= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KktcCfct; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698159708; a=rsa-sha256; cv=none; b=e+phKr51N/C0z1IMlwPbmYaEkwawYNaS8HokHQbE6lqFzkpldIHxVplgPddlqUDuu6kT22 M8s/8NQMEePoESGfSkdx6ac2XtNe0LrwoTLJx7hNb9/sPs/AcRNcvGa6c9L+yg5fsoy5lZ zxZtGltGdgoEemNP5I/hJYpPFjfWmHI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 0F544CE2C35; Tue, 24 Oct 2023 15:01:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCA60C433C7; Tue, 24 Oct 2023 15:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698159702; bh=1pZsvfNqaW8uD8hkD8AmBgpUOr49aKiJeiOe+uJEpVk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KktcCfctLPQhL+IMb6wsd/xVbuB4Q7Z5eQOmT1zrSH7h1ipk5I8vl04BNqcrZgGvX 6p2KXUL1xZti/clWXXm44msXQxCjZyJMiyQc4KOQ0XS1P5CIDWnGLtULiZE4Ff3hny y+neJtJ7/4YisAEb+ijlwPXXhNf/x+ZskCQEjvgOvC7u2z0XZOswGyoa216htHBczY ZMI9pt0ayZWV2vdpSGrgkuxhZoNaeZK6L8fhLcMTvxtXa+O1stF0RItZ8EjGsV+f+I Vw4dqX6JTWlq61EQJiskayVfnapJeRuLWVoKP5vHaOyt0O80BPCgoxs9iUOBqHhtX4 fElkE/WbP55Xw== Date: Tue, 24 Oct 2023 08:01:42 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Jens Axboe , Matthew Wilcox , Ilya Dryomov , Andrew Morton , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/3] block: update the stable_writes flag in bdev_add Message-ID: <20231024150142.GZ3195650@frogsfrogsfrogs> References: <20231024064416.897956-1-hch@lst.de> <20231024064416.897956-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231024064416.897956-3-hch@lst.de> X-Rspamd-Queue-Id: 3A4AE800B5 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: tk1tswpnmh1ixi7gt993a9yoous3at88 X-HE-Tag: 1698159707-960904 X-HE-Meta: U2FsdGVkX18cQrpwHuHp9/idmaa2ynKMkNRSjzQu7J6T+jM7teWdKCAMBZaP9s27EPCBTjoNGN5N7U78d8D+gW94AVTiBvhBiP/8eGae/o14zCgEnnEY7zPVkF20x9ILnV4Pm9JtlfEDaNnINKjewDr9eO3UmNGqZLcr3b9OmXWts09leLJ0+044aj6SmV9o1U8XxziZe8YeOpopiApHb3LX1HTUTklJ9spjqI/Ina8pjuhvruShIBk//wPiMO83XcQ/3M9C7wGrLGDowVML42jW0uKNgQ08967mBflryM9fu6IvNSw2GC6o63cMhzdIDxkTO+FpLwx9+Cvqa7RdkIJF2hpb6pihfhCeO1+Ix6gEOeMJcoPId3+Cd/42ThziLiPkkY8T+/bB9tdGGNjJLNPbPN1AhiYka9WYtgl+NtxeH2PYw3QBpdY5lC0wyHfc1mYUogX415XOQvlQKPsX8lKUVvAUim3yTlQChS0VXxusMQh5Wx6D8yPgqIYiYsFI1PajSCwsTXH5MLEjHiw5tUG3GPnX0wjjQwMj2imnB2b5sHeg+vw0+HzpLdLU+J+vDem5eRZ2ObKpAhdU9qMV0yry4oyVmyADWjY2h01ZatGgnEZMCTC2fpXi7Y0r0H1kB0+A9CsutfEOsCuShOlNuqzEbtlaSKf70NmcnqZRG6nfCpfsNs/JmJMH1EFpuVK/+Roqhot8YFX7lu6NvsrNVMwRzLSsyxj2QS7pfGlUbCPqWTPOwrSf5kZ2fN0V/dZOSMSPXn0kIolvstDz17LSOjFYJrb8+8vBuNXrOk5cRQn/9IkWOCSKf00BcLqP4ICmoQA/pS78SgzTKyG2ZA8mmkYWjhJYetf5n6GKocCflXEhab1ZbTBBhSptZoahC33SGho9hS6jSXkvehUUAVQYv/Css9cMDRC4rGK2t7fvk3oaGEsMrj25YdqQLRWywWj92iChlDwVzldxtP4Ugz8 ADogVrwt XuVAl4VMuFb02POBOukKinvYZn7hZ0wEjOXB3FDZv5koimnis1WhzRxfVAQdiTHe0DVj4GgEyTHval7BRdiirkGicUq4PUSfDHbD4wrOfhJtAw856RE1vyLo4JYqbANq6lafdUxdasTpuVGnOOALWT4HIbigucx5UYjBFFdCBMK9YXQEKxTaOW63PIlp2UC/WLaG7ghwB8qwH5H+m0op8Ab6rukULPALrm9iEh991z5PP9gYFk1XA4VuHuztNQgxbujvUZmzvpOw25PFukTqLrkBw0cV5Hl/vxpSmllx6rdwdnY3Q5e8MXiMDgw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 24, 2023 at 08:44:15AM +0200, Christoph Hellwig wrote: > Propagate the per-queue stable_write flags into each bdev inode in bdev_add. > This makes sure devices that require stable writes have it set for I/O > on the block device node as well. > > Note that this doesn't cover the case of a flag changing on a live device > yet. We should handle that as well, but I plan to cover it as part of a > more general rework of how changing runtime paramters on block devices > works. Yessssssssss! :) > Fixes: 1cb039f3dc16 ("bdi: replace BDI_CAP_STABLE_WRITES with a queue and a sb flag") > Reported-by: Ilya Dryomov > Signed-off-by: Christoph Hellwig Seems sane to me, Reviewed-by: Darrick J. Wong --D > --- > block/bdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/block/bdev.c b/block/bdev.c > index f3b13aa1b7d428..04dba25b0019eb 100644 > --- a/block/bdev.c > +++ b/block/bdev.c > @@ -425,6 +425,8 @@ void bdev_set_nr_sectors(struct block_device *bdev, sector_t sectors) > > void bdev_add(struct block_device *bdev, dev_t dev) > { > + if (bdev_stable_writes(bdev)) > + mapping_set_stable_writes(bdev->bd_inode->i_mapping); > bdev->bd_dev = dev; > bdev->bd_inode->i_rdev = dev; > bdev->bd_inode->i_ino = dev; > -- > 2.39.2 >