From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06820C07545 for ; Tue, 24 Oct 2023 10:03:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 829446B0209; Tue, 24 Oct 2023 06:03:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D95E6B020A; Tue, 24 Oct 2023 06:03:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C8C86B020B; Tue, 24 Oct 2023 06:03:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5E2B56B0209 for ; Tue, 24 Oct 2023 06:03:24 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1CC65B629A for ; Tue, 24 Oct 2023 10:03:24 +0000 (UTC) X-FDA: 81379917528.27.4C18EDE Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf03.hostedemail.com (Postfix) with ESMTP id E3DAE20006 for ; Tue, 24 Oct 2023 10:03:21 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fTe5JwqZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lu8wohMT; dmarc=none; spf=pass (imf03.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698141802; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fd1uUtLWVCbrf8y0Y5fzHoEuPomC3eJzUI1A7frlr0k=; b=70DcDwSlt1to1Bm8uzjfjN940PhsmUGHei33k2b/1I5ICKiJX+hwR+VY9CL9FhxV57txfB vlKUamrcB47N8ayYfEm7Vp/fGHdqENHK28bPJp6Vb1kDhisY9ScPPVBdQR6nse/e2QtDrJ ar82/E+ufchvGcPxSOIhX0yEzp+SYa4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fTe5JwqZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lu8wohMT; dmarc=none; spf=pass (imf03.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698141802; a=rsa-sha256; cv=none; b=DExM9xyBEGQHnN8nXiYOY/c78QdsmutOvKRvSWwExLrCXUZCoIXcPPrKoQQJqAJNDsAXZx rGPCwgGa3NStTFe0zcSiVqoyIMaPqD9Q8IMrq3tVJEux8uHKU44+BeU577iLlUWav3yl1s KNWlzomz0tZirjxE53fkX2BBsOEgAEM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3BDC61FD71; Tue, 24 Oct 2023 10:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1698141799; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fd1uUtLWVCbrf8y0Y5fzHoEuPomC3eJzUI1A7frlr0k=; b=fTe5JwqZApsvVOwBvi/bUvWfqL8S/Y3kpoaBcpJHKymvKS6ByF5Y0kEb/MJ4Z3AmMw+N+U 81AKCJBzLg5vth28OzYeD3CxRLIsHXbeexfVbgTfabGx4/5pSof0w2b8RNrRjCIV9F6Myn JU59VeDBqKpjQKjZt5+OIIqLOV18BPw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1698141799; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fd1uUtLWVCbrf8y0Y5fzHoEuPomC3eJzUI1A7frlr0k=; b=lu8wohMTf9sRWi3q/EUd7SnoZluEEDtz4L6+yEoGOwFq5AFryjFZUATjzMpPOBvANypAj6 ueeB8HNfQKUTJ/Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2D601134F5; Tue, 24 Oct 2023 10:03:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bgINC2eWN2UrGQAAMHmgww (envelope-from ); Tue, 24 Oct 2023 10:03:19 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id AD60DA05BC; Tue, 24 Oct 2023 12:03:18 +0200 (CEST) Date: Tue, 24 Oct 2023 12:03:18 +0200 From: Jan Kara To: Hugh Dickins Cc: Andrew Morton , Matthew Wilcox , Hui Zhu , Jan Kara , Theodore Ts'o , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] ext4: add __GFP_NOWARN to GFP_NOWAIT in readahead Message-ID: <20231024100318.muhq5omspyegli4c@quack3> References: <7bc6ad16-9a4d-dd90-202e-47d6cbb5a136@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7bc6ad16-9a4d-dd90-202e-47d6cbb5a136@google.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E3DAE20006 X-Stat-Signature: 4y78qtbk8xmzkr7do14tyuowonzz6xt1 X-HE-Tag: 1698141801-112031 X-HE-Meta: U2FsdGVkX1/pAfQhlBhgx2KAB+k0WH98g+d9E7FbpEKIL76647DctxVO8PWZTHWvZpSqNni0t6uFg8f+QnevwC8Oi4TdQzr0GqM4VtMR/XupHA7aBZoQmvwQoH7IgnyeSt3TIuGlXON4HVWPFTdgTszxtfBo25Cn1YnjX69SG+kzC0KkefiOFMa7K2CkY2yknO85hEYjhWc+oKIQvkG6EQfv5lytPpkZBZt1a610CH0LVT6fxvdq2EFuL0MyY9QDlFuNntZPpa9ziTcEktrBOHkBaHZ7DJHGIEPzaCNWL/530+WrzGkRlaelKD0opEtmpLY4PJ0b0PWmrDJHfAfabm8B1nBLGIlU4j8pr/BWdnU3mjWgNlCtdVCi6fwtERe/0A0G/QftMCs20aGrb3RcyqREW0rVT2K8H/Vdh0lJj15eOKlBVKQfG7omkoQvXbPtW3tlX8kaYaBNpzLKtYwNxzGK2AD37eKCgv0MC3M7s1EkO/FEcDWUhkoibf0G3jEWB3yxh/XlclcNbjwjgNnDLxQJD9aflurbbFFIpxXI9lF2d2lrNqB3u8YSZn0027jyjWj8k/LoUS9y27tL5fdUCchl9AQx8F5Zlv/buZgKqK1TE4+165a6aTLqrflHSjXpLdwm+MdIU/nZU+GdHFZOSBc8Pv8AnSuXs4IBekpyXnSDDC9SzrfvAJIqT8p+K/H5JvBu/3w6uv9ge8H9tjMZbeg6h75W7oSDmxw8qa3eM7e7g4jsCx92BfhLazbycLj4kvXcfJpAp1MjfYYodf+XyjjHjRS7oKVUsvfIlwIO0pUegL9iHx2BuxeY6bZtpyfSSVNfT2dbY53e4DzTMOYHDCHyDkul3lTKTlIeUGbINiRtIVLic0As/D3uoYeZPPEb/a1KUUgiKFj8e6rb7T5SskB3j/kC98JaAwKCxEt6JCh8HeLn/iAJjjUmAl5JQi0KddNMGniD9XjkGf0ku1K 4k+PjHxZ fN469nplKAFhUrCR7/R0TR0ReEoCijTxfCkAhyj6bmTeiv32ExFo0y6HV8bcTM7JZSwLffTLOp2y6uR2MiBa3xqCgfh/JflQKY9EmqsxmeQFTLBMqsIaOIS+8JfYa5SAN2e6TuEKqvOFBc5dWmXHIulaOznHOIo013WyAwWStOale2Fkn8LQ9Zd35C51dkuqsOrJJPEgeTWNKhcY9Rxnub7ofrDkGuHRVPkphkWY8fHz8Hn4kP1g45FtmkgvFmyZWm7h0U7pIVShTzcC20CCzjVgCsI0CcsozUR4bUY2GbyaacS/Jzz12uJrMeZu0oE9xTaiW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 23-10-23 23:26:08, Hugh Dickins wrote: > Since mm-hotfixes-stable commit e509ad4d77e6 ("ext4: use bdev_getblk() to > avoid memory reclaim in readahead path") rightly replaced GFP_NOFAIL > allocations by GFP_NOWAIT allocations, I've occasionally been seeing > "page allocation failure: order:0" warnings under load: all with > ext4_sb_breadahead_unmovable() in the stack. I don't think those > warnings are of any interest: suppress them with __GFP_NOWARN. > > Fixes: e509ad4d77e6 ("ext4: use bdev_getblk() to avoid memory reclaim in readahead path") > Signed-off-by: Hugh Dickins Yeah, makes sense. Just the commit you mention isn't upstream yet so I'm not sure whether the commit hash is stable. I guess something for Andrew to figure out. In any case feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/ext4/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index c00ec159dea5..56a08fc5c5d5 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -262,7 +262,7 @@ struct buffer_head *ext4_sb_bread_unmovable(struct super_block *sb, > void ext4_sb_breadahead_unmovable(struct super_block *sb, sector_t block) > { > struct buffer_head *bh = bdev_getblk(sb->s_bdev, block, > - sb->s_blocksize, GFP_NOWAIT); > + sb->s_blocksize, GFP_NOWAIT | __GFP_NOWARN); > > if (likely(bh)) { > if (trylock_buffer(bh)) > -- > 2.35.3 > -- Jan Kara SUSE Labs, CR