From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E057AC25B48 for ; Tue, 24 Oct 2023 14:53:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D2FB6B02B0; Tue, 24 Oct 2023 10:53:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35C496B02B3; Tue, 24 Oct 2023 10:53:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 223BE6B02B4; Tue, 24 Oct 2023 10:53:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 107A66B02B0 for ; Tue, 24 Oct 2023 10:53:51 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E518AA0324 for ; Tue, 24 Oct 2023 14:53:50 +0000 (UTC) X-FDA: 81380649420.25.9047D1D Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf27.hostedemail.com (Postfix) with ESMTP id A89194000D for ; Tue, 24 Oct 2023 14:53:48 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=CXhWXThu; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698159229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2aCBahLET1aN/DJtwOBoNeWzNfIk2eqWCDD4u+/6DzU=; b=cUH4rHYALKqhJE+NazANFoFQ7EnMD07okrV5xXcQr5iizN8sSfj2zvWZouiglcZp6nZksg 6krbryY9sW/05evB+D4Msn3KUrDiN4uw5Fcrd+ZZoUkV/6X4wD1wwoV9W+k14cthvVegse O0u/ZVKL+5OvIgyHtzJRO0BLmbgyQv4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698159229; a=rsa-sha256; cv=none; b=ZKiFnbG5GqaFJgaxPaTE+9AWCCDeiG56NGXRkPyfic0JL6S9yRolGbGVk75mF6V0XuOkqv 5yi0HiWsLOxKl8o/T2R7X/UhhFZxrzgOg3Rtdg7UPxLwn+ltLTMFCuj2HrNlRNynSFQJxt F1nOetdtsqTL/Q0psf85fChyVMVE3N4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=CXhWXThu; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1C022CE2073; Tue, 24 Oct 2023 14:53:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2C25C433C8; Tue, 24 Oct 2023 14:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1698159224; bh=lUFQ3v5CpOWCmK337y0OntuNv8kN0NqIfQIZ92fiWus=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CXhWXThuIDw9jKycAqBYeGO1zaSDEwHFFDU85loiH8gAoxWw5SqknD3YVaoS6JGqU a1ThKCAQvYu0jUzy/7hHQ98oDaBztYtGaw1pGrb/aydcCO8bgK3ABc+ILTZuZ0AZd8 baKcazGQMt5RFzuENhwcElOglBDCbiCPld9XGvQA= Date: Tue, 24 Oct 2023 07:53:43 -0700 From: Andrew Morton To: Jan Kara Cc: Hugh Dickins , Matthew Wilcox , Hui Zhu , Theodore Ts'o , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] ext4: add __GFP_NOWARN to GFP_NOWAIT in readahead Message-Id: <20231024075343.e5f0bd0d99962a4f0e32d1a0@linux-foundation.org> In-Reply-To: <20231024100318.muhq5omspyegli4c@quack3> References: <7bc6ad16-9a4d-dd90-202e-47d6cbb5a136@google.com> <20231024100318.muhq5omspyegli4c@quack3> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A89194000D X-Rspam-User: X-Stat-Signature: 3ekeiuhor5fbjewmiodfsuqfdtezgqjp X-Rspamd-Server: rspam03 X-HE-Tag: 1698159228-990077 X-HE-Meta: U2FsdGVkX18uZxndDJr/uW0ldiCJRclOVy6NohJnK6u/3gwSpnfEp5CXXfu+anOtKBkEvx5sZl5kazZga+MvISuLwV+j5jFgF03OAPDiafgYC7/t5GuKL6VZOdWlsLxreMPEP/aXn1kL+rO3p4WD9+tJMh7O18jOIADftf3ZUjkufeccCxJof8094UFDxZV1z/ksWCZcZPnPmQDrhgKsDVQjDk7CRkjcPhP05SNWf6e3d0+oZl3GzRZZea7F8J5C53fh7KZY1w6UfyOBy9nkmT2EIgdZR9cSdR17QgRq9lex3wvUXRh1B/LW6VfGb61KTgcF+rFP5Z4574WftCjy04ZDNqKN6u9d1oItILML3YZaEyDTU05TaGRpezUsWMzFfXziVbbohzJSt/A8tvXWKa3AqMCFnRrY4MKbaL9bMqUErJZZpPgSNxmfLg2DSW9Jtlz/ZOa+BWmrB0wdfkrHHkVPY55Uzvldixl77vhdMge3vbOS4UM3pqN9qnaYguQW/UHdx/BPue2ipt9XjBwbqkhP3o/BwE8gnlGzNHJgc4OFHieDRJRQ4fnmggXTNCZALbv9nFbERXreXURTIGPBiXUnX9mp2w7rpziVPO6psmD1ZUJEXNgvXlQ/n0g1vO/8YFZSDPpSzXWMvSXTYyGf0eLGC8DdYwBE14wdGvZ4wj5ml1I5o4zJLy+SXh1IePPYh3/LWp6okEn/RhcQQMqOlMyyUTpTM9cwo7gvpFTa76hFg5W5TJ2r3IggLXULjdnUQs834m94EPzT+acY9kjWO0JFNsVmJbMiAUm0MiZP+HUb7O7FyV5kYsU4Uuaj3qM8csSxhc++8np7V2++Sp5CeAu8azeusW4ZJOntA0QWrFHIxAkHc0y0SSwgkDUZY1QYzP9nwATjAqoAIejApkREwrgmQz0/GJ+03VtzS5wdjk730tfYNZvE6fPqtr+ivhZgnZ6kH47Et46d69/bDRt Jg7JGpXs /lytueG/FQG5f7aem/rKsEV0QYSlbz1pXjrPmpQQQFmmHQIi1FnIVhfb5p8sDPy5Q0THOHZRpO8wKZ+0DipK0FscKX9wkvZCU+jzK+DMkY5SnAz7m4r8sS024+U6Ux+ZxT/Y2j0NprhEjmFMN+zWygMcyccxeALh/tnxbbGMKtg6JKoDunOX8gLCCCyBx8j9bhKKSzGU8CB0yei2aEk8YIsPMSIz5z+3wrc0sXkiz2xBcmgfsOV0ZmLgnqy2Qzz1G98y3m+mxgx/SujglH3Bf5kWKP6OFLXSuqCyCTKV3ty5V5Yk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 24 Oct 2023 12:03:18 +0200 Jan Kara wrote: > On Mon 23-10-23 23:26:08, Hugh Dickins wrote: > > Since mm-hotfixes-stable commit e509ad4d77e6 ("ext4: use bdev_getblk() to > > avoid memory reclaim in readahead path") rightly replaced GFP_NOFAIL > > allocations by GFP_NOWAIT allocations, I've occasionally been seeing > > "page allocation failure: order:0" warnings under load: all with > > ext4_sb_breadahead_unmovable() in the stack. I don't think those > > warnings are of any interest: suppress them with __GFP_NOWARN. > > > > Fixes: e509ad4d77e6 ("ext4: use bdev_getblk() to avoid memory reclaim in readahead path") > > Signed-off-by: Hugh Dickins > > Yeah, makes sense. Just the commit you mention isn't upstream yet so I'm > not sure whether the commit hash is stable. e509ad4d77e6 is actually in mm-stable so yes, the hash should be stable.