From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98264C25B46 for ; Mon, 23 Oct 2023 19:06:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 142016B0153; Mon, 23 Oct 2023 15:06:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F2A56B0154; Mon, 23 Oct 2023 15:06:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F22EF6B0155; Mon, 23 Oct 2023 15:05:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E40C36B0153 for ; Mon, 23 Oct 2023 15:05:59 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B77B240AE3 for ; Mon, 23 Oct 2023 19:05:59 +0000 (UTC) X-FDA: 81377656038.13.02885A9 Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) by imf05.hostedemail.com (Postfix) with ESMTP id 9FAD610001B for ; Mon, 23 Oct 2023 19:05:57 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=QdWeswfC; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.161.53 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698087958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FJT4jfY3CvkrAsPNDoMHVpWpbleU6NBvUL9f6Zwuc+E=; b=FHRyGywCfvISsevav94z6KZs9H2ZXviMWRk493WGQc8bdefv9EHS61xGFO+vYQoJSdeBZW M3nKnFgPhmi7x2vRujZVv9CKrFr6e4JDkdj5E9fWipAiqdN1jgSr4ikho/FdNic4LuKBU2 WPK/S1uzjSdyt0YYHEEllCzQlHzxPo0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=QdWeswfC; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.161.53 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698087958; a=rsa-sha256; cv=none; b=g6VRW5DeOJ8MXz0mRMEcbS7sDwmR01DdqL2pVSKQPyVe1uDKEO5clwL2JF1COA3afpto8s PyIqBhjWR8Xus/Y7yoytj94krul56y8lEv9AeO76UnxRRwQUtLpHrOwFaiD8MfEmRrh4/9 gptlgWm2OlSz5JhP5mzBqhicNd7jgAw= Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-581de3e691dso2177605eaf.3 for ; Mon, 23 Oct 2023 12:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1698087956; x=1698692756; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FJT4jfY3CvkrAsPNDoMHVpWpbleU6NBvUL9f6Zwuc+E=; b=QdWeswfCZo4HOvf3UH2s0QAvjl299Su/RpgIYgH/xLGsQpLQZCCgTK+1i94PJ9i/cM bIjSdsh8hGfaM640UCs6RvdePQkLCAf+3Mk2xjolERJ1RXw7gX1B6ogBrj8ZJ3ru7BJR x+qA1wM/8VYoUMf46r4NRhDXkWAxyxRhkBQNS35POBwppHsrcxgH3leVuncgRWFpNph6 VKPFHg671757ra9DN+I0fEHTFSajTvchAEkI1E1mukKB8IC6wYKBJ+ayFO8IXC+U1xOC SiHKdzzIMGD8Eqw9BionIXV3/aXpiF/UhBN9eiDoMSDyC/h1ZYPI99Pp+ba3mhySRBwj tnDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698087956; x=1698692756; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FJT4jfY3CvkrAsPNDoMHVpWpbleU6NBvUL9f6Zwuc+E=; b=bWqOh8AVWqtp98em3zbrBt33QnBo4iW7SD66jM33y7o/KnPQencYltQ/wilRdHmPEb fx56xYqVXSKvMg3YmBMFki/YU89+I7CTlXzUdMcxuNGBPP85xyEA6NlNmwGbOmRKovkz DAUxYJGpbPEh0RtOV3ikPXfpdG2fJWbVzGCqlbOQvo/ngeIBeHmi/cVjQzs97QYGOfkU 7eg/e8EPsdnyCLNWEWdQfci1okfj/Gec2mbXyn/GQ7f0a+r2fRXQOvjBTa2+G0/X66tk iEmvaQ06uprygqLX2bPpSfxaGPvhTsaLXdm8OkWiitruLDVKNGYkRIJL6OeDI9w9S19j l2qw== X-Gm-Message-State: AOJu0Yx/3JlNV4fHZYFBv1SgeDy0tkirlXpelaTOQPclTPR3oXVS1qiM aXATg+csDPLJWpD5e7Ow/yQgcA== X-Google-Smtp-Source: AGHT+IErO3ABVE+c36xRgbzOY401WH0mzlzh5jiHlM3x2w/kFEwmNdKfxp8iD//AwWm+/PfcZ8BwOQ== X-Received: by 2002:a05:6359:1a44:b0:168:d1ba:e3c8 with SMTP id ru4-20020a0563591a4400b00168d1bae3c8mr6159850rwb.19.1698087956589; Mon, 23 Oct 2023 12:05:56 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:f369]) by smtp.gmail.com with ESMTPSA id jy12-20020a0562142b4c00b0065823d20381sm3074118qvb.8.2023.10.23.12.05.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 12:05:56 -0700 (PDT) Date: Mon, 23 Oct 2023 15:05:55 -0400 From: Johannes Weiner To: domenico cerasuolo Cc: Andrew Morton , Hugh Dickins , Andi Kleen , Christoph Lameter , Matthew Wilcox , Mike Kravetz , David Hildenbrand , Suren Baghdasaryan , Yang Shi , Sidhartha Kumar , Vishal Moola , Kefeng Wang , Greg Kroah-Hartman , Tejun Heo , Mel Gorman , Michal Hocko , "Huang, Ying" , Nhat Pham , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 10/12] mempolicy: alloc_pages_mpol() for NUMA policy without vma Message-ID: <20231023190555.GA1964810@cmpxchg.org> References: <74e34633-6060-f5e3-aee-7040d43f2e93@google.com> <1738368e-bac0-fd11-ed7f-b87142a939fe@google.com> <20231023105331.311373ed33a0dfe78ddaa9e5@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 9FAD610001B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 3pjn93xnp8uwmjqscorg3kdoqbg83b5m X-HE-Tag: 1698087957-180693 X-HE-Meta: U2FsdGVkX19l401jcjhhQgg9BC5Hp8agU7rKFu3XCxt/9oI5rWD6qXIv5En6R/ht8RVHIH9d/VcBGzmE0n7ozCrmOMMCTCKV53MOATY2pdSP6HzrRYAaRngMFSQMUNFKzxRmtk7g3G34TQXnpZMhHaYmCUT6rAcb5wo1ZeYdeICi+PjhVmS6179SliTgKbUMKQg0yqNwsWn4AUoL7yUTPwJhgwkCrBKtg6L7wpHXp3Ybk0y7R8eBNbNo8O4HxQCMIUMaiRDimcs4rrlWsdTOpGVCt1mYzAirh2VG6JbMFu4Ik1dnsFunt1qfaTr3thdcWJkCYocT/X6HElAryYPAt7a0IXQURuXe/C9PeTkC1ls9yOANv2IykQkf5M55VmPTdzpQvthfPSys5EihQ1Avprmn5Lbp1EOORpSsO+xwefxirWHsk7HRa71D7QrcM11SBOIAAYWpQXSbMAnWgqM8Td+RRQGfXE2JOwK/U5+G4D5Hlg54vZdBjlfysVbcDz8OaW34r/HvuM8QXfruxrPlXXZt72hOOpmedjwuJKyZi/io4gLPK1hC7wRusRS7HTGVeJSc6Q93Ym73XAQ/V+KXmyYhh6n2thjNiq94rYXjYpXGP+pLDLzsZFr/+VDUHa1/Gc6NUtOW7UuvL4QM2B8ugKYVZp1lk9sdBaGggWdf/vNLIefRtJMeyK4KBvGHgROPcR2maQ7tkO7qTOjOzbInoIBWjMPL5mXU1sEztXMV6/ZuQz5ZI/4NntrqJ7WFw9kQVBgUZa3cMV/XOuIF4S35NPRfQox9yG2UeYCW5KHbeSlIvuNkPthKHKzgOlow+QO9bejQ2icBNSd/ujDjUiV3WIkSpzma+aznzDGpPVxJ1q6KK6WQRy4Cu0cKCPEq4TAicaAarZIQCzPS+AjMu56fK2nje+Z2rY79ERVKlz+hZjMFW+st12Q8BFpYyI1DQj+nahAXgQBaoXaUJxGnYMJ klNTs5Qo aU2S/4p5xSM5T/ppnpaex8vmYxPuJiiawBHOhU6GJ6pzkrRiX93u5EKLb8U3iVldAaO7Dt90ooA304uAdZiSXP3k2cE1T+2kSm9DcD72XgAkMGp6MouAKIGXJrr/zP5JVkUwSqPB1FrNTbanTWaaK/KPV6tI05LyZxGtyOkNYBDdMne0Cm7HzcQlZrq8v+xk9YufUOS1yv/e8tYLB5PBy0SPGrM6zj/gYORpih3UjthNcweVrLWvlxJyIx3dPydoAyc6nA9i+3C/vd+L3YS7O69ZFfJZUTeEDrEl54LqTayCr+qt2qjoalYYTK4849bJTr9CT9WqWugxK/2Bbi01aNKnCOAo8gNAuVSLamrhP6HZ44pfIRpzI6+sIyvXHT1C+daaIn0vTBQvC8ZbycmvaYKZtVgFUAO5668q6ADu3A9qZkgKn4uKkV1v58jutCU8XpzWlTV/kTgKPjzc87XmAL/vE9afGncA5XUeq/lJNU8h5mDpHgADd8rHb1j9WaOawSvZolT6aF++lrs9vowfTdJEIrHeEzoqohCWM46FwMiBt2VLQMEeNUGCKfmMzURrmVDrzlkWVJBfJTxPLv4M7/ccFuqjtaUqYSc98T3WGYVlaOTh1uhf8CGCWCA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 23, 2023 at 08:10:32PM +0200, domenico cerasuolo wrote: > Il giorno lun 23 ott 2023 alle ore 19:53 Andrew Morton > ha scritto: > > > > On Mon, 23 Oct 2023 18:53:26 +0200 domenico cerasuolo wrote: > > > > > > Rebased to mm.git's current mm-stable, to resolve with removal of > > > > vma_policy() from include/linux/mempolicy.h, and temporary omission > > > > of Nhat's ZSWAP mods from mm/swap_state.c: no other changes. > > > > > > Hi Hugh, > > > > > > not sure if it's the rebase, but I don't see an update to > > > __read_swap_cache_async invocation in zswap.c at line 1078. Shouldn't we pass a > > > mempolicy there too? > > > > No change needed. zswap_writeback_entry() was passing a NULL for arg > > `vma' and it's now passing a NULL for arg `mpol'. > > Problem is that alloc_pages_mpol is dereferencing mpol, when I test the zswap > writeback at 397148729f21edcf700ecb2a01749dbce955d09e it crashes, not sure if > I'm missing something. I don't think you are. The NULL vma used to go to get_vma_policy(), which fell back to pol = get_task_policy(current); Now the NULL pol gets passed to alloc_pages_mpol() directly, which dereferences it. Oops. I think Hugh's patch needs zswap to pass get_task_policy(current) instead of NULL.