From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F68ACDB474 for ; Mon, 23 Oct 2023 09:56:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AECD6B00B9; Mon, 23 Oct 2023 05:56:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65F236B00BA; Mon, 23 Oct 2023 05:56:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54DDA6B00BB; Mon, 23 Oct 2023 05:56:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 45C4E6B00B9 for ; Mon, 23 Oct 2023 05:56:52 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 17BA0A0A27 for ; Mon, 23 Oct 2023 09:56:52 +0000 (UTC) X-FDA: 81376272264.04.33FF6A5 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by imf20.hostedemail.com (Postfix) with ESMTP id 939DE1C000A for ; Mon, 23 Oct 2023 09:56:49 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aA5CSEby; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf20.hostedemail.com: domain of lkp@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698055010; a=rsa-sha256; cv=none; b=F2yGICrEWu0e6i2St3XKEzpE7zu2Vmuu8nyuYVh1AU1eVdM5Bucf1vRCaWEGprdPzu1Mg3 NSzglIBKIf/XsJSBbOHMV6G+mF5D1VLTGs8kHlQx9104Qpsh8/Y1E7HRR09N7DOLJFa7em 3Z0FxZ8RYckRJPgl/lOoWeGy4ta5kbI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aA5CSEby; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf20.hostedemail.com: domain of lkp@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698055010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=V5rTLhgaNIYDSPaGLiW9IBOxI7sXPd7P+dbvB5TY648=; b=T75b/8e6u2hQtEImoFRHwU2DO/fSMOy+cFUBLgXPs2ohdxdNGYgQUZoO2D3GBmmg7ohoUc NqZ82yGm+Dj2B6eCnq7SPoGMADvZ4oNUjFwtfkRMju9WYhHaMpZnUzSUIUYv6XdSPIZGF0 y/epyiI4pFFwkz57C7ET+P2O8a39YOk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698055009; x=1729591009; h=date:from:to:cc:subject:message-id:mime-version; bh=BFKrseatZMnx8DrejxIYjCAEBmhgcv6+5iLkB3YBHS8=; b=aA5CSEby+Wx/+xuj8rWzNmpgy7a2wRt08fLNyEuvQIZ7Q0AtWo0CQBhH V/w5leLauCavtQpoNR3MnR9lWOeRzEn7/M5e1Wm7YGJMcejg/IK2Ur5LB bQNmervevHjSQMW9m1gxN5ATIWZzKuWJIv/wFg687WsX8zn1zhyYfkyRn io0jlYr8QXf5ncUaiFlYru9fjudwtelEVt50iLW3x3hsEUJ5Et4z0d/R8 Uw0FHcCWqB03oXFSvBD+UDE2nP9ikew6A9hzA79Q7ADFWjC6r8rGGGw8J 3yEKG4uGu04mwsjd3VOKLOsViX9ZNK2V7aUopAcRzsOKwMXNJHWnmEk+k Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10871"; a="451025901" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="451025901" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 02:56:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10871"; a="793077398" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="793077398" Received: from lkp-server01.sh.intel.com (HELO 8917679a5d3e) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 23 Oct 2023 02:56:46 -0700 Received: from kbuild by 8917679a5d3e with local (Exim 4.96) (envelope-from ) id 1qurfv-0006nI-2O; Mon, 23 Oct 2023 09:56:43 +0000 Date: Mon, 23 Oct 2023 17:56:30 +0800 From: kernel test robot To: Sergey Khimich Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Vinod Koul Subject: [linux-next:master 9304/13906] drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1239 dma_chan_pause() warn: inconsistent indenting Message-ID: <202310231733.tM3xW1hV-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 939DE1C000A X-Stat-Signature: 9ygifzsenh3d81yhwbbccxci4cesxkeo X-HE-Tag: 1698055009-47542 X-HE-Meta: U2FsdGVkX18oB4hbfTU+TBbuTqSNZiIpU2LT86mVdlgjGy1FvYFCmayKkCJQlWHfEB3hJF0pBQPhAWeb07EwPtZW2nzeQ3gwPjeyTClysqTKo4093Zo9zb7MP7SHtlSxf/IJu5/FbF74lydlLi+53Hg/KyMjrEAaW2GQu8ZkS0zNQejlojY9aCa3JqyW1iyw3v5c0ip+9O48pPRQgEj6D2MvO1x8USQ29P2m5BPEEKATTl8UTTgQ+sODixdHoICh2VbkHv38kmTYJKOINAG3IUazyMH8bO7MwodoJo1fObmDW6wx/w/q9pgruVmN8PqnuAQlIq3y1XHl1z5cWSnoftM0je++KFjFX5xlCVYAK+k5XYKTN1R9m5zydfa4onZm14AqJj4hRUsKVr+TMcXY1w0udNKrGNIDKXmffGqYtOcVi72op0N9EFhCWdUxl8ZIZ93p3KTrf1nDaxfoIIPVEg02ed6jJXnTIIx2i724gQ9NaPJEbHv8mXg6eeHJPnTgEfKaZlqsjxQ3LNlLger5yRBB0wtuQyAnGxg3p1OccXVP2BmlNyaGNbRlU0p6szXDCWqRJVizj8Yfvlm9SCeqghxzq2YadMwsYBStnmD2UGMEhLCgpivo5dzz/JNT2IW7F4z6zTiBDSSHXshST7fiCXPEsayRNjqPpu6g4bmlnXcIjO0GTtrdLEI6LjeajkuZ+vBBMDJsB5c8bPYWnJJmQRhUVDm2DKbb7uuA9oC0VJDMVrRp/H4mqfa29rbDbqMFJFVX+GZRdbmklauglDaUFST6QI3ffbbvFkllbOOiHmRSMQIwBIdGYPwd3XL3s+cu30csq6rRBpe32P/7S0PU2WHRTelwbur0P43Q1CQFgUDCKHSDsFQWna1q3lqJkE+Qi/O7cLmXmrssIHWNpMENgneFSHW+NtB9VciliC7cVslvoSS04tpOcONmFpcA+b+OGnOtJ9caLXEgLQh9GB2 BW24hXCN vkPthzym//5e8rSSfdeMljDln1mmmDBrZ9tPAPRAiJL55AkPD0vmiypGPjY7jczoAiBiF2Bm5Spv5mDRsr6e4uKezgXQiYEy6IdIpjOvxaRTP9IAtH/RSqjIf1VZP8j8BY0psInJwqhrh2czaIYDgcnyiLpn/sIbDjLGYPrVkkkQYLaM6sLuM54++FHbncqm1/N+8YAXxa7uBq8iiFIAuBMTXvi6FfWLGodcG+Ulaleaz9JogCSJe6cZ9OIQL6RjoGnido7d2pw2G/xarrrm7dBRdTsV8ApJPbLE3XYIgaWF8t1PB+xzep/GrLPhMTNzex8kKL02Nl1YAOBLGvZWZ20iHp0CyE1IpOcZM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 2030579113a1b1b5bfd7ff24c0852847836d8fd1 commit: 495e18b16e3dd8218eaec6a8a55334fb55245d59 [9304/13906] dmaengine: dw-axi-dmac: Add support DMAX_NUM_CHANNELS > 16 config: x86_64-randconfig-161-20231022 (https://download.01.org/0day-ci/archive/20231023/202310231733.tM3xW1hV-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 reproduce: (https://download.01.org/0day-ci/archive/20231023/202310231733.tM3xW1hV-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310231733.tM3xW1hV-lkp@intel.com/ New smatch warnings: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1239 dma_chan_pause() warn: inconsistent indenting drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1286 axi_chan_resume() warn: inconsistent indenting Old smatch warnings: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1345 axi_dma_resume() warn: 'chip->cfgr_clk' from clk_prepare_enable() not released on lines: 1340. vim +1239 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c 1218 1219 static int dma_chan_pause(struct dma_chan *dchan) 1220 { 1221 struct axi_dma_chan *chan = dchan_to_axi_dma_chan(dchan); 1222 unsigned long flags; 1223 unsigned int timeout = 20; /* timeout iterations */ 1224 u64 val; 1225 1226 spin_lock_irqsave(&chan->vc.lock, flags); 1227 1228 if (chan->chip->dw->hdata->nr_channels >= DMAC_CHAN_16) { 1229 val = axi_dma_ioread64(chan->chip, DMAC_CHSUSPREG); 1230 if (chan->id >= DMAC_CHAN_16) { 1231 val |= (u64)(BIT(chan->id) >> DMAC_CHAN_16) 1232 << (DMAC_CHAN_SUSP2_SHIFT + DMAC_CHAN_BLOCK_SHIFT) | 1233 (u64)(BIT(chan->id) >> DMAC_CHAN_16) 1234 << (DMAC_CHAN_SUSP2_WE_SHIFT + DMAC_CHAN_BLOCK_SHIFT); 1235 } else { 1236 val |= BIT(chan->id) << DMAC_CHAN_SUSP2_SHIFT | 1237 BIT(chan->id) << DMAC_CHAN_SUSP2_WE_SHIFT; 1238 } > 1239 axi_dma_iowrite64(chan->chip, DMAC_CHSUSPREG, val); 1240 } else { 1241 if (chan->chip->dw->hdata->reg_map_8_channels) { 1242 val = axi_dma_ioread32(chan->chip, DMAC_CHEN); 1243 val |= BIT(chan->id) << DMAC_CHAN_SUSP_SHIFT | 1244 BIT(chan->id) << DMAC_CHAN_SUSP_WE_SHIFT; 1245 axi_dma_iowrite32(chan->chip, DMAC_CHEN, (u32)val); 1246 } else { 1247 val = axi_dma_ioread32(chan->chip, DMAC_CHSUSPREG); 1248 val |= BIT(chan->id) << DMAC_CHAN_SUSP2_SHIFT | 1249 BIT(chan->id) << DMAC_CHAN_SUSP2_WE_SHIFT; 1250 axi_dma_iowrite32(chan->chip, DMAC_CHSUSPREG, (u32)val); 1251 } 1252 } 1253 1254 do { 1255 if (axi_chan_irq_read(chan) & DWAXIDMAC_IRQ_SUSPENDED) 1256 break; 1257 1258 udelay(2); 1259 } while (--timeout); 1260 1261 axi_chan_irq_clear(chan, DWAXIDMAC_IRQ_SUSPENDED); 1262 1263 chan->is_paused = true; 1264 1265 spin_unlock_irqrestore(&chan->vc.lock, flags); 1266 1267 return timeout ? 0 : -EAGAIN; 1268 } 1269 1270 /* Called in chan locked context */ 1271 static inline void axi_chan_resume(struct axi_dma_chan *chan) 1272 { 1273 u64 val; 1274 1275 if (chan->chip->dw->hdata->nr_channels >= DMAC_CHAN_16) { 1276 val = axi_dma_ioread64(chan->chip, DMAC_CHSUSPREG); 1277 if (chan->id >= DMAC_CHAN_16) { 1278 val &= ~((u64)(BIT(chan->id) >> DMAC_CHAN_16) 1279 << (DMAC_CHAN_SUSP2_SHIFT + DMAC_CHAN_BLOCK_SHIFT)); 1280 val |= ((u64)(BIT(chan->id) >> DMAC_CHAN_16) 1281 << (DMAC_CHAN_SUSP2_WE_SHIFT + DMAC_CHAN_BLOCK_SHIFT)); 1282 } else { 1283 val &= ~(BIT(chan->id) << DMAC_CHAN_SUSP2_SHIFT); 1284 val |= (BIT(chan->id) << DMAC_CHAN_SUSP2_WE_SHIFT); 1285 } > 1286 axi_dma_iowrite64(chan->chip, DMAC_CHSUSPREG, val); 1287 } else { 1288 if (chan->chip->dw->hdata->reg_map_8_channels) { 1289 val = axi_dma_ioread32(chan->chip, DMAC_CHEN); 1290 val &= ~(BIT(chan->id) << DMAC_CHAN_SUSP_SHIFT); 1291 val |= (BIT(chan->id) << DMAC_CHAN_SUSP_WE_SHIFT); 1292 axi_dma_iowrite32(chan->chip, DMAC_CHEN, (u32)val); 1293 } else { 1294 val = axi_dma_ioread32(chan->chip, DMAC_CHSUSPREG); 1295 val &= ~(BIT(chan->id) << DMAC_CHAN_SUSP2_SHIFT); 1296 val |= (BIT(chan->id) << DMAC_CHAN_SUSP2_WE_SHIFT); 1297 axi_dma_iowrite32(chan->chip, DMAC_CHSUSPREG, (u32)val); 1298 } 1299 } 1300 1301 chan->is_paused = false; 1302 } 1303 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki