From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F84C07545 for ; Sat, 21 Oct 2023 14:44:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE74B8E0006; Sat, 21 Oct 2023 10:44:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B97108D0008; Sat, 21 Oct 2023 10:44:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A37D68E0006; Sat, 21 Oct 2023 10:44:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9353F8D0008 for ; Sat, 21 Oct 2023 10:44:30 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 72914B519E for ; Sat, 21 Oct 2023 14:44:30 +0000 (UTC) X-FDA: 81369739500.16.F5D3550 Received: from out-209.mta1.migadu.com (out-209.mta1.migadu.com [95.215.58.209]) by imf26.hostedemail.com (Postfix) with ESMTP id A4020140004 for ; Sat, 21 Oct 2023 14:44:27 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xZpLnPA5; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.209 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697899467; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tHWic5xUklM9ZxSjedPZ6GHTnBcatj0QDeFJJJdaZnI=; b=Wjb3j1jh8FC1oVrUiQOMEF+WPcen5UKHeHGjRQTU0+Th84Ir4AKT7G/j7V1PfI/bNnmGY/ WqF3IPWb7Bt8Wm8Zgh9b9lsH+d3XkSV3IBIw5eF7imqB9DLwJIKw0q/8odwid/GfG2wEdS Dgz2HE65eS9Y1Ik/6c7XBmn1Ixvmml8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xZpLnPA5; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.209 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697899467; a=rsa-sha256; cv=none; b=mcGejbhLMZ8/p2VkSD8oXaI5RamCAeMTLGjuLYSC+WzsA11CZTx0LnTkij8Ccf6ghhuBTW Q5wAIgpE9GFssgs3dEmer8aBG5Afzn45d/NtlYo/aRzKkA+YqLZXqboI/+3LXQC/6nloqp fqR3RNjMmx4fp0EDq9uB+MRJOEZ+5fM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1697899466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tHWic5xUklM9ZxSjedPZ6GHTnBcatj0QDeFJJJdaZnI=; b=xZpLnPA5vle6JTPcFbJ0n67rIsmg5XrvSZmL7TRfIktWc0DANpJ7X1ziqse/jIv0Pz1dUf o7Qc3QwNW64n42WyqJ9gTrBPvWfFdigRhBwW2USYW3Yx3/zSf5l0CB9wXdlFqaxE+Px/su W+CQPFSDyncBRZEtuylakjuQDjHwMzc= From: chengming.zhou@linux.dev To: cl@linux.com, penberg@kernel.org Cc: rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, willy@infradead.org, pcc@google.com, tytso@mit.edu, maz@kernel.org, ruansy.fnst@fujitsu.com, vishal.moola@gmail.com, lrh2000@pku.edu.cn, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, chengming.zhou@linux.dev, Chengming Zhou Subject: [RFC PATCH v2 5/6] slub: Introduce get_cpu_partial() Date: Sat, 21 Oct 2023 14:43:16 +0000 Message-Id: <20231021144317.3400916-6-chengming.zhou@linux.dev> In-Reply-To: <20231021144317.3400916-1-chengming.zhou@linux.dev> References: <20231021144317.3400916-1-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: A4020140004 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: tcwxox5cw3bnhu7w3cbkyqco37b47gih X-HE-Tag: 1697899467-159663 X-HE-Meta: U2FsdGVkX1/WJHnPdEPHmsh1LifeZWLL2FKB0tS6h/VdzfZXfvMD/SufVe0wSPVVxAAKj5Na5vz2cLQRqpv/kuuD++XviOXijtieToNiuIX2DtNb70PrKO8ZIwqujuuBedUSPZtnBaNpuw/shfoC6axq8NRcnpuW87iuJ4HB1eKW1LoW9G4K2tnAVFMSvUwn2lszi7tspxRQzRIJYd6nhhv+pkPJeTheAuHOJcOPviiLrJxnFXZsXZxA9JbFKJYxhCGQia6yMQc8+V/Sk6gHSvw9aXh5lLzyfNIamTET14bUF9hbYjjCEe6fRyKHa9fsjvNxP8TygmhRKD90ZouOFz8Hz5sgIAr6ikN4pbsyyzx4C+eD7Lz/Q3nzqanPd/X27jFP+qllFt+5/s9G40VgjeeDyumv4/aHEIwtSdjEeu17Gy3RWPlbIJEwk0GtbOAf2suVjnK+JvvXKmrn6k1UaiqCCu27GWP0Gw7rGbJ+rFS8mPSKrVUFNKnZNHNZOhr+qU2/dasFLGjjy8CB4mazWy65QWaYjuwjluTkB5tpgy7RThyt8WyuIauaqL+EHlRTCKcyCLnTvPwVDPCOJQz3L8iabDHVAbWsNylm/4iF+XOQ9G4ZC+nz2tG8t7fmDCyRKhT6q7z7+VdZz5rmnrZaUow1aTWHkZycCMkzCh7RIXlp1PCVtix0H/c74q9HNUMB4+wlfN4BpOvvFHHalEUgq0NVBvTD7Fc930O82uYX80sMKcAMXY69iLRXShnLevb7aPOdO+LB/NRGyCrwaSRGrUiznoQpdK5BhkwzzTmB4oJX+qW1xPXWVWk8iyt/vPhKm3jzMiL/CrGl7z5XgmBtlHBXb+LdQRL87fw7X6efI9wxDVqgzlfykT7sOeC2iDn/1VO7eg5P2UAZGsph/1MbmQOtGbXe04iG96sxtWLW7YjAmpeOKFxo2jdssjMVPpYwrJTDRlP0rgDu5j53CEY fKVjmwjf i4NbWBdHYoEPxUN+pOvpJI6e5He8dLtNoIdops+hWYfJtTGH02z0W8AekJQGVAMPV3/3AIG3iuN60nPC++wTIYFTNLuLfc7omr6jCqHAE2D1dYYqIVtIt3tdQQVjS82/N218IqBN2MNWUIXLt16RltNFhH33JAjxauty9J4iUbStx6KKFC7KrOdKEec/qrxsDxioN7pw5h9b4IhMlytnMidlQUwLhefwXsQTgWyNHf6QoGJdJyK9FgTo77+TYmJDNwNzP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Chengming Zhou Since the slabs on cpu partial list are not frozen anymore, we introduce get_cpu_partial() to get a frozen slab with its freelist from cpu partial list. It's now much like getting a frozen slab with its freelist from node partial list. Another change is about get_partial(), which can return no frozen slab when all slabs are failed when acquire_slab(), but get some unfreeze slabs in its cpu partial list, so we need to check this rare case to avoid allocating a new slab. Signed-off-by: Chengming Zhou --- mm/slub.c | 87 +++++++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 68 insertions(+), 19 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 9f0b80fefc70..7fae959c56eb 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -3055,6 +3055,68 @@ static inline void *get_freelist(struct kmem_cache *s, struct slab *slab) return freelist; } +#ifdef CONFIG_SLUB_CPU_PARTIAL + +static void *get_cpu_partial(struct kmem_cache *s, struct kmem_cache_cpu *c, + struct slab **slabptr, int node, gfp_t gfpflags) +{ + unsigned long flags; + struct slab *slab; + struct slab new; + unsigned long counters; + void *freelist; + + while (slub_percpu_partial(c)) { + local_lock_irqsave(&s->cpu_slab->lock, flags); + if (unlikely(!slub_percpu_partial(c))) { + local_unlock_irqrestore(&s->cpu_slab->lock, flags); + /* we were preempted and partial list got empty */ + return NULL; + } + + slab = slub_percpu_partial(c); + slub_set_percpu_partial(c, slab); + local_unlock_irqrestore(&s->cpu_slab->lock, flags); + stat(s, CPU_PARTIAL_ALLOC); + + if (unlikely(!node_match(slab, node) || + !pfmemalloc_match(slab, gfpflags))) { + slab->next = NULL; + __unfreeze_partials(s, slab); + continue; + } + + do { + freelist = slab->freelist; + counters = slab->counters; + + new.counters = counters; + VM_BUG_ON(new.frozen); + + new.inuse = slab->objects; + new.frozen = 1; + } while (!__slab_update_freelist(s, slab, + freelist, counters, + NULL, new.counters, + "get_cpu_partial")); + + *slabptr = slab; + return freelist; + } + + return NULL; +} + +#else /* CONFIG_SLUB_CPU_PARTIAL */ + +static void *get_cpu_partial(struct kmem_cache *s, struct kmem_cache_cpu *c, + struct slab **slabptr, int node, gfp_t gfpflags) +{ + return NULL; +} + +#endif + /* * Slow path. The lockless freelist is empty or we need to perform * debugging duties. @@ -3097,7 +3159,6 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, node = NUMA_NO_NODE; goto new_slab; } -redo: if (unlikely(!node_match(slab, node))) { /* @@ -3173,24 +3234,9 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, new_slab: - if (slub_percpu_partial(c)) { - local_lock_irqsave(&s->cpu_slab->lock, flags); - if (unlikely(c->slab)) { - local_unlock_irqrestore(&s->cpu_slab->lock, flags); - goto reread_slab; - } - if (unlikely(!slub_percpu_partial(c))) { - local_unlock_irqrestore(&s->cpu_slab->lock, flags); - /* we were preempted and partial list got empty */ - goto new_objects; - } - - slab = c->slab = slub_percpu_partial(c); - slub_set_percpu_partial(c, slab); - local_unlock_irqrestore(&s->cpu_slab->lock, flags); - stat(s, CPU_PARTIAL_ALLOC); - goto redo; - } + freelist = get_cpu_partial(s, c, &slab, node, gfpflags); + if (freelist) + goto retry_load_slab; new_objects: @@ -3201,6 +3247,9 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, if (freelist) goto check_new_slab; + if (slub_percpu_partial(c)) + goto new_slab; + slub_put_cpu_ptr(s->cpu_slab); slab = new_slab(s, gfpflags, node); c = slub_get_cpu_ptr(s->cpu_slab); -- 2.20.1