From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6269FC004C0 for ; Sat, 21 Oct 2023 14:44:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD10A8D0024; Sat, 21 Oct 2023 10:44:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C811F8D0008; Sat, 21 Oct 2023 10:44:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B48DB8D0024; Sat, 21 Oct 2023 10:44:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9EAAF8D0008 for ; Sat, 21 Oct 2023 10:44:06 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6FF0816036E for ; Sat, 21 Oct 2023 14:44:06 +0000 (UTC) X-FDA: 81369738492.06.5F21CEB Received: from out-204.mta1.migadu.com (out-204.mta1.migadu.com [95.215.58.204]) by imf12.hostedemail.com (Postfix) with ESMTP id B0F3A40015 for ; Sat, 21 Oct 2023 14:44:04 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xX8mHLDH; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.204 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697899444; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5cQE9ZFnILnFxpwPZY6R/Y63Il/vf0eHaCXoNa8ST4o=; b=JtvufQ5eM/pewnj97ZZ1i3QpZx0/44QTHUW0ODCAY89sm6n6b5KDd81XJzRSTUekRMvkUI eCkjgKYSbTB73TbzvkhRuTD/f4xZd0FoGdLtM9bxe5UCR4ewAuJhWqTeYf9EdlCE+HkvRt KvIAeXZBmbn1NMEvO+gSrN0SpZnHS84= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xX8mHLDH; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.204 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697899444; a=rsa-sha256; cv=none; b=WT1L9wQVCvQCNop+c5ONT2hawf/N2CRPzdqLY7sCIxZJ28+0x0vYKdBt8DpCXtz/AVYAa1 pUrdCiZbbf3Hfbqo6p/6m038TJDjcF15HSkIQwdXC7EPTQPV0RsmIQAjmzWl3kn7pESpLl 2jVQiywmtU0yJgo6gIJMh5RhABUMkWU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1697899443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5cQE9ZFnILnFxpwPZY6R/Y63Il/vf0eHaCXoNa8ST4o=; b=xX8mHLDHA6jFLEhdUxuEf1tXL2PZcg10QlIE6EE+u+VIO1Ec/ICxJ/WjowvxWiwRTrQeqm rLm5/Uzh0gR0aIfDdIxK6teeg/FWiuTnzKUIMz43WCQ8Awhnrqp5HujqEJ+KKY2sWYUBDV RSgUvb/mgs0boYQF+AOgd4q17KMw5RI= From: chengming.zhou@linux.dev To: cl@linux.com, penberg@kernel.org Cc: rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, willy@infradead.org, pcc@google.com, tytso@mit.edu, maz@kernel.org, ruansy.fnst@fujitsu.com, vishal.moola@gmail.com, lrh2000@pku.edu.cn, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, chengming.zhou@linux.dev, Chengming Zhou Subject: [RFC PATCH v2 2/6] slub: Prepare __slab_free() for unfrozen partial slab out of node partial list Date: Sat, 21 Oct 2023 14:43:13 +0000 Message-Id: <20231021144317.3400916-3-chengming.zhou@linux.dev> In-Reply-To: <20231021144317.3400916-1-chengming.zhou@linux.dev> References: <20231021144317.3400916-1-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: B0F3A40015 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: thkiz5gcz4gd9nq5axu1jyfaxbdjiiro X-HE-Tag: 1697899444-950683 X-HE-Meta: U2FsdGVkX183eOJw+KGuxWdiJSED+kiyrusSJOQem7dBFh3PicrcsGeZmH283QHtNKxkvwf0/r2IDCNOYon+A8BXnsI2ltltslqOtT44NBBL7K9aSBCzHSI1Hp0XHWdHrxNE1olmheJqBu2Pkzu1IwZOhUyIpJWVN+rHGAz97M4GDGcLXhxnEAqmhnZNSBlrCPlcpdAZkAE55vmo/hpROaNcU68BELmYtLmOxg1k04jc1AChBXW+spGBOBkDx1Oy2o+7M+/1vTnN3qwsNS9ANVcVCvp/NYgqSqz1TFNksVrohY38rjbyrbAXiUgJ5AU7Jo/XZS9pd0E8hl5QfHyXTpSmrVVNJ+oUjpllz4t6EwiBaF/+OzkOgkuuO6yM+BJbooF0AFOn5uoFY+av05mUv+lTvtqkMkaiJP9GVM/b3KlGc7cCjo5tzbTwwmY/3rqkBgQx+bjyLF6DJQgB+0ySm2jeMr/vVV8srh5eoD6LIvAqybDOcgymzlAm2WX8tXasxsP3FiY5n+bLZISdfjs1we/e2VvUfzNIKP3td+a/F5pEqnVwCKNTPn2KWDbWGJsajUskyYn/tQO6QojFwJlS8oEFa23k6TMAYPsurseqnMAO6/RYi64g8d5EM4K3qkV18Q7yPVTgxMs9QpRSRLiqYfvv0nAYHyl2aJF1FS74Rw3hx66Idpv28XQuHx1HTXvYDzCKlLmX435dSJFwg4CHHr9G0j2Z85+wT+q9Y91LXfsCZVCLesWdmmzF39lZEn+0M/DmXWmsl8Iq1zgTk3Ze/qtt57+atmFmgueMjOXCFYtUHdP3D/aFwelT0CrDcnIfOGujwUWxhk3vhVmI/GShkt7XbD9lqitjvtKRXaWcgxSYZXZEC3QB6dHsJgXxzqDgiWCDBKiVtlvvsG3bGtEby44jcYOG9nkKpfXxzJP+oGrlf06SA6v6YMxDFo7MObG1EmPHU5Z3kn2SF+FVm+0 TIfhdV5I 0iJg9N9f7bPA5W2zo8o14HKe9vuOVm534aZDhXoYht98QAqfP2jjLt3D4mTITXcn056a5dq1yfNywXXHrWnYqjTxX5GQi7quIC16zfMWgolkZeiHdx5zn3TUCFV3HAlWimyQu1xSUkwuMjDXNATLylJB2zWEa6JTUm3oSD6zj4Atvfsms4vSEf9yUF+PJTnLu4bm//KkK60ArttwKQ4E5SnwAgbBQCYVGoMKWLUd16LpRWJ4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Chengming Zhou Now the partial slub will be frozen when taken out of node partial list, so the __slab_free() will know from "was_frozen" that the partial slab is not on node partial list and is used by one kmem_cache_cpu. But we will change this, make partial slabs leave the node partial list with unfrozen state, so we need to change __slab_free() to use the new slab_test_node_partial() we just introduced. Signed-off-by: Chengming Zhou --- mm/slub.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/mm/slub.c b/mm/slub.c index 3fad4edca34b..adeff8df85ec 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -3610,6 +3610,7 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, unsigned long counters; struct kmem_cache_node *n = NULL; unsigned long flags; + bool on_node_partial; stat(s, FREE_SLOWPATH); @@ -3657,6 +3658,7 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, */ spin_lock_irqsave(&n->list_lock, flags); + on_node_partial = slab_test_node_partial(slab); } } @@ -3685,6 +3687,15 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, return; } + /* + * This slab was not full and not on the per-node partial list either, + * in which case we shouldn't manipulate its list, just early return. + */ + if (prior && !on_node_partial) { + spin_unlock_irqrestore(&n->list_lock, flags); + return; + } + if (unlikely(!new.inuse && n->nr_partial >= s->min_partial)) goto slab_empty; -- 2.20.1