From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B230DC001DF for ; Fri, 20 Oct 2023 15:24:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 132EE8D00B6; Fri, 20 Oct 2023 11:24:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E4438D0003; Fri, 20 Oct 2023 11:24:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F138C8D00B6; Fri, 20 Oct 2023 11:24:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DFFD38D0003 for ; Fri, 20 Oct 2023 11:24:28 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AF805160FCC for ; Fri, 20 Oct 2023 15:24:28 +0000 (UTC) X-FDA: 81366211416.04.EA3D601 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 3CD1116000D for ; Fri, 20 Oct 2023 15:24:26 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sllUA0pZ; dmarc=none; spf=none (imf08.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697815466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NYhb3tt2EPKODPsCiyKE5j5C9RcaVkLCIwab0yGWNqQ=; b=1GgjIttihwYknpxvUJk2TPL3Qz5vePvL3/pldPwOe3EK9xrW7PxxrNtx/6qsL0JhhYYypO mQJwNewDKOZBzYrzrzAzRAUZ6p3yrnyG+XkwIf7lLmvtcE0C5Us65QwcNmgemGzpdfde+Z +CAblXoH8Tb021reFtHpmwp++bb0ql8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sllUA0pZ; dmarc=none; spf=none (imf08.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697815466; a=rsa-sha256; cv=none; b=8D8ZYMxV5Vx29BmtsKcBC3wGR0zD+I2b3Y3PGZTTBGpTKCzMdrzu7aw3wJJQXhEOIcZ/Mc SeTrorb2bIX380SsknCoi9kNbT8tn4Zthcuh5z6fZ3kEfBrzY8Je7k0er0NcDN/7y2U5kY /3gIDmFUplEGWw1IBog2KrubO0caMqI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NYhb3tt2EPKODPsCiyKE5j5C9RcaVkLCIwab0yGWNqQ=; b=sllUA0pZVAuRO6ldGt0htyYZ+S PdfNDAKQiWXgq9+OMT/8dGd05TAIhP1Z3mbgbvRkprhHySGpBSwIFcOfIlg5bucZLxv6LeAfOBCJy ygplxLd3KH4/hblqRD04vmFVrVEVhD5ZDwbfcakMU+s53nCPS6LS1E4kj1nN+KALLkw5maL4StRh+ Ll7CBTHJsBxup64tpp8Abu+LvWCCRPUR7pEhfaScCCPJmBi9EPePi2cVLnN6ldOW3h2XysgBDi63U R1F+Eiyh2fv822mVkkRyMy7+vO3SX5waPF+A+tg0BNsIAsBPB3eS67nkVeSMOa6LmpfimvOryNYXT FKTTTJVA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qtrLv-00DqsE-Bp; Fri, 20 Oct 2023 15:23:56 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 07D40300392; Fri, 20 Oct 2023 17:23:55 +0200 (CEST) Date: Fri, 20 Oct 2023 17:23:54 +0200 From: Peter Zijlstra To: Muhammad Usama Anjum Cc: jeffxu@chromium.org, akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, surenb@google.com, alex.sierra@amd.com, apopple@nvidia.com, aneesh.kumar@linux.ibm.com, axelrasmussen@google.com, ben@decadent.org.uk, catalin.marinas@arm.com, david@redhat.com, dwmw@amazon.co.uk, ying.huang@intel.com, hughd@google.com, joey.gouly@arm.com, corbet@lwn.net, wangkefeng.wang@huawei.com, Liam.Howlett@oracle.com, lstoakes@gmail.com, mawupeng1@huawei.com, linmiaohe@huawei.com, namit@vmware.com, peterx@redhat.com, ryan.roberts@arm.com, shr@devkernel.io, vbabka@suse.cz, xiujianfeng@huawei.com, yu.ma@intel.com, zhangpeng362@huawei.com, dave.hansen@intel.com, luto@kernel.org, linux-hardening@vger.kernel.org Subject: Re: [RFC PATCH v2 8/8] selftest mm/mseal mprotect/munmap/mremap/mmap Message-ID: <20231020152354.GC31411@noisy.programming.kicks-ass.net> References: <20231017090815.1067790-1-jeffxu@chromium.org> <20231017090815.1067790-9-jeffxu@chromium.org> <3cf29cd5-8346-419f-88f1-3a5c8ddbacad@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3cf29cd5-8346-419f-88f1-3a5c8ddbacad@collabora.com> X-Rspam-User: X-Stat-Signature: 876prj1nue3grmng18qzttogcjxdojas X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3CD1116000D X-HE-Tag: 1697815466-618543 X-HE-Meta: U2FsdGVkX1+MVTx9ChE9vIc8vhQU+xO00DbWpp5TIasOe9vgU77v2S0SVF/xto+9VQAlT2BJynzJeg799F/9ZlzmNZ+I1f9aN7cgsfZ459zFoBYstAJkAiBInWxSzF/8CDW/oJPcShbX+/6TRD269/RBZxPPqADzpKWYsEpI8dDbthlRYDXtq+zgUu99ZEhjzrc6nHhtrJgVUywe/9KjIw7O1l5ge18X8uiU3mIjeMG6jqXnqsWHywcAZKdh9MewcKrJJRx7Z1uFU8KR/TSMvom79wBKl5NPRCvZxnFymd2QY0abmPXjdbab+KCdlRa5i0PlxCQTK2E+vF8RTNmSX1FcIrwKtLBzeKCzNiqJnI5p2WAb2BGflwCKsCdUJ8d1AutX0uAb0/pXg6gAVbBsV6SlSB0YY069WQJ3e63jN1ZzEVdEPqOJl9vAHBYVRK32ulaA/9JOfeBoIc/zdP8tKzgQGKX52pxrloVIj5fpBt0cOv7r8GxneGP7ZKOiKKsuoqR78w7qnUemJUng1cVJxQCdBIPGmwtzufPGSmjZdeIwZqutZuhIg8CwQIk/CQPAqYwZ03ZGf3E1Cyy0ifqFYCuM/1bWX20dHGhs/WxtbssHVAOzoRUKmjkrRWim55r6vkA4MWgTu0MaM51bhxg2lsX11dnKdh7qBf+xQw5krCPCUuvTM8nAd3xbBtxqoF+gJZ5C8doLgRPct+F7MiY2KGSTQY2RnS2oqGXp8f43hdxFk7OllB+ok/9LDbtBEtnTOi29bRX7B8SSEOf+CJZ08tWisGoFyWViH9Nc29ZS6psUOw43PwQD/Ey827vryN3Sg2Lpdwg27swhwz7M6VAf3d6FYhWawOSt6of8+5srhEzeZIDw+dort8Qgrha4X7Lzk3VlmdPigC5kPnT7ev8jII7A5pqDrkby2iFbhcvhYPpkFR+VfOL1A827HZPxO+PTjbRPq+MvX7ToQlTmMmJ 0rt2C0je 8SRfMmYnCUvhJTrqW7HogB6xLyvA/rbZghpGvRAZ3cW57rBnRM4VvARXMEdkKKtdeOG7N7Lq0LqGrJO4WYXVj7nr9BNUt6++3VP4mgz7ZLvxUiQv/alIoYIQzt8S8e45X36Qh+DvU9uKuOqE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 20, 2023 at 07:24:03PM +0500, Muhammad Usama Anjum wrote: > Please remove these. These macros would be picked up from the kernel > headers automatically. As per the previous discussions, how does that work if you have O= build directories? I find this push to force people to do 'make headers' in order to use simple selftests quite misguided. You're making it *harder* to use, leading to less use.