From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC7F4CDB474 for ; Fri, 20 Oct 2023 13:50:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A45398D00D1; Fri, 20 Oct 2023 09:50:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A8A78D0003; Fri, 20 Oct 2023 09:50:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FAD48D00D1; Fri, 20 Oct 2023 09:50:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 717108D0003 for ; Fri, 20 Oct 2023 09:50:23 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4F7FA160F87 for ; Fri, 20 Oct 2023 13:50:23 +0000 (UTC) X-FDA: 81365974326.16.FD48F9D Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf25.hostedemail.com (Postfix) with ESMTP id 8EF0AA0012 for ; Fri, 20 Oct 2023 13:50:19 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=none (imf25.hostedemail.com: domain of houtao@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=houtao@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697809821; a=rsa-sha256; cv=none; b=IIqX8qwewU0UnDJGB3VITYsel5a6AsSh1W3wY4zPu11VhJx4ZHpFrz79NX5H32EdK/PVIR ZOexG2A1kk5zkUl0zS9Gna1bkt2GUox7g1Z0ZDMU3bWQUdsWsqZpogrSFWcSLgTyauWdcQ dzfInskHTarqetXc2cwYE8bzA//+OK0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=none; spf=none (imf25.hostedemail.com: domain of houtao@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=houtao@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697809821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=9UrUCQEzMSzUdL9QGv2RSlwzojvJaeb9+lCwSH6sFWk=; b=iqmYGhbLxU4hab/eCu4BVjck9V6Kb5zo5AcnUSeJAH7LOcW3TmDrtSJCFmpRIykowttOgs 4kApyOAfVminnnh702aT6/c6TAqb3U3Ticve1XBj96rtrg8jPeMC5HP2oyAIe1hxvHlK3b Ym4X+knrSOzc6DtTjG42OjYF5W15Og0= Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4SBlpM23chz4f3lfr for ; Fri, 20 Oct 2023 21:30:51 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgBn+dgIgTJlmYjjDQ--.7231S4; Fri, 20 Oct 2023 21:30:50 +0800 (CST) From: Hou Tao To: bpf@vger.kernel.org, linux-mm@kvack.org Cc: Martin KaFai Lau , Alexei Starovoitov , Andrii Nakryiko , Song Liu , Hao Luo , Yonghong Song , Daniel Borkmann , KP Singh , Stanislav Fomichev , Jiri Olsa , John Fastabend , houtao1@huawei.com, Dennis Zhou , Tejun Heo , Christoph Lameter , Andrew Morton Subject: [PATCH bpf-next v3 0/7] bpf: Fixes for per-cpu kptr Date: Fri, 20 Oct 2023 21:31:55 +0800 Message-Id: <20231020133202.4043247-1-houtao@huaweicloud.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgBn+dgIgTJlmYjjDQ--.7231S4 X-Coremail-Antispam: 1UD129KBjvJXoW7CFWUXrWkXrWxGFyrKw1DAwb_yoW5JF1kpF W8Jr13tr4vqFyxGwn7Kr1xua4rZw48Wr17t3WfWw15uFZIqFy7Krs7KF45uas8GFZ0gF13 tF9xGFZaka4UZw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkIb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7MxAIw28I cxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2 IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWrXwCIc40Y0x0EwIxGrwCI 42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42 IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E 87Iv6xkF7I0E14v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa7IU13rcDUUUUU== X-CM-SenderInfo: xkrx3t3r6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8EF0AA0012 X-Stat-Signature: mzcewyq5xn9yazdt7ktrpssmtyiwfifh X-Rspam-User: X-HE-Tag: 1697809819-594202 X-HE-Meta: U2FsdGVkX1/VFlg/7wlH3U9mFX1wlmpOCfhaCg17Ugv7zv/TkhaBJAX9844hs2WJyiPWvi4nk4LlZVUZ1LuG/Viv5NIWKXbCdWiEyopVGMQ8vLVp0sHfqYKXQKDdcvGGgfJqYysonYykNDHbGMhFUr5wmURP+yDYX7GmVtEG6CN8Bu5+IrNvvTmdSTV6ouOXDN6rddq89uEugjv3kkHQ59WWtCj26YVwEZ1ulaoUl7zFSXbtTp4pHOiS8Idc1qIQ6ChT6QUXpbC/KGvjqWXij34dZIPTnRDDtEcTgrgtTow2LDhvbcZPyOwB4/8z0+1i16SQEYWPKR0InYXOirbaYoqOr4QSvb30kbv0JNKe6dL+mYO0+59S0k4vG8SpKN9P4jNaLY3pjE26Uy+p9+emqLJghL1KC0J3KuS2DumrybGmE80JDHveT4xP/Rp2Yl7V0UJMNuHM767mzCs2uijMtNp87ngqNO8EvEHn96vNHJQwTNIXmtv2bjfxkCbLqagB/tM2exJn00I04TQAujhyj6qR4HbTRep4ULLdOEuX8Hr/Y7K2cokPx5fV4Q3c/vLC/fOL/l/OMN5D9Eb3lUvuhgDPbyJfBVkEWR6k1OLSqZ2FHPs0nBnUUYwlkhYzdoukDU1gRxO2NkU+/CBC7XULY7cYhKrQ9dR3ErAL1ikyqUOIyrtSzgI2hwRVaqUahAZNALqLdLswWvB9w6SLelJRgNY55L/LNWmgJXOSP8cJhXGK6uliaLPbRtPYPtldG5ScotDx7HnE977n9vT2n8G6HXxbXrE1YLBnfWw5NHo0ZPUpqrVa1SIvoAyBmNIxeUlOcTwlnyv/OAYTICzZzl82DGusoDAT8ya1HzkrYqnKssc89ZsekJ2I3Y3NPY83HqSTMEG4YeYTsE6GvQePfb9r0tTVyRhcrSjnLKziH19svo3YZt8xtoweYSRj8jHzzr+dPjeHGut9EveE3Rvbzu4 PxiSazDr myvcuwAlfFlC+fA9XzbhXVGzPuhWJAjC5M4S9kWlcouyHB88vgv7Fxy8ltwRUcayIeB9nV1JKWvuDYZBHKqDQOTzlF7mai5iX8raPD/viWXkEODINkRywZk83+HbLuHycycGOob+6z85MPIzTi3X7GNum5x0t6ee/Ekrtkf5O9zld1V1Y9lI6D7aV2hPV4ct/sRMiI+80QwDtRm3a4JZ88EXGSGBzNgpNUHxtaGhLDbkP4B7iaoeeDm4t39Ts0MtDA7lstbsrxMmulHbT4coAMLmTrlRPYlLZnTxl6kiZnDMYK6xhLVsou43IUiVOvyzJ3irW7n2rCRC0rxz0KQoamjTH6qjefxBenbAv46N65eWaFAkdQhW8gXLOepE8llzfMWehPd8Wsc53X2g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Hou Tao Hi, The patchset aims to fix the problems found in the review of per-cpu kptr patch-set [0]. Patch #1 moves pcpu_lock after the invocation of pcpu_chunk_addr_search() and it is a micro-optimization for free_percpu(). The reason includes it in the patch is that the same logic is used in newly-added API pcpu_alloc_size(). Patch #2 introduces pcpu_alloc_size() for dynamic per-cpu area. Patch #2 and #3 use pcpu_alloc_size() to check whether or not unit_size matches with the size of underlying per-cpu area and to select a matching bpf_mem_cache. Patch #4 fixes the freeing of per-cpu kptr when these kptrs are freed by map destruction. The last patch adds test cases for these problems. Please see individual patches for details. And comments are always welcome. Change Log: v3: * rebased on bpf-next * patch 2: update API document to note that pcpu_alloc_size() doesn't support statically allocated per-cpu area. (Dennis) * patch 1 & 2: add Acked-by from Dennis v2: https://lore.kernel.org/bpf/20231018113343.2446300-1-houtao@huaweicloud.com/ * add a new patch "don't acquire pcpu_lock for pcpu_chunk_addr_search()" * patch 2: change type of bit_off and end to unsigned long (Andrew) * patch 2: rename the new API as pcpu_alloc_size and follow 80-column convention (Dennis) * patch 5: move the common declaration into bpf.h (Stanislav, Alxei) v1: https://lore.kernel.org/bpf/20231007135106.3031284-1-houtao@huaweicloud.com/ [0]: https://lore.kernel.org/bpf/20230827152729.1995219-1-yonghong.song@linux.dev Hou Tao (7): mm/percpu.c: don't acquire pcpu_lock for pcpu_chunk_addr_search() mm/percpu.c: introduce pcpu_alloc_size() bpf: Re-enable unit_size checking for global per-cpu allocator bpf: Use pcpu_alloc_size() in bpf_mem_free{_rcu}() bpf: Move the declaration of __bpf_obj_drop_impl() to bpf.h bpf: Use bpf_global_percpu_ma for per-cpu kptr in __bpf_obj_drop_impl() selftests/bpf: Add more test cases for bpf memory allocator include/linux/bpf.h | 1 + include/linux/bpf_mem_alloc.h | 1 + include/linux/percpu.h | 1 + kernel/bpf/helpers.c | 24 ++- kernel/bpf/memalloc.c | 38 ++-- kernel/bpf/syscall.c | 6 +- mm/percpu.c | 35 +++- .../selftests/bpf/prog_tests/test_bpf_ma.c | 20 +- .../testing/selftests/bpf/progs/test_bpf_ma.c | 180 +++++++++++++++++- 9 files changed, 270 insertions(+), 36 deletions(-) -- 2.29.2