From: Andrew Morton <akpm@linux-foundation.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Vishal Moola <vishal.moola@gmail.com>,
linux-mm@kvack.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] mm/khugepaged: Fix a NULL vs IS_ERR() bug in collapse_pte_mapped_thp()
Date: Fri, 20 Oct 2023 09:36:26 -0700 [thread overview]
Message-ID: <20231020093626.bae70759c0f0fe5ee5159eae@linux-foundation.org> (raw)
In-Reply-To: <0882a964-770e-418c-9c34-1a64195baafc@moroto.mountain>
On Fri, 20 Oct 2023 17:14:36 +0300 Dan Carpenter <dan.carpenter@linaro.org> wrote:
> This was changed from find_lock_page() which returns NULL to
> filemap_lock_folio() which returns error pointers. Update the
> error checking to match.
>
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -1508,7 +1508,7 @@ int collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long addr,
>
> folio = filemap_lock_folio(vma->vm_file->f_mapping,
> linear_page_index(vma, haddr));
> - if (!folio)
> + if (IS_ERR(folio))
> return SCAN_PAGE_NULL;
>
> if (folio_order(folio) != HPAGE_PMD_ORDER) {
Also doesn't appear applicable to current kernels?
next prev parent reply other threads:[~2023-10-20 16:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 14:13 [PATCH 1/2] mm/khugepaged: Fix an uninitialized variable bug Dan Carpenter
2023-10-20 14:14 ` [PATCH 2/2] mm/khugepaged: Fix a NULL vs IS_ERR() bug in collapse_pte_mapped_thp() Dan Carpenter
2023-10-20 16:36 ` Andrew Morton [this message]
2023-10-20 16:49 ` Vishal Moola
2023-10-23 4:59 ` Dan Carpenter
2023-10-23 14:16 ` Dan Carpenter
2023-10-20 16:34 ` [PATCH 1/2] mm/khugepaged: Fix an uninitialized variable bug Andrew Morton
2023-10-23 4:57 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020093626.bae70759c0f0fe5ee5159eae@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vishal.moola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox